re: Add d3drmdef.h header - try 2

2007-03-13 Thread Dan Kegel 

Vijay wrote:

Add minimalistic d3drmdef.h


But why?  None of the code in wine currently
needs it.  Maybe you should submit it together
with the first bit of code that needs it.

--
Wine for Windows ISVs: http://kegel.com/wine/isv

Re: Add d3drmdef.h header - try 2

2007-03-13 Thread Francois Gouget 
On Tue, 13 Mar 2007, Vijay Kiran Kamuju wrote:

 Changelog
 ---
 Add minimalistic d3drmdef.h
 
 extern LPD3DVECTOR D3DRMAPI D3DRMVectorAdd(LPD3DVECTOR, LPD3DVECTOR, 
 LPD3DVECTOR);

Two nitpicks:

Wine's headers usually don't specify extern (it's implicit).

If there's a large list of functions it can also be nice to sort them in 
alphabetical order as other forms of grouping tend to break down after a 
time. But this is not a hard and fast rules and it is not always 
followed.

-- 
Francois Gouget [EMAIL PROTECTED]  http://fgouget.free.fr/
  Computers are like airconditioners
They stop working properly if you open WINDOWS

Re: Add d3drmdef.h header - try 2

2007-03-13 Thread Vijay Kiran Kamuju 

Hi,

Please ignore the this one.
I am sending a new one.
I wrongly named the header file, effects of late night coding

bye,
VJ
On 3/13/07, Francois Gouget [EMAIL PROTECTED] wrote:

On Tue, 13 Mar 2007, Vijay Kiran Kamuju wrote:

 Changelog
 ---
 Add minimalistic d3drmdef.h

 extern LPD3DVECTOR D3DRMAPI D3DRMVectorAdd(LPD3DVECTOR, LPD3DVECTOR, 
LPD3DVECTOR);

Two nitpicks:

Wine's headers usually don't specify extern (it's implicit).

If there's a large list of functions it can also be nice to sort them in
alphabetical order as other forms of grouping tend to break down after a
time. But this is not a hard and fast rules and it is not always
followed.

--
Francois Gouget [EMAIL PROTECTED]  http://fgouget.free.fr/
  Computers are like airconditioners
They stop working properly if you open WINDOWS