Re: Cmd tests timeout and splitting tests
On Sun, Aug 28, 2011 at 01:24, Octavian Voicu octavian.vo...@gmail.com wrote: Hello, I've noticed a lot of timeouts for cmd tests lately, which is not so surprising with all the new incoming tests. OK found them I think test_builtins.cmd should be split in a few files, which would then be run separately. An added benefit is that it would permit putting tests that affect other tests in separate files. In order to fix the timeout problem it's not enough to split the tests in different files. Each file has to be run on its own from winetest. I see following solutions: 1) Hack winetest and increase timeout just for cmd.exe batch tests. 2) Allow individual tests to receive a parameter. ... 3) Add a new source file for each .cmd file. ... I would go for number 3, I think it's the cleanest solution (although it would add a few more source files). Any comments on that? 1) would probably need to be done temporarily until a proper solution is implemented Frédéric
Re: Cmd tests timeout and splitting tests
Frédéric Delanoy frederic.dela...@gmail.com writes: On Sun, Aug 28, 2011 at 01:24, Octavian Voicu octavian.vo...@gmail.com wrote: Hello, I've noticed a lot of timeouts for cmd tests lately, which is not so surprising with all the new incoming tests. Which timeouts are you talking about? On windows machines? Never experienced a timeout It only times out on Wine, because cmd is too slow (reading the input char by char and other silliness). That's what should be fixed. -- Alexandre Julliard julli...@winehq.org
Re: Cmd tests timeout and splitting tests
On Sun, Aug 28, 2011 at 01:24, Octavian Voicu octavian.vo...@gmail.com wrote: Hello, I've noticed a lot of timeouts for cmd tests lately, which is not so surprising with all the new incoming tests. Which timeouts are you talking about? On windows machines? Never experienced a timeout Could you give me some link? I think test_builtins.cmd should be split in a few files, which would then be run separately. An added benefit is that it would permit putting tests that affect other tests in separate files. It's difficult to test in complete isolation given that we use our own dogfood (i.e. run with cmd) for cmd tests. Also you would have to run all the tests anyway, since a small change to a builtin can lead to regressions in other parts. The association .cmd/.exp would have to be handled specially as well. Frédéric
re: Cmd tests timeout and splitting tests
Hi Octavian, the intention was to just add new TESTCMD resources into rsrc.rc when test_builtins.cmd got too big but I never thought the tests would be so slow, splitting them by adding new rsrc.rc entries wouldn't help a timeout problem. I'd go for solution #3, too, but it's troubling that test names would be duplicated in the Makefile.in and in rsrc.rc. An awful thought just occurred to me: we could make test_builtins.cmd itself take a parameter saying which subtest to run. That would avoid needing to modify rsrc.rc, but you'd still need to figure out how to iterate through the tests. - Dan
