Re: Spelling fixes - round 6
On Tuesday 08 January 2008, Dan Kegel wrote: > A few issues: > > 1. > * DPMI_xalloc > - * special virtualalloc, allocates lineary monoton growing memory. > + * special virtualalloc, allocates linear monoton growing memory. > > Um... Probably should be 'linearly'. > But if you're opening the can of worms, might as well really > improve it. I suspect this would be better: > > * DPMI_xalloc > - * special virtualalloc, allocates lineary monoton growing memory. > + * Try to VirtualAlloc the len bytes just past the last block we allocated > + * If that's not available, try 64K beyond; if still not available, fail. > > 2. > > -/* Volume functions derived from Alsaplayer source */ > +/* Volume functions derivated from Alsaplayer source */ > > What? What's wrong with "derived"? "Derivated" isn't even a word?! He's translating it to Gerenglish. Maybe we should get a native speaker to do it? Cheers, Kuba
RE: Spelling fixes round 6 - resend - don't apply first patch
James McKenzie: > I am a long time programmer and expect the include to be next > to the # sign. However, you are correct in that it does not > break code, and if it is not broken, why fix? Is it possible > to indent the entire line by two spaces (I think it is not)? Probably not. I know there are (ancient) C compilers that will bark when the # is not the first character in a line as the preprocessor will then not see it as a valid preprocessor line and simply ignore it. Rolf Kalbermatter
Re: Spelling fixes round 6 - resend - don't apply first patch
Francois Gouget wrote: > #ifdef HAVE_UNISTD_H > -# include > +#include > #endif > #include > #include > > I think this chunk should not be applied because: > * as pointed out before, it's not a spelling fix > * it's perfectly valid to have a space there > * the indentation makes the scope of the #ifdef clearer. So removing it > makes the code less readable > > > Francois: I am a long time programmer and expect the include to be next to the # sign. However, you are correct in that it does not break code, and if it is not broken, why fix? Is it possible to indent the entire line by two spaces (I think it is not)? James McKenzie
Re: Spelling fixes - round 6
Austin English wrote: > On Jan 8, 2008 10:42 AM, Francois Gouget <[EMAIL PROTECTED]> wrote: > >> - *3 - controller supports hardware stereoscopic signalling >> + *3 - controller supports hardware stereoscopic signaling >> *4 - =0 stereo signalling via external VESA stereo connector >> *=1 stereo signalling via VESA EVC connector >> >> Why are you changing 'signalling' to 'signaling' in one place, but >> leaving it as is twice two lines down. Note that I'm not sure which form >> is right, but ispell is happy with both so it's possible both are ok. >> > > Ispell caught steroscopic, and while investigating that, I corrected > signaling. I didn't notice the line below at the time. > > Hold off the this patch Alexandre. It's apparently controversial, > since people don't like the whitespace change(s). If you want to apply > certain chunks feel free, otherwise, I'll get a less controversial > patch ready. > > Just so I know, are we going with American or British English? There's > a lot of inconsistency, though the majority seems to be American... > It does not matter to me. Color is colour. Slang should be avoided if at all possible. James McKenzie
Re: Spelling fixes - round 6
On Tue, 8 Jan 2008, Austin English wrote: [...] > Just so I know, are we going with American or British English? There's > a lot of inconsistency, though the majority seems to be American... We're not standardising on either, that is, both spellings should be considered valid. Any other course of action will only bring about flamewars. -- Francois Gouget <[EMAIL PROTECTED]> http://fgouget.free.fr/ Computers are like airconditioners They stop working properly if you open WINDOWS
Re: Spelling fixes - round 6
> Just so I know, are we going with American or British English? There's > a lot of inconsistency, though the majority seems to be American... I think there's a weak preference for American spelling, but I don't see much reason to "correct" spelling from British to American English. --Juan
Re: Spelling fixes - round 6
On Jan 8, 2008 10:42 AM, Francois Gouget <[EMAIL PROTECTED]> wrote: > > - *3 - controller supports hardware stereoscopic signalling > + *3 - controller supports hardware stereoscopic signaling > *4 - =0 stereo signalling via external VESA stereo connector > *=1 stereo signalling via VESA EVC connector > > Why are you changing 'signalling' to 'signaling' in one place, but > leaving it as is twice two lines down. Note that I'm not sure which form > is right, but ispell is happy with both so it's possible both are ok. Ispell caught steroscopic, and while investigating that, I corrected signaling. I didn't notice the line below at the time. Hold off the this patch Alexandre. It's apparently controversial, since people don't like the whitespace change(s). If you want to apply certain chunks feel free, otherwise, I'll get a less controversial patch ready. Just so I know, are we going with American or British English? There's a lot of inconsistency, though the majority seems to be American... -Austin
Re: Spelling fixes - round 6
- *3 - controller supports hardware stereoscopic signalling + *3 - controller supports hardware stereoscopic signaling *4 - =0 stereo signalling via external VESA stereo connector *=1 stereo signalling via VESA EVC connector Why are you changing 'signalling' to 'signaling' in one place, but leaving it as is twice two lines down. Note that I'm not sure which form is right, but ispell is happy with both so it's possible both are ok. -- Francois Gouget <[EMAIL PROTECTED]> http://fgouget.free.fr/ We are Pentium of Borg. You will be approximated. Division is futile.
Re: Spelling fixes round 6 - resend - don't apply first patch
#ifdef HAVE_UNISTD_H -# include +#include #endif #include #include I think this chunk should not be applied because: * as pointed out before, it's not a spelling fix * it's perfectly valid to have a space there * the indentation makes the scope of the #ifdef clearer. So removing it makes the code less readable -- Francois Gouget <[EMAIL PROTECTED]> http://fgouget.free.fr/ You can have my guns when you pry them from my kids cold, dead hands.
re: Spelling fixes - round 6
A few issues: 1. * DPMI_xalloc - * special virtualalloc, allocates lineary monoton growing memory. + * special virtualalloc, allocates linear monoton growing memory. Um... Probably should be 'linearly'. But if you're opening the can of worms, might as well really improve it. I suspect this would be better: * DPMI_xalloc - * special virtualalloc, allocates lineary monoton growing memory. + * Try to VirtualAlloc the len bytes just past the last block we allocated + * If that's not available, try 64K beyond; if still not available, fail. 2. -/* Volume functions derived from Alsaplayer source */ +/* Volume functions derivated from Alsaplayer source */ What? What's wrong with "derived"? "Derivated" isn't even a word?! 3. -# include +#include That's not a spelling fix, and you would have to fix a whole lot of those. Best leave alone. - Dan -- Wine for Windows ISVs: http://kegel.com/wine/isv
Re: Spelling fixes - round 6
On Jan 7, 2008 11:57 PM, Juan Lang <[EMAIL PROTECTED]> wrote: > Hi Austin, > > -case 0x32: /* ENABLE/DISABLE VIDEO ADDRERSSING */ > +case 0x32: /* ENABLE/DISABLE VIDEO ADDRRESSING */ > > That's still misspelled. Thanks for catching that/these. After looking at all these misspellings, some of the incorrect start to look correct. I've got a replacement patch ready, this time triple checked :-). > > - * special virtualalloc, allocates lineary monoton growing memory. > + * special virtualalloc, allocates linear monoton growing memory. > > > Monoton isn't a word. Monotone is, as is monotonic, and > monotonically, which is probably what's meant. I changed it to monotonically. I wasn't sure what it meant, I was correcting linear. > -/* Volume functions derived from Alsaplayer source */ > +/* Volume functions derivated from Alsaplayer source */ > > This change doesn't look correct to me. There was one correct and one incorrect spelling. I apparently switched around my find and replace on that one. I fixed this as well. I'm sending a replacement patch now. Sorry for the mistake. I'll be more careful in the future. -Austin
Re: Spelling fixes - round 6
Hi Austin, -case 0x32: /* ENABLE/DISABLE VIDEO ADDRERSSING */ +case 0x32: /* ENABLE/DISABLE VIDEO ADDRRESSING */ That's still misspelled. - * special virtualalloc, allocates lineary monoton growing memory. + * special virtualalloc, allocates linear monoton growing memory. Monoton isn't a word. Monotone is, as is monotonic, and monotonically, which is probably what's meant. -/* Volume functions derived from Alsaplayer source */ +/* Volume functions derivated from Alsaplayer source */ This change doesn't look correct to me. --Juan
