Re: shellpath: use wine_get_dos_file_name
Juan Lang wrote: > Sorry, I wasn't clear enough. I mean, _SHGetDefaultValue was already > problematic for you, before I changed it to call wine_get_dos_file_name. > The special cases portion of _SHGetDefaultValue don't apply to ROS, so > they should be removed from your tree in any case. Ah ok thanks. - Thomas
Re: shellpath: use wine_get_dos_file_name
--- Thomas Weidenmueller <[EMAIL PROTECTED]> wrote: > > This function was already going to cause you trouble... > > Actually no as it is only used in shfldr_unixfs.c - which we don't port. Sorry, I wasn't clear enough. I mean, _SHGetDefaultValue was already problematic for you, before I changed it to call wine_get_dos_file_name. The special cases portion of _SHGetDefaultValue don't apply to ROS, so they should be removed from your tree in any case. --Juan __ Yahoo! Mail - PC Magazine Editors' Choice 2005 http://mail.yahoo.com
Re: shellpath: use wine_get_dos_file_name
Juan Lang wrote:
> This function was already going to cause you trouble, as getenv("HOME")
> probably won't produce the correct results anyway. Just get rid of the
> special cases portion of _SHGetDefaultValue, they never apply to ROS.
Actually no as it is only used in shfldr_unixfs.c - which we don't port.
- Thomas
Re: shellpath: use wine_get_dos_file_name
> This is going to cause us poor ReactOS guys some trouble as that
> kernel32 function neither exists in Windows nor ReactOS. Isn't there a
> better solution?
This function was already going to cause you trouble, as getenv("HOME")
probably won't produce the correct results anyway. Just get rid of the
special cases portion of _SHGetDefaultValue, they never apply to ROS.
--Juan
__
Yahoo! Mail - PC Magazine Editors' Choice 2005
http://mail.yahoo.com
Re: shellpath: use wine_get_dos_file_name
Juan Lang wrote: > ChangeLog: use wine_get_dos_file_name rather than relying on > GetFullPathNameW hack. This is going to cause us poor ReactOS guys some trouble as that kernel32 function neither exists in Windows nor ReactOS. Isn't there a better solution? - Thomas
