Re: vbscript/tests: Skip some of the weekday tests if the first day of the week is not Sunday.

[Huw Davies]

On Wed, Oct 31, 2012 at 12:34:49PM +0100, Jacek Caban wrote:
> Did you see those failures on Windows? test.winehq.org shows only some
> Linux failures, which suggests that the problem is in implementation,
> not tests.

Hi Jacek,

You're right.  The current tests all pass on my Windows box with the
exception of
WeekDayName(1, true, 0) = "Mon"
which is the system default.  Not sure how to cleanly skip this one.

I'll send in a patch for the implementation.

Thanks,
Huw.

Re: vbscript/tests: Skip some of the weekday tests if the first day of the week is not Sunday.

[Jacek Caban]

Hi Huw,

On 10/31/12 12:04, Huw Davies wrote:
> ---
>  dlls/vbscript/tests/api.vbs |   17 +
>  1 files changed, 9 insertions(+), 8 deletions(-)

Did you see those failures on Windows? test.winehq.org shows only some
Linux failures, which suggests that the problem is in implementation,
not tests.

Jacek

Re: vbscript/tests: Skip some of the weekday tests if the first day of the week is not Sunday.

[Marvin]

Hi,

While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
http://testbot.winehq.org/JobDetails.pl?Key=22625

Your paranoid android.


=== WNT4WSSP6 (32 bit) ===
No test summary line found

=== W2KPROSP4 (32 bit) ===
No test summary line found

=== WXPPROSP3 (32 bit) ===
No test summary line found

=== W2K3R2SESP2 (32 bit) ===
No test summary line found

=== WVISTAADM (32 bit) ===
No test summary line found

=== W2K8SE (32 bit) ===
No test summary line found

=== W7PRO (32 bit) ===
No test summary line found

=== W7PROX64 (32 bit) ===
No test summary line found

=== TEST64_W7SP1 (32 bit) ===
No test summary line found

=== W7PROX64 (64 bit) ===
No test summary line found

=== TEST64_W7SP1 (64 bit) ===
No test summary line found