Re: version: Use proper type for third parameter of VerQueryValue

2005-03-29 Thread Dmitry Timoshkov 
"Uwe Bonnes" <[EMAIL PROTECTED]> wrote:

> >> -DWORD WINAPI VerQueryValueA(LPVOID,LPCSTR,LPVOID*,UINT*); -DWORD
> >> WINAPI VerQueryValueW(LPVOID,LPCWSTR,LPVOID*,UINT*); +BOOL WINAPI
> >> VerQueryValueA(const LPVOID,LPCSTR,UINT*,UINT*); +BOOL WINAPI
> >> VerQueryValueW(const LPVOID,LPCWSTR,UINT*,UINT*);
> 
> Dmitry> Where did you get it? PSDK agrees with current Wine definition
> Dmitry> on the 3rd param type. Also the 2nd param should not be 'const'.
> 
> MSDN (look with Google for VerQueryValue and use the first hit) has
> (const LPVOID ..., LPTSTR ..., PUINT ..., PUINT ...)

MSDN is known to contradict with PSDK headers. PSDK February 2003 has the 
following:

VerQueryValueA(
const LPVOID pBlock,
LPSTR lpSubBlock,
LPVOID * lplpBuffer,
PUINT puLen
);
BOOL
APIENTRY
VerQueryValueW(
const LPVOID pBlock,
LPWSTR lpSubBlock,
LPVOID * lplpBuffer,
PUINT puLen
);

-- 
Dmitry.

Re: version: Use proper type for third parameter of VerQueryValue

2005-03-28 Thread Uwe Bonnes 
> "Dmitry" == Dmitry Timoshkov <[EMAIL PROTECTED]> writes:

Dmitry> "James Hawkins" <[EMAIL PROTECTED]> wrote:
>> Changelog * Use proper type for third parameter of VerQueryValue

>> -DWORD WINAPI VerQueryValueA(LPVOID,LPCSTR,LPVOID*,UINT*); -DWORD
>> WINAPI VerQueryValueW(LPVOID,LPCWSTR,LPVOID*,UINT*); +BOOL WINAPI
>> VerQueryValueA(const LPVOID,LPCSTR,UINT*,UINT*); +BOOL WINAPI
>> VerQueryValueW(const LPVOID,LPCWSTR,UINT*,UINT*);

Dmitry> Where did you get it? PSDK agrees with current Wine definition
Dmitry> on the 3rd param type. Also the 2nd param should not be 'const'.

MSDN (look with Google for VerQueryValue and use the first hit) has
(const LPVOID ..., LPTSTR ..., PUINT ..., PUINT ...)

Bye
-- 
Uwe Bonnes[EMAIL PROTECTED]

Institut fuer Kernphysik  Schlossgartenstrasse 9  64289 Darmstadt
- Tel. 06151 162516  Fax. 06151 164321 --

Re: version: Use proper type for third parameter of VerQueryValue

2005-03-28 Thread James Hawkins 
On Tue, 29 Mar 2005 14:02:03 +0900, Dmitry Timoshkov <[EMAIL PROTECTED]> wrote:
> "James Hawkins" <[EMAIL PROTECTED]> wrote:
> 
> > Changelog
> > * Use proper type for third parameter of VerQueryValue
> 
> > -DWORD   WINAPI VerQueryValueA(LPVOID,LPCSTR,LPVOID*,UINT*);
> > -DWORD   WINAPI VerQueryValueW(LPVOID,LPCWSTR,LPVOID*,UINT*);
> > +BOOL   WINAPI VerQueryValueA(const LPVOID,LPCSTR,UINT*,UINT*);
> > +BOOL   WINAPI VerQueryValueW(const LPVOID,LPCWSTR,UINT*,UINT*);
> 
> Where did you get it? PSDK agrees with current Wine definition on
> the 3rd param type. Also the 2nd param should not be 'const'.

My PSDK (Server 2003) has this definition:

BOOL VerQueryValue(
const LPVOID pBlock,
LPTSTR lpSubBlock,
PUINT lplpBuffer,
PUINT puLen
);

And msdn agrees with it:
http://msdn.microsoft.com/library/default.asp?url=/library/en-us/winui/winui/windowsuserinterface/resources/versioninformation/versioninformationreference/versioninformationfunctions/verqueryvalue.asp

I wrote this patch to keep up with the PSDK, but if we want to keep
the original definition, then that's cool too.  I can fix the error
when compiling visual studio another way.  What are some thoughts
about this?

-- 
James Hawkins

Re: version: Use proper type for third parameter of VerQueryValue

2005-03-28 Thread Dmitry Timoshkov 
"James Hawkins" <[EMAIL PROTECTED]> wrote:

> Changelog
> * Use proper type for third parameter of VerQueryValue

> -DWORD   WINAPI VerQueryValueA(LPVOID,LPCSTR,LPVOID*,UINT*);
> -DWORD   WINAPI VerQueryValueW(LPVOID,LPCWSTR,LPVOID*,UINT*);
> +BOOL   WINAPI VerQueryValueA(const LPVOID,LPCSTR,UINT*,UINT*);
> +BOOL   WINAPI VerQueryValueW(const LPVOID,LPCWSTR,UINT*,UINT*);

Where did you get it? PSDK agrees with current Wine definition on
the 3rd param type. Also the 2nd param should not be 'const'.

-- 
Dmitry.