Re: wineconsole: command line option output / configurable default backend

2006-08-09 Thread Vitaliy Margolen
Wednesday, August 9, 2006, 2:33:17 AM, Ekkehard Morgenstern wrote:
 This patch is akin to the previously posted; however, instead of making 
 the user backend
 the default, I read an environment variable WINECONBACKEND to determine 
 the default.
 If the value isn't set, curses will be the default as in the original 
 code.

You patch wrapped again. Please attach it to the e-mail instead.

Vitaliy.





Re: wineconsole: command line option output / configurable default backend

2006-08-09 Thread Ekkehard Morgenstern



You patch wrapped again. Please attach it to the e-mail instead.

Vitaliy.


 

Are you sure? It doesn't wrap in Mozilla Mail unless it crosses window 
borders. I've checked it multiple times and tried out different window 
sizes in the mail viewer. In the Mail config, I set the margin to 512 
characters.


But okay, I'll resend it attached this time.





Re: wineconsole: command line option output / configurable default backend

2006-08-09 Thread Alexandre Julliard
Ekkehard Morgenstern [EMAIL PROTECTED] writes:

 This patch is akin to the previously posted; however, instead of making 
 the user backend
 the default, I read an environment variable WINECONBACKEND to determine 
 the default.

I don't think that's an improvement, please let's not add more obscure
environment variables. You should try to use the user backend when the
X display is available and fall back to curses otherwise.

-- 
Alexandre Julliard
[EMAIL PROTECTED]




Re: wineconsole: command line option output / configurable default backend

2006-08-09 Thread Ekkehard Morgenstern

Alexandre Julliard wrote:



I don't think that's an improvement, please let's not add more obscure
environment variables. You should try to use the user backend when the
X display is available and fall back to curses otherwise.

 


How should I check if the X Display is available?

The DISPLAY environment variable doesn't suffice for that. It might be 
set, but the connection might be unavailable anyway. Or some user that 
doesn't have X Windows might use the DISPLAY variable for something 
else. Not a good idea IMO.









Re: wineconsole: command line option output / configurable default backend

2006-08-09 Thread Alexandre Julliard
Ekkehard Morgenstern [EMAIL PROTECTED] writes:

 How should I check if the X Display is available?

Try to create the console window, it should fail if X is not
available.

-- 
Alexandre Julliard
[EMAIL PROTECTED]




Re: wineconsole: command line option output / configurable default backend

2006-08-09 Thread Ekkehard Morgenstern

Alexandre Julliard wrote:



Try to create the console window, it should fail if X is not
available.

 


Well, I'll look into that when I find time.