Re: wined3d: Rebind texture before checking for its content in check_fbo_compat().

2013-01-27 Thread Stefan Dösinger 
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1

Am 2013-01-26 23:52, schrieb Matteo Bruni:
 2013/1/26 Stefan D￶singer stefandoesin...@gmail.com:
 Do you really have to re-attach it to the FBO? Or does 
 glBindTexture(GL_TEXTURE_2D, tex) work as well?
 Yeah, that works too. I've sent a new patch with this change.
Is it really an fglrx bug in this case? I vaguely remember that the
spec says you have to rebind a texture before reading it after you've
rendered to an FBO it is attached to. Or was this about rebinding the
FBO after modifying the texture via glSubTexImage?

-BEGIN PGP SIGNATURE-
Version: GnuPG v2.0.19 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQIcBAEBAgAGBQJRBW8AAAoJEN0/YqbEcdMwklUP/RpyJHfjwmDVU/X0mC1PLAJ3
S+Eg98BRllP+YbP5nIIVORLJo/kwHtjl2eHYc11N59b8Q0LEGDvPhUODxGa8lmS+
RJzGb/QstPUgoKCpCsUbJPwom+IoB8fx9CSXpsDMj1if10VSHQsePrK6458QdD90
S96k/3f256LepHkdXBE5rWddpFGE6sCJ8ZEaLyB07211SpO/4wrCd2+7V/YyETKU
om7uQFD8OUOjMMN5O2Mihm+XBwvyha1S5AfPlxo54V1x5aaYBBBUzTFIgl0dxg7c
B8SjJak4sPvnLmUO2VTnZ/LkBq/sKyh1+RI0furnt5LFWA0Lag0XvexPXLS8Eq7F
SDqcNn4UBcs6Awfg5LKnzrYNVC8ChkRvruDzezCsFO7vZUQaO/3xgOMK37sXtwcd
5hvnoxUSABKZMVt7/Xgy505oQGPkaNzLfDwH6xFQ+RzDpFjp8LenChhI1Ox5/cNP
BI8VtxMzOU5yz7T5X0WpNEHumGlRlKWs97FUBQASfogyX6P7uz4bwb2t8dsu8Zkn
pgOjqwUZf2WcRScFgwHsyNbDbxZ9WaVoFn8Y4ZD6eX4iXj3QGZIqL/ZcQXYtugzH
oeMw1wIL/lNw0WliCXl+SEqYsKCgDSIotu7gs30NgbKRgUbW9tyGzkQZQaKaSAgt
aiJeMK8b2ndrP3O8jCjQ
=mDF3
-END PGP SIGNATURE-

Re: wined3d: Rebind texture before checking for its content in check_fbo_compat().

2013-01-27 Thread Henri Verbeet 
On 27 January 2013 19:16, Stefan Dösinger stefandoesin...@gmail.com wrote:
 -BEGIN PGP SIGNED MESSAGE-
 Hash: SHA1

 Am 2013-01-26 23:52, schrieb Matteo Bruni:
 2013/1/26 Stefan D￶singer stefandoesin...@gmail.com:
 Do you really have to re-attach it to the FBO? Or does
 glBindTexture(GL_TEXTURE_2D, tex) work as well?
 Yeah, that works too. I've sent a new patch with this change.
 Is it really an fglrx bug in this case? I vaguely remember that the
 spec says you have to rebind a texture before reading it after you've
 rendered to an FBO it is attached to. Or was this about rebinding the
 FBO after modifying the texture via glSubTexImage?

That's when multiple contexts are involved.

Re: wined3d: Rebind texture before checking for its content in check_fbo_compat().

2013-01-26 Thread Matteo Bruni 
2013/1/26 Stefan Dösinger stefandoesin...@gmail.com:
 -BEGIN PGP SIGNED MESSAGE-
 Hash: SHA1

 Am 2013-01-26 22:32, schrieb Matteo Bruni:
 +
 gl_info-fbo_ops.glFramebufferTexture2D(GL_FRAMEBUFFER,
 GL_COLOR_ATTACHMENT0, GL_TEXTURE_2D, tex, 0);
 Do you really have to re-attach it to the FBO? Or does
 glBindTexture(GL_TEXTURE_2D, tex) work as well?


Yeah, that works too. I've sent a new patch with this change.

 -BEGIN PGP SIGNATURE-
 Version: GnuPG v2.0.19 (GNU/Linux)
 Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

 iQIcBAEBAgAGBQJRBFTlAAoJEN0/YqbEcdMw7bcQAIfUM81xBr3zIpcEYek3gMso
 jXPq49+8Dp8Y3xiJGU/nFD8yLH9Y24SXpyageueCMWZR2jnEQcXBL0l76MmL5ZYK
 Y/L1ytRwrOvdXP07pJ8p3ZXxmA6hl82fuNxMvYhlSYP8PVCoobhaH7MwGp9WPpGF
 Ij20eOOR3GQnDjb6M2qHHfP9s+mNREu5NrvZ76NCf/lURXLJyDECuMz+6TbSl4CM
 qv0xCKdtqxm13gTZio3ftKc3QZZUSstiYjUYQmFh5NXQe5oIr9j2/iueU2K0zA/M
 CqswN4divbFFbh7QwCIDaubwfGidRfiwIG3lCCiNpfIvnowQouELIoFKjIipQ1AL
 ihIIS7iyekasAxkErVZ3E8O8IJCKYbTC+tAXBfK3niKmSRfdUB9cmfo5nVZw4Xjb
 3/Zz84WnjMlIznyBGsKyKX+VLKlqzXY5zCyboHuEWPxTXdS0FAbwHzz06Kv0zIqc
 Pe4X6dJOUz6EPnx2gkbtFygGFbAa8haWhiIcY01H1bMSa7NnZPU3QgQXimrvXaKK
 SbQofZfhbNSVv0dL1kxqUYeLPb5hKXqMRHO7yi/GeyejTie9onzjxrjt4zn4rxe3
 9IEZ0ymUYs499ahUnW/DAe0yFJvX+EXiPIiWwLBGVpx/Dzduk0WADOLBaN/YwrEz
 1gxkuQjF2tbVSTkP41yr
 =xi8z
 -END PGP SIGNATURE-