Re: winspool.drv: Write-strings warnings fix (Resent)
Alexandre Julliard wrote: > This one is not in an API structure so it should be made const. > Thanks, Alexandre. I have posted a revised version, accordingly. -- Andy.
Re: winspool.drv: Write-strings warnings fix (Resent)
Andrew Talbot <[EMAIL PROTECTED]> writes: > @@ -421,7 +431,7 @@ > *s=':'; > pent = s; > } else > -pent = ""; > +pent = empty; This one is not in an API structure so it should be made const. -- Alexandre Julliard [EMAIL PROTECTED]
Re: winspool.drv: Write-strings warnings fix
Andrew Talbot wrote: > Changelog: > winspool.drv: Write-strings warnings fix. The touched parts should call the UNICODE-Functions instead of the ANSI-Functions. That's on my ToDo-List, but after the Port-Functions are fixed. Many tests for the affected Functions also needs to come before the touched Parts will be updated again. I'm ok with this Patch. -- By By ... ... Detlef
Re: winspool.drv: Write-strings warnings fix
Mike McCormack wrote: > These strings should really be const. IMO, a better fix would be to add > a cast to cast them back to (char*) than to change their storage class. > The trouble is, if you leave them as they were, you get a write-strings warning, since you are pointing a writeable pointer at a read-only string). But if you cast, thus: CHAR *dtype = (LPSTR) "RAW"; ... then you swap the write-strings warning for a cast-qual one. In general, it's a solution that Alexandre has accepted. -- Andy.
Re: winspool.drv: Write-strings warnings fix
Andrew Talbot wrote: +static CHAR dtype[] = "RAW", +processor[] = "WinPrint", These strings should really be const. IMO, a better fix would be to add a cast to cast them back to (char*) than to change their storage class. Mike
