[Wireshark-bugs] [Bug 9625] [BACnet] Event Notifications of Event Type CHANGE_OF_CHARACTERSTRING are not decoded properly

2014-10-18 Thread bugzilla-daemon
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9625

Anish Bhatt  changed:

   What|Removed |Added

 CC||an...@chelsio.com

--- Comment #1 from Anish Bhatt  ---
Any pointers to what isn't decoded correctly ? Just saying it's wrong doesn't
help find the bug..

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Sent via:Wireshark-bugs mailing list 
Archives:http://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 9626] [BACnet] Event Notifications of Event Type CHANGE_OF_STATUS_FLAGS are not decoded properly

2014-10-18 Thread bugzilla-daemon
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9626

Anish Bhatt  changed:

   What|Removed |Added

 CC||an...@chelsio.com

--- Comment #1 from Anish Bhatt  ---
Any pointers to what isn't decoded correctly ? Just saying it's wrong doesn't
help find the bug..

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Sent via:Wireshark-bugs mailing list 
Archives:http://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 9626] [BACnet] Event Notifications of Event Type CHANGE_OF_STATUS_FLAGS are not decoded properly

2014-10-18 Thread bugzilla-daemon
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9626

--- Comment #2 from nuabara...@web.de ---
Both my initial comment and the attached capture show the problem:

(In reply to nuabaranda from comment #0)
> The eventValues part of EventNotifications of Event Type
> CHANGE_OF_STATUS_FLAGS do not get decoded correctly. This also applies to
> ReadRange-Acks of EventLog Log-Buffers including such notifications.

So have a look at the attached capture and if you take more than 2 seconds
before writing comments, you may see (in packet #1, 3, 6) that the eventValues
part of the EventNotifications do not decode as expected (Time_Delay and
Selected_Flags are shown as clearly wrong Process_Identifier stuff). Please
some more effort before making accusations.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Sent via:Wireshark-bugs mailing list 
Archives:http://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 9625] [BACnet] Event Notifications of Event Type CHANGE_OF_CHARACTERSTRING are not decoded properly

2014-10-18 Thread bugzilla-daemon
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9625

--- Comment #2 from nuabara...@web.de ---
Both my initial comment and the attached capture show the problem:

(In reply to nuabaranda from comment #0)
> The eventValues part of EventNotifications of Event Type
> CHANGE_OF_STATUS_FLAGS do not get decoded correctly. This also applies to
> ReadRange-Acks of EventLog Log-Buffers including such notifications.

So have a look at the attached capture and if you take more than 2 seconds
before writing comments, you may see (in packet #1, 3, 6) that the eventValues
part of the EventNotifications do not decode as expected (Time_Delay and
List_Of_Alarm_Values are shown as clearly wrong stuff). Please some more effort
before making accusations.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Sent via:Wireshark-bugs mailing list 
Archives:http://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 9625] [BACnet] Event Notifications of Event Type CHANGE_OF_CHARACTERSTRING are not decoded properly

2014-10-18 Thread bugzilla-daemon
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9625

Pascal Quantin  changed:

   What|Removed |Added

 CC||pascal.quan...@gmail.com

--- Comment #3 from Pascal Quantin  ---
(In reply to nuabaranda from comment #2)
> Both my initial comment and the attached capture show the problem:
> 
> (In reply to nuabaranda from comment #0)
> > The eventValues part of EventNotifications of Event Type
> > CHANGE_OF_STATUS_FLAGS do not get decoded correctly. This also applies to
> > ReadRange-Acks of EventLog Log-Buffers including such notifications.
> 
> So have a look at the attached capture and if you take more than 2 seconds
> before writing comments, you may see (in packet #1, 3, 6) that the
> eventValues part of the EventNotifications do not decode as expected
> (Time_Delay and List_Of_Alarm_Values are shown as clearly wrong stuff).
> Please some more effort before making accusations.

I do not see anyone doing any accusation here, but simply asking for more
details about the failure. Keep in mind that not everybody knows BACNet
protocol, so a detzilled description of the issue increase the chances to get a
fix. So please stay cool.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Sent via:Wireshark-bugs mailing list 
Archives:http://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 9626] [BACnet] Event Notifications of Event Type CHANGE_OF_STATUS_FLAGS are not decoded properly

2014-10-18 Thread bugzilla-daemon
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9626

Pascal Quantin  changed:

   What|Removed |Added

 CC||pascal.quan...@gmail.com

--- Comment #3 from Pascal Quantin  ---
(In reply to nuabaranda from comment #2)
> Both my initial comment and the attached capture show the problem:
> 
> (In reply to nuabaranda from comment #0)
> > The eventValues part of EventNotifications of Event Type
> > CHANGE_OF_STATUS_FLAGS do not get decoded correctly. This also applies to
> > ReadRange-Acks of EventLog Log-Buffers including such notifications.
> 
> So have a look at the attached capture and if you take more than 2 seconds
> before writing comments, you may see (in packet #1, 3, 6) that the
> eventValues part of the EventNotifications do not decode as expected
> (Time_Delay and Selected_Flags are shown as clearly wrong Process_Identifier
> stuff). Please some more effort before making accusations

I do not see anyone doing any accusation here, but simply asking for more
details about the failure. Keep in mind that not everybody knows BACNet
protocol, so a detailled description of the issue increase the chances to get a
fix. So please stay cool.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Sent via:Wireshark-bugs mailing list 
Archives:http://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 9625] [BACnet] Event Notifications of Event Type CHANGE_OF_CHARACTERSTRING are not decoded properly

2014-10-18 Thread bugzilla-daemon
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9625

--- Comment #4 from nuabara...@web.de ---
Fixing that bug without proper practical knowledge of BACnet and the standard
document at hand won't be possible. 

(In reply to Pascal Quantin from comment #3)
> Keep in mind that not everybody knows BACNet
> protocol, so a detzilled description of the issue increase the chances to
> get a fix.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Sent via:Wireshark-bugs mailing list 
Archives:http://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 10580] Changing diplay filters on a 20MB file takes time to redisplay

2014-10-18 Thread bugzilla-daemon
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=10580

Alexis La Goutte  changed:

   What|Removed |Added

 CC||alexis.lagou...@gmail.com

--- Comment #1 from Alexis La Goutte  ---
Hi Matthieu,

Don't missing "the file" ?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Sent via:Wireshark-bugs mailing list 
Archives:http://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 10564] Not all monitor interfaces show up in Wireless Toolbar menu

2014-10-18 Thread bugzilla-daemon
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=10564

Gerrit Code Review  changed:

   What|Removed |Added

 Status|IN_PROGRESS |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Sent via:Wireshark-bugs mailing list 
Archives:http://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 10564] Not all monitor interfaces show up in Wireless Toolbar menu

2014-10-18 Thread bugzilla-daemon
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=10564

--- Comment #2 from Gerrit Code Review  ---
Change 4611 merged by Alexis La Goutte:
Add support for split wiphy dump to Wireless Toolbar

https://code.wireshark.org/review/4611

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Sent via:Wireshark-bugs mailing list 
Archives:http://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 10578] IPv6 Mobility Option Mobile Node Link Layer Identifier Link-layer Identifier field is read beyond the option data

2014-10-18 Thread bugzilla-daemon
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=10578

--- Comment #1 from Gerrit Code Review  ---
Change 4818 had a related patch set uploaded by Alexis La Goutte:
MIPv6: Mobility Option Mobile Node Link Layer Identifier Link-layer Identifier
field is read beyond the option data

https://code.wireshark.org/review/4818

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Sent via:Wireshark-bugs mailing list 
Archives:http://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 10577] IPv6 Mobility Option Binding Authorization Data for FMIPv6 Authenticator field is read beyond the option data

2014-10-18 Thread bugzilla-daemon
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=10577

--- Comment #1 from Gerrit Code Review  ---
Change 4817 had a related patch set uploaded by Alexis La Goutte:
MIPv6: Mobility Option Binding Authorization Data for FMIPv6 Authenticator
field is read beyond the option data

https://code.wireshark.org/review/4817

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Sent via:Wireshark-bugs mailing list 
Archives:http://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 10576] IPv6 Mobility Option IPv6 Address/Prefix marks too many bytes for the address/prefix field

2014-10-18 Thread bugzilla-daemon
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=10576

--- Comment #1 from Gerrit Code Review  ---
Change 4816 had a related patch set uploaded by Alexis La Goutte:
MIPv6: Mobility Option IPv6 Address/Prefix marks too many bytes for the
address/prefix field

https://code.wireshark.org/review/4816

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Sent via:Wireshark-bugs mailing list 
Archives:http://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 10576] IPv6 Mobility Option IPv6 Address/Prefix marks too many bytes for the address/prefix field

2014-10-18 Thread bugzilla-daemon
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=10576

--- Comment #2 from Gerrit Code Review  ---
Change 4816 merged by Michael Mann:
MIPv6: Mobility Option IPv6 Address/Prefix marks too many bytes for the
address/prefix field

https://code.wireshark.org/review/4816

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Sent via:Wireshark-bugs mailing list 
Archives:http://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 10576] IPv6 Mobility Option IPv6 Address/Prefix marks too many bytes for the address/prefix field

2014-10-18 Thread bugzilla-daemon
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=10576

Gerrit Code Review  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Sent via:Wireshark-bugs mailing list 
Archives:http://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 10577] IPv6 Mobility Option Binding Authorization Data for FMIPv6 Authenticator field is read beyond the option data

2014-10-18 Thread bugzilla-daemon
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=10577

--- Comment #2 from Gerrit Code Review  ---
Change 4817 merged by Michael Mann:
MIPv6: Mobility Option Binding Authorization Data for FMIPv6 Authenticator
field is read beyond the option data

https://code.wireshark.org/review/4817

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Sent via:Wireshark-bugs mailing list 
Archives:http://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 10577] IPv6 Mobility Option Binding Authorization Data for FMIPv6 Authenticator field is read beyond the option data

2014-10-18 Thread bugzilla-daemon
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=10577

Gerrit Code Review  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Sent via:Wireshark-bugs mailing list 
Archives:http://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 10578] IPv6 Mobility Option Mobile Node Link Layer Identifier Link-layer Identifier field is read beyond the option data

2014-10-18 Thread bugzilla-daemon
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=10578

Gerrit Code Review  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Sent via:Wireshark-bugs mailing list 
Archives:http://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 10578] IPv6 Mobility Option Mobile Node Link Layer Identifier Link-layer Identifier field is read beyond the option data

2014-10-18 Thread bugzilla-daemon
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=10578

--- Comment #2 from Gerrit Code Review  ---
Change 4818 merged by Michael Mann:
MIPv6: Mobility Option Mobile Node Link Layer Identifier Link-layer Identifier
field is read beyond the option data

https://code.wireshark.org/review/4818

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Sent via:Wireshark-bugs mailing list 
Archives:http://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 10583] New: Buildbot crash output: fuzz-2014-10-18-26900.pcap

2014-10-18 Thread bugzilla-daemon
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=10583

Bug ID: 10583
   Summary: Buildbot crash output: fuzz-2014-10-18-26900.pcap
   Product: Wireshark
   Version: unspecified
  Hardware: x86-64
   URL: https://www.wireshark.org/download/automated/captures/
fuzz-2014-10-18-26900.pcap
OS: Ubuntu
Status: CONFIRMED
  Severity: Major
  Priority: High
 Component: Dissection engine (libwireshark)
  Assignee: bugzilla-ad...@wireshark.org
  Reporter: buildbot-do-not-re...@wireshark.org

Problems have been found with the following capture file:

https://www.wireshark.org/download/automated/captures/fuzz-2014-10-18-26900.pcap

stderr:
Input file: /home/wireshark/menagerie/menagerie/13179-AMQPDTX.CAP

Build host information:
Linux wsbb04 3.13.0-37-generic #64-Ubuntu SMP Mon Sep 22 21:28:38 UTC 2014
x86_64 x86_64 x86_64 GNU/Linux
Distributor ID:Ubuntu
Description:Ubuntu 14.04.1 LTS
Release:14.04
Codename:trusty

Buildbot information:
BUILDBOT_REPOSITORY=
BUILDBOT_BUILDNUMBER=595
BUILDBOT_URL=http://buildbot.wireshark.org/trunk-1.10/
BUILDBOT_BUILDERNAME=Fuzz Test
BUILDBOT_SLAVENAME=fuzz-test
BUILDBOT_GOT_REVISION=810ed9b46de9b65de22565bcb9f48b7c5758addf

Return value:  139

Dissector bug:  0

Valgrind error count:  0



Git commit
commit 810ed9b46de9b65de22565bcb9f48b7c5758addf
Author: Guy Harris 
Date:   Fri Oct 17 18:31:26 2014 -0700

More replacement of ctype.h functions.

Change-Id: I6a1b5b4e621080490d2f3161d954425973faeb5c
Reviewed-on: https://code.wireshark.org/review/4810
Reviewed-by: Guy Harris 


Command and args: ./tshark -nVxr


[ no debug trace ]

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Sent via:Wireshark-bugs mailing list 
Archives:http://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 10583] Buildbot crash output: fuzz-2014-10-18-26900.pcap

2014-10-18 Thread bugzilla-daemon
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=10583

Guy Harris  changed:

   What|Removed |Added

 Status|CONFIRMED   |RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #1 from Guy Harris  ---
Looks like infinite recursion in the AMQP dissector.  And the bug says:

/home/wireshark/menagerie/menagerie/13179-AMQPDTX.CAP

which is the capture attached to bug 10582.

Probably best treated as a dup of 10582.

*** This bug has been marked as a duplicate of bug 10582 ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Sent via:Wireshark-bugs mailing list 
Archives:http://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 10582] AMQP dissector crash

2014-10-18 Thread bugzilla-daemon
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=10582

Guy Harris  changed:

   What|Removed |Added

 CC||buildbot-do-not-reply@wires
   ||hark.org

--- Comment #7 from Guy Harris  ---
*** Bug 10583 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Sent via:Wireshark-bugs mailing list 
Archives:http://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 10584] New: Buildbot crash output: fuzz-2014-10-18-14589.pcap

2014-10-18 Thread bugzilla-daemon
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=10584

Bug ID: 10584
   Summary: Buildbot crash output: fuzz-2014-10-18-14589.pcap
   Product: Wireshark
   Version: unspecified
  Hardware: x86-64
   URL: https://www.wireshark.org/download/automated/captures/
fuzz-2014-10-18-14589.pcap
OS: Ubuntu
Status: CONFIRMED
  Severity: Major
  Priority: High
 Component: Dissection engine (libwireshark)
  Assignee: bugzilla-ad...@wireshark.org
  Reporter: buildbot-do-not-re...@wireshark.org

Problems have been found with the following capture file:

https://www.wireshark.org/download/automated/captures/fuzz-2014-10-18-14589.pcap

stderr:
Input file: /home/wireshark/menagerie/menagerie/13179-AMQPDTX.CAP

Build host information:
Linux wsbb04 3.13.0-37-generic #64-Ubuntu SMP Mon Sep 22 21:28:38 UTC 2014
x86_64 x86_64 x86_64 GNU/Linux
Distributor ID:Ubuntu
Description:Ubuntu 14.04.1 LTS
Release:14.04
Codename:trusty

Buildbot information:
BUILDBOT_REPOSITORY=
BUILDBOT_BUILDNUMBER=214
BUILDBOT_URL=http://buildbot.wireshark.org/master-1.12/
BUILDBOT_BUILDERNAME=Fuzz Test
BUILDBOT_SLAVENAME=fuzz-test
BUILDBOT_GOT_REVISION=c734c57a37e4a84e8b66cc054d4b2c07aecebc9e

Return value:  139

Dissector bug:  0

Valgrind error count:  0



Git commit
commit c734c57a37e4a84e8b66cc054d4b2c07aecebc9e
Author: Guy Harris 
Date:   Fri Oct 17 18:16:10 2014 -0700

Don't use ctype.h routines.

That eliminates locale-dependent behavior when parsing packets.

While we're at it, rename a variable to reflect what it's being used for.

Change-Id: I672553c784edf73f826dad993d7c47c3b545b506
Reviewed-on: https://code.wireshark.org/review/4807
Reviewed-by: Guy Harris 


Command and args:
/home/wireshark/builders/wireshark-1.12-fuzz/fuzztest/install/bin/tshark -nVxr


[ no debug trace ]

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Sent via:Wireshark-bugs mailing list 
Archives:http://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 10585] New: Buildbot crash output: fuzz-2014-10-18-27943.pcap

2014-10-18 Thread bugzilla-daemon
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=10585

Bug ID: 10585
   Summary: Buildbot crash output: fuzz-2014-10-18-27943.pcap
   Product: Wireshark
   Version: unspecified
  Hardware: x86-64
   URL: https://www.wireshark.org/download/automated/captures/
fuzz-2014-10-18-27943.pcap
OS: Ubuntu
Status: CONFIRMED
  Severity: Major
  Priority: High
 Component: Dissection engine (libwireshark)
  Assignee: bugzilla-ad...@wireshark.org
  Reporter: buildbot-do-not-re...@wireshark.org

Problems have been found with the following capture file:

https://www.wireshark.org/download/automated/captures/fuzz-2014-10-18-27943.pcap

stderr:
Input file: /home/wireshark/menagerie/menagerie/12694-AllJoynSample1.pcapng

Build host information:
Linux wsbb04 3.13.0-37-generic #64-Ubuntu SMP Mon Sep 22 21:28:38 UTC 2014
x86_64 x86_64 x86_64 GNU/Linux
Distributor ID:Ubuntu
Description:Ubuntu 14.04.1 LTS
Release:14.04
Codename:trusty

Buildbot information:
BUILDBOT_REPOSITORY=ssh://wireshark-build...@code.wireshark.org:29418/wireshark
BUILDBOT_BUILDNUMBER=3004
BUILDBOT_URL=http://buildbot.wireshark.org/trunk/
BUILDBOT_BUILDERNAME=Clang Code Analysis
BUILDBOT_SLAVENAME=clang-code-analysis
BUILDBOT_GOT_REVISION=44d4339eb335b6d6f7a8ffad6846e82aba90b233

Return value:  0

Dissector bug:  0

Valgrind error count:  77



Git commit
commit 44d4339eb335b6d6f7a8ffad6846e82aba90b233
Author: Guy Harris 
Date:   Thu Oct 16 23:20:52 2014 -0700

Don't use  macros, and eliminate an include of .

This avoids locale-dependent tests, and fixes cases where we passed
signed char values to those macros (which is not safe with char being
signed, as it is on most, but not all, platforms).

Change-Id: I51d9716fe3eb02a6e98208334285c07597a6be79
Reviewed-on: https://code.wireshark.org/review/4761
Reviewed-by: Guy Harris 


Command and args: ./tools/valgrind-wireshark.sh 

==26137== Memcheck, a memory error detector
==26137== Copyright (C) 2002-2013, and GNU GPL'd, by Julian Seward et al.
==26137== Using Valgrind-3.10.0.SVN and LibVEX; rerun with -h for copyright
info
==26137== Command:
/home/wireshark/builders/wireshark-master-fuzz/clangcodeanalysis/install/bin/tshark
-nr /fuzz/buildbot/clangcodeanalysis/valgrind-fuzz/fuzz-2014-10-18-27943.pcap
==26137== 
==26137== Invalid read of size 1
==26137==at 0x6719DBD: parse_arg (packet-alljoyn.c:1180)
==26137==by 0x671AA49: dissect_AllJoyn_message (packet-alljoyn.c:1387)
==26137==by 0x668D1AE: call_dissector_through_handle (packet.c:622)
==26137==by 0x668DA94: call_dissector_work (packet.c:713)
==26137==by 0x668E14B: dissector_try_uint_new (packet.c:1145)
==26137==by 0x6D89D95: decode_tcp_ports (packet-tcp.c:4049)
==26137==by 0x6D8A13E: process_tcp_payload (packet-tcp.c:4107)
==26137==by 0x6D8A92F: dissect_tcp_payload (packet-tcp.c:1987)
==26137==by 0x6D8C3AB: dissect_tcp (packet-tcp.c:5000)
==26137==by 0x668D173: call_dissector_through_handle (packet.c:626)
==26137==by 0x668DA94: call_dissector_work (packet.c:713)
==26137==by 0x668E14B: dissector_try_uint_new (packet.c:1145)
==26137==  Address 0x11adc923 is 0 bytes after a block of size 3 alloc'd
==26137==at 0x4C2CE8E: realloc (in
/usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
==26137==by 0x9AC16AE: g_realloc (in
/lib/x86_64-linux-gnu/libglib-2.0.so.0.4000.0)
==26137==by 0x71B3F70: wmem_simple_realloc (wmem_allocator_simple.c:90)
==26137==by 0x71B552C: wmem_strbuf_finalize (wmem_strbuf.c:252)
==26137==by 0x67197E8: parse_arg (packet-alljoyn.c:940)
==26137==by 0x671A8EB: dissect_AllJoyn_message (packet-alljoyn.c:1288)
==26137==by 0x668D1AE: call_dissector_through_handle (packet.c:622)
==26137==by 0x668DA94: call_dissector_work (packet.c:713)
==26137==by 0x668E14B: dissector_try_uint_new (packet.c:1145)
==26137==by 0x6D89D95: decode_tcp_ports (packet-tcp.c:4049)
==26137==by 0x6D8A13E: process_tcp_payload (packet-tcp.c:4107)
==26137==by 0x6D8A92F: dissect_tcp_payload (packet-tcp.c:1987)
==26137== 
==26137== Invalid read of size 1
==26137==at 0x6719D97: parse_arg (packet-alljoyn.c:1181)
==26137==by 0x671AA49: dissect_AllJoyn_message (packet-alljoyn.c:1387)
==26137==by 0x668D1AE: call_dissector_through_handle (packet.c:622)
==26137==by 0x668DA94: call_dissector_work (packet.c:713)
==26137==by 0x668E14B: dissector_try_uint_new (packet.c:1145)
==26137==by 0x6D89D95: decode_tcp_ports (packet-tcp.c:4049)
==26137==by 0x6D8A13E: process_tcp_payload (packet-tcp.c:4107)
==26137==by 0x6D8A92F: dissect_tcp_payload (packet-tcp.c:1987)
==26137==by 0x6D8C3AB: dissect_tcp (packet-tcp.c:5000)
==26137==by 0x668D173: call_dissector_through_handle (packet.c:626)
==26137==by 0x668DA94: call_dissector_work (packet.c:713)
==26137==by 0x668E14B: dissecto

[Wireshark-bugs] [Bug 10586] New: Buildbot crash output: fuzz-2014-10-19-4259.pcap

2014-10-18 Thread bugzilla-daemon
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=10586

Bug ID: 10586
   Summary: Buildbot crash output: fuzz-2014-10-19-4259.pcap
   Product: Wireshark
   Version: unspecified
  Hardware: x86-64
   URL: https://www.wireshark.org/download/automated/captures/
fuzz-2014-10-19-4259.pcap
OS: Ubuntu
Status: CONFIRMED
  Severity: Major
  Priority: High
 Component: Dissection engine (libwireshark)
  Assignee: bugzilla-ad...@wireshark.org
  Reporter: buildbot-do-not-re...@wireshark.org

Problems have been found with the following capture file:

https://www.wireshark.org/download/automated/captures/fuzz-2014-10-19-4259.pcap

stderr:
Input file: /home/wireshark/menagerie/menagerie/13179-AMQPDTX.CAP

Build host information:
Linux wsbb04 3.13.0-37-generic #64-Ubuntu SMP Mon Sep 22 21:28:38 UTC 2014
x86_64 x86_64 x86_64 GNU/Linux
Distributor ID:Ubuntu
Description:Ubuntu 14.04.1 LTS
Release:14.04
Codename:trusty

Buildbot information:
BUILDBOT_REPOSITORY=
BUILDBOT_BUILDNUMBER=215
BUILDBOT_URL=http://buildbot.wireshark.org/master-1.12/
BUILDBOT_BUILDERNAME=Fuzz Test
BUILDBOT_SLAVENAME=fuzz-test
BUILDBOT_GOT_REVISION=c734c57a37e4a84e8b66cc054d4b2c07aecebc9e

Return value:  139

Dissector bug:  0

Valgrind error count:  0



Git commit
commit c734c57a37e4a84e8b66cc054d4b2c07aecebc9e
Author: Guy Harris 
Date:   Fri Oct 17 18:16:10 2014 -0700

Don't use ctype.h routines.

That eliminates locale-dependent behavior when parsing packets.

While we're at it, rename a variable to reflect what it's being used for.

Change-Id: I672553c784edf73f826dad993d7c47c3b545b506
Reviewed-on: https://code.wireshark.org/review/4807
Reviewed-by: Guy Harris 


Command and args:
/home/wireshark/builders/wireshark-1.12-fuzz/fuzztest/install/bin/tshark -nVxr


[ no debug trace ]

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Sent via:Wireshark-bugs mailing list 
Archives:http://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 10586] Buildbot crash output: fuzz-2014-10-19-4259.pcap

2014-10-18 Thread bugzilla-daemon
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=10586

Michael Mann  changed:

   What|Removed |Added

 Status|CONFIRMED   |RESOLVED
 CC||mman...@netscape.net
 Resolution|--- |DUPLICATE

--- Comment #1 from Michael Mann  ---


*** This bug has been marked as a duplicate of bug 10584 ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Sent via:Wireshark-bugs mailing list 
Archives:http://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 10584] Buildbot crash output: fuzz-2014-10-18-14589.pcap

2014-10-18 Thread bugzilla-daemon
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=10584

--- Comment #1 from Michael Mann  ---
*** Bug 10586 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Sent via:Wireshark-bugs mailing list 
Archives:http://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 10585] Buildbot crash output: fuzz-2014-10-18-27943.pcap

2014-10-18 Thread bugzilla-daemon
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=10585

Michael Mann  changed:

   What|Removed |Added

 CC||jhuff...@codeaurora.org

--- Comment #1 from Michael Mann  ---
CCing Joe Huffman, original author of AllJoyn dissector

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Sent via:Wireshark-bugs mailing list 
Archives:http://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 10584] Buildbot crash output: fuzz-2014-10-18-14589.pcap

2014-10-18 Thread bugzilla-daemon
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=10584

Michael Mann  changed:

   What|Removed |Added

 Status|CONFIRMED   |RESOLVED
 CC||mman...@netscape.net
 Resolution|--- |DUPLICATE

--- Comment #2 from Michael Mann  ---


*** This bug has been marked as a duplicate of bug 10582 ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Sent via:Wireshark-bugs mailing list 
Archives:http://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 10582] AMQP dissector crash

2014-10-18 Thread bugzilla-daemon
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=10582

--- Comment #8 from Michael Mann  ---
*** Bug 10584 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Sent via:Wireshark-bugs mailing list 
Archives:http://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe