[Wireshark-bugs] [Bug 12580] (Qt5) after obtaining a packet trace, crashes when quitting or starting new trace

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=12580

Alexis La Goutte  changed:

   What|Removed |Added

 CC||alexis.lagou...@gmail.com

--- Comment #4 from Alexis La Goutte  ---
Thanks for the analysis and the patch 


Can you push the patch on Gerrit ?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 12271] Support for Service Function Chaining Network Service Header Encapsulated with VxLan-gpe (draft-ietf-sfc-nsh-02.txt)

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=12271

--- Comment #4 from Gerrit Code Review  ---
Change 16251 merged by Michael Mann:
Support for NSH with VXLAN-GPE encapsulation

https://code.wireshark.org/review/16251

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 12271] Support for Service Function Chaining Network Service Header Encapsulated with VxLan-gpe (draft-ietf-sfc-nsh-02.txt)

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=12271

Gerrit Code Review  changed:

   What|Removed |Added

 Status|INCOMPLETE  |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 12581] ICMP Echo reply for ICMP Echo request to multicast address can't be found

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=12581

--- Comment #2 from Gerrit Code Review  ---
Change 16252 had a related patch set uploaded by João Valverde:
ICMP: Avoid "no response found" for multicast ping

https://code.wireshark.org/review/16252

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 12271] Support for Service Function Chaining Network Service Header Encapsulated with VxLan-gpe (draft-ietf-sfc-nsh-02.txt)

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=12271

Sumit Kumar Jha  changed:

   What|Removed |Added

 CC||sj...@ncsu.edu

--- Comment #3 from Sumit Kumar Jha  ---
Created attachment 14701
  --> https://bugs.wireshark.org/bugzilla/attachment.cgi?id=14701&action=edit
Network service header with VXLAN encapsulation

Hi.

I have attached a sample pcap file for capturing Network Service Header (NSH)
with VXLAN Genric Protocol Extension (VXLAN-GPE) encapsulation

Thanks
Sumit

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 12323] Support for General Protocol Extension in VxLAN (draft-ietf-nvo3-vxlan-gpe-01.txt)

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=12323

--- Comment #2 from Sumit Kumar Jha  ---
Created attachment 14700
  --> https://bugs.wireshark.org/bugzilla/attachment.cgi?id=14700&action=edit
Generic Protocol Extension for VXLAN

Hi.

I have attached a sample pcap file for capturing generic protocol extension of
VXLAN

Thanks
Sumit

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 12067] Unable to resize the packet list pane, packet details pane

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=12067

--- Comment #9 from James Elliott  ---
(In reply to Matt Day from comment #8)
> (In reply to James Elliott from comment #7)
> > I can report, however, that removing it and reinstalling it --with-qt-5 made
> > everything work fine, so I am going to remove my votes, and just use the
> > newer QT version!
> 
> I'm surprised to hear you say everything works fine with Qt 5, though I
> agree that at least the packet list panes are resizeable there.
> 
> When I built with Qt 5 to get resizeable packet list panes, I immediately
> ran into two new bugs:
> 
> bug 12580 - (Qt5) after obtaining a packet trace, crashes when quitting or
> starting new trace
> 
> bug 12582 - (Qt5) app menus won't pull down
> 
> It seems nobody has tested Wireshark+Qt5 much beyond successful compilation.

Ow, how painful! I feel really lucky that it is working for me now.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 12067] Unable to resize the packet list pane, packet details pane

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=12067

--- Comment #8 from Matt Day  ---
(In reply to James Elliott from comment #7)
> I can report, however, that removing it and reinstalling it --with-qt-5 made
> everything work fine, so I am going to remove my votes, and just use the
> newer QT version!

I'm surprised to hear you say everything works fine with Qt 5, though I agree
that at least the packet list panes are resizeable there.

When I built with Qt 5 to get resizeable packet list panes, I immediately ran
into two new bugs:

bug 12580 - (Qt5) after obtaining a packet trace, crashes when quitting or
starting new trace

bug 12582 - (Qt5) app menus won't pull down

It seems nobody has tested Wireshark+Qt5 much beyond successful compilation.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 12582] New: (Qt5) app menus won't pull down

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=12582

Bug ID: 12582
   Summary: (Qt5) app menus won't pull down
   Product: Wireshark
   Version: 2.0.4
  Hardware: x86-64
OS: Mac OS X 10.11
Status: UNCONFIRMED
  Severity: Major
  Priority: Low
 Component: Qt UI
  Assignee: bugzilla-ad...@wireshark.org
  Reporter: fja...@gmail.com

Build Information:
Wireshark with Qt 5 was installed via Homebrew by running:
brew install --with-qt5 wireshark

Wireshark 2.0.4 (Git Rev Unknown from unknown)

Copyright 1998-2016 Gerald Combs  and contributors.
License GPLv2+: GNU GPL version 2 or later

This is free software; see the source for copying conditions. There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

Compiled (64-bit) with Qt 5.6.1, with libpcap, without POSIX capabilities, with
libz 1.2.5, with GLib 2.48.1, without SMI, with c-ares 1.11.0, without Lua,
with
GnuTLS 3.4.13, with Gcrypt 1.7.1, with MIT Kerberos, with GeoIP, with
QtMultimedia, without AirPcap.

Running on Mac OS X 10.11.5, build 15F34 (Darwin 15.5.0), with locale C, with
libpcap version 1.5.3 - Apple version 54, with libz 1.2.5, with GnuTLS 3.4.13,
with Gcrypt 1.7.1.
Intel(R) Xeon(R) CPU   E5462  @ 2.80GHz

Built using clang 4.2.1 Compatible Apple LLVM 7.3.0 (clang-703.0.31).

--
In order to avoid the problem of bug 12067 (can't resize packet trace panes
when built with Qt4), I'm building Wireshark with Qt 5 on my OS X systems.

But, after starting Wireshark, the app menus do not pull down when selected by
the mouse. To reproduce:

1. brew install --with-qt5 wireshark
2. start Wireshark
3. use the mouse to try to open any of the app menus (the pull-down menus on
the OS X menu bar)
4. observe that none of the app menus will pull down or react to the mouse in
any way

Workaround: The app menus function properly after switching focus to another
app and then switching focus back to Wireshark.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 12581] ICMP Echo reply for ICMP Echo request to multicast address can't be found

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=12581

João Valverde  changed:

   What|Removed |Added

 Status|UNCONFIRMED |CONFIRMED
 Ever confirmed|0   |1

--- Comment #1 from João Valverde  ---
(In reply to Garri from comment #0)
> Created attachment 14698 [details]
> Multicast ICMP Echo packets
> 
> Build Information:
> Version 2.1.0-git (v2.1.0rc0-3301-gf7cd537 from unknown)
> --
> Dear Wireshark developers,
> 
> Wireshark generates 'no response found!' when ICMP is used to ping multicast
> IP address, even if there is an ICMP Echo reply for the request. I believe
> Wireshark should not search an ICMP Echo reply for an ICMP Echo request to
> multicast address or it should search a reply with different source IP
> address but with related Echo identified, sequence number and destination IP
> address.

I agree...

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 12580] (Qt5) after obtaining a packet trace, crashes when quitting or starting new trace

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=12580

--- Comment #3 from Matt Day  ---
Created attachment 14699
  --> https://bugs.wireshark.org/bugzilla/attachment.cgi?id=14699&action=edit
a patch that stops the crash from happening

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 12580] (Qt5) after obtaining a packet trace, crashes when quitting or starting new trace

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=12580

--- Comment #2 from Matt Day  ---
Yeah, the crash stops happening after amending PacketList::selectionChanged()
to avoid calling QTreeView::selectionChanged() when `selected` is empty.

I haven't had enough experience with Qt to say whether this patch is the best
way to solve this problem, but it is an improvement, at least.

I will add this diff as an attachment:

--- ui/qt/packet_list.cpp.orig2016-06-07 12:27:47.0 -0600
+++ ui/qt/packet_list.cpp2016-07-02 16:46:15.0 -0600
@@ -434,7 +434,9 @@
 }

 void PacketList::selectionChanged (const QItemSelection & selected, const
QItemSelection & deselected) {
-QTreeView::selectionChanged(selected, deselected);
+if (!selected.isEmpty()) {
+QTreeView::selectionChanged(selected, deselected);
+}

 if (!cap_file_) return;

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 12580] (Qt5) after obtaining a packet trace, crashes when quitting or starting new trace

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=12580

--- Comment #1 from Matt Day  ---
To investigate further, I built the same Wireshark 2.0.4 source (as obtained
via Homebrew) locally with Qt 5, and added some debugging prints.

What's happening is:

* PacketList::freeze() is calling QTreeView::setModel(NULL)
* this results in PacketList::selectionChanged() being called with an empty
`selected` parameter
* the first thing PacketList::selectionChanged() does is call
QTreeView::selectionChanged(selected, deselected) with those same parameters
* it then crashes in the guts of Qt

Specifically, PacketList::selectionChanged() is being called with an empty
`selected` (size 0), and a `deselected` of size 1 (and the one item is valid).

I'm no Qt programmer, but looks like it's wrong to call
QTreeView::selectionChanged with an empty `selected` parameter. (No idea why
this crash doesn't happen in Qt 4)

According to http://doc.qt.io/qt-5/qabstractitemview.html#selectionChanged ...

  "void QAbstractItemView::selectionChanged(const QItemSelection &selected,
const QItemSelection &deselected)
   This slot is called when the selection is changed. The previous selection
(which may be empty), is specified by deselected, and the new selection by
selected."

Looks like `deselected` is permitted to be empty, implying that `selected` must
not be. (The Qt 4 documentation is identical.)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 12581] ICMP Echo reply for ICMP Echo request to multicast address can't be found

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=12581

Alexis La Goutte  changed:

   What|Removed |Added

 CC||alexis.lagou...@gmail.com,
   ||joao.valverde@tecnico.ulisb
   ||oa.pt

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 12581] New: ICMP Echo reply for ICMP Echo request to multicast address can't be found

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=12581

Bug ID: 12581
   Summary: ICMP Echo reply for ICMP Echo request to multicast
address can't be found
   Product: Wireshark
   Version: Git
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: Normal
  Priority: Low
 Component: Dissection engine (libwireshark)
  Assignee: bugzilla-ad...@wireshark.org
  Reporter: g.djavad...@gmail.com

Created attachment 14698
  --> https://bugs.wireshark.org/bugzilla/attachment.cgi?id=14698&action=edit
Multicast ICMP Echo packets

Build Information:
Version 2.1.0-git (v2.1.0rc0-3301-gf7cd537 from unknown)
--
Dear Wireshark developers,

Wireshark generates 'no response found!' when ICMP is used to ping multicast IP
address, even if there is an ICMP Echo reply for the request. I believe
Wireshark should not search an ICMP Echo reply for an ICMP Echo request to
multicast address or it should search a reply with different source IP address
but with related Echo identified, sequence number and destination IP address.

The dump of the affected ICMP conversation is attached. Many thanks in advance!

Garri

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 12580] New: (Qt5) after obtaining a packet trace, crashes when quitting or starting new trace

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=12580

Bug ID: 12580
   Summary: (Qt5) after obtaining a packet trace, crashes when
quitting or starting new trace
   Product: Wireshark
   Version: 2.0.4
  Hardware: x86-64
OS: Mac OS X 10.11
Status: UNCONFIRMED
  Severity: Major
  Priority: Low
 Component: Qt UI
  Assignee: bugzilla-ad...@wireshark.org
  Reporter: fja...@gmail.com

Created attachment 14697
  --> https://bugs.wireshark.org/bugzilla/attachment.cgi?id=14697&action=edit
full crash report

Build Information:
Wireshark with Qt 5 was installed via Homebrew by running:
brew install --with-qt5 wireshark

Wireshark 2.0.4 (Git Rev Unknown from unknown)

Copyright 1998-2016 Gerald Combs  and contributors.
License GPLv2+: GNU GPL version 2 or later

This is free software; see the source for copying conditions. There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

Compiled (64-bit) with Qt 5.6.1, with libpcap, without POSIX capabilities, with
libz 1.2.5, with GLib 2.48.1, without SMI, with c-ares 1.11.0, without Lua,
with
GnuTLS 3.4.13, with Gcrypt 1.7.1, with MIT Kerberos, with GeoIP, with
QtMultimedia, without AirPcap.

Running on Mac OS X 10.11.5, build 15F34 (Darwin 15.5.0), with locale C, with
libpcap version 1.5.3 - Apple version 54, with libz 1.2.5, with GnuTLS 3.4.13,
with Gcrypt 1.7.1.
Intel(R) Xeon(R) CPU   E5462  @ 2.80GHz

Built using clang 4.2.1 Compatible Apple LLVM 7.3.0 (clang-703.0.31).
--
In order to avoid the problem of bug 12067 (can't resize packet trace panes
when built with Qt4), I'm building Wireshark with Qt 5 on my OS X systems.

But, there is a very easy, severe crash that happens when built with Qt 5. To
reproduce it:

1. brew install --with-qt5 wireshark
2. start Wireshark
3. start a packet trace and capture a few packets
4. stop the packet trace
5. quit wireshark (without saving)
5a. instead of quitting, the same crash also happens when you start capturing a
new trace

When the crash occurs, these messages are printed at the shell:

Cannot creat accessible child interface for object:  PacketList(0x7ffe9683a7e0)
 index:  0
Cannot creat accessible child interface for object:  PacketList(0x7ffe9683a7e0)
 index:  0
Cannot creat accessible child interface for object:  PacketList(0x7ffe9683a7e0)
 index:  0
[1]94376 segmentation fault  wireshark

Attached is a full crash report. The interesting part is thread 0's backtrace:

Thread 0 Crashed:: Dispatch queue: com.apple.main-thread
0   org.qt-project.QtGui  0x00010abc7e33
QAccessibleEvent::uniqueId() const + 163
1   libqcocoa.dylib   0x00010e749873
QCocoaAccessibility::notifyAccessibilityUpdate(QAccessibleEvent*) + 83
2   org.qt-project.QtWidgets  0x00010a7a31f0
QTreeView::selectionChanged(QItemSelection const&, QItemSelection const&) + 880
3   wireshark 0x000105bbde96
PacketList::selectionChanged(QItemSelection const&, QItemSelection const&) + 28
4   org.qt-project.QtWidgets  0x00010a75037a
QAbstractItemView::setSelectionModel(QItemSelectionModel*) + 1178
5   org.qt-project.QtWidgets  0x00010a7924f7
QTreeView::setSelectionModel(QItemSelectionModel*) + 119
6   org.qt-project.QtWidgets  0x00010a74fe85
QAbstractItemView::setModel(QAbstractItemModel*) + 1269
7   org.qt-project.QtWidgets  0x00010a79231c
QTreeView::setModel(QAbstractItemModel*) + 604
8   wireshark 0x000105bba072 PacketList::freeze() +
126
9   wireshark 0x000105a3349a cf_close + 343
10  wireshark 0x000105b658f3
MainWindow::testCaptureFileClose(bool, QString) + 2223
11  wireshark 0x000105b64d32
MainWindow::closeEvent(QCloseEvent*) + 116
12  org.qt-project.QtWidgets  0x00010a520a08
QWidget::event(QEvent*) + 2184
13  org.qt-project.QtWidgets  0x00010a63019a
QMainWindow::event(QEvent*) + 1546
14  org.qt-project.QtWidgets  0x00010a4df096
QApplicationPrivate::notify_helper(QObject*, QEvent*) + 294
15  org.qt-project.QtWidgets  0x00010a4e05f8
QApplication::notify(QObject*, QEvent*) + 504
16  org.qt-project.QtCore 0x00010b3ef814
QCoreApplication::notifyInternal2(QObject*, QEvent*) + 164
17  org.qt-project.QtWidgets  0x00010a5104cd
QWidgetPrivate::close_helper(QWidgetPrivate::CloseMode) + 189
18  org.qt-project.QtWidgets  0x00010a527d92
QWidget::qt_static_metacall(QObject*, QMetaObject::Call, int, void**) + 1554
19  org.qt-project.QtCore 0x00010b424d96
QMetaObject::activate(QObject*, int, int, void**) + 742
20  org.qt-project.QtWidgets  0x00010a4d59f7
QAction::activate(QAction::ActionEvent) + 263
21  o

[Wireshark-bugs] [Bug 12567] Wireshark requires strict format for SPI field of ESP/SA configuration option

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=12567

--- Comment #2 from Gerrit Code Review  ---
Change 16248 had a related patch set uploaded by Michael Mann:
Treat SPI field in ESP/SA configuration as string only if wildcards are used.

https://code.wireshark.org/review/16248

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 12579] New: TCP: nextseq incorrect if TCP_MAX_UNACKED_SEGMENTS exceeded & FIN true

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=12579

Bug ID: 12579
   Summary: TCP: nextseq incorrect if TCP_MAX_UNACKED_SEGMENTS
exceeded & FIN true
   Product: Wireshark
   Version: 2.0.4
  Hardware: x86
OS: Mac OS X 10.11
Status: UNCONFIRMED
  Severity: Normal
  Priority: Low
 Component: Dissection engine (libwireshark)
  Assignee: bugzilla-ad...@wireshark.org
  Reporter: from_wiresh...@frear.com

Build Information:
Wireshark 2.0.4 (v2.0.4-0-gdd7746e from master-2.0)

Copyright 1998-2016 Gerald Combs  and contributors.
License GPLv2+: GNU GPL version 2 or later

This is free software; see the source for copying conditions. There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

Compiled (64-bit) with Qt 5.3.2, with libpcap, without POSIX capabilities, with
libz 1.2.5, with GLib 2.36.0, with SMI 0.4.8, with c-ares 1.10.0, with Lua 5.2,
with GnuTLS 2.12.19, with Gcrypt 1.5.0, with MIT Kerberos, with GeoIP, with
QtMultimedia, without AirPcap.

Running on Mac OS X 10.11.5, build 15F34 (Darwin 15.5.0), with locale C, with
libpcap version 1.5.3 - Apple version 54, with libz 1.2.5, with GnuTLS 2.12.19,
with Gcrypt 1.5.0.
Intel(R) Core(TM) i7-4980HQ CPU @ 2.80GHz (with SSE4.2)

Built using llvm-gcc 4.2.1 (Based on Apple Inc. build 5658) (LLVM build
2336.9.00).
--
If tcp data payload (tcp.len) is present, FIN is set, and we've
exceeded TCP_MAX_UNACKED_SEGMENTS, then we don't calculate next
sequence number correctly.

The code to consider the FIN already exists, but is inside of an if
statement that is there for an unrelated purpose, checking for
too many unacked segments to suppress adding sequences to the fwd list.

I've pushed my proposed fix for this into the wireshark code submission system:
Change-Id: Idb68cea4b4dcba39461019c08db09367cbfc6d68
at
https://code.wireshark.org/review/#q,Idb68cea4b4dcba39461019c08db09367cbfc6d68,n,z

To generate an demonstration packet, copy and paste this into
the commandline

openssl base64 -d << EOF | \
gzip -dc | \
text2pcap - demonstration-invalid-nextseq-packet.pcap
H4sICBAheFcCA3NhbXBsZS1wYWNrZXQuaGV4AJ3YTW6DMBRF4XlWcZfw/hzMcgyF
/S+hmCSt1FF1pCcLKTnPTL4JZmaSrmPOLnNFqtrvw3NRXzU2WZ//mT/Zw8zvrKlS
dqgW1b1ink+NoSjZ+OyN1/OVxec2n2czja59ve85tZeWRZtp3XWc2pq6ydcry5nl
rq3rPOe8F/s9/V6/zZdcQ0fMpTFvq5ktQ+16H/vnXFmb2b+Dn+zJsoVlnWUrywbL
NpbtLPti2cGyE2VuLHOWBcuSZcUy5s2ZN2fenHlz5s2ZN2fenHlz5s2ZN2fegnkL
5i2Yt2DegnkL5i2Yt2DegnkL5i2Yt2DegnkL5i2Yt2DeknlL5i2Zt2TeknlL5i2Z
t2TeknlL5i2Zt2TeknlL5i2Zt2Teinkr5q2Yt2Leinkr5q2Yt2Leinkr5q2Yt2Le
inkr5q2Yt2LeGvPWmLfGvDXmrTFv7ePt9Wnmz7y/1Mx5fAPaUGWSbhIAAA==
EOF

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 7336] Sort is considering only packet count while displaying the results instead of percents

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7336

--- Comment #1 from Gerald Combs  ---
In the GTK+ UI the "Lost" column is rendered using a GtkCellRendererText. It's
doing a string comparison to sort the column instead of a numeric comparison.
(The Qt UI does a numeric comparison.)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 7336] Sort is considering only packet count while displaying the results instead of percents

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7336

Tzu  changed:

   What|Removed |Added

  Component|Qt UI   |GTK+ UI

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 12576] Attempted use of uninitialized pointer in dissect_nds_request

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=12576

Michael Mann  changed:

   What|Removed |Added

 CC||buildbot-do-not-reply@wires
   ||hark.org

--- Comment #4 from Michael Mann  ---
*** Bug 12578 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 12578] Buildbot crash output: fuzz-2016-07-02-25220.pcap

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=12578

Michael Mann  changed:

   What|Removed |Added

 Status|CONFIRMED   |RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #1 from Michael Mann  ---


*** This bug has been marked as a duplicate of bug 12576 ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 12576] Attempted use of uninitialized pointer in dissect_nds_request

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=12576

Gerrit Code Review  changed:

   What|Removed |Added

 Status|CONFIRMED   |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 12576] Attempted use of uninitialized pointer in dissect_nds_request

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=12576

--- Comment #2 from Gerrit Code Review  ---
Change 16245 had a related patch set uploaded by Michael Mann:
dissect_nds_request: Add NULL check

https://code.wireshark.org/review/16245

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 12568] Wireshark is marking BGP FlowSpec NLRI as malformed if NLRI length is larger than 239 bytes

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=12568

Gerrit Code Review  changed:

   What|Removed |Added

 Resolution|WONTFIX |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 12568] Wireshark is marking BGP FlowSpec NLRI as malformed if NLRI length is larger than 239 bytes

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=12568

--- Comment #30 from Gerrit Code Review  ---
Change 16237 merged by Michael Mann:
BGP: Fixed an side effect of length coding on offset

https://code.wireshark.org/review/16237

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 12577] Divide-by-zero error in dissect_pbb_tlvblock()

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=12577

--- Comment #4 from Gerrit Code Review  ---
Change 16244 had a related patch set uploaded by Michael Mann:
packetbb: Prevent divide by 0.

https://code.wireshark.org/review/16244

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 12577] Divide-by-zero error in dissect_pbb_tlvblock()

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=12577

--- Comment #3 from Gerrit Code Review  ---
Change 16243 had a related patch set uploaded by Michael Mann:
packetbb: Prevent divide by 0.

https://code.wireshark.org/review/16243

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 12577] Divide-by-zero error in dissect_pbb_tlvblock()

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=12577

--- Comment #2 from Gerrit Code Review  ---
Change 16241 merged by Michael Mann:
packetbb: Prevent divide by 0.

https://code.wireshark.org/review/16241

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 12577] Divide-by-zero error in dissect_pbb_tlvblock()

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=12577

Gerrit Code Review  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 12577] Divide-by-zero error in dissect_pbb_tlvblock()

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=12577

--- Comment #1 from Gerrit Code Review  ---
Change 16241 had a related patch set uploaded by Michael Mann:
packetbb: Prevent divide by 0.

https://code.wireshark.org/review/16241

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 12576] Attempted use of uninitialized pointer in dissect_nds_request

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=12576

Michael Mann  changed:

   What|Removed |Added

 Status|UNCONFIRMED |CONFIRMED
 Ever confirmed|0   |1

--- Comment #1 from Michael Mann  ---
This is only present on the 1.12 branch.  The refactoring of NCP prior to 2.0
release fixed this.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 12578] New: Buildbot crash output: fuzz-2016-07-02-25220.pcap

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=12578

Bug ID: 12578
   Summary: Buildbot crash output: fuzz-2016-07-02-25220.pcap
   Product: Wireshark
   Version: unspecified
  Hardware: x86-64
   URL: https://www.wireshark.org/download/automated/captures/
fuzz-2016-07-02-25220.pcap
OS: Ubuntu
Status: CONFIRMED
  Severity: Major
  Priority: High
 Component: Dissection engine (libwireshark)
  Assignee: bugzilla-ad...@wireshark.org
  Reporter: buildbot-do-not-re...@wireshark.org

Problems have been found with the following capture file:

https://www.wireshark.org/download/automated/captures/fuzz-2016-07-02-25220.pcap

stderr:
Input file: /home/wireshark/menagerie/menagerie/14695-sample.pcap

Build host information:
Linux wsbb04 3.13.0-86-generic #131-Ubuntu SMP Thu May 12 23:33:13 UTC 2016
x86_64 x86_64 x86_64 GNU/Linux
Distributor ID:Ubuntu
Description:Ubuntu 14.04.4 LTS
Release:14.04
Codename:trusty

Buildbot information:
BUILDBOT_REPOSITORY=
BUILDBOT_BUILDNUMBER=954
BUILDBOT_URL=http://buildbot.wireshark.org/wireshark-1.12/
BUILDBOT_BUILDERNAME=Fuzz Test
BUILDBOT_SLAVENAME=fuzz-test
BUILDBOT_GOT_REVISION=d49fb83f6f6b6ef4ffc4accb6c5071cca1f7b4be

Return value:  139

Dissector bug:  0

Valgrind error count:  0



Git commit
commit d49fb83f6f6b6ef4ffc4accb6c5071cca1f7b4be
Author: Ashish Shukla 
Date:   Fri Jun 24 15:59:39 2016 -0700

radiotap: Fix for the VHT 20MHz MCS 9 data rate not displayed

MCS 9 at 20 MHz is valid for 3 and 6 spatial streams.
Changed the rate table to include rate (mbps) for VHT 20MHz MCS 9.

Signed-off-by: Alexis La Goutte 

Bug: 12558
Change-Id: Ia16ae545a5ac1779131e24e1f54a5659390cd321
Reviewed-on: https://code.wireshark.org/review/16146
Reviewed-by: Guy Harris 
(cherry picked from commit a4711f80c6d466cdd7eef376bf911699f55d35eb)
Reviewed-on: https://code.wireshark.org/review/16161


Command and args:
/home/wireshark/builders/wireshark-1.12-fuzz/fuzztest/install/bin/tshark -nVxr


[ no debug trace ]

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 12561] DCE/RPC malformed error when stub-data is missing but a sub-dissector has been registered

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=12561

--- Comment #10 from Gerrit Code Review  ---
Change 16240 merged by Pascal Quantin:
proto.c: allow calling get_hfi_length() with a 0 byte tvb and length=-1

https://code.wireshark.org/review/16240

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 12561] DCE/RPC malformed error when stub-data is missing but a sub-dissector has been registered

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=12561

--- Comment #9 from Gerrit Code Review  ---
Change 16240 had a related patch set uploaded by Pascal Quantin:
proto.c: allow calling get_hfi_length() with a 0 byte tvb and length=-1

https://code.wireshark.org/review/16240

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 12561] DCE/RPC malformed error when stub-data is missing but a sub-dissector has been registered

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=12561

--- Comment #8 from Gerrit Code Review  ---
Change 16167 merged by Anders Broman:
proto.c: allow calling get_hfi_length() with a 0 byte tvb and length=-1

https://code.wireshark.org/review/16167

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 12561] DCE/RPC malformed error when stub-data is missing but a sub-dissector has been registered

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=12561

Gerrit Code Review  changed:

   What|Removed |Added

 Status|IN_PROGRESS |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe