date:20200226

[Wireshark-bugs] [Bug 16396] TCP stream not linked if ICMP includes less than 16 B of TCP

2020-02-26 Thread bugzilla-daemon

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=16396

--- Comment #1 from Rasmus Jonsson  ---
This is in fact expected behaviour. packet-icmp.c has the following comment:

/* There is a collision between RFC 1812 and draft-ietf-mpls-icmp-02.
   We don't know how to decode the 128th and following bytes of the ICMP
payload.
   According to draft-ietf-mpls-icmp-02, these bytes should be decoded as MPLS
extensions
   whereas RFC 1812 tells us to decode them as a portion of the original
packet.
   Let the user decide.
   Here the user decided to favor MPLS extensions.
   Force the IP dissector to decode only the first 128 bytes. */

https://tools.ietf.org/html/rfc1812
https://tools.ietf.org/html/draft-ietf-mpls-icmp-02

Wireshark opted for the second approach.

> * The encapsulated TCP header not padded enough (the enveloping IP packet
> length increased from the original 56 to only 63 B) so, that the dissector
> engine does not associate it with any TCP streams:

The reason this works is that the code expects a multiple of 32 bytes, when you
padded you reached 32, and it was treated as the "original datagram" part.

Perhaps the "user choice" could be moved into the Wireshark preferences?

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 16379] Support dissecting the encrypted (phase 2) EAP packets of EAP-TEAP

2020-02-26 Thread bugzilla-daemon

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=16379

Mikael Kanstrup  changed:

   What|Removed |Added

 Status|IN_PROGRESS |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 16396] TCP stream not linked if ICMP includes less than 16 B of TCP

2020-02-26 Thread bugzilla-daemon

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=16396

Rasmus Jonsson  changed:

   What|Removed |Added

   Assignee|bugzilla-ad...@wireshark.or |was...@zom.bi
   |g   |
 CC||was...@zom.bi

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 16396] TCP stream not linked if ICMP includes less than 16 B of TCP

2020-02-26 Thread bugzilla-daemon

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=16396

Rasmus Jonsson  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|UNCONFIRMED |CONFIRMED

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 16416] Check for updates, and auto-update, not working in 3.2.1

2020-02-26 Thread bugzilla-daemon

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=16416

--- Comment #2 from Guy Harris  ---
(In reply to Guy Harris from comment #1)
> However, if, on my main machine, I remove 3.2.1 (as in "sudo rm -rf
> /Applications/Wireshark.app") and download and install 3.2.0, it behaves the
> same way as 3.2.1 does - no auto-popup for updating, and the weird download
> with no dialogs popping up.

3.2.2 obviously doesn't pop up an auto-update dialog, but if I do "Check for
Updates", it pops up nothing - no "you're up to date!" dialog.  It does no
downloading, perhaps because there's no update to download.

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 16416] Check for updates, and auto-update, not working in 3.2.1

2020-02-26 Thread bugzilla-daemon

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=16416

--- Comment #1 from Guy Harris  ---
(In reply to Guy Harris from comment #0)
> If this is reproducible, we might want to put in a note about auto-update in
> 3.2.1, similar to the note for Windows; 3.2.0 appeared to auto-update OK on
> a VM.

However, if, on my main machine, I remove 3.2.1 (as in "sudo rm -rf
/Applications/Wireshark.app") and download and install 3.2.0, it behaves the
same way as 3.2.1 does - no auto-popup for updating, and the weird download
with no dialogs popping up.

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 16416] New: Check for updates, and auto-update, not working in 3.2.1

2020-02-26 Thread bugzilla-daemon

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=16416

Bug ID: 16416
   Summary: Check for updates, and auto-update, not working in
3.2.1
   Product: Wireshark
   Version: 3.2.1
  Hardware: x86-64
OS: macOS 10.15
Status: UNCONFIRMED
  Severity: Major
  Priority: Low
 Component: Qt UI
  Assignee: bugzilla-ad...@wireshark.org
  Reporter: g...@alum.mit.edu
  Target Milestone: ---

Build Information:
Wireshark 3.2.1 (v3.2.1-0-gbf38a67724d0)

Copyright 1998-2020 Gerald Combs  and contributors.
License GPLv2+: GNU GPL version 2 or later

This is free software; see the source for copying conditions. There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

Compiled (64-bit) with Qt 5.12.6, with libpcap, without POSIX capabilities,
with
GLib 2.37.6, with zlib 1.2.11, with SMI 0.4.8, with c-ares 1.15.0, with Lua
5.2.4, with GnuTLS 3.4.17, with Gcrypt 1.7.7, with MIT Kerberos, with MaxMind
DB
resolver, with nghttp2 1.39.2, with brotli, with LZ4, with Zstandard, with
Snappy, with libxml2 2.9.9, with QtMultimedia, with SpeexDSP (using bundled
resampler), with SBC, with SpanDSP, with bcg729.

Running on Mac OS X 10.15.3, build 19D76 (Darwin 19.3.0), with Intel(R)
Core(TM)
i9-9980HK CPU @ 2.40GHz (with SSE4.2), with 65536 MB of physical memory, with
locale en_US.UTF-8, with libpcap version 1.9.1, with GnuTLS 3.4.17, with Gcrypt
1.7.7, with brotli 1.0.7, with zlib 1.2.11, binary plugins supported (0
loaded).

Built using clang 4.2.1 Compatible Apple LLVM 11.0.0 (clang-1100.0.33.16).
--
When I started 3.2.1, it didn't say anything about 3.2.2 being available.

If I do Help > Check for Updates, it starts fetching something from
dl1.wireshark.net, but doesn't pop up any dialog, even when it appears to be
finished doing whatever it's doing.

If this is reproducible, we might want to put in a note about auto-update in
3.2.1, similar to the note for Windows; 3.2.0 appeared to auto-update OK on a
VM.

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 16379] Support dissecting the encrypted (phase 2) EAP packets of EAP-TEAP

2020-02-26 Thread bugzilla-daemon

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=16379

--- Comment #5 from Gerrit Code Review  ---
Change 36104 merged by Anders Broman:
Add TEAP dissector

https://code.wireshark.org/review/36104

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 11221] Cannot re-set manually resolved address

2020-02-26 Thread bugzilla-daemon

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=11221

--- Comment #11 from Gerrit Code Review  ---
Change 36206 had a related patch set uploaded by Dylan Ulis:
Edit Resolved Name: Allow user to remove name

https://code.wireshark.org/review/36206

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 16414] Packet List selection is gone when adding or removing a display filter

2020-02-26 Thread bugzilla-daemon

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=16414

--- Comment #2 from Gerrit Code Review  ---
Change 36204 had a related patch set uploaded by Rasmus Jonsson:
Qt: fix packet list selection regression

https://code.wireshark.org/review/36204

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 16407] Wireshark not working for other admin users - 'permission denied' error

2020-02-26 Thread bugzilla-daemon

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=16407

--- Comment #6 from Gerrit Code Review  ---
Change 36203 had a related patch set uploaded by Gerald Combs:
macOS: Add a sanity check.

https://code.wireshark.org/review/36203

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 16414] Packet List selection is gone when adding or removing a display filter

2020-02-26 Thread bugzilla-daemon

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=16414

Rasmus Jonsson  changed:

   What|Removed |Added

   Assignee|bugzilla-ad...@wireshark.or |was...@zom.bi
   |g   |

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 16414] Packet List selection is gone when adding or removing a display filter

2020-02-26 Thread bugzilla-daemon

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=16414

Rasmus Jonsson  changed:

   What|Removed |Added

 Status|UNCONFIRMED |CONFIRMED
 Ever confirmed|0   |1
 CC||was...@zom.bi

--- Comment #1 from Rasmus Jonsson  ---
I can confirm this.

Steps:

1. Have a capture open.
2. Select a packet with protocol e.g. TCP and note the packet number.
3. Add a "tcp" filter.
4. That packet is still visible but not selected.

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 16407] Wireshark not working for other admin users - 'permission denied' error

2020-02-26 Thread bugzilla-daemon

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=16407

--- Comment #5 from Gerrit Code Review  ---
Change 36193 had a related patch set uploaded by Gerald Combs:
macOS: Add a sanity check.

https://code.wireshark.org/review/36193

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 16407] Wireshark not working for other admin users - 'permission denied' error

2020-02-26 Thread bugzilla-daemon

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=16407

--- Comment #4 from Gerald Combs  ---
(In reply to Guy Harris from comment #1)
> 2) That file - and all other files - should be rw-r--r--, not rw---.

This appears to have been due to a umask issue on the macOS builder. Running

find path/to/build/directory ! -perm -0444

returned a bunch of files. I removed the master and master-3.2 build
directories which forced a fresh git clone and the find command no longer
returns anything.

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 13193] Support for DTLS-SRTP (used by WebRTC) with SIP signalling over Websockets

2020-02-26 Thread bugzilla-daemon

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=13193

Peter Wu  changed:

   What|Removed |Added

 Status|IN_PROGRESS |CONFIRMED

--- Comment #6 from Peter Wu  ---
This is now listed at
https://wiki.wireshark.org/GSoC2020#WebRTC:_DTLS-SRTP_decryption_and_Opus_playback_support

Further notes:
The original WebRTC architecture link is unfortunately dead, however the
details are still the same.

DTLS-SRTP uses the exporter secret as defined in
Keying Material Exporters for Transport Layer Security (TLS)
https://tools.ietf.org/html/rfc5705#section-4

The Opus codec library can be found at:
https://opus-codec.org/

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 16413] Buildbot crash output: randpkt-2020-02-26-4920.pcap

2020-02-26 Thread bugzilla-daemon

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=16413

--- Comment #1 from Gerald Combs  ---
I'm unable to duplicate this here on macOS and Ubuntu.

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 16410] Importing profiles in Windows - zip files fail and from directory crashes Wireshark

2020-02-26 Thread bugzilla-daemon

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=16410

Tomasz Mon  changed:

   What|Removed |Added

 CC||deso...@gmail.com
 Ever confirmed|0   |1
 Status|UNCONFIRMED |CONFIRMED

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 16396] TCP stream not linked if ICMP includes less than 16 B of TCP

2020-02-26 Thread bugzilla-daemon

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=16396

Betty DuBois  changed:

   What|Removed |Added

 CC||be...@bettydubois.com

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 16411] Filter bthci_cmd.le_long_tem_key is spelled incorrectly

2020-02-26 Thread bugzilla-daemon

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=16411

Alexis La Goutte  changed:

   What|Removed |Added

 CC||alexis.lagou...@gmail.com
 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |FIXED

--- Comment #5 from Alexis La Goutte  ---
Thanks,

it will be fixed on next 3.2.x (planned soon)

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 16411] Filter bthci_cmd.le_long_tem_key is spelled incorrectly

2020-02-26 Thread bugzilla-daemon

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=16411

--- Comment #4 from Gerrit Code Review  ---
Change 36188 merged by Anders Broman:
bthci_cmd: fix typo

https://code.wireshark.org/review/36188

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 16414] Packet List selection is gone when adding or removing a display filter

2020-02-26 Thread bugzilla-daemon

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=16414

Stig Bjørlykke  changed:

   What|Removed |Added

 CC||rkn...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 16414] New: Packet List selection is gone when adding or removing a display filter

2020-02-26 Thread bugzilla-daemon

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=16414

Bug ID: 16414
   Summary: Packet List selection is gone when adding or removing
a display filter
   Product: Wireshark
   Version: 3.2.1
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: Normal
  Priority: Low
 Component: Qt UI
  Assignee: bugzilla-ad...@wireshark.org
  Reporter: s...@bjorlykke.org
  Target Milestone: ---

Build Information:
3.2.1 (v3.2.1-0-gbf38a67724d0)

Compiled (64-bit) with Qt 5.12.6, with libpcap, without POSIX capabilities,
with
GLib 2.37.6, with zlib 1.2.11, with SMI 0.4.8, with c-ares 1.15.0, with Lua
5.2.4, with GnuTLS 3.4.17, with Gcrypt 1.7.7, with MIT Kerberos, with MaxMind
DB
resolver, with nghttp2 1.39.2, with brotli, with LZ4, with Zstandard, with
Snappy, with libxml2 2.9.9, with QtMultimedia, with SpeexDSP (using bundled
resampler), with SBC, with SpanDSP, with bcg729.

Running on Mac OS X 10.15.3, build 19D76 (Darwin 19.3.0), with Intel(R)
Core(TM)
i7-6700K CPU @ 4.00GHz (with SSE4.2), with 16384 MB of physical memory, with
locale C, with light display mode, with HiDPI, with libpcap version 1.9.1, with
GnuTLS 3.4.17, with Gcrypt 1.7.7, with brotli 1.0.7, with zlib 1.2.11, binary
plugins supported (19 loaded).

Built using clang 4.2.1 Compatible Apple LLVM 11.0.0 (clang-1100.0.33.16).

--
The Packet List selection is gone when adding or removing a display filter. The
Packet Details and Packet Bytes still show the data for the selected packet,
but operations on the Packet List (mark, ignore, time reference, etc.) does not
work.

This is a regression from c07aad10159327ef09041c80c2de71ce576505fb
Review in https://code.wireshark.org/review/35135

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 16411] Filter bthci_cmd.le_long_tem_key is spelled incorrectly

2020-02-26 Thread bugzilla-daemon

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=16411

--- Comment #3 from Gerrit Code Review  ---
Change 36188 had a related patch set uploaded by Alexis La Goutte:
bthci_cmd: fix typo

https://code.wireshark.org/review/36188

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 16413] New: Buildbot crash output: randpkt-2020-02-26-4920.pcap

2020-02-26 Thread bugzilla-daemon

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=16413

Bug ID: 16413
   Summary: Buildbot crash output: randpkt-2020-02-26-4920.pcap
   Product: Wireshark
   Version: unspecified
  Hardware: x86-64
OS: Ubuntu
Status: CONFIRMED
  Severity: Major
  Priority: High
 Component: Dissection engine (libwireshark)
  Assignee: bugzilla-ad...@wireshark.org
  Reporter: buildbot-do-not-re...@wireshark.org
  Target Milestone: ---

Problems have been found with the following capture file:

https://www.wireshark.org/download/automated/captures/randpkt-2020-02-26-4920.pcap

stderr:
Input file: 

Build host information:
Linux build6 4.15.0-88-generic #88-Ubuntu SMP Tue Feb 11 20:11:34 UTC 2020
x86_64 x86_64 x86_64 GNU/Linux
Distributor ID: Ubuntu
Description:Ubuntu 18.04.4 LTS
Release:18.04
Codename:   bionic

Buildbot information:
BUILDBOT_WORKERNAME=fuzz-test
BUILDBOT_BUILDNUMBER=157
BUILDBOT_BUILDERNAME=Fuzz Test
BUILDBOT_URL=http://buildbot.wireshark.org/wireshark-3.0/
BUILDBOT_REPOSITORY=ssh://wireshark-build...@code.wireshark.org:29418/wireshark
BUILDBOT_GOT_REVISION=68a6a92bff2a9cb5b599a8bfd23c0eba1da07148

Return value:  134

Dissector bug:  0

Valgrind error count:  0



Git commit
commit 68a6a92bff2a9cb5b599a8bfd23c0eba1da07148
Author: Guy Harris 
Date:   Sat Feb 22 20:35:43 2020 -0800

Use "must" instead of "should" to avoid ambiguity.

As I said in

   
https://ask.wireshark.org/question/10361/how-to-properly-use-heuristic-dissector-for-tcp/?answer=10363#post-id-10363

  "Should" has multiple meanings; there's "Used to indicate obligation,
  duty, or correctness, typically when criticizing someone's actions.", as
  in "I think we should trust our people more", and there's "Used to
  indicate what is probable.", as in "the bus should arrive in a few
  minutes". You're reading it in the latter sense; it was intended in the
  former sense.

  That sentence should probably be changed to "Wireshark must be then set
  up..." to avoid the ambiguity.

Make it so (over half a year later, sigh), and change another case where
"should" is meant in the first sense while we're at it.

Change-Id: I90198d1616619c75802deeeb703ceee0c8bac1bf
Reviewed-on: https://code.wireshark.org/review/36155
Reviewed-by: Guy Harris 
(cherry picked from commit c268e9b0d563cfd248fae611c06e39430e1bad6c)
Reviewed-on: https://code.wireshark.org/review/36157


Command and args:
/home/wireshark/builders/wireshark-3.0-fuzz/fuzztest/install.asan/bin/tshark
-nVxr

Null pointer passed to bytes_to_str()

[ no debug trace ]

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 16396] TCP stream not linked if ICMP includes less than 16 B of TCP

[Wireshark-bugs] [Bug 16379] Support dissecting the encrypted (phase 2) EAP packets of EAP-TEAP

[Wireshark-bugs] [Bug 16396] TCP stream not linked if ICMP includes less than 16 B of TCP

[Wireshark-bugs] [Bug 16396] TCP stream not linked if ICMP includes less than 16 B of TCP

[Wireshark-bugs] [Bug 16416] Check for updates, and auto-update, not working in 3.2.1

[Wireshark-bugs] [Bug 16416] Check for updates, and auto-update, not working in 3.2.1

[Wireshark-bugs] [Bug 16416] New: Check for updates, and auto-update, not working in 3.2.1

[Wireshark-bugs] [Bug 16379] Support dissecting the encrypted (phase 2) EAP packets of EAP-TEAP

[Wireshark-bugs] [Bug 11221] Cannot re-set manually resolved address

[Wireshark-bugs] [Bug 16414] Packet List selection is gone when adding or removing a display filter

[Wireshark-bugs] [Bug 16407] Wireshark not working for other admin users - 'permission denied' error

[Wireshark-bugs] [Bug 16414] Packet List selection is gone when adding or removing a display filter

[Wireshark-bugs] [Bug 16414] Packet List selection is gone when adding or removing a display filter

[Wireshark-bugs] [Bug 16407] Wireshark not working for other admin users - 'permission denied' error

[Wireshark-bugs] [Bug 16407] Wireshark not working for other admin users - 'permission denied' error

[Wireshark-bugs] [Bug 13193] Support for DTLS-SRTP (used by WebRTC) with SIP signalling over Websockets

[Wireshark-bugs] [Bug 16413] Buildbot crash output: randpkt-2020-02-26-4920.pcap

[Wireshark-bugs] [Bug 16410] Importing profiles in Windows - zip files fail and from directory crashes Wireshark

[Wireshark-bugs] [Bug 16396] TCP stream not linked if ICMP includes less than 16 B of TCP

[Wireshark-bugs] [Bug 16411] Filter bthci_cmd.le_long_tem_key is spelled incorrectly

[Wireshark-bugs] [Bug 16411] Filter bthci_cmd.le_long_tem_key is spelled incorrectly

[Wireshark-bugs] [Bug 16414] Packet List selection is gone when adding or removing a display filter

[Wireshark-bugs] [Bug 16414] New: Packet List selection is gone when adding or removing a display filter

[Wireshark-bugs] [Bug 16411] Filter bthci_cmd.le_long_tem_key is spelled incorrectly

[Wireshark-bugs] [Bug 16413] New: Buildbot crash output: randpkt-2020-02-26-4920.pcap

25 matches

Site Navigation

Mail list logo

Footer information