[Wireshark-bugs] [Bug 11131] Wrong color scheme for packet filter

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=11131

Pascal Quantin  changed:

   What|Removed |Added

 Status|CONFIRMED   |RESOLVED
 CC||pascal.quan...@gmail.com
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 11131] Wrong color scheme for packet filter

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=11131

--- Comment #14 from Gerrit Code Review  ---
Change 21827 merged by Anders Broman:
Qt+prefs: Add a dark theme check and default colors.

https://code.wireshark.org/review/21827

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 11131] Wrong color scheme for packet filter

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=11131

Guy Harris  changed:

   What|Removed |Added

   Hardware|x86 |All

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 11131] Wrong color scheme for packet filter

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=11131

--- Comment #13 from Guy Harris  ---
For what it's worth:

QPalette:

http://doc.qt.io/qt-5/qpalette.html

doesn't seem to have color roles that would correspond to "OK", "not OK", and
"maybe OK", or anything that would correspond to our green/red/yellow colors
for filter boxes.

KDE's KColorScheme API:

https://api.kde.org/frameworks/kconfigwidgets/html/classKColorScheme.html

has the notion of "negative", "neutral", and "positive" background colors and
foreground text colors.  It might be nice to have Wireshark, when running on
KDE, pick up those colors from the current theme, but it'd also probably be
nice to have Wireshark on {Linux,*BSD,Solaris,other UN*Xes with names that
don't contain "OS X" or "mac"} not require that you have KDE installed.

macOS appears not to have any notion of "positive", "negative", and "neutral"
colors, so we're on our own there.  Then again, macOS also doesn't have much in
the way of color themes - exactly as Apple intends.

GetSysColor() in Windows:

   
https://msdn.microsoft.com/en-us/library/windows/desktop/ms724371(v=vs.85).aspx

doesn't appear to have those notions, either.

So Gerald's change is probably the right way to handle this, unless somebody
*really* complains about their KDE theme's positive/neutral/negative colors not
being used or unless there's some better way to calculate the right colors.

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 11131] Wrong color scheme for packet filter

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=11131

Gerald Combs  changed:

   What|Removed |Added

 CC||wiresh...@sedrubal.de

--- Comment #12 from Gerald Combs  ---
*** Bug 13738 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 11131] Wrong color scheme for packet filter

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=11131

--- Comment #11 from Gerrit Code Review  ---
Change 21827 had a related patch set uploaded by Gerald Combs:
Qt+prefs: Add a dark theme check and default colors.

https://code.wireshark.org/review/21827

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 11131] Wrong color scheme for packet filter

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=11131

Michael Mann  changed:

   What|Removed |Added

 Status|INCOMPLETE  |CONFIRMED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 11131] Wrong color scheme for packet filter

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=11131

Michael Mann  changed:

   What|Removed |Added

  Component|GTK+ UI |Qt UI
   Severity|Major   |Normal

--- Comment #10 from Michael Mann  ---
I don't see a reason for this to be marked INCOMPLETE.  Bug seems fairly well
explained and doesn't have any missing information.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 11131] Wrong color scheme for packet filter

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=11131

--- Comment #9 from Mate Soos mas...@cisco.com ---
(In reply to Gerald Combs from comment #8)
 The syntax line edit, which is used for the capture and display filter
 entries, is a bit of a special case. The foreground is drawn using the
 palette text color but the background is drawn using custom colors.

Exactly. I used the newest GIT about 1-2 months ago and it was the same with
the QT. Essentially unusable. Imagine an app where the developers assume you
use white text just like them! They then specifically set the background to
dark gray because it's nicer than the default black they of course use.
Hilarity ensues.

The moral of the story is that if you mess with any of the
foreground/background colours you must ensure that you also mess with the
reverse (background/foreground) colours, too. Neither the QT nor the GTK
version of Wireshark fix the foreground colour or allow me to change it. But
they both set the background to light red when the filter is not right -- i.e.
when typing any unfinished filter expression.

As far as I see, this is a bug that is trivial to solve: allow a user to change
the foreground colour. You already allow to change the background colour (most
of the time, not for the 'incorrect expression'='red' -- also a bug).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Sent via:Wireshark-bugs mailing list wireshark-bugs@wireshark.org
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 11131] Wrong color scheme for packet filter

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=11131

--- Comment #5 from Alexis La Goutte alexis.lagou...@gmail.com ---
(In reply to Mate Soos from comment #4)
 OK, newest version with QT now (1.12.4), just compiled it. I cannot change
 the font color only the background color
 (edit-preferences-appearance-'font and colors'). This is mostly OK but
 once we can change the background of the filter, we might as well allow the
 user to change the font color too.

For Qt, you need to use 1.99.x

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Sent via:Wireshark-bugs mailing list wireshark-bugs@wireshark.org
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 11131] Wrong color scheme for packet filter

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=11131

--- Comment #6 from Guy Harris g...@alum.mit.edu ---
(In reply to Alexis La Goutte from comment #3)
 (In reply to Mate Soos from comment #2)
  I didn't try with more updated release. But I'd bet good money that it would
  still be a bug. As for the Qt interface, I didn't try but even if that's
  fine, the bug would still apply to GTK. I think it should be fixable with a
  2-3 line diff. Let me try to do that in the evening, out of working hours,
  and attach a diff.
  
  Cheers,
  
  Mate
 
 GTK Gui is deprecated and the work is actually on Qt Gui

For the current supported release, the GTK+ GUI is the official supported GUI,
and we do fix bugs in it, so this should probably be fixed.  We don't add new
*features* to the currently supported release (unless that's necessary to fix a
bug, but we *do* fix bugs.

New *feature* work is done in the trunk, and we aren't adding new features to
the GTK+ GUI unless that's done as part of the process of adding new
capabilities to the Qt UI.  We're also fixing bugs with the Qt GUI, but we
might as well put any GTK+ bug fixes in the 1.12 branch into the trunk as well.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Sent via:Wireshark-bugs mailing list wireshark-bugs@wireshark.org
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 11131] Wrong color scheme for packet filter

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=11131

--- Comment #8 from Gerald Combs ger...@wireshark.org ---
Can you try the Qt UI from Git master? I've tried to be careful about using
QPalette in the Qt port, e.g. palette().text().color() instead of Qt::black. I
ran some tests using the Windows High Contrast theme a while back but it
would be helpful if someone who uses a dark theme daily could take a look at
it.

The syntax line edit, which is used for the capture and display filter entries,
is a bit of a special case. The foreground is drawn using the palette text
color but the background is drawn using custom colors. Most platforms (and Qt
by extension) don't make moral judgements about text like we do so we have to
make up colors for good, bad, and deprecated. The colors can be changed
via Preferences→Font and Colors in case they don't look right on your
particular platform.


Ideally we should do something similar in the GTK+ UI but that path appears to
lead down a deprecation rabbit hole:

https://developer.gnome.org/gtk3/stable/GtkSettings.html#GtkSettings--gtk-color-scheme

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Sent via:Wireshark-bugs mailing list wireshark-bugs@wireshark.org
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 11131] Wrong color scheme for packet filter

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=11131

--- Comment #7 from Guy Harris g...@alum.mit.edu ---
(In reply to Mate Soos from comment #2)
 I didn't try with more updated release. But I'd bet good money that it would
 still be a bug.

But you might lose that money. :-)  We're not supporting 1.10 any more, so
fixes to that won't be checked in, but we are still supporting 1.12, so please
try it with 1.12.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Sent via:Wireshark-bugs mailing list wireshark-bugs@wireshark.org
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 11131] Wrong color scheme for packet filter

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=11131

--- Comment #4 from Mate Soos mas...@cisco.com ---
OK, newest version with QT now (1.12.4), just compiled it. I cannot change the
font color only the background color (edit-preferences-appearance-'font and
colors'). This is mostly OK but once we can change the background of the
filter, we might as well allow the user to change the font color too.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Sent via:Wireshark-bugs mailing list wireshark-bugs@wireshark.org
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 11131] Wrong color scheme for packet filter

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=11131

--- Comment #2 from Mate Soos mas...@cisco.com ---
I didn't try with more updated release. But I'd bet good money that it would
still be a bug. As for the Qt interface, I didn't try but even if that's fine,
the bug would still apply to GTK. I think it should be fixable with a 2-3 line
diff. Let me try to do that in the evening, out of working hours, and attach a
diff.

Cheers,

Mate

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Sent via:Wireshark-bugs mailing list wireshark-bugs@wireshark.org
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 11131] Wrong color scheme for packet filter

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=11131

Alexis La Goutte alexis.lagou...@gmail.com changed:

   What|Removed |Added

 Status|UNCONFIRMED |INCOMPLETE
 CC||alexis.lagou...@gmail.com
 Ever confirmed|0   |1

--- Comment #1 from Alexis La Goutte alexis.lagou...@gmail.com ---
Do you have try with more update release (like 1.12) or with Qt Gui ? (1.99.x)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Sent via:Wireshark-bugs mailing list wireshark-bugs@wireshark.org
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 11131] Wrong color scheme for packet filter

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=11131

--- Comment #3 from Alexis La Goutte alexis.lagou...@gmail.com ---
(In reply to Mate Soos from comment #2)
 I didn't try with more updated release. But I'd bet good money that it would
 still be a bug. As for the Qt interface, I didn't try but even if that's
 fine, the bug would still apply to GTK. I think it should be fixable with a
 2-3 line diff. Let me try to do that in the evening, out of working hours,
 and attach a diff.
 
 Cheers,
 
 Mate

GTK Gui is deprecated and the work is actually on Qt Gui

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Sent via:Wireshark-bugs mailing list wireshark-bugs@wireshark.org
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 11131] Wrong color scheme for packet filter

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=11131

Alexis La Goutte alexis.lagou...@gmail.com changed:

   What|Removed |Added

 CC||ger...@wireshark.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Sent via:Wireshark-bugs mailing list wireshark-bugs@wireshark.org
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe