[Wireshark-bugs] [Bug 12580] (Qt5) after obtaining a packet trace, crashes when quitting or starting new trace
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=12580 Peter Wu changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED CC||pe...@lekensteyn.nl Resolution|--- |FIXED --- Comment #7 from Peter Wu --- Thanks for the feedback, marking as solved. -- You are receiving this mail because: You are watching all bug changes. ___ Sent via:Wireshark-bugs mailing list Archives:https://www.wireshark.org/lists/wireshark-bugs Unsubscribe: https://wireshark.org/mailman/options/wireshark-bugs mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe
[Wireshark-bugs] [Bug 12580] (Qt5) after obtaining a packet trace, crashes when quitting or starting new trace
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=12580 --- Comment #6 from Matt Day --- (In reply to Gerald Combs from comment #5) > @Matt can you try the change in https://code.wireshark.org/review/#/c/16062/ > ? I've tried this patch, and yes, it fixes the problem. Thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Sent via:Wireshark-bugs mailing list Archives:https://www.wireshark.org/lists/wireshark-bugs Unsubscribe: https://wireshark.org/mailman/options/wireshark-bugs mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe
[Wireshark-bugs] [Bug 12580] (Qt5) after obtaining a packet trace, crashes when quitting or starting new trace
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=12580 --- Comment #5 from Gerald Combs --- @Matt can you try the change in https://code.wireshark.org/review/#/c/16062/ ? -- You are receiving this mail because: You are watching all bug changes. ___ Sent via:Wireshark-bugs mailing list Archives:https://www.wireshark.org/lists/wireshark-bugs Unsubscribe: https://wireshark.org/mailman/options/wireshark-bugs mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe
[Wireshark-bugs] [Bug 12580] (Qt5) after obtaining a packet trace, crashes when quitting or starting new trace
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=12580 Alexis La Goutte changed: What|Removed |Added CC||alexis.lagou...@gmail.com --- Comment #4 from Alexis La Goutte --- Thanks for the analysis and the patch Can you push the patch on Gerrit ? -- You are receiving this mail because: You are watching all bug changes. ___ Sent via:Wireshark-bugs mailing list Archives:https://www.wireshark.org/lists/wireshark-bugs Unsubscribe: https://wireshark.org/mailman/options/wireshark-bugs mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe
[Wireshark-bugs] [Bug 12580] (Qt5) after obtaining a packet trace, crashes when quitting or starting new trace
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=12580 --- Comment #3 from Matt Day --- Created attachment 14699 --> https://bugs.wireshark.org/bugzilla/attachment.cgi?id=14699&action=edit a patch that stops the crash from happening -- You are receiving this mail because: You are watching all bug changes. ___ Sent via:Wireshark-bugs mailing list Archives:https://www.wireshark.org/lists/wireshark-bugs Unsubscribe: https://wireshark.org/mailman/options/wireshark-bugs mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe
[Wireshark-bugs] [Bug 12580] (Qt5) after obtaining a packet trace, crashes when quitting or starting new trace
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=12580
--- Comment #2 from Matt Day ---
Yeah, the crash stops happening after amending PacketList::selectionChanged()
to avoid calling QTreeView::selectionChanged() when `selected` is empty.
I haven't had enough experience with Qt to say whether this patch is the best
way to solve this problem, but it is an improvement, at least.
I will add this diff as an attachment:
--- ui/qt/packet_list.cpp.orig2016-06-07 12:27:47.0 -0600
+++ ui/qt/packet_list.cpp2016-07-02 16:46:15.0 -0600
@@ -434,7 +434,9 @@
}
void PacketList::selectionChanged (const QItemSelection & selected, const
QItemSelection & deselected) {
-QTreeView::selectionChanged(selected, deselected);
+if (!selected.isEmpty()) {
+QTreeView::selectionChanged(selected, deselected);
+}
if (!cap_file_) return;
--
You are receiving this mail because:
You are watching all bug changes.
___
Sent via:Wireshark-bugs mailing list
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://wireshark.org/mailman/options/wireshark-bugs
mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe
[Wireshark-bugs] [Bug 12580] (Qt5) after obtaining a packet trace, crashes when quitting or starting new trace
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=12580 --- Comment #1 from Matt Day --- To investigate further, I built the same Wireshark 2.0.4 source (as obtained via Homebrew) locally with Qt 5, and added some debugging prints. What's happening is: * PacketList::freeze() is calling QTreeView::setModel(NULL) * this results in PacketList::selectionChanged() being called with an empty `selected` parameter * the first thing PacketList::selectionChanged() does is call QTreeView::selectionChanged(selected, deselected) with those same parameters * it then crashes in the guts of Qt Specifically, PacketList::selectionChanged() is being called with an empty `selected` (size 0), and a `deselected` of size 1 (and the one item is valid). I'm no Qt programmer, but looks like it's wrong to call QTreeView::selectionChanged with an empty `selected` parameter. (No idea why this crash doesn't happen in Qt 4) According to http://doc.qt.io/qt-5/qabstractitemview.html#selectionChanged ... "void QAbstractItemView::selectionChanged(const QItemSelection &selected, const QItemSelection &deselected) This slot is called when the selection is changed. The previous selection (which may be empty), is specified by deselected, and the new selection by selected." Looks like `deselected` is permitted to be empty, implying that `selected` must not be. (The Qt 4 documentation is identical.) -- You are receiving this mail because: You are watching all bug changes. ___ Sent via:Wireshark-bugs mailing list Archives:https://www.wireshark.org/lists/wireshark-bugs Unsubscribe: https://wireshark.org/mailman/options/wireshark-bugs mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe
