[Wireshark-bugs] [Bug 12630] "Save As" not always enabled if you have a file open

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=12630

--- Comment #11 from Thomas Baudelet  ---
(In reply to Guy Harris from comment #10)
> I can't reproduce the "Save As" issue on a build from the tip of the
> master-2.0 branch, but I could reproduce it on the master branch; the
> previous changes fix that.
> 
> When you say "Reopen the new pcapng", do you mean "close the file or exit
> Wireshark, and then open the file"?
> 
> What are the exact steps to make "Save As" not enabled in a freshly-opened
> file?  ("Save" is another matter, as per my comments below.)

* On 2.0.4:
-> exiting Wireshark and opening new file: doesn't show Save As
-> Closing file without exiting Wireshark and opening new file: shows Save As

* On 2.1.1:
-> I even can't make the test! Save As doesn't appear at all when opening first
pcapng. I must edit a comment to make it appear.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 12630] "Save As" not always enabled if you have a file open

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=12630

--- Comment #10 from Guy Harris  ---
I can't reproduce the "Save As" issue on a build from the tip of the master-2.0
branch, but I could reproduce it on the master branch; the previous changes fix
that.

When you say "Reopen the new pcapng", do you mean "close the file or exit
Wireshark, and then open the file"?

What are the exact steps to make "Save As" not enabled in a freshly-opened
file?  ("Save" is another matter, as per my comments below.)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 12630] "Save As" not always enabled if you have a file open

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=12630

Gerrit Code Review  changed:

   What|Removed |Added

 Status|CONFIRMED   |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 12630] "Save As" not always enabled if you have a file open

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=12630

--- Comment #8 from Gerrit Code Review  ---
Change 16613 had a related patch set uploaded by Guy Harris:
Enable "Save As..." iff cf_can_save_as() returns TRUE.

https://code.wireshark.org/review/16613

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 12630] "Save As" not always enabled if you have a file open

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=12630

--- Comment #6 from Gerrit Code Review  ---
Change 16612 had a related patch set uploaded by Guy Harris:
Enable "Save As..." iff cf_can_save_as() returns TRUE.

https://code.wireshark.org/review/16612

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 12630] "Save As" not always enabled if you have a file open

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=12630

Guy Harris  changed:

   What|Removed |Added

Summary|"Save" and "Save As" not|"Save As" not always
   |always enabled if you have  |enabled if you have a file
   |a file open |open

--- Comment #5 from Guy Harris  ---
(In reply to Guy Harris from comment #4)
> (In reply to Guy Harris from comment #2)
> > "Save", however, *should* be disabled on a newly-opened file, as the file
> > hasn't been edited - there's nothing to save.
> 
> Actually, some experimentation with TextEdit, WordPad, KWrite, and gedit
> seem to indicate that keeping Save and Save As activated as long as you have
> a file open - and having Save write the file out even if nothing has changed
> - may be the right behavior.

On the other hand, we currently don't actually write out anything with "Save"
if there are no unsaved changes, so perhaps we shouldn't enable "Save" unless
it'll actually do anything.  We can consider changing "Save"'s behavior as a
separate item.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe