[Wireshark-bugs] [Bug 13672] Welcome screen invalid capture filter wihtout WinPcap installed causes runtime error

2017-05-29 Thread bugzilla-daemon
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=13672

--- Comment #15 from Kenneth Soerensen  ---
Thanks

This solves the issue.

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 13672] Welcome screen invalid capture filter wihtout WinPcap installed causes runtime error

2017-05-25 Thread bugzilla-daemon
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=13672

--- Comment #14 from Gerrit Code Review  ---
Change 21760 merged by Michael Mann:
Don't try to compile capture filter if pcap_compile isn't available.

https://code.wireshark.org/review/21760

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 13672] Welcome screen invalid capture filter wihtout WinPcap installed causes runtime error

2017-05-25 Thread bugzilla-daemon
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=13672

--- Comment #13 from Gerrit Code Review  ---
Change 21761 merged by Michael Mann:
Don't try to compile capture filter if pcap_compile isn't available.

https://code.wireshark.org/review/21761

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 13672] Welcome screen invalid capture filter wihtout WinPcap installed causes runtime error

2017-05-25 Thread bugzilla-daemon
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=13672

Michael Mann  changed:

   What|Removed |Added

 Status|CONFIRMED   |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 13672] Welcome screen invalid capture filter wihtout WinPcap installed causes runtime error

2017-05-25 Thread bugzilla-daemon
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=13672

--- Comment #12 from Gerrit Code Review  ---
Change 21761 had a related patch set uploaded by Michael Mann:
Don't try to compile capture filter if pcap_compile isn't available.

https://code.wireshark.org/review/21761

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 13672] Welcome screen invalid capture filter wihtout WinPcap installed causes runtime error

2017-05-25 Thread bugzilla-daemon
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=13672

--- Comment #11 from Gerrit Code Review  ---
Change 21760 had a related patch set uploaded by Michael Mann:
Don't try to compile capture filter if pcap_compile isn't available.

https://code.wireshark.org/review/21760

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 13672] Welcome screen invalid capture filter wihtout WinPcap installed causes runtime error

2017-05-25 Thread bugzilla-daemon
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=13672

--- Comment #10 from Gerrit Code Review  ---
Change 21757 merged by Michael Mann:
Don't try to compile capture filter if pcap_compile isn't available.

https://code.wireshark.org/review/21757

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 13672] Welcome screen invalid capture filter wihtout WinPcap installed causes runtime error

2017-05-25 Thread bugzilla-daemon
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=13672

--- Comment #9 from Gerrit Code Review  ---
Change 21757 had a related patch set uploaded by Michael Mann:
Don't try to compile capture file if pcap_compile isn't available.

https://code.wireshark.org/review/21757

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 13672] Welcome screen invalid capture filter wihtout WinPcap installed causes runtime error

2017-05-25 Thread bugzilla-daemon
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=13672

Michael Mann  changed:

   What|Removed |Added

 CC||mman...@netscape.net

--- Comment #8 from Michael Mann  ---
(In reply to Kenneth Soerensen from comment #6)
> You are right that it is not possible to compile a capture filter without
> (Win)Pcap. However, as far as I know the capture filter still makes sense
> because, as far as I know, the filter is passed directly to the extcap
> interface as a string using the --extcap-capture-filter option.

Right now I don't see a way to determine if capture interface is "extcap". 
There is external_cap_args_settings, but I'm not sure if that's always non-null
for all extcap interfaces.

I have a hack that is preventing the crash on Qt, but I can duplicate similar
issues on GTK.  The issue is that we're not always "gracefully" handling
has_wpcap == FALSE.

It seems the solution would be to not call pcap_compile (or similar) if capture
interface is extcap, but I can't figure out how to tell that.

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 13672] Welcome screen invalid capture filter wihtout WinPcap installed causes runtime error

2017-05-04 Thread bugzilla-daemon
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=13672

--- Comment #7 from Anders Broman  ---
As a side note
> Here Wireshark by it self populates the capture filter
> with 'not tcp port 3389' in order to ignore RDP.
Which is anoying in it self if you have a machine with an O interface and a
traffic interface and capture on the traffic interface(where the filter makes
no sense).

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 13672] Welcome screen invalid capture filter wihtout WinPcap installed causes runtime error

2017-05-04 Thread bugzilla-daemon
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=13672

--- Comment #6 from Kenneth Soerensen  ---
You are right that it is not possible to compile a capture filter without
(Win)Pcap. However, as far as I know the capture filter still makes sense
because, as far as I know, the filter is passed directly to the extcap
interface as a string using the --extcap-capture-filter option.

An example is the 'SSH remote capture'. On my installation without WinPcap the
filter entry becomes yellow when I enter a filter string and Wireshark does not
crash.

>From my point of the view, the problem is not that the filter doesn't make
sense but that Wireshark crashes if a capture filter is entered in this
situation.

The specific use case where we see this issue is when Wireshark is started via
remote desktop. Here Wireshark by it self populates the capture filter with
'not tcp port 3389' in order to ignore RDP. This makes sense for network
captures but not for an extcap capture. Even worse Wireshark crashes if you
forget to clear this filter before starting a capture.

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 13672] Welcome screen invalid capture filter wihtout WinPcap installed causes runtime error

2017-05-03 Thread bugzilla-daemon
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=13672

--- Comment #5 from Guy Harris  ---
Without WinPcap, how are you going to compile a capture filter?

I.e., "without WinPcap" also means "without pcap_compile() or bpf_filter()", so
you won't be able to apply any capture filters to an extcap device.

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 13672] Welcome screen invalid capture filter wihtout WinPcap installed causes runtime error

2017-05-03 Thread bugzilla-daemon
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=13672

Pascal Quantin  changed:

   What|Removed |Added

Summary|Welcome screen invalid  |Welcome screen invalid
   |capture filter causes   |capture filter wihtout
   |runtime error   |WinPcap installed causes
   ||runtime error
 Status|INCOMPLETE  |CONFIRMED

--- Comment #4 from Pascal Quantin  ---
Thanks for the detailed setup.
The key point to reproduce the issue is to uninstall WinPcap. When installed,
no crash happens.

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe