[Wireshark-bugs] [Bug 14636] NEWS is out of date and does not display properly in Notepad

2018-07-15 Thread bugzilla-daemon
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=14636

Michael Mann  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 14636] NEWS is out of date and does not display properly in Notepad

2018-05-01 Thread bugzilla-daemon
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=14636

--- Comment #11 from Gerrit Code Review  ---
Change 27242 merged by Anders Broman:
Force textify.ps1 to read files as UTF-8.

https://code.wireshark.org/review/27242

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 14636] NEWS is out of date and does not display properly in Notepad

2018-05-01 Thread bugzilla-daemon
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=14636

--- Comment #10 from Gerrit Code Review  ---
Change 27240 merged by Anders Broman:
Force textify.ps1 to read files as UTF-8.

https://code.wireshark.org/review/27240

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 14636] NEWS is out of date and does not display properly in Notepad

2018-05-01 Thread bugzilla-daemon
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=14636

--- Comment #9 from Gerrit Code Review  ---
Change 27242 had a related patch set uploaded by Gerald Combs:
Force textify.ps1 to read files as UTF-8.

https://code.wireshark.org/review/27242

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 14636] NEWS is out of date and does not display properly in Notepad

2018-05-01 Thread bugzilla-daemon
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=14636

--- Comment #8 from Guy Harris  ---
(In reply to Christopher Maynard from comment #0)
> Build Information:
> Paste the COMPLETE build information from "Help->About Wireshark",
> "wireshark -v", or "tshark -v".
> --
> The NEWS file for 2.6.0 still contains the following out-of-date information:
> 
>  This is the first release candidate for Wireshark 2.6.0.

That's easy to fix, but are there any changes between rc1 and the final release
that need to be reflected in the NEWS file?

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 14636] NEWS is out of date and does not display properly in Notepad

2018-05-01 Thread bugzilla-daemon
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=14636

--- Comment #7 from Christopher Maynard  ---
(In reply to Gerald Combs from comment #5)
> (In reply to Christopher Maynard from comment #3)
> > This also seems to work just fine:
> > 
> > type NEWS | MORE /P > NEWS.txt
> > 
> > (Credit:
> > https://stackoverflow.com/questions/17579553/windows-command-to-convert-unix-
> > line-endings)
> 
> Does "more" work across code pages? I don't think anyone uses 65001 (UTF-8)
> in practice, but it definitely breaks more:
> 
> > chcp 65001
> > more /?
> Not enough memory.

It seems to work OK for me:

>chcp
Active code page: 437

>chcp 65001
Active code page: 65001

>more /?
Displays output one screen at a time.

MORE [/E [/C] [/P] [/S] [/Tn] [+n]] < [drive:][path]filename
...

>type NEWS | MORE /P > NEWS.txt
>diff -b NEWS NEWS.txt
226a227
>

The only difference appears to be 1 less trailing blank line.

Well, I only mentioned unix2dos and this method as possible temporary
work-arounds, but the fix mentioned in comment #4 is probably the best
solution, especially if you're experiencing "Not enough memory" when running
`more`.

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 14636] NEWS is out of date and does not display properly in Notepad

2018-05-01 Thread bugzilla-daemon
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=14636

--- Comment #6 from Guy Harris  ---
(In reply to Gerald Combs from comment #5)
> Does "more" work across code pages? I don't think anyone uses 65001 (UTF-8)
> in practice, but it definitely breaks more:
> 
> > chcp 65001
> > more /?
> Not enough memory.

...and breaks other things, as I remember from a quick test I did, which may be
*why* nobody uses it in practice.

Perhaps the Shiny New Open Microsoft, in the Shiny New World where UTF-8
matters more and {pick your random ASCII-derived code page} depends less, will
make more of an effort to have Windows handle UTF-8 as well as UTF-16 in more
cases.

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 14636] NEWS is out of date and does not display properly in Notepad

2018-05-01 Thread bugzilla-daemon
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=14636

--- Comment #5 from Gerald Combs  ---
(In reply to Christopher Maynard from comment #3)
> This also seems to work just fine:
> 
> type NEWS | MORE /P > NEWS.txt
> 
> (Credit:
> https://stackoverflow.com/questions/17579553/windows-command-to-convert-unix-
> line-endings)

Does "more" work across code pages? I don't think anyone uses 65001 (UTF-8) in
practice, but it definitely breaks more:

> chcp 65001
> more /?
Not enough memory.

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 14636] NEWS is out of date and does not display properly in Notepad

2018-05-01 Thread bugzilla-daemon
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=14636

--- Comment #4 from Gerald Combs  ---
Fix inbound in https://code.wireshark.org/review/#/c/27240. We switched NEWS
from ASCII to UTF-8 and didn't update textify.ps1 to match. The goal is to
convert our various text files to a format that's double-clickable using
Notepad and to do so without requiring any extra dependencies like unix2dos. If
there's a better way to do so feel free to commit it.

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 14636] NEWS is out of date and does not display properly in Notepad

2018-05-01 Thread bugzilla-daemon
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=14636

--- Comment #3 from Christopher Maynard  ---
This also seems to work just fine:

type NEWS | MORE /P > NEWS.txt

(Credit:
https://stackoverflow.com/questions/17579553/windows-command-to-convert-unix-line-endings)

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 14636] NEWS is out of date and does not display properly in Notepad

2018-05-01 Thread bugzilla-daemon
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=14636

--- Comment #2 from Christopher Maynard  ---
(In reply to Jaap Keuter from comment #1)
> Well, the CMake build uses the textify.ps1 PowerShell script to rewrite the
> (non-BOM UTF-8) Unix file called NEWS to the (non-BOM UTF-8) Windows file
> called NEWS.txt. I'm not sure what the rewriting does; a straight up file
> copy seems not to confuse Notepad (apart from the line endings)

Indeed.  With Cygwin's "unix2dos -n NEWS NEWS.txt" command, the resulting file
displays just fine.  I'm not sure what the Powershell script is doing either.

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 14636] NEWS is out of date and does not display properly in Notepad

2018-05-01 Thread bugzilla-daemon
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=14636

--- Comment #1 from Jaap Keuter  ---
Well, the CMake build uses the textify.ps1 PowerShell script to rewrite the
(non-BOM UTF-8) Unix file called NEWS to the (non-BOM UTF-8) Windows file
called NEWS.txt. I'm not sure what the rewriting does; a straight up file copy
seems not to confuse Notepad (apart from the line endings)

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe