[Wireshark-bugs] [Bug 16083] Missing include causes builds to fail on specific include orders

2019-12-01 Thread bugzilla-daemon
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=16083

Michael Mann  changed:

   What|Removed |Added

 Resolution|--- |FIXED
   Hardware|x86 |All
 Status|UNCONFIRMED |RESOLVED
 OS|Linux   |All
   Severity|Major   |Normal

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 16083] Missing include causes builds to fail on specific include orders

2019-11-30 Thread bugzilla-daemon
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=16083

--- Comment #5 from Gerrit Code Review  ---
Change 35268 merged by Anders Broman:
expert.h: Reorder includes

https://code.wireshark.org/review/35268

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 16083] Missing include causes builds to fail on specific include orders

2019-11-30 Thread bugzilla-daemon
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=16083

--- Comment #4 from Gerrit Code Review  ---
Change 35268 had a related patch set uploaded by Michael Mann:
expert.h: Reorder includes

https://code.wireshark.org/review/35268

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 16083] Missing include causes builds to fail on specific include orders

2019-09-27 Thread bugzilla-daemon
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=16083

--- Comment #3 from Anders Broman  ---
Perhaps expert.h should include proto.h before packet_info.h?

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 16083] Missing include causes builds to fail on specific include orders

2019-09-27 Thread bugzilla-daemon
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=16083

--- Comment #2 from Jonatan Hatakeyama Zeidler  ---
I am not. But shouldn't frame_data.h have that include itself, if it relies on
those types?

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 16083] Missing include causes builds to fail on specific include orders

2019-09-26 Thread bugzilla-daemon
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=16083

--- Comment #1 from Gerald Combs  ---
(In reply to Jonatan Hatakeyama Zeidler from comment #0)

> In file included from /usr/include/wireshark/epan/frame_data.h:20:0,
>  from /usr/include/wireshark/epan/packet_info.h:14,
>  from /usr/include/wireshark/epan/expert.h:16,
>  from
> /home/jonatan.h.zeidler/wireshark-dissector/protocols/EGSZTellState_proto.c:
> 5:
> /usr/include/wireshark/wsutil/nstime.h:38:15: error: unknown type name
> ‘gboolean’
>  WS_DLL_PUBLIC gboolean nstime_is_zero(nstime_t *nstime);

A great deal of Wireshark's API uses GLib data types. Are you including glib.h
before frame_data.h?

-- 
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe