[Wireshark-bugs] [Bug 16416] Check for updates, and auto-update, not working in 3.2.1
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=16416 Gerald Combs changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |FIXED --- Comment #12 from Gerald Combs --- Marking as fixed under the assumption that Sparkle's Autoupdate.app will work reliably. For those playing along at home, you can work around the issue by running defaults write org.wireshark.Wireshark SUAutomaticallyUpdate 0 or by deleting ~/Library/Preferences/org.wireshark.Wireshark.plist -- You are receiving this mail because: You are watching all bug changes.___ Sent via:Wireshark-bugs mailing list Archives:https://www.wireshark.org/lists/wireshark-bugs Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe
[Wireshark-bugs] [Bug 16416] Check for updates, and auto-update, not working in 3.2.1
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=16416 --- Comment #11 from Gerrit Code Review --- Change 36230 merged by Gerald Combs: macOS: Software update fixes. https://code.wireshark.org/review/36230 -- You are receiving this mail because: You are watching all bug changes.___ Sent via:Wireshark-bugs mailing list Archives:https://www.wireshark.org/lists/wireshark-bugs Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe
[Wireshark-bugs] [Bug 16416] Check for updates, and auto-update, not working in 3.2.1
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=16416 --- Comment #10 from Gerrit Code Review --- Change 36230 had a related patch set uploaded by Gerald Combs: macOS: Software update fixes. https://code.wireshark.org/review/36230 -- You are receiving this mail because: You are watching all bug changes.___ Sent via:Wireshark-bugs mailing list Archives:https://www.wireshark.org/lists/wireshark-bugs Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe
[Wireshark-bugs] [Bug 16416] Check for updates, and auto-update, not working in 3.2.1
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=16416 --- Comment #9 from Gerrit Code Review --- Change 36221 merged by Anders Broman: macOS: Software update fixes. https://code.wireshark.org/review/36221 -- You are receiving this mail because: You are watching all bug changes.___ Sent via:Wireshark-bugs mailing list Archives:https://www.wireshark.org/lists/wireshark-bugs Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe
[Wireshark-bugs] [Bug 16416] Check for updates, and auto-update, not working in 3.2.1
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=16416 --- Comment #8 from Gerrit Code Review --- Change 36221 had a related patch set uploaded by Gerald Combs: macOS: Software update fixes. https://code.wireshark.org/review/36221 -- You are receiving this mail because: You are watching all bug changes.___ Sent via:Wireshark-bugs mailing list Archives:https://www.wireshark.org/lists/wireshark-bugs Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe
[Wireshark-bugs] [Bug 16416] Check for updates, and auto-update, not working in 3.2.1
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=16416 --- Comment #7 from Guy Harris --- (In reply to Gerald Combs from comment #5) > (In reply to Guy Harris from comment #4) > > However, 3.2.2 *still* does nothing - not even telling me Wireshark is > > up-to-date - if I do "Check for Updates". > > This might be because we're calling checkForUpdatesInBackground instead of > checkForUpdates. If the user explicitly requests a check for updates, we probably shouldn't do it in the background. -- You are receiving this mail because: You are watching all bug changes.___ Sent via:Wireshark-bugs mailing list Archives:https://www.wireshark.org/lists/wireshark-bugs Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe
[Wireshark-bugs] [Bug 16416] Check for updates, and auto-update, not working in 3.2.1
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=16416 --- Comment #6 from Gerald Combs --- Side note: Updates on macOS take a while because we include dSYMs. Maybe we should ship them separately? -- You are receiving this mail because: You are watching all bug changes.___ Sent via:Wireshark-bugs mailing list Archives:https://www.wireshark.org/lists/wireshark-bugs Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe
[Wireshark-bugs] [Bug 16416] Check for updates, and auto-update, not working in 3.2.1
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=16416 --- Comment #5 from Gerald Combs --- (In reply to Guy Harris from comment #4) > Is [1] Wireshark documentation or Sparkle documentation? > > I.e., is this just what Sparkle does, or can it be configured? Oops - [1] is https://sparkle-project.org/documentation/customization/. There are quite a few configuration options, but... > It seems to me as if "updates will be silently installed when the app > *starts*" might work better - i.e., check for updates when Wireshark starts, > and do the install then. ...silently installing at startup time would require a bit of coordination and related plumbing. > I'm also not sure how silent "silently" should be - no dialog indicating > that the download is being done, no dialog indicating that the update is > being done, just some activity? > > > > > If I do the following: > > > > - Install Wireshark 3.2.1. > > - Verify that SUAutomaticallyUpdate is 0. > > - Run Wireshark and select "Help → Check For Updates" > > > > I'm presented with an update dialog for 3.2.2. If I then do the following: > > > > - Check the "Automatically download and install updates in the future" > > checkbox > > - Click "Remind Me Later" > > - Quit Wireshark > > > > SUAutomaticallyUpdate is set to 1. > > On my Catalina VM, I got rid of the Wireshark preferences plist, removed > Wireshark, downloaded and installed 3.2.1, and started it. It told me an > update was available, so I told it to install the update. > > Once that was done, I tried "Check for Updates" on 3.2.2; nothing happened. > > defaults read org.wireshark.Wireshark | grep SU > > reports > > "NSWindow Frame SUUpdateAlert" = "202 264 620 392 0 0 1024 745 "; > SUEnableAutomaticChecks = 1; > SUFeedURL = > "https://www.wireshark.org/update/0/Wireshark/3.2.2/macOS/x86-64/en-US/ > stable.xml"; > SUHasLaunchedBefore = 1; > SULastCheckTime = "2020-02-27 17:57:16 +"; > SUScheduledCheckInterval = 86400; > SUUpdateGroupIdentifier = 1684147953; > SUUpdateRelaunchingMarker = 0; > > I then did > > defaults write org.wireshark.Wireshark SUAutomaticallyUpdate 0 > > and "defaults read org.wireshark.Wireshark | grep SU" now reports that it's > 0. > > However, 3.2.2 *still* does nothing - not even telling me Wireshark is > up-to-date - if I do "Check for Updates". This might be because we're calling checkForUpdatesInBackground instead of checkForUpdates. > The same thing happens on my host machine, also running Catalina. > > > At that point, Wireshark behaves as you > > describe. The logs on the server end show that selecting "Help → Check For > > Updates" fetches the update URL followed by the 3.2.2 .dmg. Contrary to the > > documentation, Wireshark isn't updated when I quit the application. > > OK, so that's *another* bug. This appears to be due to us not posting NSApplicationWillTerminateNotification https://github.com/sparkle-project/Sparkle/issues/232 https://github.com/sparkle-project/Sparkle/issues/839 https://github.com/sparkle-project/Sparkle/issues/892 -- You are receiving this mail because: You are watching all bug changes.___ Sent via:Wireshark-bugs mailing list Archives:https://www.wireshark.org/lists/wireshark-bugs Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe
[Wireshark-bugs] [Bug 16416] Check for updates, and auto-update, not working in 3.2.1
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=16416 --- Comment #4 from Guy Harris --- (In reply to Gerald Combs from comment #3) > What does `defaults read org.wireshark.Wireshark | grep SU` show? In > particular, what's the value of SUAutomaticallyUpdate? SUAutomaticallyUpdate = 1; > By default it's > disabled, but according to [1], "If set to YES, users will not be informed > about updates, and updates will be silently installed when the app quits." Is [1] Wireshark documentation or Sparkle documentation? I.e., is this just what Sparkle does, or can it be configured? It seems to me as if "updates will be silently installed when the app *starts*" might work better - i.e., check for updates when Wireshark starts, and do the install then. I'm also not sure how silent "silently" should be - no dialog indicating that the download is being done, no dialog indicating that the update is being done, just some activity? > > If I do the following: > > - Install Wireshark 3.2.1. > - Verify that SUAutomaticallyUpdate is 0. > - Run Wireshark and select "Help → Check For Updates" > > I'm presented with an update dialog for 3.2.2. If I then do the following: > > - Check the "Automatically download and install updates in the future" > checkbox > - Click "Remind Me Later" > - Quit Wireshark > > SUAutomaticallyUpdate is set to 1. On my Catalina VM, I got rid of the Wireshark preferences plist, removed Wireshark, downloaded and installed 3.2.1, and started it. It told me an update was available, so I told it to install the update. Once that was done, I tried "Check for Updates" on 3.2.2; nothing happened. defaults read org.wireshark.Wireshark | grep SU reports "NSWindow Frame SUUpdateAlert" = "202 264 620 392 0 0 1024 745 "; SUEnableAutomaticChecks = 1; SUFeedURL = "https://www.wireshark.org/update/0/Wireshark/3.2.2/macOS/x86-64/en-US/stable.xml;; SUHasLaunchedBefore = 1; SULastCheckTime = "2020-02-27 17:57:16 +"; SUScheduledCheckInterval = 86400; SUUpdateGroupIdentifier = 1684147953; SUUpdateRelaunchingMarker = 0; I then did defaults write org.wireshark.Wireshark SUAutomaticallyUpdate 0 and "defaults read org.wireshark.Wireshark | grep SU" now reports that it's 0. However, 3.2.2 *still* does nothing - not even telling me Wireshark is up-to-date - if I do "Check for Updates". The same thing happens on my host machine, also running Catalina. > At that point, Wireshark behaves as you > describe. The logs on the server end show that selecting "Help → Check For > Updates" fetches the update URL followed by the 3.2.2 .dmg. Contrary to the > documentation, Wireshark isn't updated when I quit the application. OK, so that's *another* bug. -- You are receiving this mail because: You are watching all bug changes.___ Sent via:Wireshark-bugs mailing list Archives:https://www.wireshark.org/lists/wireshark-bugs Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe
[Wireshark-bugs] [Bug 16416] Check for updates, and auto-update, not working in 3.2.1
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=16416 --- Comment #3 from Gerald Combs --- What does `defaults read org.wireshark.Wireshark | grep SU` show? In particular, what's the value of SUAutomaticallyUpdate? By default it's disabled, but according to [1], "If set to YES, users will not be informed about updates, and updates will be silently installed when the app quits." If I do the following: - Install Wireshark 3.2.1. - Verify that SUAutomaticallyUpdate is 0. - Run Wireshark and select "Help → Check For Updates" I'm presented with an update dialog for 3.2.2. If I then do the following: - Check the "Automatically download and install updates in the future" checkbox - Click "Remind Me Later" - Quit Wireshark SUAutomaticallyUpdate is set to 1. At that point, Wireshark behaves as you describe. The logs on the server end show that selecting "Help → Check For Updates" fetches the update URL followed by the 3.2.2 .dmg. Contrary to the documentation, Wireshark isn't updated when I quit the application. -- You are receiving this mail because: You are watching all bug changes.___ Sent via:Wireshark-bugs mailing list Archives:https://www.wireshark.org/lists/wireshark-bugs Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe
[Wireshark-bugs] [Bug 16416] Check for updates, and auto-update, not working in 3.2.1
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=16416 --- Comment #2 from Guy Harris --- (In reply to Guy Harris from comment #1) > However, if, on my main machine, I remove 3.2.1 (as in "sudo rm -rf > /Applications/Wireshark.app") and download and install 3.2.0, it behaves the > same way as 3.2.1 does - no auto-popup for updating, and the weird download > with no dialogs popping up. 3.2.2 obviously doesn't pop up an auto-update dialog, but if I do "Check for Updates", it pops up nothing - no "you're up to date!" dialog. It does no downloading, perhaps because there's no update to download. -- You are receiving this mail because: You are watching all bug changes.___ Sent via:Wireshark-bugs mailing list Archives:https://www.wireshark.org/lists/wireshark-bugs Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe
[Wireshark-bugs] [Bug 16416] Check for updates, and auto-update, not working in 3.2.1
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=16416 --- Comment #1 from Guy Harris --- (In reply to Guy Harris from comment #0) > If this is reproducible, we might want to put in a note about auto-update in > 3.2.1, similar to the note for Windows; 3.2.0 appeared to auto-update OK on > a VM. However, if, on my main machine, I remove 3.2.1 (as in "sudo rm -rf /Applications/Wireshark.app") and download and install 3.2.0, it behaves the same way as 3.2.1 does - no auto-popup for updating, and the weird download with no dialogs popping up. -- You are receiving this mail because: You are watching all bug changes.___ Sent via:Wireshark-bugs mailing list Archives:https://www.wireshark.org/lists/wireshark-bugs Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe
