[Wireshark-bugs] [Bug 16487] tshark live capture finishes with a use-after-free
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=16487
--- Comment #12 from Peter Wu ---
While this is a bug, the problem does not seem to be very severe. It will only
crash when built with ASAN. It is a correctness issue.
Prior to the use-after-free, the file was already closed, so no data loss
should occur. The worst thing that can happen when ASAN crashes is that the
temporary file is not deleted in cf_close (which calls wtap_close first).
void
wtap_close(wtap *wth)
{
wtap_sequential_close(wth);
if (wth->subtype_close != NULL)
(*wth->subtype_close)(wth);
if (wth->random_fh != NULL)
file_close(wth->random_fh);
// at this point the file is closed and no data loss should occur.
g_free(wth->priv);
if (wth->fast_seek != NULL) {
g_ptr_array_foreach(wth->fast_seek, g_fast_seek_item_free, NULL);
g_ptr_array_free(wth->fast_seek, TRUE);
}
// use-after-free in the next line
wtap_block_array_free(wth->shb_hdrs);
wtap_block_array_free(wth->nrb_hdrs);
wtap_block_array_free(wth->interface_data);
wtap_block_array_free(wth->dsbs);
g_free(wth);
}
--
You are receiving this mail because:
You are watching all bug changes.___
Sent via:Wireshark-bugs mailing list
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe
[Wireshark-bugs] [Bug 16487] tshark live capture finishes with a use-after-free
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=16487 Peter Wu changed: What|Removed |Added Status|IN_PROGRESS |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.___ Sent via:Wireshark-bugs mailing list Archives:https://www.wireshark.org/lists/wireshark-bugs Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe
[Wireshark-bugs] [Bug 16487] tshark live capture finishes with a use-after-free
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=16487 --- Comment #11 from Peter Wu --- Fixed in v3.3.0rc0-974-ga0600e02a9 v3.2.3-1-gf7537ea094 v3.0.10-1-geb0680d0b4 -- You are receiving this mail because: You are watching all bug changes.___ Sent via:Wireshark-bugs mailing list Archives:https://www.wireshark.org/lists/wireshark-bugs Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe
[Wireshark-bugs] [Bug 16487] tshark live capture finishes with a use-after-free
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=16487 --- Comment #10 from Gerrit Code Review --- Change 36757 merged by Peter Wu: tshark: fix use-after-free while closing a live capture file https://code.wireshark.org/review/36757 -- You are receiving this mail because: You are watching all bug changes.___ Sent via:Wireshark-bugs mailing list Archives:https://www.wireshark.org/lists/wireshark-bugs Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe
[Wireshark-bugs] [Bug 16487] tshark live capture finishes with a use-after-free
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=16487 --- Comment #9 from Gerrit Code Review --- Change 36757 had a related patch set uploaded by Peter Wu: tshark: fix use-after-free while closing a live capture file https://code.wireshark.org/review/36757 -- You are receiving this mail because: You are watching all bug changes.___ Sent via:Wireshark-bugs mailing list Archives:https://www.wireshark.org/lists/wireshark-bugs Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe
[Wireshark-bugs] [Bug 16487] tshark live capture finishes with a use-after-free
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=16487 --- Comment #7 from Gerrit Code Review --- Change 36756 had a related patch set uploaded by Peter Wu: tshark: fix use-after-free while closing a live capture file https://code.wireshark.org/review/36756 -- You are receiving this mail because: You are watching all bug changes.___ Sent via:Wireshark-bugs mailing list Archives:https://www.wireshark.org/lists/wireshark-bugs Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe
[Wireshark-bugs] [Bug 16487] tshark live capture finishes with a use-after-free
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=16487 --- Comment #6 from Gerrit Code Review --- Change 36755 merged by Peter Wu: tshark: fix use-after-free while closing a live capture file https://code.wireshark.org/review/36755 -- You are receiving this mail because: You are watching all bug changes.___ Sent via:Wireshark-bugs mailing list Archives:https://www.wireshark.org/lists/wireshark-bugs Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe
[Wireshark-bugs] [Bug 16487] tshark live capture finishes with a use-after-free
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=16487 --- Comment #8 from Gerrit Code Review --- Change 36756 merged by Peter Wu: tshark: fix use-after-free while closing a live capture file https://code.wireshark.org/review/36756 -- You are receiving this mail because: You are watching all bug changes.___ Sent via:Wireshark-bugs mailing list Archives:https://www.wireshark.org/lists/wireshark-bugs Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe
[Wireshark-bugs] [Bug 16487] tshark live capture finishes with a use-after-free
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=16487 Guy Harris changed: What|Removed |Added Status|CONFIRMED |IN_PROGRESS --- Comment #5 from Guy Harris --- (In reply to Gerrit Code Review from comment #4) > Change 36755 had a related patch set uploaded by Peter Wu: > tshark: fix use-after-free while closing a live capture file > > https://code.wireshark.org/review/36755 Yes, that's the ticket; I was in the middle of doing a compile with ASAN to test a similar fix, but I just moved cf_close() right above wtap_cleanup(). Moving it all the way to the top of the clean_exit block is probably the right thing to do. -- You are receiving this mail because: You are watching all bug changes.___ Sent via:Wireshark-bugs mailing list Archives:https://www.wireshark.org/lists/wireshark-bugs Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe
[Wireshark-bugs] [Bug 16487] tshark live capture finishes with a use-after-free
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=16487 Peter Wu changed: What|Removed |Added Summary|tshark live capture |tshark live capture |finishes with an|finishes with a |out-of-bounds read |use-after-free -- You are receiving this mail because: You are watching all bug changes.___ Sent via:Wireshark-bugs mailing list Archives:https://www.wireshark.org/lists/wireshark-bugs Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe
