Re: [Wireshark-dev] Patch to airpcap_loader that produces a modal dialog with garbage
Peter Johansson wrote: > I compiled Wireshark with HAVE_AIRPDCAP by mistake (since I do not > have AirPcap). This leads to a runtime problem however. When > choosing "options" from the "Capture interfaces" dialog, I receive a > modal dialogue with an OK button with a textual description that is > only garbage (uninitialized memory). > > The provided patch adds a new error - AIRPCAP_NOT_LOADED (2) code to > the airpcap loader that also adds the text "AirPcap was expected to > be loaded but is not" to the modal dialogue instead of the > uninitialized string. Hmm, I think you found the problem of bug 1377: http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1377 Having a quick look, though, I am a bit confused because it doesn't appear anybody ever allocates any space for 'err_str' before calling though maybe I'm missing it. Anyway I don't really have time to dig further for the moment. Another thing that needs a look is it appears that it's normal that AirPcap is compiled in (I didn't change my setup and my Windoze builds say "with Airpcap") though in that case I'm not sure it should be complaining at all if it doesn't find an AirPcap device or whatever. ___ Wireshark-dev mailing list Wireshark-dev@wireshark.org http://www.wireshark.org/mailman/listinfo/wireshark-dev
Re: [Wireshark-dev] Patch to airpcap_loader that produces a modal dialog with garbage
2007/3/29, Peter Johansson <[EMAIL PROTECTED]>:
I compiled Wireshark with HAVE_AIRPDCAP by mistake (since I do not have
AirPcap). This leads to a runtime problem however. When choosing "options"
from the "Capture interfaces" dialog, I receive a modal dialogue with an OK
button with a textual description that is only garbage (uninitialized
memory).
The provided patch adds a new error - AIRPCAP_NOT_LOADED (2) code to the
airpcap loader that also adds the text "AirPcap was expected to be loaded
but is not" to the modal dialogue instead of the uninitialized string.
Regards, Peter
Repost to include a missing file in the previous mail.
/ Regards, Peter
Index: C:/wireshark-win32-libs/airpcap_loader.h
===
--- C:/wireshark-win32-libs/airpcap_loader.h(revision 21269)
+++ C:/wireshark-win32-libs/airpcap_loader.h(working copy)
@@ -33,6 +33,7 @@
/* Error values from "get_airpcap_interface_list()". */
#defineCANT_GET_AIRPCAP_INTERFACE_LIST 0 /* error getting list */
#defineNO_AIRPCAP_INTERFACES_FOUND 1 /* list is empty */
+#defineAIRPCAP_NOT_LOADED 2 /* AirPcap not loaded */
#define AIRPCAP_CHANNEL_ANY_NAME "ANY"
Index: C:/wireshark-win32-libs/airpcap_loader.c
===
--- C:/wireshark-win32-libs/airpcap_loader.c(revision 21269)
+++ C:/wireshark-win32-libs/airpcap_loader.c(working copy)
@@ -1138,7 +1138,11 @@
char errbuf[PCAP_ERRBUF_SIZE];
if (!AirpcapLoaded)
- return il;
+{
+*err = AIRPCAP_NOT_LOADED;
+*err_str = "AirPcap was expected to be loaded but is not";
+return il;
+}
if (!g_PAirpcapGetDeviceList(&devsList, errbuf))
{
Index: C:/wireshark-win32-libs/gtk/capture_dlg.c
===
--- C:/wireshark-win32-libs/gtk/capture_dlg.c (revision 21279)
+++ C:/wireshark-win32-libs/gtk/capture_dlg.c (working copy)
@@ -639,7 +639,9 @@
decryption_cm = OBJECT_GET_DATA(airpcap_tb,AIRPCAP_TOOLBAR_DECRYPTION_KEY);
update_decryption_mode_list(decryption_cm);
- if (airpcap_if_list == NULL && err == CANT_GET_AIRPCAP_INTERFACE_LIST) {
+ if (airpcap_if_list == NULL &&
+ (err == CANT_GET_AIRPCAP_INTERFACE_LIST ||
+ err == AIRPCAP_NOT_LOADED)) {
simple_dialog(ESD_TYPE_ERROR, ESD_BTN_OK, "%s", err_str);
g_free(err_str);
}
___
Wireshark-dev mailing list
Wireshark-dev@wireshark.org
http://www.wireshark.org/mailman/listinfo/wireshark-dev
[Wireshark-dev] Missing msvcr80.dll
Hi list, I have some trouble running a version that I compiled of Wireshark: - compiled on XP SP2, using Visual Studio 2005 Express. - after compiling, I copied the Wireshark.exe from the build folder to the Program Files\Wireshark folder. - when I try to launch it, Windows warns me about the missing msvcr80.dll. I did a little research on the list about this issue, and all I could get is that I would need to download the Visual C++ 2005 redistributables if I am trying to run Wireshark on a machine without Visual Studio installed. The fact is that I'm trying to run it in my development machine. Anyhow, I installed the redistributables and had no success also. Any clues of what am I doing wrong? Thanks, Ronaldo BTW: the .exe I compiled is approximately half the size of the .exe copied by the Wireshark installer. Is the latter one statically linked to the runtime? ___ Wireshark-dev mailing list Wireshark-dev@wireshark.org http://www.wireshark.org/mailman/listinfo/wireshark-dev
[Wireshark-dev] [PATCH] Fix for bug 598
Hi, I have written a patch for bug 598 (getting 2 linefeeds when copying data from the "follow tcp stream" display). It seems GTK is converting all CR's to LF's when you copy data from the widget. This patch converts CRLF's to LF's before inserting them into the widget. The patch is attached on bugzilla, could someone please review it? Cheers, Sake ___ Wireshark-dev mailing list Wireshark-dev@wireshark.org http://www.wireshark.org/mailman/listinfo/wireshark-dev
Re: [Wireshark-dev] tcp_dissect_pdus() and PDU header across segments
Thanks, I came to the same conclusion. It will require changes probably in desegment_tcp(). -Original Message- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] On Behalf Of Janusz Chorko Sent: Thursday, March 29, 2007 4:51 PM To: Developer support list for Wireshark Subject: Re: [Wireshark-dev] tcp_dissect_pdus() and PDU header across segments > it seems that tcp_dissect_pdus() (or TCP reassembly itself) does not > work well if PDU header is spreaded across segments. > Does anybody have any experince with it? > I am asking before I start investigatin where the problem is. It seems its a known bug (http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1124) There are some workarounds listed there, but they didn't work for me ___ Wireshark-dev mailing list Wireshark-dev@wireshark.org http://www.wireshark.org/mailman/listinfo/wireshark-dev ___ Wireshark-dev mailing list Wireshark-dev@wireshark.org http://www.wireshark.org/mailman/listinfo/wireshark-dev
Re: [Wireshark-dev] tcp_dissect_pdus() and PDU header across segments
> it seems that tcp_dissect_pdus() (or TCP reassembly itself) does not > work well if PDU header is spreaded across segments. > Does anybody have any experince with it? > I am asking before I start investigatin where the problem is. It seems its a known bug (http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1124) There are some workarounds listed there, but they didn't work for me ___ Wireshark-dev mailing list Wireshark-dev@wireshark.org http://www.wireshark.org/mailman/listinfo/wireshark-dev
[Wireshark-dev] tcp_dissect_pdus() and PDU header across segments
Hi, it seems that tcp_dissect_pdus() (or TCP reassembly itself) does not work well if PDU header is spreaded across segments. Does anybody have any experince with it? I am asking before I start investigatin where the problem is. Thanks in advance, Tomas ___ Wireshark-dev mailing list Wireshark-dev@wireshark.org http://www.wireshark.org/mailman/listinfo/wireshark-dev
Re: [Wireshark-dev] Regarding downloading source
Manjunath P wrote: > Hi Graham, > I followed each and every step faithfully as given in > Developer's guide , but still I am not able to get the source and I get > the same error. > I download source from > http://www.wireshark.org/download/src/wireshark-0.99.5.tar.gz > separately(without SVN), untarred it through cygwin, and then tried to > put the source into SVN( by specifying the untarred file directory in > the checkout file option ). I got the error "Error: Unable to open an > ra_local session to URL " > I hv even mailed to the dev guide of Tortoise but no reply from > them > > Ur advice is very essential Pls help > ---Manju > Manju, You seem to be mixing different approaches and not getting the best of either. You can use SVN *or* the downloaded source tarball, but trying to combine them isn't a good idea. To use SVN, on windows the choice is either command line SVN, or TortoiseSVN. There are other GUI clients, but I don't have a great deal of experience with them. Note that TortoiseSVN doesn't play well with the cygwin version of SVN, but is OK with win32 SVN. To use SVN follow the instructions in the dev guide or my previous instructions (left below) for TortoiseSVN. Remember TortoiseSVN is all point and click and menus via Explorer, and you will need to translate any command line SVN instructions into the menu equivalent. To use the tarball, just untar it and it is then ready, with no need for SVN. This is not the recommended approach as it is difficult to integrate other developers changes with yours. > >> Manjunath P wrote: >>> I have special "Downloading Rights " in my office and my m/c is not >>> behind >>> any firewall. I downloaded a tortoise SVN( recent SVN 1.4.3 win32 ). >>> When I try to do "svn --version"on my cmd line , I get an error >>> "The >>> application has failed to start because cygdb-4.2.dll was not found. Re >>> installing the application may fix this problem". >>> After this, I tried to repair with installer package. >>> Later I uninstalled the present client and re-installed the windows >>> installer package again from the Tortoise website but again found >>> the same >>> problem(given below). I read sections 3.3.2 and 3.3.3 and 3.3.4 of >>> Developer's guide. >>> How can I proceed further? Pls advice >> >> The dll error was probably because your command line is picking up a >> cygwin version of svn. Tortoise does *not* provide a command line >> version of svn. It does provide some command line tools, but they >> aren't the same as standard svn. >> >> Using TortoiseSVN, open an Explorer window, right click any directory or >> drive and choose "SVN Checkout..." from the context menu. It might be >> in the TortoiseSVN sub menu. >> >> In the resulting dialog, enter the correct url >> (http://anonsvn.wireshark.org/wireshark/trunk) in the "URL of >> repository" field, and a suitable local directory in the "Checkout >> directory" field. Ensure the two check boxes are cleared and select the >> "HEAD" radio button. Click "OK". >> >> After a suitable period of time you should have the source tree on your >> local hard disk. Continue as per the developers guide. >> >> -- >> Regards, >> >> Graham Bloice >> -- Regards, Graham Bloice ___ Wireshark-dev mailing list Wireshark-dev@wireshark.org http://www.wireshark.org/mailman/listinfo/wireshark-dev
[Wireshark-dev] Patch to airpcap_loader that produces a modal dialog with garbage
I compiled Wireshark with HAVE_AIRPDCAP by mistake (since I do not have
AirPcap). This leads to a runtime problem however. When choosing "options"
from the "Capture interfaces" dialog, I receive a modal dialogue with an OK
button with a textual description that is only garbage (uninitialized
memory).
The provided patch adds a new error - AIRPCAP_NOT_LOADED (2) code to the
airpcap loader that also adds the text "AirPcap was expected to be loaded
but is not" to the modal dialogue instead of the uninitialized string.
Regards, Peter
Index: C:/wireshark-win32-libs/airpcap_loader.h
===
--- C:/wireshark-win32-libs/airpcap_loader.h(revision 21269)
+++ C:/wireshark-win32-libs/airpcap_loader.h(working copy)
@@ -33,6 +33,7 @@
/* Error values from "get_airpcap_interface_list()". */
#defineCANT_GET_AIRPCAP_INTERFACE_LIST 0 /* error getting list */
#defineNO_AIRPCAP_INTERFACES_FOUND 1 /* list is empty */
+#defineAIRPCAP_NOT_LOADED 2 /* AirPcap not loaded */
#define AIRPCAP_CHANNEL_ANY_NAME "ANY"
Index: C:/wireshark-win32-libs/airpcap_loader.c
===
--- C:/wireshark-win32-libs/airpcap_loader.c(revision 21269)
+++ C:/wireshark-win32-libs/airpcap_loader.c(working copy)
@@ -1138,7 +1138,11 @@
char errbuf[PCAP_ERRBUF_SIZE];
if (!AirpcapLoaded)
- return il;
+{
+*err = AIRPCAP_NOT_LOADED;
+*err_str = "AirPcap was expected to be loaded but is not";
+return il;
+}
if (!g_PAirpcapGetDeviceList(&devsList, errbuf))
{
___
Wireshark-dev mailing list
Wireshark-dev@wireshark.org
http://www.wireshark.org/mailman/listinfo/wireshark-dev
Re: [Wireshark-dev] Mobile IPv6
just a precision, the counter of mobile IPv6 is not incremented at all for the unknown option. Sebastien Tandel wrote: > Hi, > > >I found a strange (to me) thing in the code of the IPv6 dissector. In > the options decode function (dissect_opts), there are two "tvb offset" > counters, one for IPv6 and one for mobile IPv6 which are incremented in > the same way for all the options except for the default one (unknown > option). Does anybody know whether this behavior is really accurate? > > > > Regards, > Sebastien Tandel > > ___ > Wireshark-dev mailing list > Wireshark-dev@wireshark.org > http://www.wireshark.org/mailman/listinfo/wireshark-dev > ___ Wireshark-dev mailing list Wireshark-dev@wireshark.org http://www.wireshark.org/mailman/listinfo/wireshark-dev
[Wireshark-dev] Mobile IPv6
Hi, I found a strange (to me) thing in the code of the IPv6 dissector. In the options decode function (dissect_opts), there are two "tvb offset" counters, one for IPv6 and one for mobile IPv6 which are incremented in the same way for all the options except for the default one (unknown option). Does anybody know whether this behavior is really accurate? Regards, Sebastien Tandel ___ Wireshark-dev mailing list Wireshark-dev@wireshark.org http://www.wireshark.org/mailman/listinfo/wireshark-dev
Re: [Wireshark-dev] State of pidl and idl/cnf files?
Forgot: I think this was discussed some 2 years ago or so. I think the long term plans are that samba owns the idl files and we only use copies of them. We on the other hand should own the conformance files and any conformance files in samba should be deleted or linked to ours. On 3/29/07, Joerg Mayer <[EMAIL PROTECTED]> wrote: > Hello (mostly) Ronnie, > > (ignoring the #pragma patch) we have been using the original pidl stuff > from the samba team for quite a while now. What we are not using are the > original .idl and .cnf files. Is this still necessary and if so, what > needs to be done to change this? > > Thanks > Joerg > -- > Joerg Mayer <[EMAIL PROTECTED]> > We are stuck with technology when what we really want is just stuff that > works. Some say that should read Microsoft instead of technology. > ___ > Wireshark-dev mailing list > Wireshark-dev@wireshark.org > http://www.wireshark.org/mailman/listinfo/wireshark-dev > ___ Wireshark-dev mailing list Wireshark-dev@wireshark.org http://www.wireshark.org/mailman/listinfo/wireshark-dev
Re: [Wireshark-dev] State of pidl and idl/cnf files?
We kind of use the original idl files, or at least some of them. There are two exceptions where we are out of sync with samba and that is the EVENTLOG and the SRVSVC idl files where there are a additional fields and functions that samba have not yet merged into their idl files. PIDL still needs an implementation of the TYPE conformance file directive in order to manage prettification of strings. This is required in order to make strings appear on the info column, etc. I think we really need to get TYPE working properly in PIDL before we can start PIDLifying the more critical interfaces such as LSA, SAMR, NETLOGON. PIDL is not yet mature enough to generate those interfaces (unless one accepts a massive regression in useability and prettification) Once I am happy with how PIDL can generate the less imporant interfaces we already have PIDLified I will cut those critical interfaces over as well. That will be quite a lot of work since our handwritten dissectors do contain a lot of things that are not yet in the IDL files so they have to be audited and all items not present in the idl files have to first be merged to the idl files. We are getting there, step by step. On 3/29/07, Joerg Mayer <[EMAIL PROTECTED]> wrote: > Hello (mostly) Ronnie, > > (ignoring the #pragma patch) we have been using the original pidl stuff > from the samba team for quite a while now. What we are not using are the > original .idl and .cnf files. Is this still necessary and if so, what > needs to be done to change this? > > Thanks > Joerg > -- > Joerg Mayer <[EMAIL PROTECTED]> > We are stuck with technology when what we really want is just stuff that > works. Some say that should read Microsoft instead of technology. > ___ > Wireshark-dev mailing list > Wireshark-dev@wireshark.org > http://www.wireshark.org/mailman/listinfo/wireshark-dev > ___ Wireshark-dev mailing list Wireshark-dev@wireshark.org http://www.wireshark.org/mailman/listinfo/wireshark-dev
Re: [Wireshark-dev] [Wireshark-commits] rev 21262: /trunk/epan/dissectors/ /trunk/epan/dissectors/: packet-dcerpc-atsvc.c packet-dcerpc-dfs.c packet-dcerpc-efs.c packet-dcerpc-eventlog.c packet-dcerpc
Note that I did not yet regenerate WKSSVC since this dissector would really need the not yet finished TYPE conformance file directive in order to handle the dependency for a type from SRVSVC properly. On 3/29/07, Joerg Mayer <[EMAIL PROTECTED]> wrote: > On Thu, Mar 29, 2007 at 02:22:24AM +, [EMAIL PROTECTED] wrote: > > Log: > > regenerate the dissectors with an even newer patched version of pidl to > add two more pragmas > > > > > > you need this patch ontop of svn pidl to regenerate the files : > ... > > I've updated the pidl repo to that of the samba team and applied your > patch on top of it, so hopefully everyone should be able to use the ws > pidl right now. > > Ciao > Joerg > -- > Joerg Mayer <[EMAIL PROTECTED]> > We are stuck with technology when what we really want is just stuff that > works. Some say that should read Microsoft instead of technology. > ___ > Wireshark-dev mailing list > Wireshark-dev@wireshark.org > http://www.wireshark.org/mailman/listinfo/wireshark-dev > ___ Wireshark-dev mailing list Wireshark-dev@wireshark.org http://www.wireshark.org/mailman/listinfo/wireshark-dev
[Wireshark-dev] State of pidl and idl/cnf files?
Hello (mostly) Ronnie, (ignoring the #pragma patch) we have been using the original pidl stuff from the samba team for quite a while now. What we are not using are the original .idl and .cnf files. Is this still necessary and if so, what needs to be done to change this? Thanks Joerg -- Joerg Mayer <[EMAIL PROTECTED]> We are stuck with technology when what we really want is just stuff that works. Some say that should read Microsoft instead of technology. ___ Wireshark-dev mailing list Wireshark-dev@wireshark.org http://www.wireshark.org/mailman/listinfo/wireshark-dev
Re: [Wireshark-dev] [Wireshark-commits] rev 21262: /trunk/epan/dissectors/ /trunk/epan/dissectors/: packet-dcerpc-atsvc.c packet-dcerpc-dfs.c packet-dcerpc-efs.c packet-dcerpc-eventlog.c packet-dcerpc
On Thu, Mar 29, 2007 at 02:22:24AM +, [EMAIL PROTECTED] wrote: > Log: > regenerate the dissectors with an even newer patched version of pidl to add > two more pragmas > > > you need this patch ontop of svn pidl to regenerate the files : ... I've updated the pidl repo to that of the samba team and applied your patch on top of it, so hopefully everyone should be able to use the ws pidl right now. Ciao Joerg -- Joerg Mayer <[EMAIL PROTECTED]> We are stuck with technology when what we really want is just stuff that works. Some say that should read Microsoft instead of technology. ___ Wireshark-dev mailing list Wireshark-dev@wireshark.org http://www.wireshark.org/mailman/listinfo/wireshark-dev
