[Wireshark-dev] Use of wireshark to interpret input data that does not depend on any other existing protocols
Hi All, I am adding a new protocol to wireshark that does not rely or depend on any other protocols(tcp, udp, ethernet,ppp,etc). I will be thankful if anyone can help me understand the following things: 1. I have written the protocol dissector for my unique protocol. But how do I differentiate the input packets in .pcap file so that only my protocol dissector gets called to process the data? And how can I add uniqueness to the input data stream to customize it to my protocol. Is the protocol identified by means of some common pattern in the input stream of bytes .If that is the case, how can I do that? 2. What is the difference between the dissector table and encapsulation table. I have understood how the protocol dissector encodes the input data and display it in a tree based on the formatting defined by static arrays ett and hf. What all steps I need to perform in order to write a protocol dissector that does not depend on any existing protocols and customize the input data in pcap file so that my protocol dissector gets called only when it comes across correct input data. Mrunal ___ Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
Re: [Wireshark-dev] Use of wireshark to interpret input data that does not depend on any other existing protocols
Thus wrote Mrunal Upadhyay (m.upadh...@sta.samsung.com): 1. I have written the protocol dissector for my unique protocol. But how do I differentiate the input packets in .pcap file so that only my protocol dissector gets called to process the data? And how can I add uniqueness to the input data stream to customize it to my protocol. Is the protocol identified by means of some common pattern in the input stream of bytes .If that is the case, how can I do that? you have a data link type (DLT) in the .pcap file (http://www.tcpdump.org/linktypes.html) In wireshark, you map this DLT value to a WTAP_xxx value in pcap_to_wtap_map[]. In your dissector, you call dissector_add_uint() to register your dissector for your WTAP_xxx. And you should check all incoming data to make sure that it's actually your protocol. You can take the DVB-CI dissector (any many others) as an example. ___ Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
Re: [Wireshark-dev] Installer missing ZLib1.DLL
Original-Nachricht Datum: Wed, 20 Apr 2011 14:21:28 + (UTC) Von: Chris Maynard chris.mayn...@gtech.com An: wireshark-dev@wireshark.org Betreff: Re: [Wireshark-dev] Installer missing ZLib1.DLL Chaswi Przellczyk cp70@... writes: after successfully building a custom wireshark I also built an installer. The installer works fine, but when starting Wireshark, the system complains about ZLib1.DLL missing. After copying that file to the installation-dir, everything is fine. Can I configure the installation-creation-procedure such, that ZLib1.DLL is included in the install? The wireshark.nsi includes zlib1.dll, so it should be included in the installer already. Which version of Wireshark are you building against and on what platform? Maybe you could try to run the following and see if this helps? nmake -f Makefile.nmake setup nmake -f Makefile.nmake distclean nmake -f Makefile.nmake all nmake -f Makefile.nmake packaging Dear Chris, thanks for your response. I'm building Version 1.4.4 on WindowsXP. I received the source in tar.bz2-packaged form. The ZIP is dated on 25.03.2011. I'll try your suggestions and get back with results. Thanks! CP. -- Empfehlen Sie GMX DSL Ihren Freunden und Bekannten und wir belohnen Sie mit bis zu 50,- Euro! https://freundschaftswerbung.gmx.de ___ Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
Re: [Wireshark-dev] Installer missing ZLib1.DLL
Original-Nachricht Datum: Thu, 21 Apr 2011 10:04:10 +0200 Von: Chaswi Przellczyk c...@gmx.de An: Developer support list for Wireshark wireshark-dev@wireshark.org Betreff: Re: [Wireshark-dev] Installer missing ZLib1.DLL Original-Nachricht Datum: Wed, 20 Apr 2011 14:21:28 + (UTC) Von: Chris Maynard chris.mayn...@gtech.com An: wireshark-dev@wireshark.org Betreff: Re: [Wireshark-dev] Installer missing ZLib1.DLL Chaswi Przellczyk cp70@... writes: after successfully building a custom wireshark I also built an installer. The installer works fine, but when starting Wireshark, the system complains about ZLib1.DLL missing. After copying that file to the installation-dir, everything is fine. Can I configure the installation-creation-procedure such, that ZLib1.DLL is included in the install? The wireshark.nsi includes zlib1.dll, so it should be included in the installer already. Which version of Wireshark are you building against and on what platform? Maybe you could try to run the following and see if this helps? nmake -f Makefile.nmake setup nmake -f Makefile.nmake distclean nmake -f Makefile.nmake all nmake -f Makefile.nmake packaging Dear Chris, thanks for your response. I'm building Version 1.4.4 on WindowsXP. I received the source in tar.bz2-packaged form. The ZIP is dated on 25.03.2011. I'll try your suggestions and get back with results. Thanks! CP. Hi Chris, coming back with results. After performing the 4 steps outlined above I reinstalled on my VirtualBox (another WinXP) with the same results as before. Nothing has changed. Thanks for the effort, though. Regards, CP. -- NEU: FreePhone - kostenlos mobil telefonieren und surfen! Jetzt informieren: http://www.gmx.net/de/go/freephone ___ Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
[Wireshark-dev] Compilation errors
Hi, I'm not sure what the right fix for this one is hostlist_table.c: In function `hostlist_sort_column': hostlist_table.c:341: warning: control reaches end of non-void function make: *** [libui_a-hostlist_table.o] Error 1 Should case 1: return CMP.. ? In the default branch there should also be a return, right? Best regards Anders ___ Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
Re: [Wireshark-dev] Compilation errors
On Thu, Apr 21, 2011 at 1:03 PM, Anders Broman anders.bro...@ericsson.com wrote: Should case 1: return CMP.. ? In the default branch there should also be a return, right? Do you get this without GEOIP? We should always have a default in a switch, so I guess we should have a return 0 in the default branch if not having GEOIP (which will never happend, but will remove the warning). -- Stig Bjørlykke ___ Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
Re: [Wireshark-dev] Compilation errors
-Original Message- From: wireshark-dev-boun...@wireshark.org [mailto:wireshark-dev-boun...@wireshark.org] On Behalf Of Stig Bjørlykke Sent: den 21 april 2011 13:19 To: Developer support list for Wireshark Subject: Re: [Wireshark-dev] Compilation errors On Thu, Apr 21, 2011 at 1:03 PM, Anders Broman anders.bro...@ericsson.com wrote: Should case 1: return CMP.. ? In the default branch there should also be a return, right? Do you get this without GEOIP? We should always have a default in a switch, so I guess we should have a return 0 in the default branch if not having GEOIP (which will never happend, but will remove the warning). -- Stig Bjørlykke Ok, but both case 1 and the default branch (with GEOIP) ends in g_assert unless I'm misstaken and that's hardly the intention is it? Regards Anders ___ Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe ___ Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
Re: [Wireshark-dev] Compilation errors
On Thu, Apr 21, 2011 at 1:30 PM, Anders Broman anders.bro...@ericsson.com wrote: Ok, but both case 1 and the default branch (with GEOIP) ends in g_assert unless I'm misstaken and that's hardly the intention is it? case 1 has a CMP_INT which does return. The default branch is only used for GEOIP because we only use hostlist_sort_column with values 0 and 1 without GEOIP. But I'm not sure if we will get a warning about unused code if we always return before g_assert, and g_assert is intended here, so maybe the return 0 will be wrong. -- Stig Bjørlykke ___ Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
Re: [Wireshark-dev] Compilation errors
-Original Message- From: wireshark-dev-boun...@wireshark.org [mailto:wireshark-dev-boun...@wireshark.org] On Behalf Of Stig Bjørlykke Sent: den 21 april 2011 13:52 To: Developer support list for Wireshark Subject: Re: [Wireshark-dev] Compilation errors On Thu, Apr 21, 2011 at 1:30 PM, Anders Broman anders.bro...@ericsson.com wrote: Ok, but both case 1 and the default branch (with GEOIP) ends in g_assert unless I'm misstaken and that's hardly the intention is it? case 1 has a CMP_INT which does return. The default branch is only used for GEOIP because we only use hostlist_sort_column with values 0 and 1 without GEOIP. But I'm not sure if we will get a warning about unused code if we always return before g_assert, and g_assert is intended here, so maybe the return 0 will be wrong. Ok, unfortunately I can't try myself as I'm trying to assist a co-worker at a remote location. He is using gcc version 3.4.3 20041212 (Red Hat 3.4.3-9.EL4) which is quite old. Regards Anders __ Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe ___ Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
[Wireshark-dev] Compilation error 2
Hi, gcc version 3.4.3 20041212 (Red Hat 3.4.3-9.EL4) tempfile.c: In function `create_tempfile': tempfile.c:197: warning: implicit declaration of function `time' tempfile.c:198: warning: implicit declaration of function `strftime' tempfile.c:198: warning: implicit declaration of function `localtime' tempfile.c:198: warning: passing arg 4 of `strftime' makes pointer from integer without a cast make[2]: *** [wireshark-tempfile.o] Error 1 Including time.h solves the problem, should that be added? Why is this turning up now, for this compiler? Regards Anders ___ Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
Re: [Wireshark-dev] Compilation error 2
Anders Broman wrote: Hi, gcc version 3.4.3 20041212 (Red Hat 3.4.3-9.EL4) tempfile.c: In function `create_tempfile': tempfile.c:197: warning: implicit declaration of function `time' tempfile.c:198: warning: implicit declaration of function `strftime' tempfile.c:198: warning: implicit declaration of function `localtime' tempfile.c:198: warning: passing arg 4 of `strftime' makes pointer from integer without a cast make[2]: *** [wireshark-tempfile.o] Error 1 Including time.h solves the problem, should that be added? Why is this turning up now, for this compiler? On my Fedora Core 10 system (glib 2.18) glib.h includes gdate.h which includes time.h . On a RHEL 4 system (glib 2.4), gdate.h does not include time.h but instead has this comment: /* make struct tm known without having to include time.h */ So I'd guess including time.h is the right thing to do here. (I think some other glib 2.4 systems--like Solaris 10--get time.h through other headers like select.h which comes in through types.h .) ___ Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
Re: [Wireshark-dev] Compilation error 2
Hi, You should seriosly consider moving to a more modern Linux system (BETE/Vipro) As this is quite old (gcc version 3.4.3 20041212 (Red Hat 3.4.3-9.EL4)) And seems to have trouble with a more modern Wireshark. Regards Anders -Original Message- From: wireshark-dev-boun...@wireshark.org [mailto:wireshark-dev-boun...@wireshark.org] On Behalf Of Jeff Morriss Sent: den 21 april 2011 15:49 To: Developer support list for Wireshark Subject: Re: [Wireshark-dev] Compilation error 2 Anders Broman wrote: Hi, gcc version 3.4.3 20041212 (Red Hat 3.4.3-9.EL4) tempfile.c: In function `create_tempfile': tempfile.c:197: warning: implicit declaration of function `time' tempfile.c:198: warning: implicit declaration of function `strftime' tempfile.c:198: warning: implicit declaration of function `localtime' tempfile.c:198: warning: passing arg 4 of `strftime' makes pointer from integer without a cast make[2]: *** [wireshark-tempfile.o] Error 1 Including time.h solves the problem, should that be added? Why is this turning up now, for this compiler? On my Fedora Core 10 system (glib 2.18) glib.h includes gdate.h which includes time.h . On a RHEL 4 system (glib 2.4), gdate.h does not include time.h but instead has this comment: /* make struct tm known without having to include time.h */ So I'd guess including time.h is the right thing to do here. (I think some other glib 2.4 systems--like Solaris 10--get time.h through other headers like select.h which comes in through types.h .) ___ Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe ___ Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
[Wireshark-dev] Compilation failure (mv: cannot stat `.deps/privileges.Tpo': No such file or directory)
r36767, Fedora 15/x64 beta, gcc (GCC) 4.6.0 20110419 (Red Hat 4.6.0-5) : make[2]: Entering directory `/home/ykaul/wireshark/wsutil' /bin/sh ../libtool --tag=CC --mode=compile gcc -DHAVE_CONFIG_H -I. -I.. -I./.. -I/usr/local/include '-DPLUGIN_DIR=/usr/local/lib/wireshark/plugins/1.5.2' -DINET6 -D_U_=__attribute__((unused)) -g -O2 -Wall -W -Wextra -Wdeclaration-after-statement -Wendif-labels -Wpointer-arith -Wno-pointer-sign -Warray-bounds -Wcast-align -Wformat-security -fexcess-precision=fast -I/usr/local/include -pthread -I/usr/include/gtk-2.0 -I/usr/lib64/gtk-2.0/include -I/usr/include/atk-1.0 -I/usr/include/cairo -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/pango-1.0 -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -I/usr/include/pixman-1 -I/usr/include/freetype2 -I/usr/include/libpng12 -MT privileges.lo -MD -MP -MF .deps/privileges.Tpo -c -o privileges.lo privileges.c mv -f .deps/privileges.Tpo .deps/privileges.Plo mv: cannot stat `.deps/privileges.Tpo': No such file or directory make[2]: *** [privileges.lo] Error 1 make[2]: Leaving directory `/home/ykaul/wireshark/wsutil' make[1]: *** [all-recursive] Error 1 make[1]: Leaving directory `/home/ykaul/wireshark' make: *** [all] Error 2 ___ Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
Re: [Wireshark-dev] [Wireshark-commits] rev 36755: /trunk/epan/dissectors/ /trunk/epan/dissectors/: packet-l2tp.c
2011/4/21 Stig Bjørlykke s...@bjorlykke.org On Thu, Apr 21, 2011 at 3:32 PM, alagou...@wireshark.org wrote: Fix Dead Store (Dead nested assignment) Warning found by Clang - msg_type = tvb_get_ntohs(tvb, (tmp_idx+=2)); + msg_type = tvb_get_ntohs(tvb, tmp_idx); Are you sure this is correct? What about tmp_idx+2? Oups ! Fix in Rev 36768 ___ Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
[Wireshark-dev] Wireshark
Hi, Is wireshark a C or C++ project? -- Thanks, Mahdi Yusuf ___ Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
Re: [Wireshark-dev] Wireshark
On Thu, Apr 21, 2011 at 11:56:22AM -0400, Mahdi Yusuf wrote: Is wireshark a C or C++ project? C. http://www.wireshark.org/docs/wsdg_html_chunked/ChIntroDevelopment.html ___ Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
Re: [Wireshark-dev] [Wireshark-commits] rev 36772: /trunk/plugins/profinet/ /trunk/plugins/profinet/: packet-dcerpc-pn-io.c
On Thu, Apr 21, 2011 at 6:01 PM, alagou...@wireshark.org wrote: Fix Dead Store (Dead assignement/Dead increment) Warning found by Clang -flags1_tree = proto_item_add_subtree(flags1_item, ett_pn_io_profisafe_f_parameter_prm_flag1); +proto_item_add_subtree(flags1_item, ett_pn_io_profisafe_f_parameter_prm_flag1); This fix is completely wrong! You have no need for a proto_item_add_subtree without using the return value. In this case I suppose flags1_tree should be use in the next dissect_dcerpc_uint8 calls instead of using flags1_item. -- Stig Bjørlykke ___ Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
[Wireshark-dev] clang core dump on plugins/giop/packet-parlay.c
I'm trying again to get clang to compile Wireshark and after commenting out these two lines in configure.in temporarily: AC_WIRESHARK_GCC_CFLAGS_CHECK(-Wcast-align) AC_WIRESHARK_GCC_CFLAGS_CHECK(-fexcess-precision=fast) It gets all of the way to plugins/giop/packet-parlay.c and then clang core dumps! Is anyone else having this problem? This is a FreeBSD 8.2-RELEASE (amd64) system. It probably doesn't help that packet-parlay.c is 108,692 lines long... Making all in giop gmake[3]: Entering directory `/usr/local/src/wireshark-clang/plugins/giop' /bin/bash ../../libtool --tag=CC --mode=compile clang -DHAVE_CONFIG_H -I. -I../.. -I../.. -I/usr/local/include -I/usr/include/pcap -I/usr/include '-DPLUGIN_DIR=/usr/local/lib/wireshark/plugins/1.5.2' -DINET6 -D_U_=__attribute__((unused)) -g -O2 -Wall -W -Werror=unknown-warning-option -Wextra -Werror=unknown-warning-option -Wdeclaration-after-statement -Werror=unknown-warning-option -Wendif-labels -Werror=unknown-warning-option -Wpointer-arith -Werror=unknown-warning-option -Wno-pointer-sign -Werror=unknown-warning-option -Wformat-security -Werror=unknown-warning-option -I/usr/local/include -D_THREAD_SAFE -D_REENTRANT -I/usr/local/include/gtk-2.0 -I/usr/local/lib/gtk-2.0/include -I/usr/local/include/atk-1.0 -I/usr/local/include/cairo -I/usr/local/include/gdk-pixbuf-2.0 -I/usr/local/include/pango-1.0 -I/usr/local/include/gio-unix-2.0/ -I/usr/local/include -I/usr/local/include/glib-2.0 -I/usr/local/lib/glib-2.0/include -I/usr/local/include/pixman-1 -I/usr/local/include/freetype2 -I/usr/include/pcap -I/usr/include -MT packet-parlay.lo -MD -MP -MF .deps/packet-parlay.Tpo -c -o packet-parlay.lo packet-parlay.c libtool: compile: clang -DHAVE_CONFIG_H -I. -I../.. -I../.. -I/usr/local/include -I/usr/include/pcap -I/usr/include -DPLUGIN_DIR=\/usr/local/lib/wireshark/plugins/1.5.2\ -DINET6 -D_U_=__attribute__((unused)) -g -O2 -Wall -W -Werror=unknown-warning-option -Wextra -Werror=unknown-warning-option -Wdeclaration-after-statement -Werror=unknown-warning-option -Wendif-labels -Werror=unknown-warning-option -Wpointer-arith -Werror=unknown-warning-option -Wno-pointer-sign -Werror=unknown-warning-option -Wformat-security -Werror=unknown-warning-option -I/usr/local/include -D_THREAD_SAFE -D_REENTRANT -I/usr/local/include/gtk-2.0 -I/usr/local/lib/gtk-2.0/include -I/usr/local/include/atk-1.0 -I/usr/local/include/cairo -I/usr/local/include/gdk-pixbuf-2.0 -I/usr/local/include/pango-1.0 -I/usr/local/include/gio-unix-2.0/ -I/usr/local/include -I/usr/local/include/glib-2.0 -I/usr/local/lib/glib-2.0/include -I/usr/local/include/pixman-1 -I/usr/local/include/freetype2 -I/usr/include/pcap -I/usr/include -MT packet-parlay.lo -MD -MP -MF .deps/packet-parlay.Tpo -c packet-parlay.c -fPIC -DPIC -o .libs/packet-parlay.o packet-parlay.c:85746:13: warning: unused function 'decode_org_csapi_fw_TpLoadPolicy_st' [-Wunused-function] static void decode_org_csapi_fw_TpLoadPolicy_st(tvbuff_t *tvb _U_, packet_info *pinfo _U_, proto_tree *tree _U_, int *offset _U_, MessageHeader ... ^ packet-parlay.c:85824:13: warning: unused function 'decode_org_csapi_fw_TpLoadInitVal_st' [-Wunused-function] static void decode_org_csapi_fw_TpLoadInitVal_st(tvbuff_t *tvb _U_, packet_info *pinfo _U_, proto_tree *tree _U_, int *offset _U_, MessageHeader ... ^ clang: error: clang frontend command failed due to signal 4 (use -v to see invocation) gmake[3]: *** [packet-parlay.lo] Error 1 gmake[3]: Leaving directory `/usr/local/src/wireshark-clang/plugins/giop' gmake[2]: *** [all-recursive] Error 1 gmake[2]: Leaving directory `/usr/local/src/wireshark-clang/plugins' gmake[1]: *** [all-recursive] Error 1 gmake[1]: Leaving directory `/usr/local/src/wireshark-clang' gmake: *** [all] Error 2 gdb clang plugins/giop/clang.core GNU gdb 6.1.1 [FreeBSD] Copyright 2004 Free Software Foundation, Inc. GDB is free software, covered by the GNU General Public License, and you are welcome to change it and/or distribute copies of it under certain conditions. Type show copying to see the conditions. There is absolutely no warranty for GDB. Type show warranty for details. This GDB was configured as amd64-marcel-freebsd...(no debugging symbols found)... Core was generated by `clang'. Program terminated with signal 4, Illegal instruction. Reading symbols from /lib/libthr.so.3...(no debugging symbols found)...done. Loaded symbols for /lib/libthr.so.3 Reading symbols from /usr/lib/libstdc++.so.6...(no debugging symbols found)...done. Loaded symbols for /usr/lib/libstdc++.so.6 Reading symbols from /lib/libm.so.5...(no debugging symbols found)...done. Loaded symbols for /lib/libm.so.5 Reading symbols from /lib/libgcc_s.so.1...(no debugging symbols found)...done. Loaded symbols for /lib/libgcc_s.so.1 Reading symbols from /lib/libc.so.7...(no debugging symbols found)...done. Loaded symbols for /lib/libc.so.7 Reading symbols from
Re: [Wireshark-dev] clang core dump on plugins/giop/packet-parlay.c
Hey Stephen! might be worth sharing with clang team, don't you think? Have you tried to disable packet-parlay to check whether it is the only dissector creating such an issue? Regards, Sebastien Tandel On Thu, Apr 21, 2011 at 16:30, Stephen Fisher st...@stephen-fisher.comwrote: I'm trying again to get clang to compile Wireshark and after commenting out these two lines in configure.in temporarily: AC_WIRESHARK_GCC_CFLAGS_CHECK(-Wcast-align) AC_WIRESHARK_GCC_CFLAGS_CHECK(-fexcess-precision=fast) It gets all of the way to plugins/giop/packet-parlay.c and then clang core dumps! Is anyone else having this problem? This is a FreeBSD 8.2-RELEASE (amd64) system. It probably doesn't help that packet-parlay.c is 108,692 lines long... Making all in giop gmake[3]: Entering directory `/usr/local/src/wireshark-clang/plugins/giop' /bin/bash ../../libtool --tag=CC --mode=compile clang -DHAVE_CONFIG_H -I. -I../.. -I../.. -I/usr/local/include -I/usr/include/pcap -I/usr/include '-DPLUGIN_DIR=/usr/local/lib/wireshark/plugins/1.5.2' -DINET6 -D_U_=__attribute__((unused)) -g -O2 -Wall -W -Werror=unknown-warning-option -Wextra -Werror=unknown-warning-option -Wdeclaration-after-statement -Werror=unknown-warning-option -Wendif-labels -Werror=unknown-warning-option -Wpointer-arith -Werror=unknown-warning-option -Wno-pointer-sign -Werror=unknown-warning-option -Wformat-security -Werror=unknown-warning-option -I/usr/local/include -D_THREAD_SAFE -D_REENTRANT -I/usr/local/include/gtk-2.0 -I/usr/local/lib/gtk-2.0/include -I/usr/local/include/atk-1.0 -I/usr/local/include/cairo -I/usr/local/include/gdk-pixbuf-2.0 -I/usr/local/include/pango-1.0 -I/usr/local/include/gio-unix-2.0/ -I/usr/local/include -I/usr/local/include/glib-2.0 -I/usr/local/lib/glib-2.0/include -I/usr/local/include/pixman-1 -I/usr/local/include/freetype2 -I/usr/include/pcap -I/usr/include -MT packet-parlay.lo -MD -MP -MF .deps/packet-parlay.Tpo -c -o packet-parlay.lo packet-parlay.c libtool: compile: clang -DHAVE_CONFIG_H -I. -I../.. -I../.. -I/usr/local/include -I/usr/include/pcap -I/usr/include -DPLUGIN_DIR=\/usr/local/lib/wireshark/plugins/1.5.2\ -DINET6 -D_U_=__attribute__((unused)) -g -O2 -Wall -W -Werror=unknown-warning-option -Wextra -Werror=unknown-warning-option -Wdeclaration-after-statement -Werror=unknown-warning-option -Wendif-labels -Werror=unknown-warning-option -Wpointer-arith -Werror=unknown-warning-option -Wno-pointer-sign -Werror=unknown-warning-option -Wformat-security -Werror=unknown-warning-option -I/usr/local/include -D_THREAD_SAFE -D_REENTRANT -I/usr/local/include/gtk-2.0 -I/usr/local/lib/gtk-2.0/include -I/usr/local/include/atk-1.0 -I/usr/local/include/cairo -I/usr/local/include/gdk-pixbuf-2.0 -I/usr/local/include/pango-1.0 -I/usr/local/include/gio-unix-2.0/ -I/usr/local/include -I/usr/local/include/glib-2.0 -I/usr/local/lib/glib-2.0/include -I/usr/local/include/pixman-1 -I/usr/local/include/freetype2 -I/usr/include/pcap -I/usr/include -MT packet-parlay.lo -MD -MP -MF .deps/packet-parlay.Tpo -c packet-parlay.c -fPIC -DPIC -o .libs/packet-parlay.o packet-parlay.c:85746:13: warning: unused function 'decode_org_csapi_fw_TpLoadPolicy_st' [-Wunused-function] static void decode_org_csapi_fw_TpLoadPolicy_st(tvbuff_t *tvb _U_, packet_info *pinfo _U_, proto_tree *tree _U_, int *offset _U_, MessageHeader ... ^ packet-parlay.c:85824:13: warning: unused function 'decode_org_csapi_fw_TpLoadInitVal_st' [-Wunused-function] static void decode_org_csapi_fw_TpLoadInitVal_st(tvbuff_t *tvb _U_, packet_info *pinfo _U_, proto_tree *tree _U_, int *offset _U_, MessageHeader ... ^ clang: error: clang frontend command failed due to signal 4 (use -v to see invocation) gmake[3]: *** [packet-parlay.lo] Error 1 gmake[3]: Leaving directory `/usr/local/src/wireshark-clang/plugins/giop' gmake[2]: *** [all-recursive] Error 1 gmake[2]: Leaving directory `/usr/local/src/wireshark-clang/plugins' gmake[1]: *** [all-recursive] Error 1 gmake[1]: Leaving directory `/usr/local/src/wireshark-clang' gmake: *** [all] Error 2 gdb clang plugins/giop/clang.core GNU gdb 6.1.1 [FreeBSD] Copyright 2004 Free Software Foundation, Inc. GDB is free software, covered by the GNU General Public License, and you are welcome to change it and/or distribute copies of it under certain conditions. Type show copying to see the conditions. There is absolutely no warranty for GDB. Type show warranty for details. This GDB was configured as amd64-marcel-freebsd...(no debugging symbols found)... Core was generated by `clang'. Program terminated with signal 4, Illegal instruction. Reading symbols from /lib/libthr.so.3...(no debugging symbols found)...done. Loaded symbols for /lib/libthr.so.3 Reading symbols from /usr/lib/libstdc++.so.6...(no debugging symbols found)...done. Loaded symbols for /usr/lib/libstdc++.so.6 Reading symbols from /lib/libm.so.5...(no debugging symbols
Re: [Wireshark-dev] clang core dump on plugins/giop/packet-parlay.c
On Apr 21, 2011, at 12:35 PM, Sébastien Tandel wrote: Hey Stephen! might be worth sharing with clang team, don't you think? A (non-public) bug has already been filed on it. Have you tried to disable packet-parlay to check whether it is the only dissector creating such an issue? It takes about 2GB or more of memory in the static analyzer to analyze dissect_parlay(); is the static analyzer built 64-bit or 32-bit, or is it running out of swap space+memory? Perhaps if the CORBA-IDL-to-Wireshark-dissector tool didn't generate 3MB of source code, this would be less of a problem. (The lights dim when packet-parlay.c is compiled) On Thu, Apr 21, 2011 at 16:30, Stephen Fisher st...@stephen-fisher.com wrote: I'm trying again to get clang to compile Wireshark and after commenting out these two lines in configure.in temporarily: AC_WIRESHARK_GCC_CFLAGS_CHECK(-Wcast-align) I've been fixing those whilst trying to build with clang. AC_WIRESHARK_GCC_CFLAGS_CHECK(-fexcess-precision=fast) That reminds me - I need to file a bug asking for some way to turn unknown -f flags into errors rather than warnings, so AC_WIRESHARK_GCC_CFLAGS_CHECK will leave that one out with clang, rather than provoking tons of clang warnings. ___ Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
Re: [Wireshark-dev] [Wireshark-commits] rev 36772: /trunk/plugins/profinet/ /trunk/plugins/profinet/: packet-dcerpc-pn-io.c
2011/4/21 Stig Bjørlykke s...@bjorlykke.org On Thu, Apr 21, 2011 at 6:01 PM, alagou...@wireshark.org wrote: Fix Dead Store (Dead assignement/Dead increment) Warning found by Clang -flags1_tree = proto_item_add_subtree(flags1_item, ett_pn_io_profisafe_f_parameter_prm_flag1); +proto_item_add_subtree(flags1_item, ett_pn_io_profisafe_f_parameter_prm_flag1); This fix is completely wrong! You have no need for a proto_item_add_subtree without using the return value. In this case I suppose flags1_tree should be use in the next dissect_dcerpc_uint8 calls instead of using flags1_item. Hi, I based my change on the previous revision of jmayer (rev36724) in this file ... and there is the same mistake ! I can not fix the issue tonight, I do it tomorrow Regards, ___ Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
Re: [Wireshark-dev] [Wireshark-commits] rev 36772: /trunk/plugins/profinet/ /trunk/plugins/profinet/: packet-dcerpc-pn-io.c
On Thu, Apr 21, 2011 at 10:31 PM, Alexis La Goutte alexis.lagou...@gmail.com wrote: I based my change on the previous revision of jmayer (rev36724) in this file and there is the same mistake ! Hmm, after a closer look I find that proto_item_add_subtree() returns the input parameter, so we have no real bug here. But this raises a question why we have to use the return value from proto_item_add_subtree() for the tree, as proto_item and proto_tree are the same... I think the cleanest solution is to use the return value, as this is done elsewhere and the implementation of proto_item_add_subtree() may change. Comments? -- Stig Bjørlykke ___ Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
Re: [Wireshark-dev] Installer missing ZLib1.DLL
Chaswi Przellczyk cp70@... writes: thanks for your response. I'm building Version 1.4.4 on WindowsXP. I received the source in tar.bz2-packaged form. The ZIP is dated on 25.03.2011. The wireshark-1.4.4.tar.bz2 file posted on the download page is dated as 01-Mar-2011 11:49, but maybe you downloaded it on 25-Mar-2011 and that's why the date differs? To be sure you have the right sources, you might want to check the file signature against the one posted at http://www.wireshark.org/download/src/all-versions/. You might also try switching to 1.4.6 now that it's been released. Maybe you'll have better luck with that one? ___ Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
[Wireshark-dev] buildbot failure in Wireshark (development) on OSX-10.5-PowerPC
The Buildbot has detected a new failure of OSX-10.5-PowerPC on Wireshark (development). Full details are available at: http://buildbot.wireshark.org/trunk/builders/OSX-10.5-PowerPC/builds/2528 Buildbot URL: http://buildbot.wireshark.org/trunk/ Buildslave for this Build: osx-10.5-ppc Build Reason: Build Source Stamp: 36789 Blamelist: guy BUILD FAILED: failed compile sincerely, -The Buildbot ___ Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe