[Wireshark-dev] buildbot failure in Wireshark (development) on Visual-Studio-Code-Analysis
The Buildbot has detected a new failure of Visual-Studio-Code-Analysis on Wireshark (development). Full details are available at: http://buildbot.wireshark.org/trunk/builders/Visual-Studio-Code-Analysis/builds/796 Buildbot URL: http://buildbot.wireshark.org/trunk/ Buildslave for this Build: vs-code-analysis Build Reason: Build Source Stamp: 37234 Blamelist: wmeier BUILD FAILED: failed nmake all sincerely, -The Buildbot ___ Sent via:Wireshark-dev mailing list Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
[Wireshark-dev] buildbot failure in Wireshark (development) on OSX-10.5-PowerPC
The Buildbot has detected a new failure of OSX-10.5-PowerPC on Wireshark (development). Full details are available at: http://buildbot.wireshark.org/trunk/builders/OSX-10.5-PowerPC/builds/2763 Buildbot URL: http://buildbot.wireshark.org/trunk/ Buildslave for this Build: osx-10.5-ppc Build Reason: Build Source Stamp: 37219 Blamelist: darkjames,guy,morriss BUILD FAILED: failed compile sincerely, -The Buildbot ___ Sent via:Wireshark-dev mailing list Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
[Wireshark-dev] buildbot failure in Wireshark (development) on OSX-10.5-x86
The Buildbot has detected a new failure of OSX-10.5-x86 on Wireshark (development). Full details are available at: http://buildbot.wireshark.org/trunk/builders/OSX-10.5-x86/builds/3203 Buildbot URL: http://buildbot.wireshark.org/trunk/ Buildslave for this Build: osx-10.5-x86 Build Reason: Build Source Stamp: 37228 Blamelist: guy,wmeier BUILD FAILED: failed compile sincerely, -The Buildbot ___ Sent via:Wireshark-dev mailing list Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
[Wireshark-dev] buildbot failure in Wireshark 1.2 on Windows-XP-x86
The Buildbot has detected a new failure of Windows-XP-x86 on Wireshark 1.2. Full details are available at: http://buildbot.wireshark.org/trunk-1.2/builders/Windows-XP-x86/builds/4 Buildbot URL: http://buildbot.wireshark.org/trunk-1.2/ Buildslave for this Build: windows-xp-x86 Build Reason: Build Source Stamp: 37220 Blamelist: gerald BUILD FAILED: failed failed slave lost sincerely, -The Buildbot ___ Sent via:Wireshark-dev mailing list Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
[Wireshark-dev] buildbot failure in Wireshark (development) on OSX-10.6-x64
The Buildbot has detected a new failure of OSX-10.6-x64 on Wireshark (development). Full details are available at: http://buildbot.wireshark.org/trunk/builders/OSX-10.6-x64/builds/2754 Buildbot URL: http://buildbot.wireshark.org/trunk/ Buildslave for this Build: osx-10.6-x64 Build Reason: Build Source Stamp: 37228 Blamelist: guy,wmeier BUILD FAILED: failed compile sincerely, -The Buildbot ___ Sent via:Wireshark-dev mailing list Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
[Wireshark-dev] buildbot failure in Wireshark (development) on Windows-7-x64
The Buildbot has detected a new failure of Windows-7-x64 on Wireshark (development). Full details are available at: http://buildbot.wireshark.org/trunk/builders/Windows-7-x64/builds/1876 Buildbot URL: http://buildbot.wireshark.org/trunk/ Buildslave for this Build: windows-7-x64 Build Reason: Build Source Stamp: 37219 Blamelist: darkjames,guy,morriss BUILD FAILED: failed nmake all sincerely, -The Buildbot ___ Sent via:Wireshark-dev mailing list Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
[Wireshark-dev] buildbot failure in Wireshark (development) on Windows-XP-x86
The Buildbot has detected a new failure of Windows-XP-x86 on Wireshark (development). Full details are available at: http://buildbot.wireshark.org/trunk/builders/Windows-XP-x86/builds/2988 Buildbot URL: http://buildbot.wireshark.org/trunk/ Buildslave for this Build: windows-xp-x86 Build Reason: Build Source Stamp: 37219 Blamelist: darkjames,gerald,guy,morriss BUILD FAILED: failed failed slave lost sincerely, -The Buildbot ___ Sent via:Wireshark-dev mailing list Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
[Wireshark-dev] buildbot failure in Wireshark (development) on Windows-7-x64
The Buildbot has detected a new failure of Windows-7-x64 on Wireshark (development). Full details are available at: http://buildbot.wireshark.org/trunk/builders/Windows-7-x64/builds/1872 Buildbot URL: http://buildbot.wireshark.org/trunk/ Buildslave for this Build: windows-7-x64 Build Reason: Build Source Stamp: 37206 Blamelist: gerald,morriss BUILD FAILED: failed nmake docs sincerely, -The Buildbot ___ Sent via:Wireshark-dev mailing list Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
[Wireshark-dev] wireshark dev e-mail list
Is the wireshark dev e-mail list down..?? Just wondering. Thanks, Brian ___ Sent via:Wireshark-dev mailing list Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
Re: [Wireshark-dev] [Wireshark-commits] rev 37201: /trunk/epan/dissectors/ /trunk/epan/dissectors/: packet-ncp2222.inc
Jeff Morriss wrote: Maynard, Chris wrote: -Original Message- From: wireshark-commits-boun...@wireshark.org [mailto:wireshark- commits-boun...@wireshark.org] On Behalf Of morr...@wireshark.org Sent: Tuesday, May 17, 2011 12:08 PM To: wireshark-comm...@wireshark.org Subject: [Wireshark-commits] rev 37201: /trunk/epan/dissectors/ /trunk/epan/dissectors/: packet-ncp.inc http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=37201 User: morriss Date: 2011/05/17 09:07 AM Log: Avoid passing a NULL string pointer to format routines: some libc's (e.g., Solaris') will seg-fault on that. Directory: /trunk/epan/dissectors/ ChangesPath Action +8 -4 packet-ncp.incModified Would it be better to use val_to_str() or val_to_str_const() in cases such as this? Yes, either would probably work here: NCP's get_string() (which is used to generate the string most of the time) also returns ep_alloc'd memory (as val_to_str() may). And anyway, most can be replaced with the _const version. ... which I'll work on. Found a few more unprotected match_strval()s in there at the same time. :-) Thanks for the pointer! ___ Sent via:Wireshark-dev mailing list Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
Re: [Wireshark-dev] [Wireshark-commits] rev 37201: /trunk/epan/dissectors/ /trunk/epan/dissectors/: packet-ncp2222.inc
On May 17, 2011, at 9:35 AM, Maynard, Chris wrote: > What about changing match_strval() to behave like val_to_str() does (i.e., > make IT handle the NULL case), That would require code that uses match_strval() to check whether a given numeric value has a match in the value_string table or not and do different things depending on whether it has a match or not to be changed to use some other mechanism to do so. ___ Sent via:Wireshark-dev mailing list Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
Re: [Wireshark-dev] dissecting bits versus bytes
On Tue, May 17, 2011 at 10:28:23AM -0400, Brian Oleksa wrote: > I am dissecting bits not bytes. I am running into some problems. > ... > Any help with this is greatly appreciated. You can try using proto_tree_add_bits_item(), hth. ___ Sent via:Wireshark-dev mailing list Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
Re: [Wireshark-dev] [Wireshark-commits] rev 37201: /trunk/epan/dissectors/ /trunk/epan/dissectors/: packet-ncp2222.inc
Maynard, Chris wrote: -Original Message- From: wireshark-commits-boun...@wireshark.org [mailto:wireshark- commits-boun...@wireshark.org] On Behalf Of morr...@wireshark.org Sent: Tuesday, May 17, 2011 12:08 PM To: wireshark-comm...@wireshark.org Subject: [Wireshark-commits] rev 37201: /trunk/epan/dissectors/ /trunk/epan/dissectors/: packet-ncp.inc http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=37201 User: morriss Date: 2011/05/17 09:07 AM Log: Avoid passing a NULL string pointer to format routines: some libc's (e.g., Solaris') will seg-fault on that. Directory: /trunk/epan/dissectors/ ChangesPath Action +8 -4 packet-ncp.incModified Would it be better to use val_to_str() or val_to_str_const() in cases such as this? Yes, either would probably work here: NCP's get_string() (which is used to generate the string most of the time) also returns ep_alloc'd memory (as val_to_str() may). What about changing match_strval() to behave like val_to_str() does (i.e., make IT handle the NULL case), and then just have val_to_str() return match_strval()'s guaranteed non-NULL return value unconditionally? And also introduce a match_strval_const() counterpart for val_to_str_const(). The problem with changing match_strval() is there's a bunch of code like: if (match_strval(type, a11_types) == NULL) return 0; /* not a known message type */ ___ Sent via:Wireshark-dev mailing list Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
Re: [Wireshark-dev] strlen() and NULL pointer checks
Jeff Morriss wrote: Jakub Zawadzki wrote: - I had the same issue with another project, and we created macro: #define __(x) ((x) ? (x) : "(null)") and use it when passing possible-null-strings. It's still PITA but IMHO it looks a little better than doing it by hand. I don't mind doing it by hand (and in some cases I prefer NOT having another layer of abstraction), but then we still need to have a way to (regularly) test for it. Oh, and I figured fuzz testing on the Solaris buildbot would not be a good solution because only people with access to Solaris boxes would be able to reproduce the crash... ___ Sent via:Wireshark-dev mailing list Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
Re: [Wireshark-dev] [Wireshark-commits] rev 37201: /trunk/epan/dissectors/ /trunk/epan/dissectors/: packet-ncp2222.inc
> -Original Message- > From: wireshark-commits-boun...@wireshark.org [mailto:wireshark- > commits-boun...@wireshark.org] On Behalf Of morr...@wireshark.org > Sent: Tuesday, May 17, 2011 12:08 PM > To: wireshark-comm...@wireshark.org > Subject: [Wireshark-commits] rev 37201: /trunk/epan/dissectors/ > /trunk/epan/dissectors/: packet-ncp.inc > > http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=37201 > > User: morriss > Date: 2011/05/17 09:07 AM > > Log: > Avoid passing a NULL string pointer to format routines: some libc's > (e.g., > Solaris') will seg-fault on that. > > Directory: /trunk/epan/dissectors/ > ChangesPath Action > +8 -4 packet-ncp.incModified Would it be better to use val_to_str() or val_to_str_const() in cases such as this? What about changing match_strval() to behave like val_to_str() does (i.e., make IT handle the NULL case), and then just have val_to_str() return match_strval()'s guaranteed non-NULL return value unconditionally? And also introduce a match_strval_const() counterpart for val_to_str_const(). CONFIDENTIALITY NOTICE: The contents of this email are confidential and for the exclusive use of the intended recipient. If you receive this email in error, please delete it from your system immediately and notify us either by email, telephone or fax. You should not copy, forward, or otherwise disclose the content of the email. ___ Sent via:Wireshark-dev mailing list Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
Re: [Wireshark-dev] [Wireshark-commits] rev 37016: /trunk/gtk/ /trunk/gtk/: main_welcome.c
On Tue, May 17, 2011 at 05:13:35PM +0200, Balint Reczey wrote: > It is expected to be one inch below the text. :-) I wanted to make it > as clear as possible, but obviously I failed. How could it be made > clearer? It's further down on my screen :). Just saying "See the capture help below" would be sufficient I think. ___ Sent via:Wireshark-dev mailing list Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
Re: [Wireshark-dev] [Wireshark-commits] rev 37016: /trunk/gtk/ /trunk/gtk/: main_welcome.c
It is expected to be one inch below the text. :-) I wanted to make it as clear as possible, but obviously I failed. How could it be made clearer? I also updated documentation in docbook ant the wiki with Debian related help. Cheers, Balint On 05/16/2011 08:58 PM, Stephen Fisher wrote: This is a great idea. What is/where is "capture help" that it refers to? It would be great if it could be a clickable link to take the user there. On Sun, May 08, 2011 at 10:59:24AM +, rbal...@wireshark.org wrote: http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=37016 User: rbalint Date: 2011/05/08 03:59 AM Log: If no interface is found for capturing show this information and direct user to Capture Help instead of showing the empty list of interfaces and capture options. Directory: /trunk/gtk/ ChangesPath Action +77 -55main_welcome.cModified ___ Sent via:Wireshark-dev mailing list Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
[Wireshark-dev] climbing trees
(I posted this email twelve hours ago, but it hasn't shown up, so I'm resending. Sorry if it's a duplicate.) I've updated the patch for bug 5531 per comments from Jeff Morriss (thanks, Jeff!) but he brought up a comment I don't know how to address, so I thought I'd ask here. The comment is on a bit of code that looks like this: /* at this point there are two possibilities: either the packet * has been dissected already or it has not. If it has not, then * we already have a tvb full of C12.22 data. If it has, then we * are actually two levels deep and the data we seek is actually in * the grandparent of the current node. */ if ((tree->parent->finfo != NULL) && (tree->parent->parent != NULL)) pkt_tree = tree->parent->parent; This code, which is within asn1/c1222/packet-c1222-template.c, is called when we're just displaying the list of packets and also when the packet is being displayed in tree form. In order to allow the use of a display filter such as "c1222.crypto_good == true" the packet has to be parsed and rearranged in canonical form for cryptographic processing, per the protocol. In some cases, what gets passed here is the whole packet in which case the if clause above is false. However, if the tree has already been constructed, what this code is handed is actually deeper inside and we need to climb the tree to get access to the packet data. Is there a better way to do this? Ed ___ Sent via:Wireshark-dev mailing list Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
[Wireshark-dev] buildbot failure in Wireshark (development) on Clang-Code-Analysis
The Buildbot has detected a new failure of Clang-Code-Analysis on Wireshark (development). Full details are available at: http://buildbot.wireshark.org/trunk/builders/Clang-Code-Analysis/builds/120 Buildbot URL: http://buildbot.wireshark.org/trunk/ Buildslave for this Build: clang-code-analysis Build Reason: The Nightly scheduler named 'periodic' triggered this build Build Source Stamp: HEAD Blamelist: BUILD FAILED: failed compile sincerely, -The Buildbot ___ Sent via:Wireshark-dev mailing list Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
