Re: [Wireshark-dev] capture_dlg.c: several "unused_but_set" warnings [GCC 4.6]

2011-08-10 Thread Michael Tüxen
On Aug 10, 2011, at 11:26 PM, Bill Meier wrote:

> capture_dlg.c: In function ‘insert_new_rows’:
> 
> capture_dlg.c:665:18: warning: variable ‘cap_settings’ set but not used 
> [-Wunused-but-set-variable]
> capture_dlg.c:664:8: warning: variable ‘linktype_select’ set but not used 
> [-Wunused-but-set-variable]
> 
> 
> capture_dlg.c: In function ‘create_and_fill_model’:
> 
> capture_dlg.c:3532:12: warning: variable ‘pre_selected’ set but not used 
> [-Wunused-but-set-variable]
> capture_dlg.c:3521:8: warning: variable ‘linktype_select’ set but not used 
> [-Wunused-but-set-variable]
> 
> 
> capture_dlg.c: In function ‘capture_prep_adjust_sensitivity’:
> 
> capture_dlg.c:3934:14: warning: variable ‘if_cb’ set but not used 
> [-Wunused-but-set-variable]
Hi Bill,

thanks for the report. I'm still investigating how to fix two CID. I'll try to 
fix these warnings
too.

Best regards
Michael
> ___
> Sent via:Wireshark-dev mailing list 
> Archives:http://www.wireshark.org/lists/wireshark-dev
> Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
>mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
> 

___
Sent via:Wireshark-dev mailing list 
Archives:http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe


[Wireshark-dev] buildbot failure in Wireshark (development) on Windows-7-x64

2011-08-10 Thread buildbot-no-reply
The Buildbot has detected a new failure on builder Windows-7-x64 while building 
Wireshark (development).
Full details are available at:
 http://buildbot.wireshark.org/trunk/builders/Windows-7-x64/builds/2663

Buildbot URL: http://buildbot.wireshark.org/trunk/

Buildslave for this Build: windows-7-x64

Build Reason: scheduler
Build Source Stamp: 38462
Blamelist: wmeier

BUILD FAILED: failed nmake docs

sincerely,
 -The Buildbot



___
Sent via:Wireshark-dev mailing list 
Archives:http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe


Re: [Wireshark-dev] Rev 38350 Capture Options Changes - Named Pipe?

2011-08-10 Thread Joerg Mayer
On Wed, Aug 10, 2011 at 11:16:55PM +0200, Jakub Zawadzki wrote:
> On Wed, Aug 10, 2011 at 10:49:47PM +0200, Michael Tüxen wrote:
> > I was aware of this in the context of the -i arguments, but not that it 
> > could be
> > specified in the GUI. We need to find a way to do this. Maybe an button 
> > which
> > will add a named pipe to the list of interfaces.
> 
> Can we have it in another window?
> I'd be happy to have different options in capture submenu, like:
>  Capture
>   | - Interface
>   || - [X] eth0: ...
>   || - [X] wlan0: ...
>   || - [ ] ...
>   | - nflog
>   | - Named pipe
>   | - From program (ptrace-based)
>   | - ...
>   | --
>   | - Capture options
>   | - Start
>   | - ...

When building with remote capture, then there is a button below the Interface
list. Maybe the remote capture stuff, the interface stuff and the pipe stuff
can be unified by having a drop down button with which to select what to show
inside the area that is the interface list right now?

Ciao
   Joerg
-- 
Joerg Mayer   
We are stuck with technology when what we really want is just stuff that
works. Some say that should read Microsoft instead of technology.
___
Sent via:Wireshark-dev mailing list 
Archives:http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

Re: [Wireshark-dev] Rev 38350 Capture Options Changes - Named Pipe?

2011-08-10 Thread Colin O'Flynn
> Maybe an button which
> will add a named pipe to the list of interfaces.

If this added the pipe to a preference file that would be even better, as it
would persist between Wireshark sessions. It might help pipes feel more
loved, and not like a hack added on.

Regards,

  -Colin

-Original Message-
From: wireshark-dev-boun...@wireshark.org
[mailto:wireshark-dev-boun...@wireshark.org] On Behalf Of Michael Tüxen
Sent: August 10, 2011 5:50 PM
To: Developer support list for Wireshark
Subject: Re: [Wireshark-dev] Rev 38350 Capture Options Changes - Named Pipe?

On Aug 10, 2011, at 10:44 PM, Guy Harris wrote:

> 
> On Aug 10, 2011, at 1:33 PM, Michael Tüxen wrote:
> 
>> Use the command line options... There is currently no way to specify a
named
>> pipe in the GUI. I think there was no way to do this in Wireshark 1.6, or
>> am I missing something?
> 
> The general convention in Wireshark-the-project (i.e., Wireshark, TShark,
and dumpcap) is that if the "network interface" you specify isn't a network
interface (i.e., an attempt to open it with libpcap fails), and it's a named
pipe, it's opened as a pipe connected to a program writing a pcap (or
pcap-ng?) capture file.
> 
> I.e., in the GUI, you'd specify it by, for example, giving "/tmp/pipe" (or
whatever the named pipe path is) as the name of the "network interface" from
which to capture in the Capture Options dialog.
Hi Guy,

I was aware of this in the context of the -i arguments, but not that it
could be
specified in the GUI. We need to find a way to do this. Maybe an button
which
will add a named pipe to the list of interfaces.
I'll talk to Irene when she's available again to bring back the capability
to
specify named pipes in the GUI.

Best regards
Michael
>
___
> Sent via:Wireshark-dev mailing list 
> Archives:http://www.wireshark.org/lists/wireshark-dev
> Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
> mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
> 

___
Sent via:Wireshark-dev mailing list 
Archives:http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

___
Sent via:Wireshark-dev mailing list 
Archives:http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe


[Wireshark-dev] capture_dlg.c: several "unused_but_set" warnings [GCC 4.6]

2011-08-10 Thread Bill Meier

capture_dlg.c: In function ‘insert_new_rows’:

capture_dlg.c:665:18: warning: variable ‘cap_settings’ set but not used 
[-Wunused-but-set-variable]
capture_dlg.c:664:8: warning: variable ‘linktype_select’ set but not 
used [-Wunused-but-set-variable]



capture_dlg.c: In function ‘create_and_fill_model’:

capture_dlg.c:3532:12: warning: variable ‘pre_selected’ set but not used 
[-Wunused-but-set-variable]
capture_dlg.c:3521:8: warning: variable ‘linktype_select’ set but not 
used [-Wunused-but-set-variable]



capture_dlg.c: In function ‘capture_prep_adjust_sensitivity’:

capture_dlg.c:3934:14: warning: variable ‘if_cb’ set but not used 
[-Wunused-but-set-variable]

___
Sent via:Wireshark-dev mailing list 
Archives:http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe


[Wireshark-dev] buildbot failure in Wireshark (development) on Visual-Studio-Code-Analysis

2011-08-10 Thread buildbot-no-reply
The Buildbot has detected a new failure on builder Visual-Studio-Code-Analysis 
while building Wireshark (development).
Full details are available at:
 
http://buildbot.wireshark.org/trunk/builders/Visual-Studio-Code-Analysis/builds/1603

Buildbot URL: http://buildbot.wireshark.org/trunk/

Buildslave for this Build: vs-code-analysis

Build Reason: scheduler
Build Source Stamp: 38459
Blamelist: morriss

BUILD FAILED: failed nmake setup

sincerely,
 -The Buildbot



___
Sent via:Wireshark-dev mailing list 
Archives:http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe


[Wireshark-dev] Buildbot server upgraded

2011-08-10 Thread Gerald Combs
Buildbot.wireshark.org has been upgraded to Buildbot 0.8.4p2 (the latest
release). The new version includes an updated web interface and the
ability to do more efficient Subversion checkouts. If you run into any
issues please don't hesitate to send me an email or open a bug.
___
Sent via:Wireshark-dev mailing list 
Archives:http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe


Re: [Wireshark-dev] Rev 38350 Capture Options Changes - Named Pipe?

2011-08-10 Thread Jakub Zawadzki
On Wed, Aug 10, 2011 at 10:49:47PM +0200, Michael Tüxen wrote:
> I was aware of this in the context of the -i arguments, but not that it could 
> be
> specified in the GUI. We need to find a way to do this. Maybe an button which
> will add a named pipe to the list of interfaces.

Can we have it in another window?
I'd be happy to have different options in capture submenu, like:
 Capture
  | - Interface
  || - [X] eth0: ...
  || - [X] wlan0: ...
  || - [ ] ...
  | - nflog
  | - Named pipe
  | - From program (ptrace-based)
  | - ...
  | --
  | - Capture options
  | - Start
  | - ...

Have we got some UX experts? ;-)
___
Sent via:Wireshark-dev mailing list 
Archives:http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe


[Wireshark-dev] buildbot failure in Wireshark (development) on Windows-7-x64

2011-08-10 Thread buildbot-no-reply
The Buildbot has detected a new failure on builder Windows-7-x64 while building 
Wireshark (development).
Full details are available at:
 http://buildbot.wireshark.org/trunk/builders/Windows-7-x64/builds/2661

Buildbot URL: http://buildbot.wireshark.org/trunk/

Buildslave for this Build: windows-7-x64

Build Reason: scheduler
Build Source Stamp: 38459
Blamelist: morriss

BUILD FAILED: failed nmake all

sincerely,
 -The Buildbot



___
Sent via:Wireshark-dev mailing list 
Archives:http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe


[Wireshark-dev] reassembly again

2011-08-10 Thread Martin Kaiser
Dear all,

earlier today, I revoked my pending DVB-CI patch for spdu reassembly as
I found a problem :-(

I now think I know what happens, I'd appreciate your opinion how to deal
with it properly:

a tdpu looks like

header | body | trailer

Depending on header info, the body may contain a fragment of an spdu.
body_len is (no surprise) the body's length.

I go to the beginning of the body and do the following for each and
every message

frag_msg = fragment_add_seq_next(tvb, offset, pinfo,
SEQ_ID_TRANSPORT_LAYER,
spdu_fragment_table,
spdu_reassembled_table,
body_len,
hdr_tag == T_DATA_MORE ? 1 : 0);

-> I put the current body into the fragementation mechanism.

payload_tvb = process_reassembled_data(tvb, offset, pinfo,
"Reassembled SPDU", frag_msg, &tpdu_frag_items,
NULL, trans_tree);

And see if things can be reassembled.

If multiple fragments were reassembled, things work ok. payload_tvb contains
(body_len #1 + ... + body_len #n) bytes.

The problem occurs when there's no fragments, i.e. the message can be
"reassembled" straight away. In this case, payload_tvb contains 
body | trailer !

To me this is quite surprising, I put in just the body and get body |
trailer in return whereas usually, I get body1|body2|...|bodyN
reassembled without any trailers (as expected).

The code that causes this is in process_reassembled_data(),
epan/reassemble.c

  } else {
 /*
  * No.
  * Return a tvbuff with the payload.
  */
 next_tvb = tvb_new_subset_remaining(tvb, offset);


Should this be changed to something like 
tvb_new_subset(tvb, , , )?

with the values that we supplied to fragment_add_seq_next()?


(Needless to say that if this needs to be changed, I'm happy to look into
it.)


Thanks for your advice,


   Martin
___
Sent via:Wireshark-dev mailing list 
Archives:http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe


Re: [Wireshark-dev] Rev 38350 Capture Options Changes - Named Pipe?

2011-08-10 Thread Guy Harris

On Aug 10, 2011, at 1:49 PM, Michael Tüxen wrote:

> I was aware of this in the context of the -i arguments, but not that it could 
> be
> specified in the GUI. We need to find a way to do this. Maybe an button which
> will add a named pipe to the list of interfaces.

If you cannot type the name of an interface into a text entry field in the 
Capture Options dialog box, that is a bug.
___
Sent via:Wireshark-dev mailing list 
Archives:http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe


Re: [Wireshark-dev] Rev 38350 Capture Options Changes - Named Pipe?

2011-08-10 Thread Michael Tüxen
On Aug 10, 2011, at 10:44 PM, Guy Harris wrote:

> 
> On Aug 10, 2011, at 1:33 PM, Michael Tüxen wrote:
> 
>> Use the command line options... There is currently no way to specify a named
>> pipe in the GUI. I think there was no way to do this in Wireshark 1.6, or
>> am I missing something?
> 
> The general convention in Wireshark-the-project (i.e., Wireshark, TShark, and 
> dumpcap) is that if the "network interface" you specify isn't a network 
> interface (i.e., an attempt to open it with libpcap fails), and it's a named 
> pipe, it's opened as a pipe connected to a program writing a pcap (or 
> pcap-ng?) capture file.
> 
> I.e., in the GUI, you'd specify it by, for example, giving "/tmp/pipe" (or 
> whatever the named pipe path is) as the name of the "network interface" from 
> which to capture in the Capture Options dialog.
Hi Guy,

I was aware of this in the context of the -i arguments, but not that it could be
specified in the GUI. We need to find a way to do this. Maybe an button which
will add a named pipe to the list of interfaces.
I'll talk to Irene when she's available again to bring back the capability to
specify named pipes in the GUI.

Best regards
Michael
> ___
> Sent via:Wireshark-dev mailing list 
> Archives:http://www.wireshark.org/lists/wireshark-dev
> Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
> mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
> 

___
Sent via:Wireshark-dev mailing list 
Archives:http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe


Re: [Wireshark-dev] Rev 38350 Capture Options Changes - Named Pipe?

2011-08-10 Thread Michael Tüxen
On Aug 10, 2011, at 10:37 PM, Colin O'Flynn wrote:

> Hello,
> 
> It was possible to type over the interface name in the previous dialog with
> the named pipe. This is described at
> http://wiki.wireshark.org/CaptureSetup/Pipes ("3. The named pipe is not
> listed in the drop-down interface selection, and must be typed into the
> interface box. On Windows, it must be typed slowly (or pasted).").
Interesting... We were not aware of this. I'll put it on our ToDo list
to find a way to specify it in the GUI.
Using it on the command line should work...

Thanks for reporting this!

Best regards
Michael
> 
> Regards,
> 
>  -COlin
> 
> -Original Message-
> From: wireshark-dev-boun...@wireshark.org
> [mailto:wireshark-dev-boun...@wireshark.org] On Behalf Of Michael Tüxen
> Sent: August 10, 2011 5:33 PM
> To: Developer support list for Wireshark
> Subject: Re: [Wireshark-dev] Rev 38350 Capture Options Changes - Named Pipe?
> 
> On Aug 10, 2011, at 10:06 PM, Colin O'Flynn wrote:
> 
>> Hello,
>> 
>> With the changes committed in rev 38350 which has a new capture options
> dialog, how does one use a named pipe? I couldn’t see a way to get this
> working.
> Use the command line options... There is currently no way to specify a named
> pipe in the GUI. I think there was no way to do this in Wireshark 1.6, or
> am I missing something?
> 
> Best regards
> Michael
>> 
>> Thanks,
>> 
>>  -Colin
>> 
> ___
>> Sent via:Wireshark-dev mailing list 
>> Archives:http://www.wireshark.org/lists/wireshark-dev
>> Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
>>mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
> 
> ___
> Sent via:Wireshark-dev mailing list 
> Archives:http://www.wireshark.org/lists/wireshark-dev
> Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
> mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
> 
> ___
> Sent via:Wireshark-dev mailing list 
> Archives:http://www.wireshark.org/lists/wireshark-dev
> Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
> mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
> 

___
Sent via:Wireshark-dev mailing list 
Archives:http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe


Re: [Wireshark-dev] Rev 38350 Capture Options Changes - Named Pipe?

2011-08-10 Thread Guy Harris

On Aug 10, 2011, at 1:33 PM, Michael Tüxen wrote:

> Use the command line options... There is currently no way to specify a named
> pipe in the GUI. I think there was no way to do this in Wireshark 1.6, or
> am I missing something?

The general convention in Wireshark-the-project (i.e., Wireshark, TShark, and 
dumpcap) is that if the "network interface" you specify isn't a network 
interface (i.e., an attempt to open it with libpcap fails), and it's a named 
pipe, it's opened as a pipe connected to a program writing a pcap (or pcap-ng?) 
capture file.

I.e., in the GUI, you'd specify it by, for example, giving "/tmp/pipe" (or 
whatever the named pipe path is) as the name of the "network interface" from 
which to capture in the Capture Options dialog.
___
Sent via:Wireshark-dev mailing list 
Archives:http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe


Re: [Wireshark-dev] Rev 38350 Capture Options Changes - Named Pipe?

2011-08-10 Thread Colin O'Flynn
Hello,

It was possible to type over the interface name in the previous dialog with
the named pipe. This is described at
http://wiki.wireshark.org/CaptureSetup/Pipes ("3. The named pipe is not
listed in the drop-down interface selection, and must be typed into the
interface box. On Windows, it must be typed slowly (or pasted).").

Regards,

  -COlin

-Original Message-
From: wireshark-dev-boun...@wireshark.org
[mailto:wireshark-dev-boun...@wireshark.org] On Behalf Of Michael Tüxen
Sent: August 10, 2011 5:33 PM
To: Developer support list for Wireshark
Subject: Re: [Wireshark-dev] Rev 38350 Capture Options Changes - Named Pipe?

On Aug 10, 2011, at 10:06 PM, Colin O'Flynn wrote:

> Hello,
>  
> With the changes committed in rev 38350 which has a new capture options
dialog, how does one use a named pipe? I couldn’t see a way to get this
working.
Use the command line options... There is currently no way to specify a named
pipe in the GUI. I think there was no way to do this in Wireshark 1.6, or
am I missing something?

Best regards
Michael
>  
> Thanks,
>  
>   -Colin
>
___
> Sent via:Wireshark-dev mailing list 
> Archives:http://www.wireshark.org/lists/wireshark-dev
> Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
> mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

___
Sent via:Wireshark-dev mailing list 
Archives:http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

___
Sent via:Wireshark-dev mailing list 
Archives:http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe


Re: [Wireshark-dev] Rev 38350 Capture Options Changes - Named Pipe?

2011-08-10 Thread Michael Tüxen
On Aug 10, 2011, at 10:06 PM, Colin O'Flynn wrote:

> Hello,
>  
> With the changes committed in rev 38350 which has a new capture options 
> dialog, how does one use a named pipe? I couldn’t see a way to get this 
> working.
Use the command line options... There is currently no way to specify a named
pipe in the GUI. I think there was no way to do this in Wireshark 1.6, or
am I missing something?

Best regards
Michael
>  
> Thanks,
>  
>   -Colin
> ___
> Sent via:Wireshark-dev mailing list 
> Archives:http://www.wireshark.org/lists/wireshark-dev
> Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
> mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

___
Sent via:Wireshark-dev mailing list 
Archives:http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe


[Wireshark-dev] Rev 38350 Capture Options Changes - Named Pipe?

2011-08-10 Thread Colin O'Flynn
Hello,

 

With the changes committed in rev 38350 which has a new capture options
dialog, how does one use a named pipe? I couldn't see a way to get this
working.

 

Thanks,

 

  -Colin

___
Sent via:Wireshark-dev mailing list 
Archives:http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

[Wireshark-dev] buildbot failure in Wireshark (development) on Windows-XP-x86

2011-08-10 Thread buildbot-no-reply
The Buildbot has detected a new failure of Windows-XP-x86 on Wireshark 
(development).
Full details are available at:
 http://buildbot.wireshark.org/trunk/builders/Windows-XP-x86/builds/3710

Buildbot URL: http://buildbot.wireshark.org/trunk/

Buildslave for this Build: windows-xp-x86

Build Reason: 
Build Source Stamp: 38454
Blamelist: tuexen,wmeier

BUILD FAILED: failed failed slave lost

sincerely,
 -The Buildbot

___
Sent via:Wireshark-dev mailing list 
Archives:http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe


Re: [Wireshark-dev] Compiling Wireshark for Win32

2011-08-10 Thread Graham Bloice
On 10/08/2011 18:00, Guy Harris wrote:
> On Aug 10, 2011, at 9:18 AM, news.gmane.com wrote:
>
>> I am a bit surprised about a problem with compiling Wireshark 1.6.0 with 
>> Visual Studio 2005 for Win32. Some dissectors have assignments from 64 to 32 
>> bit, what will issue a warning C4244 by the compiler. Since the -WX 
>> parameter is passed to the compiler, the compilation fails. The warning 
>> level /W3 will not suppress the warning C4244 but /W2 would do.
>   ...
>
>> Why did this pass the compilation at wireshark.org?
> The wireshark.org buildbot is running "Microsoft Visual Studio 9.0"; I'm not 
> sure how that translates to Microsoft's year-based version scheme, but 
> perhaps it's a different version of VS than VS 2005, and perhaps that version 
> doesn't catch that if run with -WX and /W3.
>
>
>
VC 9.0 aka VS 2008.  VS 2005 is also known as VC 8.0.  Wikipedia has a table
listing the version names at
http://en.wikipedia.org/wiki/Microsoft_Visual_Studio#Version_history.

-- 
Regards,

Graham Bloice


___
Sent via:Wireshark-dev mailing list 
Archives:http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe


Re: [Wireshark-dev] If I want to add a new dialog file in gtk document, how to modify the configure file?

2011-08-10 Thread Guy Harris

On Aug 9, 2011, at 11:25 PM, pang liang wrote:

> If I want to add a new dialog file in gtk document, how to modify the 
> configure file?

What do you mean by "dialog file" and "gtk *document*"?  If you're adding a new 
dialog to the Wireshark UI, you have to add C code in the "gtk" directory.  You 
don't modify the configure file for that; you modify the "Makefile.common" file 
in the gtk directory.

___
Sent via:Wireshark-dev mailing list 
Archives:http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe


Re: [Wireshark-dev] Compiling Wireshark for Win32

2011-08-10 Thread Guy Harris

On Aug 10, 2011, at 9:18 AM, news.gmane.com wrote:

> I am a bit surprised about a problem with compiling Wireshark 1.6.0 with 
> Visual Studio 2005 for Win32. Some dissectors have assignments from 64 to 32 
> bit, what will issue a warning C4244 by the compiler. Since the -WX 
> parameter is passed to the compiler, the compilation fails. The warning 
> level /W3 will not suppress the warning C4244 but /W2 would do.

...

> Why did this pass the compilation at wireshark.org?

The wireshark.org buildbot is running "Microsoft Visual Studio 9.0"; I'm not 
sure how that translates to Microsoft's year-based version scheme, but perhaps 
it's a different version of VS than VS 2005, and perhaps that version doesn't 
catch that if run with -WX and /W3.
___
Sent via:Wireshark-dev mailing list 
Archives:http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe


Re: [Wireshark-dev] Compiling Wireshark for Win32

2011-08-10 Thread Graham Bloice
On 10/08/2011 17:18, news.gmane.com wrote:
> Hello,
>
> I am a bit surprised about a problem with compiling Wireshark 1.6.0 with 
> Visual Studio 2005 for Win32. Some dissectors have assignments from 64 to 32 
> bit, what will issue a warning C4244 by the compiler. Since the -WX 
> parameter is passed to the compiler, the compilation fails. The warning 
> level /W3 will not suppress the warning C4244 but /W2 would do.
>
> example: packet-afp.c
> function: dissect_spotlight
> line: 3999
> toc_offset = (spotlight_ntoh64(tvb, offset) >> 32) * 8 - 8;
> where the variable is defines as
> gint toc_offset;
> Compiler output:
>
> packet-afp.c
> packet-afp.c(3999) : error C2220: warning treated as error - no 'object' 
> file generated
> packet-afp.c(3999) : warning C4244: '=' : conversion from 'guint64' to 
> 'gint', possible loss of data
>
> Why did this pass the compilation at wireshark.org?
> How do I recompile Wireshark 1.6.0?
>
> This affects also
>
> packet-ieee802154.c(2162) : warning C4244: 'return' : conversion from 
> 'guint64' to 'guint', possible loss of data
>
> packet-netflow.c(2623) : warning C4244: '=' : conversion from 'guint64' to 
> 'int', possible loss of data
>
>
In the trunk these all have appropriate casts so no warnings are issued.  For
example packet-afp.c was fixed by r37694 on 17th June 2011.

-- 
Regards,

Graham Bloice


___
Sent via:Wireshark-dev mailing list 
Archives:http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe


[Wireshark-dev] Compiling Wireshark for Win32

2011-08-10 Thread news.gmane.com
Hello,

I am a bit surprised about a problem with compiling Wireshark 1.6.0 with 
Visual Studio 2005 for Win32. Some dissectors have assignments from 64 to 32 
bit, what will issue a warning C4244 by the compiler. Since the -WX 
parameter is passed to the compiler, the compilation fails. The warning 
level /W3 will not suppress the warning C4244 but /W2 would do.

example: packet-afp.c
function: dissect_spotlight
line: 3999
toc_offset = (spotlight_ntoh64(tvb, offset) >> 32) * 8 - 8;
where the variable is defines as
gint toc_offset;
Compiler output:

packet-afp.c
packet-afp.c(3999) : error C2220: warning treated as error - no 'object' 
file generated
packet-afp.c(3999) : warning C4244: '=' : conversion from 'guint64' to 
'gint', possible loss of data

Why did this pass the compilation at wireshark.org?
How do I recompile Wireshark 1.6.0?

This affects also

packet-ieee802154.c(2162) : warning C4244: 'return' : conversion from 
'guint64' to 'guint', possible loss of data

packet-netflow.c(2623) : warning C4244: '=' : conversion from 'guint64' to 
'int', possible loss of data


-- 
Andy



___
Sent via:Wireshark-dev mailing list 
Archives:http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe


Re: [Wireshark-dev] Traffic generation for ASN.1 PER

2011-08-10 Thread Ed Beroset
ANISH M wrote:
>
>I want to generate some ASN.1 PER traffic, is there any tools available for
>that? Please let me know.

It's not clear exactly what you're asking.  ASN.1 is a notation to express a 
protocol and PER is a means of encoding it.  What's missing from your question 
is some particular ASN.1 specification to describe the encoded data.  Maybe an 
example like this is what you are seeking?   
http://portal.etsi.org/mbs/languages/asn.1/asn1per.htm

Ed
___
Sent via:Wireshark-dev mailing list 
Archives:http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe


[Wireshark-dev] Traffic generation for ASN.1 PER

2011-08-10 Thread ANISH M
Hi All,

I want to generate some ASN.1 PER traffic, is there any tools available for
that? Please let me know.
Thanks

Best Regards,
Anish
___
Sent via:Wireshark-dev mailing list 
Archives:http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

[Wireshark-dev] If I want to add a new dialog file in gtk document, how to modify the configure file?

2011-08-10 Thread pang liang
If I want to add a new dialog file in gtk document, how to modify the
configure file?
___
Sent via:Wireshark-dev mailing list 
Archives:http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

[Wireshark-dev] buildbot failure in Wireshark (development) on Windows-XP-x86

2011-08-10 Thread buildbot-no-reply
The Buildbot has detected a new failure of Windows-XP-x86 on Wireshark 
(development).
Full details are available at:
 http://buildbot.wireshark.org/trunk/builders/Windows-XP-x86/builds/3707

Buildbot URL: http://buildbot.wireshark.org/trunk/

Buildslave for this Build: windows-xp-x86

Build Reason: 
Build Source Stamp: 38445
Blamelist: stig

BUILD FAILED: failed failed slave lost

sincerely,
 -The Buildbot

___
Sent via:Wireshark-dev mailing list 
Archives:http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe