[Wireshark-dev] Building with libtool /epan
Hey guys.. I have written, my own functions to reassemble split packets. Now I want to include that to wireshark more precisely wireshark/epan. I updated the Makefile.in common .am. If i run ./configure it works. He built me a Makefile and the ./deps file folder. I get a xxx.Plo File with content like dummy what is normal before make. If i run make now he will bulit but stopps with libtool: link: `libwireshark_la-list_mh.lo' is not a valid libtool object so I dont get a .lo file and no .la .a file and in may .Plo is still only dummy the content Maybe someone have an idea.. Thx and regards Marcel ___ Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
Re: [Wireshark-dev] Building with libtool /epan
-Original Message- From: wireshark-dev-boun...@wireshark.org [mailto:wireshark-dev-boun...@wireshark.org] On Behalf Of Marcel Haas Sent: den 4 oktober 2011 12:53 To: wireshark-dev@wireshark.org Subject: [Wireshark-dev] Building with libtool /epan Hey guys.. I have written, my own functions to reassemble split packets. Now I want to include that to wireshark more precisely wireshark/epan. I updated the Makefile.in common .am. If i run ./configure it works. He built me a Makefile and the ./deps file folder. I get a xxx.Plo File with content like dummy what is normal before make. If i run make now he will bulit but stopps with libtool: link: `libwireshark_la-list_mh.lo' is not a valid libtool object so I dont get a .lo file and no .la .a file and in may .Plo is still only dummy the content Maybe someone have an idea.. Thx and regards Marcel Adding the file to Makefile.common should be enough I think are you doing any weird includes? Regards Anders ___ Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe ___ Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
Re: [Wireshark-dev] Building with libtool /epan
Hmm Nope.. the makefile will work without any error but at libwireshark.la libdir= is no entry and i guess thats the library so i can not use my functions and now i havent an entry at the .deps file folder I changed it like it was before what i have done is at Makefile.common LIBWIRESHARK_SRC = ... list_mh.c \ ... LIBWIRESHARK_INCLUDES = ... list_mh.c \ ... and Makefile.in am__objects_1 = libwireshark_la-list_mh.lo \ LIBWIRESHARK_SRC = \ list_mh.c \ LIBWIRESHARK_INCLUDES = \ list_mh.h \ @AMDEP_TRUE@@am__include@ @am__quote@./$(DEPDIR)/libwireshark_la-list_mh.Plo@am__quote@ libwireshark_la-list_mh.lo: list_mh.c @am__fastdepCC_TRUE@if $(LIBTOOL) --tag=CC --mode=compile $(CC) $(DEFS) $(DEFAULT_INCLUDES) $(INCLUDES) $(AM_CPPFLAGS) $(CPPFLAGS) $(libwireshark_la_CFLAGS) $(CFLAGS) -MT libwireshark_la-list_mh.lo -MD -MP -MF $(DEPDIR)/libwireshark_la-list_mh.Tpo -c -o libwireshark_la-list_mh.lo `test -f 'list_mh.c' || echo '$(srcdir)/'`list_mh.c; \ @am__fastdepCC_TRUE@then mv -f $(DEPDIR)/libwireshark_la-list_mh.Tpo $(DEPDIR)/libwireshark_la-list_mh.Plo; else rm -f $(DEPDIR)/libwireshark_la-list_mh.Tpo; exit 1 ; fi @AMDEP_TRUE@@am__fastdepCC_FALSE@ source='list_mh.c' object='libwireshark_la-list_mh.lo' libtool=yes @AMDEPBACKSLASH@ @AMDEP_TRUE@@am__fastdepCC_FALSE@ DEPDIR=$(DEPDIR) $(CCDEPMODE) $(depcomp) @AMDEPBACKSLASH@ @am__fastdepCC_FALSE@ $(LIBTOOL) --tag=CC --mode=compile $(CC) $(DEFS) $(DEFAULT_INCLUDES) $(INCLUDES) $(AM_CPPFLAGS) $(CPPFLAGS) $(libwireshark_la_CFLAGS) $(CFLAGS) -c -o libwireshark_la-list_mh.lo `test -f 'list_mh.c' || echo '$(srcdir)/'`list_mh.c I were doning it the same way reassemble.c /.h was find in the two files. copy paste replace reassemble with list_mh On Tue, 4 Oct 2011 13:00:42 +0200, Anders Broman anders.bro...@ericsson.com wrote: -Original Message- From: wireshark-dev-boun...@wireshark.org [mailto:wireshark-dev-boun...@wireshark.org] On Behalf Of Marcel Haas Sent: den 4 oktober 2011 12:53 To: wireshark-dev@wireshark.org Subject: [Wireshark-dev] Building with libtool /epan Hey guys.. I have written, my own functions to reassemble split packets. Now I want to include that to wireshark more precisely wireshark/epan. I updated the Makefile.in common .am. If i run ./configure it works. He built me a Makefile and the ./deps file folder. I get a xxx.Plo File with content like dummy what is normal before make. If i run make now he will bulit but stopps with libtool: link: `libwireshark_la-list_mh.lo' is not a valid libtool object so I dont get a .lo file and no .la .a file and in may .Plo is still only dummy the content Maybe someone have an idea.. Thx and regards Marcel Adding the file to Makefile.common should be enough I think are you doing any weird includes? Regards Anders ___ Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe ___ Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe ___ Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
Re: [Wireshark-dev] Building with libtool /epan
Marcel Haas wrote: Hmm Nope.. the makefile will work without any error but at libwireshark.la libdir= is no entry and i guess thats the library so i can not use my functions and now i havent an entry at the .deps file folder I changed it like it was before what i have done is at Makefile.common LIBWIRESHARK_SRC = ... list_mh.c \ ... LIBWIRESHARK_INCLUDES = ... list_mh.c \ ... and Makefile.in Normally you should not edit Makefile.in: it is generated (from the .am and .common files) when you run ./autogen.sh . ___ Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
[Wireshark-dev] Fwd: [Bug 6382] Extensions to Wireshark to support TRILL payloads
niki -- Forwarded message -- From: nikitha m nikith...@gmail.com Date: Mon, Oct 3, 2011 at 12:20 PM Subject: Re: [Bug 6382] Extensions to Wireshark to support TRILL payloads To: bugzilla-dae...@wireshark.org Hi all, Sorry for the inconvinience.All these are diff files and not patches. We have attached all the Captured files too. For the router capability TLV it's RT Capable packet and for the END STATION ENABLED TLV it's ENDTLV. Thanks and regards, Nikitha Malgi Krishnamurthy Mayya ENDTLV Description: Binary data RT_capability_packet Description: Binary data ___ Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
[Wireshark-dev] Replace TRUE/FALSE with proper ENC_* in proto_tree_add_item() using a script.
I propose to use a perl script to automate as much as reasonable the replacement of TRUE/FALSE in the encoding parameter of the proto_tree_add_item() calls in dissectors as follows: First step: For hf[] entries with type FT_NONE FT_BYTES FT_IPV6 FT_IPXNET FT_UID convert the field to ENC_NA. Obviously there will be exception cases (e.g., something other than TRUE/FALSE/ENC_NA for the param) which I'll need to flag (and presumably handle manually). If I can do this step then I'll proceed from there. For the next step is it simply a case of replacing the remaining TRUE/FALSE encoding parameter by ENC_LITTLE_ENDIAN/ENC_BIG_ENDIAN ? One thing I don't quite understand: In a number of the dissectors why do proto_tree_add_item() encoding parameters for hf items with type FT_STRING have ENC_ASCII *and* ENC_LITTLE_ENDIAN|ENC_BIG_ENDIAN ? Shouldn't this be ENC_ASCII | ENC_NA in this case ? Comments ? Bill ___ Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
Re: [Wireshark-dev] Replace TRUE/FALSE with proper ENC_* in proto_tree_add_item() using a script.
I propose to use a perl script to automate as much as reasonable the replacement of TRUE/FALSE in the encoding parameter of the proto_tree_add_item() calls in dissectors as follows: sounds good, but may be difficult to write. Because you would need to write a parser for C function calls in perl. regular expressions won't do the trick, as they can not reliably match parenthesi. Also keep in mind that those proto_tree_*() functions can use multiple lines. But just doing regular expression may give you 90% of the cases which would be good enough. For the next step is it simply a case of replacing the remaining TRUE/FALSE encoding parameter by ENC_LITTLE_ENDIAN/ENC_BIG_ENDIAN ? This sounds right. One thing I don't quite understand: In a number of the dissectors why do proto_tree_add_item() encoding parameters for hf items with type FT_STRING have ENC_ASCII *and* ENC_LITTLE_ENDIAN|ENC_BIG_ENDIAN ? Shouldn't this be ENC_ASCII | ENC_NA in this case ? Probably. Don't expect every developer of the various dissectors to have specified 100% correct parameters here, since a lot of combinations so far did just work. -- --- Dirk Jagdmann http://cubic.org/~doj - http://llg.cubic.org ___ Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
Re: [Wireshark-dev] Replace TRUE/FALSE with proper ENC_* in proto_tree_add_item() using a script.
On Oct 4, 2011, at 10:53 AM, Bill Meier wrote: For the next step is it simply a case of replacing the remaining TRUE/FALSE encoding parameter by ENC_LITTLE_ENDIAN/ENC_BIG_ENDIAN ? Except for FT_STRING, FT_STRINGZ, and FT_UINT_STRING, for which an encoding should also be supplied. Presumably all the uses of proto_tree_add_item() and the like for FT_ABSOLUTE_TIME values already have the encoding specified and already use ENC_LITTLE_ENDIAN/ENC_BIG_ENDIAN. One thing I don't quite understand: In a number of the dissectors why do proto_tree_add_item() encoding parameters for hf items with type FT_STRING have ENC_ASCII *and* ENC_LITTLE_ENDIAN|ENC_BIG_ENDIAN ? Shouldn't this be ENC_ASCII | ENC_NA in this case ? The endianness is irrelevant for ENC_UTF_8, ENC_ASCII, and ENC_EBCDIC. In the future, there will be ENC_UTF_16 and possibly ENC_UCS_2, for which the endianness will be relevant. Should we always specify an endianness for strings, or only for those character encodings where it's relevant? ___ Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
Re: [Wireshark-dev] Replace TRUE/FALSE with proper ENC_* in proto_tree_add_item() using a script.
On 10/4/2011 1:53 PM, Bill Meier wrote: I propose to use a perl script to automate as much as reasonable the replacement of TRUE/FALSE in the encoding parameter of the proto_tree_add_item() calls in dissectors as follows: First step: For hf[] entries with type FT_NONE FT_BYTES FT_IPV6 FT_IPXNET FT_UID convert the field to ENC_NA. Obviously there will be exception cases (e.g., something other than TRUE/FALSE/ENC_NA for the param) which I'll need to flag (and presumably handle manually). If I can do this step then I'll proceed from there. For the next step is it simply a case of replacing the remaining TRUE/FALSE encoding parameter by ENC_LITTLE_ENDIAN/ENC_BIG_ENDIAN ? Restriction: The replacement should be done only for those proto_tree_add_item() calls directly referencing an actual hf_* variable (that is: one referenced in the hf[] array). One thing I don't quite understand: In a number of the dissectors why do proto_tree_add_item() encoding parameters for hf items with type FT_STRING have ENC_ASCII *and* ENC_LITTLE_ENDIAN|ENC_BIG_ENDIAN ? Shouldn't this be ENC_ASCII | ENC_NA in this case ? Comments ? Bill ___ Sent via: Wireshark-dev mailing list wireshark-dev@wireshark.org Archives: http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe ___ Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
Re: [Wireshark-dev] Replace TRUE/FALSE with proper ENC_* in proto_tree_add_item() using a script.
One thing I don't quite understand: In a number of the dissectors why do proto_tree_add_item() encoding parameters for hf items with type FT_STRING have ENC_ASCII *and* ENC_LITTLE_ENDIAN|ENC_BIG_**ENDIAN ? Shouldn't this be ENC_ASCII | ENC_NA in this case ? The comment for ENC_NA: /* * For protocols (FT_PROTOCOL), aggregate items with subtrees (FT_NONE), * opaque byte-array fields (FT_BYTES), and other fields where there * is no choice of encoding (either because it's just a bucket * of bytes or because the encoding is completely fixed), we * have ENC_NA (for Not Applicable). */ #define ENC_NA 0x Based on your example, it seems you might be incorrectly using ENC_NA to mean endianness not applicable. In any case, I don't think it ever makes sense to specify ENC_NA with an encoding (e.g., ENC_ASCII | ENC_NA = Use ASCII encoding *and* Encoding doesn't apply here). I would only expect to see ENC_NA on its own, but I could be wrong. ___ Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
Re: [Wireshark-dev] Replace TRUE/FALSE with proper ENC_* in proto_tree_add_item() using a script.
Dirk Jagdmann wrote: I propose to use a perl script to automate as much as reasonable the replacement of TRUE/FALSE in the encoding parameter of the proto_tree_add_item() calls in dissectors as follows: sounds good, but may be difficult to write. Because you would need to write a parser for C function calls in perl. regular expressions won't do the trick, as they can not reliably match parenthesi. Also keep in mind that those proto_tree_*() functions can use multiple lines. But just doing regular expression may give you 90% of the cases which would be good enough. I had a fair amount of luck with the (currently not run) checkAPIsCalledWithTvbGetPtr() function in checkAPIs.pl . It definitely is not 100%, but it served my purposes well. It avoids dealing with parenthesis by assuming the only semi-colon it will find is the end of the function call ;-). I imagine regexp'ing for proto_tree_add_item[^;]*[TRUE|FALSE]\s*\)\s*; would be sufficient to find offenders. ___ Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
Re: [Wireshark-dev] [Wireshark-commits] rev 38304: /trunk/epan/dissectors/ /trunk/epan/dissectors/: packet-snmp.c
Balint Reczey wrote: Hi, On 08/05/2011 04:01 AM, Jeff Morriss wrote: On 08/04/2011 07:35 PM, Tony Trinh wrote: Isn't Python also necessary for the Wireshark Python API? (It's disabled by default, unlike the Lua API.) Yes, but here we're talking about whether we have/should have a (hard) requirement to have Python in order to compile Wireshark (from the source tarball, which is often different than building from SVN). Let's make Python a requirement now. I fully support the idea of not keeping generated files in SVN and in the release tarball. I know it's been a while, but... Any other thoughts/votes on this topic? ___ Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
Re: [Wireshark-dev] Replace TRUE/FALSE with proper ENC_* in proto_tree_add_item() using a script.
On 10/4/2011 4:08 PM, Jeff Morriss wrote: I had a fair amount of luck with the (currently not run) checkAPIsCalledWithTvbGetPtr() function in checkAPIs.pl . It definitely is not 100%, but it served my purposes well. It avoids dealing with parenthesis by assuming the only semi-colon it will find is the end of the function call ;-). I imagine regexp'ing for proto_tree_add_item[^;]*[TRUE|FALSE]\s*\)\s*; would be sufficient to find offenders. Yep: I started with the regexp in in checkAPIs.pl:check_hf_entries (which you did) to get the list of hf_* entries and their types and then went from there in a similar manner as above to find the proto_tree_add_item() entries to be changed. The code is working nicely. Thanks ! Bill ___ Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
Re: [Wireshark-dev] Replace TRUE/FALSE with proper ENC_* in proto_tree_add_item() using a script.
On 10/4/2011 1:53 PM, Bill Meier wrote: I propose to use a perl script to automate as much as reasonable the replacement of TRUE/FALSE in the encoding parameter of the proto_tree_add_item() calls in dissectors as follows: First step: For hf[] entries with type FT_NONE FT_BYTES FT_IPV6 FT_IPXNET FT_UID convert the field to ENC_NA. OK: I've just about got the code working for this step. There seem to be 293 (non-autogenerated) epan/dissector/packet-*.c files with TRUE|FALSE|ENC_LITTLE_ENDIAN|ENC_BIG_ENDIAN proto_tree_add_item() calls associated with hf[] entries of the above types. I'll run this step and commit the changes a little later this evening when things have quieted down. Bill ___ Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
Re: [Wireshark-dev] Replace TRUE/FALSE with proper ENC_* in proto_tree_add_item() using a script.
On Oct 4, 2011, at 10:53 AM, Bill Meier wrote: I propose to use a perl script to automate as much as reasonable the replacement of TRUE/FALSE in the encoding parameter of the proto_tree_add_item() calls in dissectors as follows: First step: For hf[] entries with type FT_NONE FT_BYTES FT_IPV6 FT_IPXNET FT_UID convert the field to ENC_NA. Presumably by FT_UID you mean FT_OID? ___ Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
Re: [Wireshark-dev] Replace TRUE/FALSE with proper ENC_* in proto_tree_add_item() using a script.
On 10/4/2011 4:48 PM, Guy Harris wrote: On Oct 4, 2011, at 10:53 AM, Bill Meier wrote: I propose to use a perl script to automate as much as reasonable the replacement of TRUE/FALSE in the encoding parameter of the proto_tree_add_item() calls in dissectors as follows: First step: For hf[] entries with type FT_NONE FT_BYTES FT_IPV6 FT_IPXNET FT_UID convert the field to ENC_NA. Presumably by FT_UID you mean FT_OID? Yep... Thanks ___ Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
Re: [Wireshark-dev] [Wireshark-commits] rev 38304: /trunk/epan/dissectors/ /trunk/epan/dissectors/: packet-snmp.c
On 10/4/11 1:11 PM, Jeff Morriss wrote: Balint Reczey wrote: Let's make Python a requirement now. I fully support the idea of not keeping generated files in SVN and in the release tarball. I know it's been a while, but... Any other thoughts/votes on this topic? It's fine with me. ___ Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
Re: [Wireshark-dev] Replace TRUE/FALSE with proper ENC_* in proto_tree_add_item() using a script.
On 10/4/2011 2:49 PM, David Young wrote: On Tue, Oct 04, 2011 at 11:38:48AM -0700, Dirk Jagdmann wrote: Sounds like a perfect job for Coccinelle,http://coccinelle.lip6.fr/. Looks like an interesting tool; I'll have to spend a little time reading the documentation. Thanks for the reference In this case, given the specifics, I found it fairly simple to do what I needed in Perl. ___ Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
