Re: [Wireshark-dev] movement of source files from the top-level directory
On Wed, Mar 07, 2012 at 09:07:12PM -0800, Gilbert Ramirez wrote: > The existence of so many source files in the top-level directory of the > Wireshark source distribution bothers me. I would love to be able to "ls" > the top-level directory and not have it scroll off my screen. > > I have diagrammed the current Wireshark source directory hierarchy at: > > http://www.gliffy.com/pubdoc/3375981/L.png > > With this in mind, and by analyzing the groupings in Makefile.common, I'd > like to recommend the following movements: I started to move many of the files into the ui/ and ui/cli/ directories. The first small test failed horribly and others had to clean up quite a lot to get the windows build going again. I intend to continue with this once I have a working Windows build environment. Ciao Jörg -- Joerg Mayer We are stuck with technology when what we really want is just stuff that works. Some say that should read Microsoft instead of technology. ___ Sent via:Wireshark-dev mailing list Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
[Wireshark-dev] movement of source files from the top-level directory
The existence of so many source files in the top-level directory of the Wireshark source distribution bothers me. I would love to be able to "ls" the top-level directory and not have it scroll off my screen. I have diagrammed the current Wireshark source directory hierarchy at: http://www.gliffy.com/pubdoc/3375981/L.png With this in mind, and by analyzing the groupings in Makefile.common, I'd like to recommend the following movements: Create new directory called shark, to contain files common, or almost common, to the analyzer applications (wireshark, tshark, and rawshark): airpcap_loader.c alert_box.c capinfos.c capture.c capture_ifinfo.c capture_info.c capture_opts.c capture-pcap-util.c capture-pcap-util-unix.c capture_stop_conditions.c capture_sync.c capture_ui_utils.c capture-wpcap.c capture_wpcap_packet.c etc. This would help in getting rid of how automake is creating separate object files for the .c files that are shared across the applications: $ ls -l *capture_opts.o -rw-r--r-- 1 gilramir eng 46256 Feb 21 08:46 dumpcap-capture_opts.o -rw-r--r-- 1 gilramir eng 46256 Feb 21 08:23 tshark-capture_opts.o Because, they are compiled with the same flags: $ cksum *capture_opts.o 3352293452 46256 dumpcap-capture_opts.o 3352293452 46256 tshark-capture_opts.o The C files that build the smaller tool applications (mergecap, randpkt, text2pcap) should [for now] stay at the top-level directory. I also feel that the directories that distribute data files (radius, dtds, idl), should all be moved under another new directory, perhaps "definitions", but I know less about those files. Are there other thoughts on how to tidy the source directories? Is anyone working on this yet? Gilbert ___ Sent via:Wireshark-dev mailing list Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
Re: [Wireshark-dev] Assert with svn head (gtk3)
On Wed, Mar 07, 2012 at 09:34:25PM -0500, Jeff Morriss wrote: >> True, it's not ready. I fixed it to not enable File->Save if we're still >> capturing/reading from the file in r41415. > > Actually r41416 should be much better: it disallows *all* file > operations (including the icons in the toolbar) during a capture. Thanks! Jörg -- Joerg Mayer We are stuck with technology when what we really want is just stuff that works. Some say that should read Microsoft instead of technology. ___ Sent via:Wireshark-dev mailing list Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
Re: [Wireshark-dev] Assert with svn head (gtk3)
On 03/07/2012 09:19 PM, Jeff Morriss wrote: On 03/07/2012 06:26 PM, Joerg Mayer wrote: Basically what seems to be the problem is that the gui allows me to save a capture that is still ongoing via the save icon. It's a very nice feature (one that I'd like to have) but it seems like the system is not really prepared to do so. (wireshark:17111): Gtk-WARNING **: Unable to retrieve the file info for `file:///tmp/test.pcapng': Error stating file '/tmp/test.pcapng': No such file or directory ** ERROR:/home/jmayer/work/wireshark/svn/trunk/file.c:372:cf_reset_state: assertion failed: (cf->state != FILE_READ_IN_PROGRESS) Aborted True, it's not ready. I fixed it to not enable File->Save if we're still capturing/reading from the file in r41415. Actually r41416 should be much better: it disallows *all* file operations (including the icons in the toolbar) during a capture. ___ Sent via:Wireshark-dev mailing list Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
Re: [Wireshark-dev] Assert with svn head (gtk3)
On 03/07/2012 06:26 PM, Joerg Mayer wrote: Basically what seems to be the problem is that the gui allows me to save a capture that is still ongoing via the save icon. It's a very nice feature (one that I'd like to have) but it seems like the system is not really prepared to do so. (wireshark:17111): Gtk-WARNING **: Unable to retrieve the file info for `file:///tmp/test.pcapng': Error stating file '/tmp/test.pcapng': No such file or directory ** ERROR:/home/jmayer/work/wireshark/svn/trunk/file.c:372:cf_reset_state: assertion failed: (cf->state != FILE_READ_IN_PROGRESS) Aborted True, it's not ready. I fixed it to not enable File->Save if we're still capturing/reading from the file in r41415. ___ Sent via:Wireshark-dev mailing list Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
[Wireshark-dev] Assert with svn head (gtk3)
Basically what seems to be the problem is that the gui allows me to save a capture that is still ongoing via the save icon. It's a very nice feature (one that I'd like to have) but it seems like the system is not really prepared to do so. (wireshark:17111): Gtk-WARNING **: Unable to retrieve the file info for `file:///tmp/test.pcapng': Error stating file '/tmp/test.pcapng': No such file or directory ** ERROR:/home/jmayer/work/wireshark/svn/trunk/file.c:372:cf_reset_state: assertion failed: (cf->state != FILE_READ_IN_PROGRESS) Aborted Ciao Jörg -- Joerg Mayer We are stuck with technology when what we really want is just stuff that works. Some say that should read Microsoft instead of technology. ___ Sent via:Wireshark-dev mailing list Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
Re: [Wireshark-dev] [RFC] bug 6797 : proto: Add proto_tree_add_split_{uint, int} helpers for non contiguous int fields
Hi, >> I have submitted some patches under bug 6885. > I am looking forward to feedback. > > I've just ported my dissector to it and it works great. I just had an issue with signed fields that were not sign extended to properly reflect the negative value. I opened a bug and submitted a fix : https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6920 Cheers, Sylvain ___ Sent via:Wireshark-dev mailing list Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
Re: [Wireshark-dev] QtShark Translation
Hi Committed in Revision 41389 and 41390 for you Cmake patch ! (thanks) Regards, On Mon, Mar 5, 2012 at 5:48 PM, Joerg Mayer wrote: > On Mon, Mar 05, 2012 at 10:10:40AM +0100, Alexis La Goutte wrote: > > > You might try the following instructions for cmake: > > > http://www.cmake.org/Wiki/CMake:How_To_Build_Qt4_Software > > > but I'd be willing to do this once internationalization is committed. > > > > > > > I tried but... no work ! (for the moment...) > > The attached patch will make it (amost) work (this assumes some of the > renames > I proposed but you will get the idea from it). > > It will cause compilation to fail unless either > a) source dir is also the build dir or > b) you manually create a link for qtshark_fr.qm into the source dir > > I will eventually look into the dependency problem, but for now I'm happy > it works at all > > Ciao > Jörg > -- > Joerg Mayer > We are stuck with technology when what we really want is just stuff that > works. Some say that should read Microsoft instead of technology. > > ___ > Sent via:Wireshark-dev mailing list > Archives:http://www.wireshark.org/lists/wireshark-dev > Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev > mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe > ___ Sent via:Wireshark-dev mailing list Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
