Re: [Wireshark-dev] warning - error in r41911
-Original Message- From: wireshark-dev-boun...@wireshark.org [mailto:wireshark-dev- boun...@wireshark.org] On Behalf Of Jeff Morriss Sent: 03 April 2012 22:39 To: Developer support list for Wireshark Subject: Re: [Wireshark-dev] warning - error in r41911 Martin Kaiser wrote: Hi Graham and all, r41911 gives a warning on my system packet-dcerpc-spoolss.c: In function âdissect_spoolss_string_parm_dataâ: packet-dcerpc-spoolss.c:497: error: âitemâ may be used uninitialized in this function make[5]: *** [libdissectors_la-packet-dcerpc-spoolss.lo] Error 1 make[5]: *** Waiting for unfinished jobs Checked in r41912, thanks! Oops. Visual Studio strikes again with the lack of warnings. Thanks. ___ Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
Re: [Wireshark-dev] [Wireshark-commits] rev 41790: /trunk/ /trunk/: configure.in
On Apr 3, 2012, at 4:33 PM, Jeff Morriss wrote: *My* intent was to revert back out my change to go back to what Joerg had intended in r34356. That revision says the intent was to increase common source code coverage. I think I had also see some comments (r28285, for example) about wanting/trying to get the AirPcap GUI working on Linux. I don't know much more than that since I don't have one of the devices to play with. Joerg? I understand the point of code coverage... However, as far as I know the stuff works only on Windows. That's why we setup a test machine with Windows and test this with the AirPcap devices Cace provided us. Having these devices helped a lot, but we only have them running on Windows... So Joerg: It makes sense to have the auto* stuff and the cmake stuff as much in line as possible. But it would make sense to have the Airpcap stuff on by default on Windows, and off by default on other platforms. We can leave support in for switching them on, as this might help during development. Best regards Michael Michael Tuexen wrote: What is the reason to use Airpcap by default? It is (as far as I know) only supported on Windows platforms, when having some software installed. So why compile the stuff on non windows platforms? Best regards Michael On Mar 27, 2012, at 4:37 AM, morr...@wireshark.org wrote: http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=revrevision=41790 User: morriss Date: 2012/03/26 07:37 PM Log: Revert r37423: the intent of r34356 was to enable Airpcap by default, it just didn't work as intended. Then make it so we build with Airpcap by default. This should hopefully be the end of https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4879 Directory: /trunk/ ChangesPathAction +7 -1 configure.inModified ___ Sent via:Wireshark-commits mailing list wireshark-comm...@wireshark.org Archives:http://www.wireshark.org/lists/wireshark-commits Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe ___ Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
Re: [Wireshark-dev] [Wireshark-commits] rev 41790: /trunk/ /trunk/: configure.in
Guy Harris skrev 2012-04-03 18:56: On Apr 3, 2012, at 12:40 PM, Gerald Combs wrote: Bug 6973 contains a patch for a wireless toolbar which uses the Netlink library (libnl). This would fix the problem on Linux but it wouldn't use common code. Ideally, the AirPcap and non-AirPcap wireless toolbars should use as much common code as possible (AirPcap might have some options in addition to the channel). The netlink code should ultimately be stuck behind a common API that could use the *BSD ioctls or the Seekrit Private Framework code on OS X as well as whatever APIs eventually appear in libpcap, but that can be done after it's integrated into Wireshark. (There should also be support in TShark and dumpcap - I vote for -Q as the flag to use to select the channel, as I'd had it in mind for that purpose in tcpdump/dumpcap/TShark/etc.. It's one of the few options that's available in all; one of these days all of the aforementioned programs should start using getopt_long() and bring along their own version of getopt_long() for platforms that lack support - there are both GPLed and BSDLed versions of it, so *shark and tcpdump can both use it. getopt version including getopt_long() comitted :-) BTW, I think OS X's ls uses almost every letter of the alphabet, both lower-case and upper-case; I wouldn't be surprised if the GNU ls did so as well) (Oh, and -Q scan at some point, to do channel scanning. But I digress) ___ Sent via:Wireshark-dev mailing listwireshark-dev@wireshark.org Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe ___ Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
Re: [Wireshark-dev] [Wireshark-commits] rev 41790: /trunk/ /trunk/: configure.in
On Wed, Apr 04, 2012 at 08:30:28PM +0200, Anders Broman wrote: getopt version including getopt_long() comitted :-) Why not rewrite command line parsing to glib API? http://developer.gnome.org/glib/2.26/glib-Commandline-option-parser.html ;-) ___ Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
Re: [Wireshark-dev] [Wireshark-commits] rev 41790: /trunk/ /trunk/: configure.in
On 4/4/12 11:02 AM, Jakub Zawadzki wrote: On Wed, Apr 04, 2012 at 08:30:28PM +0200, Anders Broman wrote: getopt version including getopt_long() comitted :-) Why not rewrite command line parsing to glib API? http://developer.gnome.org/glib/2.26/glib-Commandline-option-parser.html ;-) Bug 2473 does this for capinfos. -- Join us for Sharkfest ’12! · Wireshark® Developer and User Conference Berkeley, CA, June 24-27 · sharkfest.wireshark.org ___ Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
