[Wireshark-dev] New contributor

2012-05-18 Thread Koosha Khajeh Moogahi
Hi developers,

I would like to contribute code to wireshark. I would appreciate your help
if there are somethings that I should consider. Are there any trivial bug
fixings for new comers?

I'm currently a contributor of Bugzilla project.

Thanks.

-- 
Koosha
___
Sent via:Wireshark-dev mailing list 
Archives:http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

Re: [Wireshark-dev] including GPLv3 autoconf macro in Wireshark

2012-05-18 Thread Guy Harris

On May 18, 2012, at 11:55 AM, Jeff Morriss wrote:

> I found out recently that Wireshark needs the Z_BLOCK macro which is only in 
> zlib 1.2.0.5 and later.  Rather than checking explicitly for the version 
> (which seemed like it would be a pain) I thought I'd check for the macro.

You could use AC_TRY_COMPILE() with a test program such as

#ifndef Z_BLOCK
#error "Z_BLOCK isn't available"
#endif

and with zlib.h being one of its includes.
___
Sent via:Wireshark-dev mailing list 
Archives:http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe


Re: [Wireshark-dev] including GPLv3 autoconf macro in Wireshark

2012-05-18 Thread Jeff Morriss

Jakub Zawadzki wrote:

Hi,

On Fri, May 18, 2012 at 02:55:06PM -0400, Jeff Morriss wrote:
I found out recently that Wireshark needs the Z_BLOCK macro which is 
only in zlib 1.2.0.5 and later.  Rather than checking explicitly for the 
version (which seemed like it would be a pain) I thought I'd check for 
the macro.

[...]
Or do I have to find another solution?


I propose another solution: 


  #ifdef Z_BLOCK
/* when preset */
  #else
/* when no */
  #endif


That would obviously be great--but is it reasonably possible?  I assumed 
this was needed for our fancy new zipped-file processing.

___
Sent via:Wireshark-dev mailing list 
Archives:http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe


Re: [Wireshark-dev] including GPLv3 autoconf macro in Wireshark

2012-05-18 Thread Jakub Zawadzki
Hi,

On Fri, May 18, 2012 at 02:55:06PM -0400, Jeff Morriss wrote:
> I found out recently that Wireshark needs the Z_BLOCK macro which is 
> only in zlib 1.2.0.5 and later.  Rather than checking explicitly for the 
> version (which seemed like it would be a pain) I thought I'd check for 
> the macro.
> [...]
> Or do I have to find another solution?

I propose another solution: 

  #ifdef Z_BLOCK
/* when preset */
  #else
/* when no */
  #endif
___
Sent via:Wireshark-dev mailing list 
Archives:http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe


[Wireshark-dev] including GPLv3 autoconf macro in Wireshark

2012-05-18 Thread Jeff Morriss

Hi folks,

I found out recently that Wireshark needs the Z_BLOCK macro which is 
only in zlib 1.2.0.5 and later.  Rather than checking explicitly for the 
version (which seemed like it would be a pain) I thought I'd check for 
the macro.


A quick search for AC_CHECK_DEFINE found me something in the Autoconf 
Archive[1] but (just before I checked it in, I discovered that) the 
current version[2] is GPLv3.


[1] https://www.gnu.org/software/autoconf-archive/
[2] 
http://git.savannah.gnu.org/gitweb/?p=autoconf-archive.git;a=blob_plain;f=m4/ax_check_define.m4


I've never done much with license compatibilities, so I have to ask: can 
I add this macro to Wireshark's aclocal-fallback?  Or do I have to find 
another solution?


Thanks,
-Jeff
___
Sent via:Wireshark-dev mailing list 
Archives:http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe


Re: [Wireshark-dev] privilege separation

2012-05-18 Thread Gerald Combs
On 5/18/12 8:16 AM, Ed Beroset wrote:
> On the Wireshark wish list is "Add privilege separation for POSIX 
> environments (in progress)."  What's left to do on that one?  Apply the 
> privilege during a "make install"?

I think it's referring to running the dissection code with as few
privileges as possible. The PrivilegeSeparation page on the wiki as a
little more information.

-- 
Join us for Sharkfest ’12! · Wireshark® Developer and User Conference
Berkeley, CA, June 24-27 · sharkfest.wireshark.org
___
Sent via:Wireshark-dev mailing list 
Archives:http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

[Wireshark-dev] privilege separation

2012-05-18 Thread Ed Beroset
On the Wireshark wish list is "Add privilege separation for POSIX environments 
(in progress)."  What's left to do on that one?  Apply the privilege during a 
"make install"?

Ed
___
Sent via:Wireshark-dev mailing list 
Archives:http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe