Re: [Wireshark-dev] [Wireshark-commits] buildbot failure in Wireshark (development) on Windows-XP-x86

2013-03-17 Thread Evan Huus
On Sun, Mar 17, 2013 at 5:20 PM, Ed Beroset  wrote:
>
>
>
> -Original Message-
>>From: Evan Huus 
>>Sent: Mar 17, 2013 12:09 PM
>>To: Developer support list for Wireshark 
>>Subject: Re: [Wireshark-dev] [Wireshark-commits] buildbot failure in 
>>Wireshark (development) on Windows-XP-x86
>>
>>I'm still not having any luck (and I've reread
>>https://www.wireshark.org/docs/wsdg_html_chunked/ChSetupWin32.html to
>>no avail). I have two shells available: cygwin's bash and windows'
>>cmd.exe.
>>
>>If I run cmd.exe and then run the vcvars32 script, I can build
>>Wireshark correctly using nmake. This seems to be working fine.
>>
>>I I run cygwin then I do not have nmake available. Running the
>>vcvars32 script from cygwin does not seem to change this (should it)?
>>
>>I cannot run test.sh from cmd.exe since cmd.exe will not interpret
>>unix shell scripts. I cannot run test.sh from cygwin since it requires
>>nmake, which I cannot get cygwin to recognize.
>
> Here's what I did (that worked).  First, from a cmd.exe prompt, I set up the 
> build environment as per 
> https://www.wireshark.org/docs/wsdg_html_chunked/ChSetupWin32.html#ChSetupPrepareCommandCom
>  (using the script there).  Next, I ran \cygwin\bin\bash to get a bash shell. 
>  Then I fixed the path (under bash) using the command "export 
> PATH=$PATH:/bin" and then I changed to the test directory "cd test". Finally, 
> I ran the test script from there "./test.sh -c" and everything worked.  If 
> that works for you (or if it doesn't) let us know.  Since I was the last 
> person to edit that portion of the developer's guide, I'd like to know your 
> thoughts on how it should be edited so that this will be easier to 
> understand.  It's definitely not intuitive, but I'm not sure where this 
> test-specific information should be placed.  Any ideas would be welcome.

That did the trick, thanks. I did initially try running bash from
inside cmd.exe but I got a ton of errors and it wasn't obvious that
the cause was my PATH variable.

One thing worth noting: during my initial setup I never looked at
vcvars32 or the batch script in the documentation, since my Visual
Studio installation created this handy "Visual Studio Command Prompt"
link which seems to do all that stuff for you (except for adding
C:\cygwin\bin to the PATH)!

As to where to put this information, I would just stick in a section
"2.2.14. Optional: Running the Test Suite" and put it there.

Anyways, it's now failing on test 4.2.3 (still not the one the
buildbot fails on!) with the message "tshark: Child dumpcap process
died: Access violation". Is that the win equivalent of a segfault?

Thanks,
Evan
___
Sent via:Wireshark-dev mailing list 
Archives:http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe


Re: [Wireshark-dev] [Wireshark-commits] buildbot failure in Wireshark (development) on Windows-XP-x86

2013-03-17 Thread Ed Beroset



-Original Message-
>From: Evan Huus 
>Sent: Mar 17, 2013 12:09 PM
>To: Developer support list for Wireshark 
>Subject: Re: [Wireshark-dev] [Wireshark-commits] buildbot failure in Wireshark 
>(development) on Windows-XP-x86
>
>I'm still not having any luck (and I've reread
>https://www.wireshark.org/docs/wsdg_html_chunked/ChSetupWin32.html to
>no avail). I have two shells available: cygwin's bash and windows'
>cmd.exe.
>
>If I run cmd.exe and then run the vcvars32 script, I can build
>Wireshark correctly using nmake. This seems to be working fine.
>
>I I run cygwin then I do not have nmake available. Running the
>vcvars32 script from cygwin does not seem to change this (should it)?
>
>I cannot run test.sh from cmd.exe since cmd.exe will not interpret
>unix shell scripts. I cannot run test.sh from cygwin since it requires
>nmake, which I cannot get cygwin to recognize.

Here's what I did (that worked).  First, from a cmd.exe prompt, I set up the 
build environment as per 
https://www.wireshark.org/docs/wsdg_html_chunked/ChSetupWin32.html#ChSetupPrepareCommandCom
 (using the script there).  Next, I ran \cygwin\bin\bash to get a bash shell.  
Then I fixed the path (under bash) using the command "export PATH=$PATH:/bin" 
and then I changed to the test directory "cd test". Finally, I ran the test 
script from there "./test.sh -c" and everything worked.  If that works for you 
(or if it doesn't) let us know.  Since I was the last person to edit that 
portion of the developer's guide, I'd like to know your thoughts on how it 
should be edited so that this will be easier to understand.  It's definitely 
not intuitive, but I'm not sure where this test-specific information should be 
placed.  Any ideas would be welcome.

Ed
___
Sent via:Wireshark-dev mailing list 
Archives:http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe


Re: [Wireshark-dev] [Wireshark-commits] buildbot failure in Wireshark (development) on Windows-XP-x86

2013-03-17 Thread Dirk Jagdmann
>> I'm still not having any luck (and I've reread
>> https://www.wireshark.org/docs/wsdg_html_chunked/ChSetupWin32.html to
>> no avail). I have two shells available: cygwin's bash and windows'
>> cmd.exe.
>>
>> If I run cmd.exe and then run the vcvars32 script, I can build
>> Wireshark correctly using nmake. This seems to be working fine.
>>
>> I I run cygwin then I do not have nmake available. Running the
>> vcvars32 script from cygwin does not seem to change this (should it)?
>>
>> I cannot run test.sh from cmd.exe since cmd.exe will not interpret
>> unix shell scripts. I cannot run test.sh from cygwin since it requires
>> nmake, which I cannot get cygwin to recognize.

> Are you starting bash from the Windows cmd env from which you executed the
> vcvars script ?

open a Windows cmd.exe, run the vcvars32.bat script, then add the path to your
cygwin bin directory to your PATH. That should result in a shell which can run
the Microsoft tools and the cygwin tools.

-- 
---> Dirk Jagdmann
> http://cubic.org/~doj
-> http://llg.cubic.org
___
Sent via:Wireshark-dev mailing list 
Archives:http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe


Re: [Wireshark-dev] [Wireshark-commits] buildbot failure in Wireshark (development) on Windows-XP-x86

2013-03-17 Thread Bill Meier

On 3/17/2013 12:09 PM, Evan Huus wrote:

I'm still not having any luck (and I've reread
https://www.wireshark.org/docs/wsdg_html_chunked/ChSetupWin32.html to
no avail). I have two shells available: cygwin's bash and windows'
cmd.exe.

If I run cmd.exe and then run the vcvars32 script, I can build
Wireshark correctly using nmake. This seems to be working fine.

I I run cygwin then I do not have nmake available. Running the
vcvars32 script from cygwin does not seem to change this (should it)?

I cannot run test.sh from cmd.exe since cmd.exe will not interpret
unix shell scripts. I cannot run test.sh from cygwin since it requires
nmake, which I cannot get cygwin to recognize.



Are you starting bash from the Windows cmd env from which you executed 
the vcvars script ?



The following works for me



cmd> "C:\Program Files\Microsoft Visual Studio 11.0\VC\bin\vcvars32"

cmd> bash

bash$ nmake /f

Microsoft (R) Program Maintenance Utility Version 10.00.30319.01
Copyright (C) Microsoft Corporation.  All rights reserved.

NMAKE : fatal error U1061: /F option requires a filename

bash$ cd test

bash$ rm -f ../epan/*.exe

bash$ l ../epan/*.exe
ls: cannot access ../epan/*.exe: No such file or directory

bash$ ./test.sh -c
--

### Test suite: All ###

Subitems:
-
1  Suite: Prerequisites (2 subitems)
2  Suite: Command line options (10 subitems)
3  Suite: File I/O (1 subitems)
4  Suite: Capture (3 subitems)
5  Suite: Unit tests (3 subitems)
6  Suite: File formats (1 subitems)
7  Suite: Decryption (1 subitems)

1-7  : Select item
Enter: Test All
Q: Quit

--

### Test suite: Unit tests ###

Subitems:
-
1 Step: exntest
2 Step: reassemble_test
3 Step: tvbtest

1-3  : Select item
Enter: Test All
U: Up
Q: Quit


--

### Unit tests ###
1 Step: exntest OK
2 Step: reassemble_test OK
3 Step: tvbtest OK

### Test suite results ###
OK: 3
Failed: 0
Skipped: 0
--

bash$ l ../epan/*.exe
-rwx--+ 1 13824 03-17-13 13:30:26  ../epan/exntest.exe
-rwx--+ 1 90624 03-17-13 13:30:27  ../epan/reassemble_test.exe
-rwx--+ 1 89600 03-17-13 13:30:29  ../epan/tvbtest.exe

bash$





___
Sent via:Wireshark-dev mailing list 
Archives:http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe


Re: [Wireshark-dev] [Wireshark-commits] buildbot failure in Wireshark (development) on Windows-XP-x86

2013-03-17 Thread Evan Huus
I'm still not having any luck (and I've reread
https://www.wireshark.org/docs/wsdg_html_chunked/ChSetupWin32.html to
no avail). I have two shells available: cygwin's bash and windows'
cmd.exe.

If I run cmd.exe and then run the vcvars32 script, I can build
Wireshark correctly using nmake. This seems to be working fine.

I I run cygwin then I do not have nmake available. Running the
vcvars32 script from cygwin does not seem to change this (should it)?

I cannot run test.sh from cmd.exe since cmd.exe will not interpret
unix shell scripts. I cannot run test.sh from cygwin since it requires
nmake, which I cannot get cygwin to recognize.

On Sun, Mar 17, 2013 at 11:09 AM, Bill Meier  wrote:
> On 3/17/2013 11:00 AM, Bill Meier wrote:
>>
>>
>> Basically:
>>
>> You have to setup the Windows cmd environment so that MSVC can be
>> invoked from the command line. (nmake, etc)
>>
>> (When you then run cygwin bash to run the test scripts nmake & etc will
>> be available).
>>
>> For instance: in my Windows cmd line setup cmd file I have:
>>
>> call "C:\Program Files\Microsoft Visual Studio 11.0\VC\bin\vcvars32"
>>
>
> (I'm actually using a .cmd file to do Windows builds which first sets up the
> env as above and then does the nmake).
>
> Doing "C:\Program Files\Microsoft Visual Studio 11.0\VC\bin\vcvars32"
> directly from the Windows command line should be fine.
>
>
>
>
> ___
> Sent via:Wireshark-dev mailing list 
> Archives:http://www.wireshark.org/lists/wireshark-dev
> Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
> mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
___
Sent via:Wireshark-dev mailing list 
Archives:http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe


Re: [Wireshark-dev] BASE_CUSTOM and 64-bit values

2013-03-17 Thread David Arnold
On 14/03/2013, at 10:36 PM, Guy Harris wrote:

> You could use proto_tree_add_uint64_format_value().

I ended up writing a 

static void
foo_tree_add_timestamp(
proto_tree *tree,
const int hf,
tvbuff_t *tvb,
gint offset);

which extracts the value using tvb_get_ntoh64(), splits it into hours, minutes, 
seconds and nanoseconds, writes it to a wmem_packet_scope() buffer using 
g_snprintf(), and calls proto_tree_add_string() to populate the FT_STRING, 
BASE_NONE element from my header_field_info array.  It's only a few more lines 
of code than the BASE_CUSTOM formatting function would have been.

My question then becomes one of consistency: should I do this for all my 
BASE_CUSTOM cases?   Or is there some advantage in using BASE_CUSTOM that I've 
missed (beyond saving a couple of lines of code)?

Thanks,




d



___
Sent via:Wireshark-dev mailing list 
Archives:http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe


Re: [Wireshark-dev] [Wireshark-commits] buildbot failure in Wireshark (development) on Windows-XP-x86

2013-03-17 Thread Bill Meier

On 3/17/2013 11:00 AM, Bill Meier wrote:


Basically:

You have to setup the Windows cmd environment so that MSVC can be
invoked from the command line. (nmake, etc)

(When you then run cygwin bash to run the test scripts nmake & etc will
be available).

For instance: in my Windows cmd line setup cmd file I have:

call "C:\Program Files\Microsoft Visual Studio 11.0\VC\bin\vcvars32"



(I'm actually using a .cmd file to do Windows builds which first sets up 
the env as above and then does the nmake).


Doing "C:\Program Files\Microsoft Visual Studio 11.0\VC\bin\vcvars32"
directly from the Windows command line should be fine.



___
Sent via:Wireshark-dev mailing list 
Archives:http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe


Re: [Wireshark-dev] [Wireshark-commits] buildbot failure in Wireshark (development) on Windows-XP-x86

2013-03-17 Thread Bill Meier

On 3/17/2013 10:30 AM, Evan Huus wrote:

These are still happening occasionally. I dug out my XP-32 virtualbox
instance but have not been able to reproduce.

Tangentially, running the test suite from cygwin I get the following
failure (after the test the build-bot keeps failing on):

5  Suite: Unit tests
5.1 Step: exntest
suite-unittests.sh: line 32: nmake: command not found

"exntest" Failed!
make ../epan/exntest failed

Which seems to imply I ought to be running the tests from the visual
studio command prompt (in order to have nmake), but of course it
doesn't interpret shell scripts. What am I missing?



Basically:

You have to setup the Windows cmd environment so that MSVC can be 
invoked from the command line. (nmake, etc)


(When you then run cygwin bash to run the test scripts nmake & etc will 
be available).


For instance: in my Windows cmd line setup cmd file I have:

call "C:\Program Files\Microsoft Visual Studio 11.0\VC\bin\vcvars32"

It's been a long time since I did this so I don't remember al the 
details. I'm sure the Wireshark Developers Guide has info.


(Can you do the setup directly from the bash cmd line ? I don't remember).


Bill



___
Sent via:Wireshark-dev mailing list 
Archives:http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe


Re: [Wireshark-dev] [Wireshark-commits] buildbot failure in Wireshark (development) on Windows-XP-x86

2013-03-17 Thread Evan Huus
These are still happening occasionally. I dug out my XP-32 virtualbox
instance but have not been able to reproduce.

Tangentially, running the test suite from cygwin I get the following
failure (after the test the build-bot keeps failing on):

5  Suite: Unit tests
5.1 Step: exntest
suite-unittests.sh: line 32: nmake: command not found

"exntest" Failed!
make ../epan/exntest failed

Which seems to imply I ought to be running the tests from the visual
studio command prompt (in order to have nmake), but of course it
doesn't interpret shell scripts. What am I missing?

Thanks,
Evan

On Sun, Mar 17, 2013 at 5:59 AM,   wrote:
> The Buildbot has detected a new failure on builder Windows-XP-x86 while 
> building Wireshark (development).
> Full details are available at:
>  http://buildbot.wireshark.org/trunk/builders/Windows-XP-x86/builds/4536
>
> Buildbot URL: http://buildbot.wireshark.org/trunk/
>
> Buildslave for this Build: windows-xp-x86
>
> Build Reason: scheduler
> Build Source Stamp: 48347
> Blamelist: etxrab
>
> BUILD FAILED: failed test.sh
>
> sincerely,
>  -The Buildbot
>
>
>
> ___
> Sent via:Wireshark-commits mailing list 
> Archives:http://www.wireshark.org/lists/wireshark-commits
> Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
>  
> mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe
___
Sent via:Wireshark-dev mailing list 
Archives:http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe


Re: [Wireshark-dev] Drop sql-oracle dissector?

2013-03-17 Thread Evan Huus
I created a general Oracle protocol page, since I've not been able to
find much to cleanly distinguish the different protocols that
apparently get lumped into the Oracle family.

http://wiki.wireshark.org/Oracle

Dissector was removed from the source tree in r48349 after being
attached (with appropriate warnings) to the wiki page.

On Sat, Mar 16, 2013 at 10:49 PM, Guy Harris  wrote:
>
> On Mar 16, 2013, at 7:17 PM, Evan Huus  wrote:
>
>> packet-sqloracle.c is currently not being built (not listed in either
>> Makefile.common or CMakeLists.txt).
>>
>> It was mentioned in bug #8449 because Moshe noticed that it had a
>> really egregious buffer overflow condition while doing random code
>> review.
>>
>> https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8449
>>
>> Having taken a look at the dissector, it is an absolute mess. Tons of
>> obvious bugs, bad practices, etc. There is no way it would be accepted
>> as a patch, were it filed new today (and nobody seems to know who
>> wrote it anyways).
>>
>> So, since nobody has complained about the fact that it's disabled, and
>> it looks like nearly as much work to rewrite as it is to fix, I'm
>> happy just removing it completely.
>
> I presume it's intended to dissect whatever protocol Oracle uses to send SQL 
> over the wire, probably encapsulated on top of TNS.
>
> Some poking around the Web found
>
> http://packetpushers.net/sqlnet-a-k-a-oracle-tns-and-firewalls/
>
> which says a bit about how TNS works but just speaks of SQL being transported 
> atop it, with no other details of how that's done (or of whether services 
> *other* than SQL are transported over TNS or how you identify the service).
>
> I saw some stuff referring to an Oracle "net8" or "Net8" protocol - perhaps 
> that's version 8 of their SQL protocol - and a Google search for
>
> net8 protocol
>
> found, among other thing:
>
> http://www.pythian.com/blog/repost-oracle-protocol/
>
> which doesn't *look* as if it's TNS, so it might be what runs atop TNS, or 
> might be an alternative to TNS, or
>
> It spoke of "TTCCode"s; Googling for "TTCCode" found some stuff and a lot of 
> irrelevant stuff, and Googling for
>
> TTCCode TTIPro
>
> found various bits of stuff for Java packages with names starting with 
> "oracle.jdbc", which *might* be Java code that puts Oracle SQL on the wire.
>
> This book:
>
> http://www.amazon.com/The-Oracle-Hackers-Handbook-ebook/dp/B000SEIC3K
>
> looks as if it has some protocol details as well.
>
> Oracle has some information at
>
> 
> http://docs.oracle.com/cd/A87860_01/doc/network.817/a76933/architec.htm
>
> but that's more of a software stack description than a protocol stack 
> description.
>
> The source file in question might have some useful information in combination 
> with various other bits of information about Net8/SQL*Net/TTC-7/whatever the 
> heck the name or names of the protocols are; perhaps either:
>
> it should be renamed as "oracle_sql.txt" with a huge comment saying 
> "this code is crap, but it might be one source of useful protocol information 
> in case anybody wants to make an Oracle SQL dissector" and left in the tree;
>
> we should create an "OracleSQL" page on the Wiki with that file as an 
> attachment and various links for the benefit of anybody trying to write an 
> Oracle SQL dissector;
>
> we should file a bug in Bugzilla saying "we need to dissect Oracle 
> SQL messages" and make that file an attachment.
> ___
> Sent via:Wireshark-dev mailing list 
> Archives:http://www.wireshark.org/lists/wireshark-dev
> Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
>  mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
___
Sent via:Wireshark-dev mailing list 
Archives:http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe