Re: [Wireshark-dev] Question regarding emem - wmem conversion
Thanks for your description. On Thu, Sep 12, 2013 at 11:46 PM, Joerg Mayer jma...@loplof.de wrote: Here is what I do (now) - I'm on Linux: - cd epan/dissectors/ - Pick a letter from the alphabet. - grep emem.h packet-letter*.c - ../../tools/checkAPI.pl -g emem packet-letter*.c ../../tools/checkAPIs.pl -g emem packet-cdp.c packet-cdp.c: found 69 useless add_text() vs. 76 add_something else() calls (90.79%) What should be done for that? Is that related to emem? ___ Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
Re: [Wireshark-dev] Question regarding emem - wmem conversion
I'm testing a way to speed up the process, for trivial cases. This is the
script I'm using.
#!/bin/bash
for file in `../../tools/checkAPIs.pl -g emem packet-*.c 21 | egrep
ep_alloc$ | awk ' { print $6 } ' | sed 's/://g'`
do
echo patching $file
sed -i 's/#include epan\/emem.h/#include epan\/wmem\/wmem.h/g' $file
sed -i 's/ep_alloc(/wmem_alloc(wmem_packet_scope(), /g' $file
done
I can open a bug with the output of this script, so we can share the result.
On Thu, Sep 12, 2013 at 11:46 PM, Joerg Mayer jma...@loplof.de wrote:
Hello Kauschik,
On Fri, Sep 13, 2013 at 02:53:50AM +0530, kaushik varanasi wrote:
Can any of you brief me about what should be done. I would like to get
involved and learn.
Here is what I do (now) - I'm on Linux:
- cd epan/dissectors/
- Pick a letter from the alphabet.
- grep emem.h packet-letter*.c
- ../../tools/checkAPI.pl -g emem packet-letter*.c
- Fix inconsistencies (remove includes for emem.h from files that don't
use ep_ or se_ functions, add the include where it is missing
- Go through all files that only contain simple to convert functions
+ Replace the include statement and se_ and ep_ functions the way Evan
described, then compile and install libwireshark (I do:
make -C epan install)
+ run tshark -v to find obvious breakages. If it breaks, svn revert
the file
+ Next file
- Commit my changes
Maybe you can do this and once you have successfully converted the fist
file open a bug and attach your patch to it. Depending on the feedback
go over the patch again or (once sufficiently confident) finish all
dissectors for that letter and attach the patch to the previous bug again.
Ciao
Jörg
Unfortunately emem.h is included everywhere via packet.h via
packet_info.h via address.h, so there are dissectors that use it
without including it directly. check-APIs is more reliable since it
actually looks for the function calls.
P.S. I have a few vim macros that I wrote to speed up the process.
I
can
share them if anybody using vim wants to help :)
Sure, go ahead please.
Put the following in your vimrc:
let @e = 'xxiwmem^[/(^Mawmem_packet_scope(), ^[/\ep_^Mkj'
let @s = 'xxiwmem^[/(^Mawmem_file_scope(), ^[/\se_^Mkj'
Then the 'e' macro will convert an ep_* call and jump to the next one,
the 's' macro will convert an se_* call and jump to the next one.
These only work for functions like _alloc and _strdup, for
data-structures (like ep_strbuf_append) which take the data-structure
and not the scope as the first argument you will have to convert
manually still, but there are not many of those.
On Thu, Sep 12, 2013 at 11:54 AM, Dario Lombardo
dario.lombardo...@gmail.com wrote:
On Thu, Sep 12, 2013 at 5:36 PM, Joerg Mayer jma...@loplof.de
wrote:
So if we could split this between a few people at least the trivial
part
could be done quickly.
Can you please show us what should be done? I could get a part of it
if
it's clear what to do.
The doc/README.wmem section 2.1.1 includes a brief example of how
calls can be replaced. You can also take a look at some of my (and
Joerg's) previous commits doing conversion.
--
Joerg Mayer jma...@loplof.de
We are stuck with technology when what we really want is just stuff that
works. Some say that should read Microsoft instead of technology.
___
Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org
Archives:http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
mailto:wireshark-dev-requ...@wireshark.org
?subject=unsubscribe
___
Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org
Archives:http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
Re: [Wireshark-dev] Question regarding emem - wmem conversion
On Fri, Sep 13, 2013 at 10:39:08AM +0200, Dario Lombardo wrote: Thanks for your description. On Thu, Sep 12, 2013 at 11:46 PM, Joerg Mayer jma...@loplof.de wrote: Here is what I do (now) - I'm on Linux: - cd epan/dissectors/ - Pick a letter from the alphabet. - grep emem.h packet-letter*.c - ../../tools/checkAPI.pl -g emem packet-letter*.c ../../tools/checkAPIs.pl -g emem packet-cdp.c packet-cdp.c: found 69 useless add_text() vs. 76 add_something else() calls (90.79%) What should be done for that? Is that related to emem? No, I just couldn't find an option to turn off the default checks, so we get them as well. The emem hits all look like this: Warning: Found emem APIs in proto.h: ep_strdup_printf Warning: Found emem APIs in proto.h: ep_strdup_printf Ciao Jörg -- Joerg Mayer jma...@loplof.de We are stuck with technology when what we really want is just stuff that works. Some say that should read Microsoft instead of technology. ___ Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
Re: [Wireshark-dev] Question regarding emem - wmem conversion
I'm trying to address se_alloc() calls. If I change this: Index: packet-infiniband_sdp.c === --- packet-infiniband_sdp.c (revision 52002) +++ packet-infiniband_sdp.c (working copy) @@ -31,6 +31,7 @@ #include epan/packet.h #include epan/prefs.h #include epan/conversation.h +#include epan/wmem/wmem.h #include stdlib.h #include errno.h @@ -529,8 +530,8 @@ heur_dissector_add(infiniband.mad.cm.private, dissect_ib_sdp, proto_ib_sdp); /* allocate enough space in the addresses to store the largest address (a GID) */ -manual_addr_data[0] = se_alloc(GID_SIZE); -manual_addr_data[1] = se_alloc(GID_SIZE); +manual_addr_data[0] = wmem_alloc(wmem_file_scope(), GID_SIZE); +manual_addr_data[1] = wmem_alloc(wmem_file_scope(), GID_SIZE); initialized = TRUE; } @@ -567,4 +568,3 @@ } } - tshark -v crashes. What is wrong with my patch? ___ Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
Re: [Wireshark-dev] Question regarding emem - wmem conversion
using wmem_epan_scope() it seems to work. Is it correct to use that scope? On Fri, Sep 13, 2013 at 1:55 PM, Dario Lombardo dario.lombardo...@gmail.com wrote: I'm trying to address se_alloc() calls. If I change this: Index: packet-infiniband_sdp.c === --- packet-infiniband_sdp.c (revision 52002) +++ packet-infiniband_sdp.c (working copy) @@ -31,6 +31,7 @@ #include epan/packet.h #include epan/prefs.h #include epan/conversation.h +#include epan/wmem/wmem.h #include stdlib.h #include errno.h @@ -529,8 +530,8 @@ heur_dissector_add(infiniband.mad.cm.private, dissect_ib_sdp, proto_ib_sdp); /* allocate enough space in the addresses to store the largest address (a GID) */ -manual_addr_data[0] = se_alloc(GID_SIZE); -manual_addr_data[1] = se_alloc(GID_SIZE); +manual_addr_data[0] = wmem_alloc(wmem_file_scope(), GID_SIZE); +manual_addr_data[1] = wmem_alloc(wmem_file_scope(), GID_SIZE); initialized = TRUE; } @@ -567,4 +568,3 @@ } } - tshark -v crashes. What is wrong with my patch? ___ Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
Re: [Wireshark-dev] Question regarding emem - wmem conversion
On 2013-09-13, at 7:55 AM, Dario Lombardo dario.lombardo...@gmail.com wrote: I'm trying to address se_alloc() calls. If I change this: Index: packet-infiniband_sdp.c === --- packet-infiniband_sdp.c (revision 52002) +++ packet-infiniband_sdp.c (working copy) @@ -31,6 +31,7 @@ #include epan/packet.h #include epan/prefs.h #include epan/conversation.h +#include epan/wmem/wmem.h #include stdlib.h #include errno.h @@ -529,8 +530,8 @@ heur_dissector_add(infiniband.mad.cm.private, dissect_ib_sdp, proto_ib_sdp); /* allocate enough space in the addresses to store the largest address (a GID) */ -manual_addr_data[0] = se_alloc(GID_SIZE); -manual_addr_data[1] = se_alloc(GID_SIZE); +manual_addr_data[0] = wmem_alloc(wmem_file_scope(), GID_SIZE); +manual_addr_data[1] = wmem_alloc(wmem_file_scope(), GID_SIZE); initialized = TRUE; } @@ -567,4 +568,3 @@ } } - tshark -v crashes. What is wrong with my patch? Apparently there is no file in scope when that code is run. Depending on the necessary lifetime of the memory, it may make sense to replace it with epan scoped memory (the lifetime of the program, basically) or manually managed memory if the lifetime is something else. ___ Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
Re: [Wireshark-dev] wireshark crashing [SOLVED]
Following up to my own report, I figured out the problem. Somehow, I had two older versions of the libwiretap libraries lying around in my /usr/local/lib directory: lrwxrwxrwx. 1 root root19 Sep 12 09:54 libwiretap.so - libwiretap.so.0.0.0 lrwxrwxrwx. 1 root root19 Sep 12 09:54 libwiretap.so.0 - libwiretap.so.0.0.3 -rwxr-xr-x. 1 root root 1492111 Sep 12 09:54 libwiretap.so.0.0.0 -rwxr-xr-x. 1 root root482721 Mar 27 06:13 libwiretap.so.0.0.2 -rwxr-xr-x. 1 root root 1428963 Apr 19 04:43 libwiretap.so.0.0.3 I deleted the two older versions and redid the logical link to point to the so.0.0.0 file and now all is well. What I don't know is how those other two got there, or why the logical link was not set to point to the correct file. I'm writing this up here so that if anyone else has this problem in the future, the problem might get solved a little faster. Ed ___ Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
Re: [Wireshark-dev] Question regarding emem - wmem conversion
I've submitted a patch with epan scope. On Fri, Sep 13, 2013 at 2:30 PM, Evan Huus eapa...@gmail.com wrote: On 2013-09-13, at 7:55 AM, Dario Lombardo dario.lombardo...@gmail.com wrote: I'm trying to address se_alloc() calls. If I change this: Index: packet-infiniband_sdp.c === --- packet-infiniband_sdp.c (revision 52002) +++ packet-infiniband_sdp.c (working copy) @@ -31,6 +31,7 @@ #include epan/packet.h #include epan/prefs.h #include epan/conversation.h +#include epan/wmem/wmem.h #include stdlib.h #include errno.h @@ -529,8 +530,8 @@ heur_dissector_add(infiniband.mad.cm.private, dissect_ib_sdp, proto_ib_sdp); /* allocate enough space in the addresses to store the largest address (a GID) */ -manual_addr_data[0] = se_alloc(GID_SIZE); -manual_addr_data[1] = se_alloc(GID_SIZE); +manual_addr_data[0] = wmem_alloc(wmem_file_scope(), GID_SIZE); +manual_addr_data[1] = wmem_alloc(wmem_file_scope(), GID_SIZE); initialized = TRUE; } @@ -567,4 +568,3 @@ } } - tshark -v crashes. What is wrong with my patch? Apparently there is no file in scope when that code is run. Depending on the necessary lifetime of the memory, it may make sense to replace it with epan scoped memory (the lifetime of the program, basically) or manually managed memory if the lifetime is something else. ___ Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org ?subject=unsubscribe ___ Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
Re: [Wireshark-dev] custom plugin (*.dll) is not working at plugin configured path %WIRESHARK%\plugins\version
Hello Evan, Thank you very much. Now it is working fne :) Regards, Hardik Patel On Thu, Sep 12, 2013 at 4:04 PM, Evan Huus eapa...@gmail.com wrote: The API/ABI has changed between 1.10 and 1.11 (and tends to change in every major version). You will have to rebuild your plugin against the 1.10 source in order to use it with a 1.10 binary. Evan On Thu, Sep 12, 2013 at 7:44 AM, Hardik Patel hardik.pa...@gmail.comwrote: Hello guys, I have created simple plugin in windows environment which just label Name on perticular TCP port number. After building with make i get .dll in same folder where source code exist. nmake -f Makefile.nmake all when i copy in following folder then launch wireshark.exe from C:\wireshark\wireshark-gtk2 works fine. C:\wireshark\wireshark-gtk2\plugins\1.11.0 - But when i used to paste foo.dll in below link: C:\Program Files (x86)\Wireshark\plugins\1.10.1 and start wireshark.exe from C:\Program Files (x86)\Wireshark then, wireshark stopped loading and close with error at Registering Plugins at start up. I am using windows 2008 64-bit and building wireshark with 32-bit library and 32-bit cmd environment with visual C++ 2010 Express Edition . What should be problem and it's solution ??? Regards, Hardik Patel ___ Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org ?subject=unsubscribe ___ Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org ?subject=unsubscribe ___ Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
Re: [Wireshark-dev] Question regarding emem - wmem conversion
Joerg Mayer jmayer@... writes: ../../tools/checkAPIs.pl -g emem packet-cdp.c packet-cdp.c: found 69 useless add_text() vs. 76 add_something else() calls (90.79%) What should be done for that? Is that related to emem? No, I just couldn't find an option to turn off the default checks, so we get them as well. Strangely and rather non-intuitively, the option is --build, as in: ../../tools/checkAPIs.pl --build -g emem packet-cdp.c (It might be a good idea to choose another name for this option and document it in the usage ... along with the nohf and debug flags.) ___ Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
Re: [Wireshark-dev] Question regarding emem - wmem conversion
Christopher Maynard Christopher.Maynard@... writes: Strangely and rather non-intuitively, the option is --build, as in: ../../tools/checkAPIs.pl --build -g emem packet-cdp.c (It might be a good idea to choose another name for this option and document it in the usage ... along with the nohf and debug flags.) Usage has now changed a bit since r52006. Hopefully things are clearer now. Usage: checkAPIs.pl [-M] [-g group1] [-g group2] ... [-s group1] [-s group2] ... [--nocheck-value-string-array-null-termination] [--nocheck-addtext] [--nocheck-hf] [--debug] file1 file2 ... -g group: Check input files for use of APIs in group (in addition to the default groups) -s group: Output summary (count) for each API in group (-g group also req'd) -M: Generate output for -g in 'machine-readable' format Default Groups[-g]: deprecated, emem, prohibited Available Groups: abort, deprecated, deprecated-gtk, deprecated-gtk-todo, emem, prohibited, termoutput ___ Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
Re: [Wireshark-dev] [Wireshark-commits] rev 52006: /trunk/tools/ /trunk/tools/: checkAPIs.pl
On Fri, Sep 13, 2013 at 04:52:09PM +, cmayn...@wireshark.org wrote: http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=revrevision=52006 Log: Rename --build to --check-addtext/--nocheck-addtext for clarity. Add --check-addtext/--nocheck-addtext, --check-hf/--nocheck-hf and --debug to the usage output and format the usage output a little better. Directory: /trunk/tools/ ChangesPathAction +15 -9 checkAPIs.plModified To be honest, I still have no idea what these options do :-( and also, why this resets the list of default checks. Can someone please explain them to me? thanks Jörg -- Joerg Mayer jma...@loplof.de We are stuck with technology when what we really want is just stuff that works. Some say that should read Microsoft instead of technology. ___ Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
[Wireshark-dev] Tool Ownership and Licensing
We have the following tools in our source tree without appropriate license headers, I expect mostly because people didn't think they were that important at the time for some trivial script. If you see one you wrote, please either add the header yourself, or email me and I can take care of adding the appropriate header. If your intention was not to license the script under one of Wireshark's permitted licenses, please remove it from the repository (or contact me to that effect). tools/asn2wrs.py tools/ftsanity.py tools/pkt-from-core.py tools/html2text.py tools/colorfilters2js.pl tools/make-tap-reg.py debian-setup.sh doc/make-authors-format.pl doc/perlnoutf.pl doc/make-authors-short.pl doc/dfilter2pod.pl help/faq.py macosx-setup.sh docbook/dfilter2xml.pl Thanks, Evan P.S. Does anyone know the legal status of whatever remains unclaimed from this list? Can we add our header on the understanding that simply having it committed was permission to do so? ___ Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
Re: [Wireshark-dev] [Wireshark-commits] rev 52016: /trunk/tools/ /trunk/tools/: checkAPIs.pl
On 09/13/13 14:11, cmayn...@wireshark.org wrote: http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=revrevision=52016 User: cmaynard Date: 2013/09/13 11:11 AM Log: OK, all the Makefiles use -build since r41943, so add that option back for now. Yes, the intent of the -build option was to prevent the buildbot from running the useless add_text() (and maybe in the future other) things which, well, we don't want to pollute the buildbot output with (and which we don't want to uselessly slow the buildbot down). ___ Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
Re: [Wireshark-dev] Tool Ownership and Licensing
Here's a list of who I can figure out to be the authors (based on svn log | tail). I'm guessing that at least some of these folks probably need to be contacted directly... On 09/13/13 14:45, Evan Huus wrote: We have the following tools in our source tree without appropriate license headers, I expect mostly because people didn't think they were that important at the time for some trivial script. If you see one you wrote, please either add the header yourself, or email me and I can take care of adding the appropriate header. If your intention was not to license the script under one of Wireshark's permitted licenses, please remove it from the repository (or contact me to that effect). tools/asn2wrs.py Thomas Kukosa tools/ftsanity.py Gilbert Ramirez tools/pkt-from-core.py Gilbert Ramirez tools/html2text.py http://www.aaronsw.com/2002/html2text/ (copied by Gerald) License (GPLv3) is already there but not with a full header. tools/colorfilters2js.pl Dirk Jagdmann tools/make-tap-reg.py Anders Broman debian-setup.sh Guy Harris doc/make-authors-format.pl Graeme Hewson doc/perlnoutf.pl Graeme Hewson doc/make-authors-short.pl Ulf Lamping doc/dfilter2pod.pl Gilbert Ramirez help/faq.py Gerald Combs macosx-setup.sh Joerg Mayer docbook/dfilter2xml.pl Ulf Lamping ___ Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
Re: [Wireshark-dev] Tool Ownership and Licensing
On Fri, Sep 13, 2013 at 05:12:44PM -0400, Jeff Morriss wrote: macosx-setup.sh Joerg Mayer Really? I don't remember. I only remember improving it. Maybe Guy or Michael remember something about this script. Ciao Jörg -- Joerg Mayer jma...@loplof.de We are stuck with technology when what we really want is just stuff that works. Some say that should read Microsoft instead of technology. ___ Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
Re: [Wireshark-dev] Tool Ownership and Licensing
On 09/13/13 18:10, Joerg Mayer wrote: On Fri, Sep 13, 2013 at 05:12:44PM -0400, Jeff Morriss wrote: macosx-setup.sh Joerg Mayer Really? I don't remember. I only remember improving it. Maybe Guy or Michael remember something about this script. That's what Guy's checkin comment said: r38053 | guy | 2011-07-15 17:48:02 -0400 (Fri, 15 Jul 2011) | 8 lines Add Joerg Mayer's macos-setup.sh script, modified to add an x after macos, to fix some bugs, to use sudo if necessary when installing, to make the library version numbers variables, and to download the optional libraries, by default, as well. Also add his patches to make GLib build and work. Update README.macos to reflect that. ___ Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
Re: [Wireshark-dev] Tool Ownership and Licensing
On Fri, Sep 13, 2013 at 06:32:49PM -0400, Jeff Morriss wrote: On 09/13/13 18:10, Joerg Mayer wrote: On Fri, Sep 13, 2013 at 05:12:44PM -0400, Jeff Morriss wrote: macosx-setup.sh Joerg Mayer Really? I don't remember. I only remember improving it. Maybe Guy or Michael remember something about this script. That's what Guy's checkin comment said: r38053 | guy | 2011-07-15 17:48:02 -0400 (Fri, 15 Jul 2011) | 8 lines Add Joerg Mayer's macos-setup.sh script, modified to add an x after macos, to fix some bugs, to use sudo if necessary when installing, to make the library version numbers variables, and to download the optional libraries, by default, as well. Also add his patches to make GLib build and work. Update README.macos to reflect that. So that was only two years ago ;-) Unbelievable. Googling a bit showed http://comments.gmane.org/gmane.network.wireshark.devel/22203 which gives pretty much the history of this script. It was (more than) inspired by https://nplab.fh-muenster.de/groups/wiki/wiki/fb7a4/Building_Wireshark_on_SnowLeopard.html So the foundation of this script was written by Irene Rüngeler. I only improved on that. Ciao Jörg -- Joerg Mayer jma...@loplof.de We are stuck with technology when what we really want is just stuff that works. Some say that should read Microsoft instead of technology. ___ Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
Re: [Wireshark-dev] Tool Ownership and Licensing
On Sat, Sep 14, 2013 at 01:07:29AM +0200, Joerg Mayer wrote: http://comments.gmane.org/gmane.network.wireshark.devel/22203 which gives pretty much the history of this script. It was (more than) inspired by https://nplab.fh-muenster.de/groups/wiki/wiki/fb7a4/Building_Wireshark_on_SnowLeopard.html Actually this second link is still mentioned at the top of the script - I tend to give credit to my sources. So the foundation of this script was written by Irene Rüngeler. I only improved on that. So if you want to put authorship on anyone, maybe Irene or Michael, Guy and me are the most likely candidates - IMO this script should contain the standard license header and we need to find out whether to put Irene or Michael onto the blame list ;- Ciao Jörg -- Joerg Mayer jma...@loplof.de We are stuck with technology when what we really want is just stuff that works. Some say that should read Microsoft instead of technology. ___ Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
Re: [Wireshark-dev] Tool Ownership and Licensing
On Sep 14, 2013, at 1:31 AM, Joerg Mayer jma...@loplof.de wrote: On Sat, Sep 14, 2013 at 01:07:29AM +0200, Joerg Mayer wrote: http://comments.gmane.org/gmane.network.wireshark.devel/22203 which gives pretty much the history of this script. It was (more than) inspired by https://nplab.fh-muenster.de/groups/wiki/wiki/fb7a4/Building_Wireshark_on_SnowLeopard.html Actually this second link is still mentioned at the top of the script - I tend to give credit to my sources. So the foundation of this script was written by Irene Rüngeler. I only improved on that. So if you want to put authorship on anyone, maybe Irene or Michael, Guy and me are the most likely candidates - IMO this script should contain the standard license header and we need to find out whether to put Irene or Michael onto the blame list ;- The commands were my list of commands how to install the support libraries on the Mac OS X buildbots. I executed them by copy and paste. Someone took them from the Wiki and made them a script. Not sure who. Maybe Jörg. I'm fine with a GPL 2 license. Best regards Michael Ciao Jörg -- Joerg Mayer jma...@loplof.de We are stuck with technology when what we really want is just stuff that works. Some say that should read Microsoft instead of technology. ___ Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe ___ Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
