Re: [Wireshark-dev] Fwd: [Wireshark-commits] rev 52741: Add APIs for PIDL generated code to return the value of the integer that was dissected.
These PIDL APIs do a wrapper of "add integer to tree" + "add integer to column (info) data", not just a simple "add integer to tree, return value" -Original Message- From: Anders Broman To: Developer support list for Wireshark Sent: Mon, Oct 21, 2013 3:54 pm Subject: [Wireshark-dev] Fwd: [Wireshark-commits] rev 52741: Add APIs for PIDL generated code to return the value of the integer that was dissected. Hi, Shouldn't something generic based on proto_tree_add_bits_ret_val() be used instead? Regards Anders Ursprungligt meddelande Ämne: [Wireshark-commits] rev 52741: /trunk/epan/dissectors/ /trunk/epan/dissectors/: packet-dcerpc-ndr.c packet-dcerpc.h Datum: Mon, 21 Oct 2013 18:25:42 GMT Från: mm...@wireshark.org Svar till: wireshark-dev@wireshark.org Till: wireshark-comm...@wireshark.org http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=52741 User: mmann Date: 2013/10/21 06:25 PM Log: Add APIs for PIDL generated code to return the value of the integer that was dissected. Bug 9305 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9305). From Matthieu Patou Directory: /trunk/epan/dissectors/ ChangesPath Action +55 -12packet-dcerpc-ndr.cModified +5 -1 packet-dcerpc.hModified ___ Sent via:Wireshark-commits mailing list Archives:http://www.wireshark.org/lists/wireshark-commits Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe ___ Sent via:Wireshark-dev mailing list Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe ___ Sent via:Wireshark-dev mailing list Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
[Wireshark-dev] Minor Samba Licensing Question
Hello Samba folks. I was poking through the recent changes being landed to PIDL in Wireshark (thank you for those!) and noticed that one of the files was being picked up as unlicensed by our buildbot. Specifically: 'epan/dissectors/pidl/idl_types.h' has non-whitelisted license 'UNKNOWN' A bit of digging reveals that this was an issue even before the recent PIDL changes, but I only just noticed the message. I'm assuming that this file is GPL2-licensed like everything else, in which case I can silence the license checker? Thanks, Evan P.S. 'epan/dissectors/pidl/mapi/request.cnf.c' and 'epan/dissectors/pidl/mapi/response.cnf.c' are also producing warnings, but I *think* that those are Wireshark's and are not upstream. Please correct me if I'm wrong. ___ Sent via:Wireshark-dev mailing list Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
Re: [Wireshark-dev] Wireshark PIDL generated dissectors
On Mon, Oct 21, 2013 at 03:48:35PM -0400, mman...@netscape.net wrote: > Checked most of the patches into r52744 > (http://anonsvn.wireshark.org/viewvc?view=revision&revision=52744) > > Didn't integrate > 0010-frsrpc-Regenerate-frsrpc-due-to-changes-in-the-pidl-.patch > 0016-Regenerate-the-dnserver.patch > > due to compile errors on Windows from applying the patch in bug 9301 > (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9301). > > See r52735 (http://anonsvn.wireshark.org/viewvc?view=revision&revision=52735) > for how it was fixed. Not sure if the PIDL compiler has to be changed for > this one. I just tried to replace tools/pidl/ with the current samba rsync version. The result doesn't look too good: jmayer@egg:~/work/wireshark/svn/trunk/epan/dissectors/pidl> ../../../tools/pidl/pidl --ws-parser -- atsvc.idl defined(@array) is deprecated at /home/jmayer/work/wireshark/svn/trunk/tools/pidl/lib/Parse/Pidl/ODL.pm line 73. (Maybe you should just omit the defined()?) defined(@array) is deprecated at ../../../tools/pidl/pidl line 608. (Maybe you should just omit the defined()?) Compiling atsvc.idl /usr/include/stdc-predef.h:0: error: Syntax error near '3' Failed to parse atsvc.idl at ../../../tools/pidl/pidl line 608. jmayer@egg:~/work/wireshark/svn/trunk/epan/dissectors/pidl> perl -version This is perl 5, version 16, subversion 2 (v5.16.2) built for i586-linux-thread-multi [...] Any idea about what's going wrong here? And when I try to do a "make install" for pidl and then run it: jmayer@egg:~/work/wireshark/svn/trunk/epan/dissectors/pidl> pidl --ws-parser -- atsvc.idl Can't locate Parse/Pidl.pm in @INC (@INC contains: /usr/bin/../share/perl5 /usr/bin/lib /usr/lib/perl5/site_perl/5.16.2/i586-linux-thread-multi /usr/lib/perl5/site_perl/5.16.2 /usr/lib/perl5/vendor_perl/5.16.2/i586-linux-thread-multi /usr/lib/perl5/vendor_perl/5.16.2 /usr/lib/perl5/5.16.2/i586-linux-thread-multi /usr/lib/perl5/5.16.2 /usr/lib/perl5/site_perl .) at /usr/bin/pidl line 410. BEGIN failed--compilation aborted at /usr/bin/pidl line 410. Which looks like the make install target doesn't work on opensuse 12.3. Ciao Jörg -- Joerg Mayer We are stuck with technology when what we really want is just stuff that works. Some say that should read Microsoft instead of technology. ___ Sent via:Wireshark-dev mailing list Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
[Wireshark-dev] Coverity warning in tshark.c
Looks like coverity has a valid complaint:
CID 1109702: Dereference after null check (FORWARD_NULL)
/tshark.c: 2859 ( var_compare_op)
2856 /* If we're going to print packet information, or we're going to
2857 run a read filter, or we're going to process taps, set up to
2858 do a dissection and do so. */
>>> Comparing "edt" to null implies that "edt" might be null.
2859 if (edt) {
2860if (gbl_resolv_flags.mac_name || gbl_resolv_flags.network_name ||
2861gbl_resolv_flags.transport_name ||
gbl_resolv_flags.concurrent_dns)
2862 /* Grab any resolved addresses */
2863 host_name_lookup_process();
/tshark.c: 2903 ( var_deref_model)
2900if (print_packet_info) {
2901 /* We're printing packet information; print the information for
2902 this packet. */
>>> Passing null variable "edt" to function "print_packet", which dereferences
>>> it.
2903 print_packet(cf, edt);
2904
2905 /* The ANSI C standard does not appear to *require* that a
line-buffered
2906 stream be flushed to the host environment whenever a
newline is
2907 written, it just says that, on such a stream, characters
"are
Ciao
Jörg
--
Joerg Mayer
We are stuck with technology when what we really want is just stuff that
works. Some say that should read Microsoft instead of technology.
___
Sent via:Wireshark-dev mailing list
Archives:http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
Re: [Wireshark-dev] [Wireshark-commits] rev 52701: /trunk/epan/ /trunk/epan/: oids_test.c
> On Oct 21, 2013, at 4:51 PM, Ed Beroset wrote: > > Joerg Mayer wrote: >>> On Sun, Oct 20, 2013 at 02:18:19AM +, eapa...@wireshark.org wrote: >>> http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=52701 >>> >>> User: eapache >>> Date: 2013/10/20 02:18 AM >>> >>> Log: >>> Don't use g_assert_cmpint, it isn't happy on Windows. g_assert is nearly as >>> good >>> except it doesn't produce as nice error messages. >> >> How about adding it to check api? > > That's a good idea, since it was certainly news to me. I also looked and > couldn't find anything in the gnome bugzilla. The closest I could find was > this: https://bugzilla.gnome.org/show_bug.cgi?id=516916 > > So for those of us without handy access to Windows (at the moment) what's the > issue, exactly? Are there other parts of gnome testing environment that > won't work under Windows? It produces funny compile warnings about loss of data casting 64-bit types to 32 bits. These are currently turned into errors in our build system. I didn't really investigated further, as I also don't have easy access to a Windows builder. Evan ___ Sent via:Wireshark-dev mailing list Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
Re: [Wireshark-dev] [Wireshark-commits] rev 52701: /trunk/epan/ /trunk/epan/: oids_test.c
Joerg Mayer wrote: >On Sun, Oct 20, 2013 at 02:18:19AM +, eapa...@wireshark.org wrote: >> http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=52701 >> >> User: eapache >> Date: 2013/10/20 02:18 AM >> >> Log: >> Don't use g_assert_cmpint, it isn't happy on Windows. g_assert is nearly as >> good >> except it doesn't produce as nice error messages. > >How about adding it to check api? That's a good idea, since it was certainly news to me. I also looked and couldn't find anything in the gnome bugzilla. The closest I could find was this: https://bugzilla.gnome.org/show_bug.cgi?id=516916 So for those of us without handy access to Windows (at the moment) what's the issue, exactly? Are there other parts of gnome testing environment that won't work under Windows? Ed ___ Sent via:Wireshark-dev mailing list Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
Re: [Wireshark-dev] FW: [Wireshark-commits] rev 52730: /trunk/epan/dissectors/ /trunk/epan/dissectors/: packet-cdp.c
Hi, > User: eapache > Date: 2013/10/21 01:07 PM > > Log: > Don't go into a loop if we find a zero-length line. Fixes > https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9312 > > Anders, this may be related to your recent TVB optimizations, since I don't > think it happened before that? Did you change the behaviour of > tvb_find_line_end or its callees at all? >From tvb_find_line_end() comment: * Set "*next_offset" to the (...) past the end of the buffer if we don't find a line terminator. This was changed, tvb_find_line_end() no longer does it, it sets *next_offset to tvb->length, so there's no exception in next call. I'm also not happy about: 2481 /* tvb_get_guint8() */ 2482 ptr=tvb->real_data + eol_offset + 1; If it really speedup dissection there should be at least DISSECTOR_ASSERT(tvb->real_data != NULL) before. Cheers, Kuba. ___ Sent via:Wireshark-dev mailing list Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
Re: [Wireshark-dev] [Wireshark-commits] rev 52701: /trunk/epan/ /trunk/epan/: oids_test.c
On Sun, Oct 20, 2013 at 02:18:19AM +, eapa...@wireshark.org wrote: > http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=52701 > > User: eapache > Date: 2013/10/20 02:18 AM > > Log: > Don't use g_assert_cmpint, it isn't happy on Windows. g_assert is nearly as > good > except it doesn't produce as nice error messages. How about adding it to check api? Ciao Jörg -- Joerg Mayer We are stuck with technology when what we really want is just stuff that works. Some say that should read Microsoft instead of technology. ___ Sent via:Wireshark-dev mailing list Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
[Wireshark-dev] Fwd: [Wireshark-commits] rev 52741: Add APIs for PIDL generated code to return the value of the integer that was dissected.
Hi, Shouldn't something generic based on proto_tree_add_bits_ret_val() be used instead? Regards Anders Ursprungligt meddelande Ämne: [Wireshark-commits] rev 52741: /trunk/epan/dissectors/ /trunk/epan/dissectors/: packet-dcerpc-ndr.c packet-dcerpc.h Datum: Mon, 21 Oct 2013 18:25:42 GMT Från: mm...@wireshark.org Svar till: wireshark-dev@wireshark.org Till: wireshark-comm...@wireshark.org http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=52741 User: mmann Date: 2013/10/21 06:25 PM Log: Add APIs for PIDL generated code to return the value of the integer that was dissected. Bug 9305 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9305). From Matthieu Patou Directory: /trunk/epan/dissectors/ ChangesPath Action +55 -12packet-dcerpc-ndr.cModified +5 -1 packet-dcerpc.hModified ___ Sent via:Wireshark-commits mailing list Archives:http://www.wireshark.org/lists/wireshark-commits Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe ___ Sent via:Wireshark-dev mailing list Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
Re: [Wireshark-dev] Wireshark PIDL generated dissectors
Checked most of the patches into r52744 (http://anonsvn.wireshark.org/viewvc?view=revision&revision=52744) Didn't integrate 0010-frsrpc-Regenerate-frsrpc-due-to-changes-in-the-pidl-.patch 0016-Regenerate-the-dnserver.patch due to compile errors on Windows from applying the patch in bug 9301 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9301). See r52735 (http://anonsvn.wireshark.org/viewvc?view=revision&revision=52735) for how it was fixed. Not sure if the PIDL compiler has to be changed for this one. -Original Message- From: Matthieu Patou To: Joerg Mayer Cc: Developer support list for Wireshark ; Samba Technical ; Andrew Bartlett Sent: Mon, Oct 21, 2013 10:17 am Subject: Re: [Wireshark-dev] Wireshark PIDL generated dissectors Hi Joerg On 10/07/2013 10:16 PM, Joerg Mayer wrote: > On Mon, Oct 07, 2013 at 09:30:58PM -0700, Matthieu Patou wrote: >> That being said I did a bit of homework yesterday to fix the >> situation I have a branch fix_pidl in my gitorious repository that I >> maintain for wireshark: >> https://gitorious.org/wireshark/wireshark/commits/fix_pidl >> >> With this branch and the latest version of the pidl in samba tree >> (that incorporate the change for Michael Mann) I'm able to >> regenerate and rebuild most of the dissectors. >> You might want to have a look at commit 27f5746 >> (https://gitorious.org/wireshark/wireshark/commit/27f5746163410acbf638cdce320fb1b8295fa682) >> that update the guide to explain and make it easy to generate the >> dissectors especially it explains how to avoid checking out the >> whole samba source tree but still get the latest version of Samba's >> pidl (minus the time it takes to update our rsync servers). >> Are you interested to fetch those fixes ? > If nobody looks at it until the weekend I will do that (or unless I > shift some of my sleeping time into this). > Did you slept well last 2 weeks ? If so can you think at integrating those patches: 0001-Update-the-README-file-for-pidl-usage-in-wireshark.patch 0002-Add-regenerated-atsvc-dissector.patch 0003-Fix-implicit-convertion-errors.patch 0004-Update-the-idl-for-dssetup.patch 0005-Update-the-generated-file-for-dssetup.patch 0006-Update-generated-file-for-efs.patch 0007-Update-the-idl-and-cnf-for-initshutdown.patch 0008-Add-regenerated-files-for-initshutdown.patch 0009-Add-regenerated-eventlog-files.patch 0010-frsrpc-Regenerate-frsrpc-due-to-changes-in-the-pidl-.patch 0011-Update-cnf-and-idl-for-misc-interface.patch 0012-Add-packet-dcerpc-misc.c-to-the-list-of-build-files.patch 0013-Generate-misc.idl-related-files.patch 0014-Update-the-idl-and-cnf-for-winreg.patch 0015-Update-generated-code-for-winreg.patch 0016-Regenerate-the-dnserver.patch 0017-Update-the-cnf-for-lsa-to-remove-some-warnings.patch 0018-Regenerate-the-lsa-files.patch 0019-Regenerate-wzcsvc.patch 0020-Update-samr.cnf-to-remove-warnings-about-void-conver.patch 0021-Regenerate-samr-files.patch Thanks. Matthieu. -- Matthieu Patou Samba Team http://samba.org ___ Sent via:Wireshark-dev mailing list Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe ___ Sent via:Wireshark-dev mailing list Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
Re: [Wireshark-dev] Wireshark PIDL generated dissectors
These are independent of the bugs logged to Bugzilla, correct? -Original Message- From: Matthieu Patou To: Joerg Mayer Cc: Developer support list for Wireshark ; Samba Technical ; Andrew Bartlett Sent: Mon, Oct 21, 2013 10:17 am Subject: Re: [Wireshark-dev] Wireshark PIDL generated dissectors Hi Joerg On 10/07/2013 10:16 PM, Joerg Mayer wrote: > On Mon, Oct 07, 2013 at 09:30:58PM -0700, Matthieu Patou wrote: >> That being said I did a bit of homework yesterday to fix the >> situation I have a branch fix_pidl in my gitorious repository that I >> maintain for wireshark: >> https://gitorious.org/wireshark/wireshark/commits/fix_pidl >> >> With this branch and the latest version of the pidl in samba tree >> (that incorporate the change for Michael Mann) I'm able to >> regenerate and rebuild most of the dissectors. >> You might want to have a look at commit 27f5746 >> (https://gitorious.org/wireshark/wireshark/commit/27f5746163410acbf638cdce320fb1b8295fa682) >> that update the guide to explain and make it easy to generate the >> dissectors especially it explains how to avoid checking out the >> whole samba source tree but still get the latest version of Samba's >> pidl (minus the time it takes to update our rsync servers). >> Are you interested to fetch those fixes ? > If nobody looks at it until the weekend I will do that (or unless I > shift some of my sleeping time into this). > Did you slept well last 2 weeks ? If so can you think at integrating those patches: 0001-Update-the-README-file-for-pidl-usage-in-wireshark.patch 0002-Add-regenerated-atsvc-dissector.patch 0003-Fix-implicit-convertion-errors.patch 0004-Update-the-idl-for-dssetup.patch 0005-Update-the-generated-file-for-dssetup.patch 0006-Update-generated-file-for-efs.patch 0007-Update-the-idl-and-cnf-for-initshutdown.patch 0008-Add-regenerated-files-for-initshutdown.patch 0009-Add-regenerated-eventlog-files.patch 0010-frsrpc-Regenerate-frsrpc-due-to-changes-in-the-pidl-.patch 0011-Update-cnf-and-idl-for-misc-interface.patch 0012-Add-packet-dcerpc-misc.c-to-the-list-of-build-files.patch 0013-Generate-misc.idl-related-files.patch 0014-Update-the-idl-and-cnf-for-winreg.patch 0015-Update-generated-code-for-winreg.patch 0016-Regenerate-the-dnserver.patch 0017-Update-the-cnf-for-lsa-to-remove-some-warnings.patch 0018-Regenerate-the-lsa-files.patch 0019-Regenerate-wzcsvc.patch 0020-Update-samr.cnf-to-remove-warnings-about-void-conver.patch 0021-Regenerate-samr-files.patch Thanks. Matthieu. -- Matthieu Patou Samba Team http://samba.org ___ Sent via:Wireshark-dev mailing list Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe ___ Sent via:Wireshark-dev mailing list Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
[Wireshark-dev] FW: [Wireshark-commits] rev 52730: /trunk/epan/dissectors/ /trunk/epan/dissectors/: packet-cdp.c
Hi, >Anders, this may be related to your recent TVB optimizations, since I don't >think it happened before that? Did you change the behaviour of >>tvb_find_line_end or its callees at all? Not intentionally ;-) I just expanded some code inside the function and used tvb_pbrk_guint8_within_tvb() to avoid a repeated call to check_offset_length() But I may have missed something... Regards Anders -Original Message- From: wireshark-commits-boun...@wireshark.org [mailto:wireshark-commits-boun...@wireshark.org] On Behalf Of eapa...@wireshark.org Sent: den 21 oktober 2013 15:07 To: wireshark-comm...@wireshark.org Subject: [Wireshark-commits] rev 52730: /trunk/epan/dissectors/ /trunk/epan/dissectors/: packet-cdp.c http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=52730 User: eapache Date: 2013/10/21 01:07 PM Log: Don't go into a loop if we find a zero-length line. Fixes https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9312 Anders, this may be related to your recent TVB optimizations, since I don't think it happened before that? Did you change the behaviour of tvb_find_line_end or its callees at all? Directory: /trunk/epan/dissectors/ ChangesPathAction +1 -0 packet-cdp.cModified ___ Sent via:Wireshark-commits mailing list Archives:http://www.wireshark.org/lists/wireshark-commits Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe ___ Sent via:Wireshark-dev mailing list Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
Re: [Wireshark-dev] asn1 plugin
On Mon, Oct 21, 2013 at 8:41 AM, Anders Broman wrote: > > >>-Original Message- >>From: wireshark-dev-boun...@wireshark.org >>[mailto:wireshark-dev-boun...@wireshark.org] On Behalf Of Ed Beroset >>Sent: den 19 oktober 2013 20:24 >>To: wireshark-dev@wireshark.org >>Subject: [Wireshark-dev] asn1 plugin >> >>Recently, while I was working on unit tests for oids.c (see >>https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9294 ), I noticed a few >>lines toward the bottom of the oids.h file which say: >> >>/* macros for legacy oid functions */ >>#define oid_resolv_cleanup() ((void)0) >>#define subid_t guint32 >> >>It seems that the only place left that oid_resolv_cleanup() was called from >>was epan.c so I submitted a patch to eliminate both. ( see >>https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9295 ) >> >>The only place that subid_t is being used is in the asn1 plugin. When I >>looked there to see about replacing them, it seems that there are many >>functions in >that plugin which duplicate functionality implemented in >>oids.c. I seem to recall that there is at least one other thing somewhere in >>the code that exists >solely to support the asn1 plugin (but I couldn't >>remember what that was). >> >>So there are two possible ways to proceed in cleaning up. One would be to >>eliminate the asn1 plugin entirely. The other would be to update the >>asn1 plugin code to eliminate such code anachronisms. I'd be willing to do >>either, but don't know if there are any available test cases for using the >>asn1 >plugin. I tried to use it once but didn't figure it out. >> >>So would anyone object to removing it from the codebase? And if so, can you >>provide some sample for how it's used? > > I think we should probably remove it from the make files but leave the > sources so it can be revived should any one require it. I don't think any > active work > Has been done on it for a very long time and I'm not sure if it's actually > used by any one. I'd be glad to get rid of it :-) > > Regards > Anders It can always be revived from git/svn history if we want it back. If it really isn't used at all then I think we can remove it entirely. Evan ___ Sent via:Wireshark-dev mailing list Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
Re: [Wireshark-dev] asn1 plugin
>-Original Message- >From: wireshark-dev-boun...@wireshark.org >[mailto:wireshark-dev-boun...@wireshark.org] On Behalf Of Ed Beroset >Sent: den 19 oktober 2013 20:24 >To: wireshark-dev@wireshark.org >Subject: [Wireshark-dev] asn1 plugin > >Recently, while I was working on unit tests for oids.c (see >https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9294 ), I noticed a few >lines toward the bottom of the oids.h file which say: > >/* macros for legacy oid functions */ >#define oid_resolv_cleanup() ((void)0) >#define subid_t guint32 > >It seems that the only place left that oid_resolv_cleanup() was called from >was epan.c so I submitted a patch to eliminate both. ( see >https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9295 ) > >The only place that subid_t is being used is in the asn1 plugin. When I >looked there to see about replacing them, it seems that there are many >functions in >that plugin which duplicate functionality implemented in oids.c. > I seem to recall that there is at least one other thing somewhere in the code >that exists >solely to support the asn1 plugin (but I couldn't remember what >that was). > >So there are two possible ways to proceed in cleaning up. One would be to >eliminate the asn1 plugin entirely. The other would be to update the >asn1 plugin code to eliminate such code anachronisms. I'd be willing to do >either, but don't know if there are any available test cases for using the >asn1 >plugin. I tried to use it once but didn't figure it out. > >So would anyone object to removing it from the codebase? And if so, can you >provide some sample for how it's used? I think we should probably remove it from the make files but leave the sources so it can be revived should any one require it. I don't think any active work Has been done on it for a very long time and I'm not sure if it's actually used by any one. I'd be glad to get rid of it :-) Regards Anders Ed ___ Sent via:Wireshark-dev mailing list Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe ___ Sent via:Wireshark-dev mailing list Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
