[Wireshark-dev] capturing on ppp interface on windows 7

2014-06-03 Thread Rahul Rohit
Hi,
Can winpcap be made to capture packets on PPP interface in case of windows 7 .


Regards
Rahul Rohit
DISCLAIMER: This message is proprietary to Aricent and is intended solely for 
the use of the individual to whom it is addressed. It may contain privileged or 
confidential information and should not be circulated or used for any purpose 
other than for what it is intended. If you have received this message in error, 
please notify the originator immediately. If you are not the intended 
recipient, you are notified that you are strictly prohibited from using, 
copying, altering, or disclosing the contents of this message. Aricent accepts 
no responsibility for loss or damage arising from the use of the information 
transmitted by this email including damage from virus.
___
Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org
Archives:http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

Re: [Wireshark-dev] capturing on ppp interface on windows 7

2014-06-03 Thread Guy Harris

On Jun 2, 2014, at 11:32 PM, Rahul Rohit rahul.ro...@aricent.com wrote:

 Can winpcap be made to capture packets on PPP interface in case of windows 7 .

It probably can, if you significantly rewrite it; for example, if you rewrote 
it to include a lightweight filter driver than a transport driver, that might 
do the job.

It can't, if you don't rewrite it.

___
Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org
Archives:http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe


Re: [Wireshark-dev] New mac cmake setup

2014-06-03 Thread Alexis La Goutte
Hi Evan,

On Tue, Jun 3, 2014 at 1:14 AM, gmail hsiv...@gmail.com wrote:
 I try against Macports.
 From my CMakeCache.txt

 GMODULE2_LDFLAGS:INTERNAL=-L/opt/local/lib;-lgmodule-2.0;-lglib-2.0;-lintl
 GMODULE2_LIBDIR:INTERNAL=/opt/local/lib
 GMODULE2_LIBRARIES:INTERNAL=gmodule-2.0;glib-2.0;intl

 = GMODULE2_LIBRARIES does not contain required link path on osx.

 Look likes a macro is missing …

 something like :
 link_directories(${GMODULE2_LIBDIR})
 or
 maybe set GMODULE2_LDFLAGS in wsutil_LIBS should be ok.

 H.sivank

 Le 3 juin 2014 à 00:21, Evan Huus eapa...@gmail.com a écrit :

 On Mon, Jun 2, 2014 at 1:24 PM, hsivank hsiv...@gmail.com wrote:

 If libmodule-2.0.dylib is installed inside /usr/local/lib on your machine,
 a library path is missing in your command (something like :
 -L/usr/local/lib)
 Quickly, You can overwrite some cache value inside CMakeCache.txt and
 add this missing path.
 Or you can take a look inside wsutil/CMakeLists.txt : i think
 GMODULE2_LIBRARIES should be set with wsutil_LIBS


 Hmm, thanks for the tips but something doesn't line up. GMODULE2_LIBRARIES
 is set in wsutil_LIBS, and contains the correct paths in CMakeCache.txt, but
 for some reason those paths aren't making it into the final command being
 run...


 H.sivank

 Le 2 juin 2014 à 18:52, Evan Huus a écrit :

 I'm trying to get an out-of-tree cmake build set up on a brand new mac.
 Cmake and the compiler seem to be working fine, but I'm having issues at
 link time. Specifically, I keep getting:

 ld: library not found for -lgmodule-2.0
 clang: error: linker command failed with exit code 1 (use -v to see
 invocation)

 with verbose mode, I get the following line being run:

 Linking C shared library ../run/libwsutil.dylib
 cd /Users/eapache/src/wireshark.org/build/wsutil 
 /usr/local/Cellar/cmake/2.8.12.2/bin/cmake -E cmake_link_script
 CMakeFiles/wsutil.dir/link.txt --verbose=1
 /usr/bin/cc   -Wall -W -Wextra -Wendif-labels -Wpointer-arith
 -Warray-bounds -Wformat-security -Wvla -Waddress -Wattributes -Wdiv-by-zero
 -Wignored-qualifiers -Wno-overlength-strings -Wwrite-strings -Wno-long-long
 -Wheader-guard -Qunused-arguments -Wc++-compat -Wdeclaration-after-statement
 -Wshadow -Wno-pointer-sign -Wold-style-definition -Wstrict-prototypes
 -Wshorten-64-to-32 -fvisibility=hidden -O2 -g -DNDEBUG -isysroot
 /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.9.sdk
 -dynamiclib -Wl,-headerpad_max_install_names   -o
 ../run/libwsutil.0.0.0.dylib -install_name
 /Users/eapache/src/wireshark.org/build/run/libwsutil.0.dylibCMakeFiles/wsutil.dir/adler32.c.o
 CMakeFiles/wsutil.dir/aes.c.o CMakeFiles/wsutil.dir/airpdcap_wep.c.o
 CMakeFiles/wsutil.dir/base64.c.o CMakeFiles/wsutil.dir/bitswap.c.o
 CMakeFiles/wsutil.dir/crash_info.c.o CMakeFiles/wsutil.dir/crc10.c.o
 CMakeFiles/wsutil.dir/crc16.c.o CMakeFiles/wsutil.dir/crc16-plain.c.o
 CMakeFiles/wsutil.dir/crc32.c.o CMakeFiles/wsutil.dir/crc6.c.o
 CMakeFiles/wsutil.dir/crc7.c.o CMakeFiles/wsutil.dir/crc8.c.o
 CMakeFiles/wsutil.dir/crc11.c.o CMakeFiles/wsutil.dir/crcdrm.c.o
 CMakeFiles/wsutil.dir/des.c.o CMakeFiles/wsutil.dir/eax.c.o
 CMakeFiles/wsutil.dir/filesystem.c.o CMakeFiles/wsutil.dir/g711.c.o
 CMakeFiles/wsutil.dir/md4.c.o CMakeFiles/wsutil.dir/md5.c.o
 CMakeFiles/wsutil.dir/mpeg-audio.c.o CMakeFiles/wsutil.dir/nstime.c.o
 CMakeFiles/wsutil.dir/plugins.c.o CMakeFiles/wsutil.dir/privileges.c.o
 CMakeFiles/wsutil.dir/sha1.c.o CMakeFiles/wsutil.dir/strnatcmp.c.o
 CMakeFiles/wsutil.dir/str_util.c.o CMakeFiles/wsutil.dir/rc4.c.o
 CMakeFiles/wsutil.dir/report_err.c.o CMakeFiles/wsutil.dir/tempfile.c.o
 CMakeFiles/wsutil.dir/time_util.c.o CMakeFiles/wsutil.dir/type_util.c.o
 CMakeFiles/wsutil.dir/u3.c.o CMakeFiles/wsutil.dir/unicode-utils.c.o
 CMakeFiles/wsutil.dir/nghttp2/nghttp2_buf.c.o
 CMakeFiles/wsutil.dir/nghttp2/nghttp2_hd.c.o
 CMakeFiles/wsutil.dir/nghttp2/nghttp2_hd_huffman.c.o
 CMakeFiles/wsutil.dir/nghttp2/nghttp2_hd_huffman_data.c.o
 CMakeFiles/wsutil.dir/nghttp2/nghttp2_helper.c.o
 -L/usr/local/opt/gettext/lib -lgmodule-2.0 -lglib-2.0 -lintl
 /usr/local/lib/libglib-2.0.dylib /usr/local/lib/libgcrypt.dylib
 /usr/local/lib/libgpg-error.dylib -Wl,-rpath,/usr/local/opt/gettext/lib

 Has anybody seen this before? A quick google turned up nothing. Does
 anyone with cmake experience know which knobs I might need to tweak? I do
 have glib installed...

You try to build with swift on Yosemite ? ;-)

I try with my VirtualBox Mac OS 10.9 and no problem with cmake and
gmodule (i have use mac-setup.sh for get glib and other stuff...)
I have disable kerberos (ENABLE_KERBEROS:BOOL=OFF) to get a build
(problem with deprecated function...)

But the autotools don't work... (Problem with libtool...)

Regards,


 Thanks,
 Evan

 ___
 Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org
 Archives:http://www.wireshark.org/lists/wireshark-dev
 Unsubscribe: 

Re: [Wireshark-dev] capturing on ppp interface on windows 7

2014-06-03 Thread Rahul Rohit
Hi ,
Can you please describe in detail as to which file is to be modified and what 
exactly to be done ?


Regards
Rahul Rohit
-Original Message-
From: wireshark-dev-boun...@wireshark.org 
[mailto:wireshark-dev-boun...@wireshark.org] On Behalf Of Guy Harris
Sent: Tuesday, June 03, 2014 12:15 PM
To: Developer support list for Wireshark
Subject: Re: [Wireshark-dev] capturing on ppp interface on windows 7


On Jun 2, 2014, at 11:32 PM, Rahul Rohit rahul.ro...@aricent.com wrote:

 Can winpcap be made to capture packets on PPP interface in case of windows 7 .

It probably can, if you significantly rewrite it; for example, if you rewrote 
it to include a lightweight filter driver than a transport driver, that might 
do the job.

It can't, if you don't rewrite it.

___
Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org
Archives:http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
DISCLAIMER: This message is proprietary to Aricent and is intended solely for 
the use of the individual to whom it is addressed. It may contain privileged or 
confidential information and should not be circulated or used for any purpose 
other than for what it is intended. If you have received this message in error, 
please notify the originator immediately. If you are not the intended 
recipient, you are notified that you are strictly prohibited from using, 
copying, altering, or disclosing the contents of this message. Aricent accepts 
no responsibility for loss or damage arising from the use of the information 
transmitted by this email including damage from virus.
___
Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org
Archives:http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe


Re: [Wireshark-dev] capturing on ppp interface on windows 7

2014-06-03 Thread Guy Harris

On Jun 3, 2014, at 12:48 AM, Rahul Rohit rahul.ro...@aricent.com wrote:

 Can you please describe in detail as to which file is to be modified

No, but I can suggest that, of the source files in the packetNtx/driver 
directory of the WinPcap source, Openclos.c, Packet.c, Read.c, and Write.c may 
have to be modified, and some others might have to be modified as well.  You 
might have to change some of the user-mode library code in packetNtx/Dll, and 
maybe even the packet-win32.c code in wpcap/libpcap.

 and what exactly to be done ?

Convert the code from a transport driver:


http://msdn.microsoft.com/en-us/library/windows/hardware/ff565685(v=vs.85).aspx

to a lightweight filter driver:


http://msdn.microsoft.com/en-us/library/windows/hardware/ff571103(v=vs.85).aspx

You will first have to learn about NDIS and writing kernel-mode code for 
Windows if you want to do this.  (No, I can't teach you how to do that.)

___
Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org
Archives:http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe


Re: [Wireshark-dev] New mac cmake setup

2014-06-03 Thread Evan Huus
On Mon, Jun 2, 2014 at 7:14 PM, gmail hsiv...@gmail.com wrote:

 I try against Macports.
 From my CMakeCache.txt

 GMODULE2_LDFLAGS:INTERNAL=-L/opt/local/lib;-lgmodule-2.0;-lglib-2.0;-lintl
 GMODULE2_LIBDIR:INTERNAL=/opt/local/lib
 GMODULE2_LIBRARIES:INTERNAL=gmodule-2.0;glib-2.0;intl

 = GMODULE2_LIBRARIES does not contain required link path on osx.

 Look likes a macro is missing …

 something like :
 link_directories(${GMODULE2_LIBDIR})
 or
 maybe set GMODULE2_LDFLAGS in wsutil_LIBS should be ok.


Ah, ya, thank you. I managed to get it working by playing with link paths
in CMakeCache.txt. I guess I should figure out why it needed tweaking in
the first place, but my knowledge of CMake is pretty limited at this point.


 H.sivank

 Le 3 juin 2014 à 00:21, Evan Huus eapa...@gmail.com a écrit :

 On Mon, Jun 2, 2014 at 1:24 PM, hsivank hsiv...@gmail.com wrote:

 If libmodule-2.0.dylib is installed inside /usr/local/lib on your
 machine, a library path is missing in your command (something like :
 -L/usr/local/lib)
 Quickly, You can overwrite some cache value inside CMakeCache.txt and
 add this missing path.
 Or you can take a look inside wsutil/CMakeLists.txt : i
 think GMODULE2_LIBRARIES should be set with wsutil_LIBS


 Hmm, thanks for the tips but something doesn't line up. GMODULE2_LIBRARIES
 is set in wsutil_LIBS, and contains the correct paths in CMakeCache.txt,
 but for some reason those paths aren't making it into the final command
 being run...


 H.sivank

 Le 2 juin 2014 à 18:52, Evan Huus a écrit :

 I'm trying to get an out-of-tree cmake build set up on a brand new mac.
 Cmake and the compiler seem to be working fine, but I'm having issues at
 link time. Specifically, I keep getting:

 ld: library not found for -lgmodule-2.0
 clang: error: linker command failed with exit code 1 (use -v to see
 invocation)

 with verbose mode, I get the following line being run:

 Linking C shared library ../run/libwsutil.dylib
 cd /Users/eapache/src/wireshark.org/build/wsutil 
 /usr/local/Cellar/cmake/2.8.12.2/bin/cmake -E cmake_link_script
 CMakeFiles/wsutil.dir/link.txt --verbose=1
 /usr/bin/cc   -Wall -W -Wextra -Wendif-labels -Wpointer-arith
 -Warray-bounds -Wformat-security -Wvla -Waddress -Wattributes -Wdiv-by-zero
 -Wignored-qualifiers -Wno-overlength-strings -Wwrite-strings -Wno-long-long
 -Wheader-guard -Qunused-arguments -Wc++-compat
 -Wdeclaration-after-statement -Wshadow -Wno-pointer-sign
 -Wold-style-definition -Wstrict-prototypes -Wshorten-64-to-32
 -fvisibility=hidden -O2 -g -DNDEBUG -isysroot
 /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.9.sdk
 -dynamiclib -Wl,-headerpad_max_install_names   -o
 ../run/libwsutil.0.0.0.dylib -install_name /Users/eapache/src/
 wireshark.org/build/run/libwsutil.0.dylibCMakeFiles/wsutil.dir/adler32.c.o
 CMakeFiles/wsutil.dir/aes.c.o CMakeFiles/wsutil.dir/airpdcap_wep.c.o
 CMakeFiles/wsutil.dir/base64.c.o CMakeFiles/wsutil.dir/bitswap.c.o
 CMakeFiles/wsutil.dir/crash_info.c.o CMakeFiles/wsutil.dir/crc10.c.o
 CMakeFiles/wsutil.dir/crc16.c.o CMakeFiles/wsutil.dir/crc16-plain.c.o
 CMakeFiles/wsutil.dir/crc32.c.o CMakeFiles/wsutil.dir/crc6.c.o
 CMakeFiles/wsutil.dir/crc7.c.o CMakeFiles/wsutil.dir/crc8.c.o
 CMakeFiles/wsutil.dir/crc11.c.o CMakeFiles/wsutil.dir/crcdrm.c.o
 CMakeFiles/wsutil.dir/des.c.o CMakeFiles/wsutil.dir/eax.c.o
 CMakeFiles/wsutil.dir/filesystem.c.o CMakeFiles/wsutil.dir/g711.c.o
 CMakeFiles/wsutil.dir/md4.c.o CMakeFiles/wsutil.dir/md5.c.o
 CMakeFiles/wsutil.dir/mpeg-audio.c.o CMakeFiles/wsutil.dir/nstime.c.o
 CMakeFiles/wsutil.dir/plugins.c.o CMakeFiles/wsutil.dir/privileges.c.o
 CMakeFiles/wsutil.dir/sha1.c.o CMakeFiles/wsutil.dir/strnatcmp.c.o
 CMakeFiles/wsutil.dir/str_util.c.o CMakeFiles/wsutil.dir/rc4.c.o
 CMakeFiles/wsutil.dir/report_err.c.o CMakeFiles/wsutil.dir/tempfile.c.o
 CMakeFiles/wsutil.dir/time_util.c.o CMakeFiles/wsutil.dir/type_util.c.o
 CMakeFiles/wsutil.dir/u3.c.o CMakeFiles/wsutil.dir/unicode-utils.c.o
 CMakeFiles/wsutil.dir/nghttp2/nghttp2_buf.c.o
 CMakeFiles/wsutil.dir/nghttp2/nghttp2_hd.c.o
 CMakeFiles/wsutil.dir/nghttp2/nghttp2_hd_huffman.c.o
 CMakeFiles/wsutil.dir/nghttp2/nghttp2_hd_huffman_data.c.o
 CMakeFiles/wsutil.dir/nghttp2/nghttp2_helper.c.o
 -L/usr/local/opt/gettext/lib -lgmodule-2.0 -lglib-2.0 -lintl
 /usr/local/lib/libglib-2.0.dylib /usr/local/lib/libgcrypt.dylib
 /usr/local/lib/libgpg-error.dylib -Wl,-rpath,/usr/local/opt/gettext/lib

 Has anybody seen this before? A quick google turned up nothing. Does
 anyone with cmake experience know which knobs I might need to tweak? I do
 have glib installed...

 Thanks,
 Evan

 ___
 Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org
 Archives:http://www.wireshark.org/lists/wireshark-dev
 Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev

 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
 

[Wireshark-dev] Is there a single document that describes converting from emem to wmem?

2014-06-03 Thread Richard Sharpe
Hi folks,

I have to get a plugin that was developed a while ago converted to wmem.

Is there a single document that describes the conversion process?

-- 
Regards,
Richard Sharpe
(何以解憂?唯有杜康。--曹操)
___
Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org
Archives:http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

Re: [Wireshark-dev] Reminder: 1.12 branch tomorrow

2014-06-03 Thread Bálint Réczey
Hi,

2014-05-23 6:33 GMT+07:00 Gerald Combs ger...@wireshark.org:
 Reminder: I'm going to create the master-1.12 branch along with the
 other changes listed below tomorrow.


  Original Message 
 Subject: 1.12 branch + release schedule
 Date: Mon, 19 May 2014 14:46:42 -0700
 From: Gerald Combs ger...@wireshark.org
 Organization: Wireshark Foundation
 To: Developer support list for Wireshark wireshark-dev@wireshark.org

 Hi,

 I'd like to create the 1.12 branch this Friday (May 23) followed by
 1.12.0rc1 in late May or early June. I'm planning on the following:


 In master-1.12:

 - Set the major.minor versions to 1.12.
 - Choose sensible names for the GTK+ and Qt binaries in the NSIS
   installer, e.g. Wireshark and Wireshark 2 preview
 - Enable GTK+ and disable Qt by default in the NSIS installer.
 - Switch the 64-bit OS X package back to GTK+ while quietly weeping[1].
 - Drop support for Windows XP[2].

I have uploaded 1.12.0 RC1 to Debian experimental using CMake as the
build system and shipping the Qt GUI in wireshark-qt package with the
binary qtshark renamed to wireshark-qt to help users in finding it
more easily:
http://packages.qa.debian.org/w/wireshark.html

Cheers,
Balint
___
Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org
Archives:http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe


Re: [Wireshark-dev] Is there a single document that describes converting from emem to wmem?

2014-06-03 Thread Evan Huus
On Tue, Jun 3, 2014 at 1:07 PM, Richard Sharpe realrichardsha...@gmail.com
wrote:

 Hi folks,

 I have to get a plugin that was developed a while ago converted to wmem.

 Is there a single document that describes the conversion process?


There isn't a conversion guide specifically, but doc/README.wmem was
written with conversion in mind. Read that, and if you still have questions
I'm happy to answer them.

--
 Regards,
 Richard Sharpe
 (何以解憂?唯有杜康。--曹操)
 ___
 Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org
 Archives:http://www.wireshark.org/lists/wireshark-dev
 Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
  mailto:wireshark-dev-requ...@wireshark.org
 ?subject=unsubscribe
___
Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org
Archives:http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

Re: [Wireshark-dev] [Wireshark-commits] master c5de173: MBIM: do not access to hash map when it is not initialized yet

2014-06-03 Thread Evan Huus
Just create it once in the init routine, rather than when the first uuid is
registered? Then you can guarantee it always exists.


On Tue, Jun 3, 2014 at 2:01 PM, Wireshark code review 
code-review-do-not-re...@wireshark.org wrote:

 URL:
 https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=c5de173edc09cceb7c351cf8b85a470ad597be17
 Submitter: Pascal Quantin (pascal.quan...@gmail.com)
 Changed: branch: master
 Repository: wireshark

 Commits:

 c5de173 by Pascal Quantin (pascal.quan...@gmail.com):

 MBIM: do not access to hash map when it is not initialized yet

 Change-Id: I560941115316ead5a85b9e0b55be693217fddff2
 Reviewed-on: https://code.wireshark.org/review/1940
 Reviewed-by: Pascal Quantin pascal.quan...@gmail.com


 Actions performed:

 from  9389d78   Qt: Export Object * Fix indent (remove tabs) * Add
 title to the window
 adds  c5de173   MBIM: do not access to hash map when it is not
 initialized yet


 Summary of changes:
  epan/dissectors/packet-mbim.c |2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
 ___
 Sent via:Wireshark-commits mailing list 
 wireshark-comm...@wireshark.org
 Archives:http://www.wireshark.org/lists/wireshark-commits
 Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
  mailto:wireshark-commits-requ...@wireshark.org
 ?subject=unsubscribe

___
Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org
Archives:http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

Re: [Wireshark-dev] [Wireshark-commits] master c5de173: MBIM: do not access to hash map when it is not initialized yet

2014-06-03 Thread Pascal Quantin
Hi Evan,

2014-06-03 20:09 GMT+02:00 Evan Huus eapa...@gmail.com:

 Just create it once in the init routine, rather than when the first uuid
 is registered? Then you can guarantee it always exists.


This is what I initially did but changed my mind at the last minute as
checking the existence of the table is less expensive than building the
lookup key and calling wmem_map_lookup while it will never succeed. So I
saw it as a micro optimization :)



 On Tue, Jun 3, 2014 at 2:01 PM, Wireshark code review 
 code-review-do-not-re...@wireshark.org wrote:

 URL:
 https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=c5de173edc09cceb7c351cf8b85a470ad597be17
 Submitter: Pascal Quantin (pascal.quan...@gmail.com)
 Changed: branch: master
 Repository: wireshark

 Commits:

 c5de173 by Pascal Quantin (pascal.quan...@gmail.com):

 MBIM: do not access to hash map when it is not initialized yet

 Change-Id: I560941115316ead5a85b9e0b55be693217fddff2
 Reviewed-on: https://code.wireshark.org/review/1940
 Reviewed-by: Pascal Quantin pascal.quan...@gmail.com


 Actions performed:

 from  9389d78   Qt: Export Object * Fix indent (remove tabs) * Add
 title to the window
 adds  c5de173   MBIM: do not access to hash map when it is not
 initialized yet


 Summary of changes:
  epan/dissectors/packet-mbim.c |2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

 ___
 Sent via:Wireshark-commits mailing list 
 wireshark-comm...@wireshark.org
 Archives:http://www.wireshark.org/lists/wireshark-commits
 Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
  mailto:wireshark-commits-requ...@wireshark.org
 ?subject=unsubscribe



 ___
 Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org
 Archives:http://www.wireshark.org/lists/wireshark-dev
 Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
  mailto:wireshark-dev-requ...@wireshark.org
 ?subject=unsubscribe

___
Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org
Archives:http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

Re: [Wireshark-dev] [Wireshark-commits] master c5de173: MBIM: do not access to hash map when it is not initialized yet

2014-06-03 Thread Evan Huus
On Tue, Jun 3, 2014 at 2:19 PM, Pascal Quantin pascal.quan...@gmail.com
wrote:

 Hi Evan,

 2014-06-03 20:09 GMT+02:00 Evan Huus eapa...@gmail.com:

 Just create it once in the init routine, rather than when the first uuid
 is registered? Then you can guarantee it always exists.


 This is what I initially did but changed my mind at the last minute as
 checking the existence of the table is less expensive than building the
 lookup key and calling wmem_map_lookup while it will never succeed. So I
 saw it as a micro optimization :)


Cool, I hadn't thought of that.



 On Tue, Jun 3, 2014 at 2:01 PM, Wireshark code review 
 code-review-do-not-re...@wireshark.org wrote:

 URL:
 https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=c5de173edc09cceb7c351cf8b85a470ad597be17
 Submitter: Pascal Quantin (pascal.quan...@gmail.com)
 Changed: branch: master
 Repository: wireshark

 Commits:

 c5de173 by Pascal Quantin (pascal.quan...@gmail.com):

 MBIM: do not access to hash map when it is not initialized yet

 Change-Id: I560941115316ead5a85b9e0b55be693217fddff2
 Reviewed-on: https://code.wireshark.org/review/1940
 Reviewed-by: Pascal Quantin pascal.quan...@gmail.com


 Actions performed:

 from  9389d78   Qt: Export Object * Fix indent (remove tabs) * Add
 title to the window
 adds  c5de173   MBIM: do not access to hash map when it is not
 initialized yet


 Summary of changes:
  epan/dissectors/packet-mbim.c |2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

 ___
 Sent via:Wireshark-commits mailing list 
 wireshark-comm...@wireshark.org
 Archives:http://www.wireshark.org/lists/wireshark-commits
 Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
  mailto:wireshark-commits-requ...@wireshark.org
 ?subject=unsubscribe




 ___
 Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org
 Archives:http://www.wireshark.org/lists/wireshark-dev
 Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
  mailto:wireshark-dev-requ...@wireshark.org
 ?subject=unsubscribe



 ___
 Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org
 Archives:http://www.wireshark.org/lists/wireshark-dev
 Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
  mailto:wireshark-dev-requ...@wireshark.org
 ?subject=unsubscribe

___
Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org
Archives:http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

Re: [Wireshark-dev] Compiling with GCC enabling sse4.2?

2014-06-03 Thread Jakub Zawadzki
Hi,

On Tue, Jun 03, 2014 at 08:37:49AM +, Anders Broman wrote:
 How do I go about compiling Wireshark with sse4.2 enabled? If I understand 
 correctly I should add GCC flag -march=native somewhere?

Anders, just to let you know your libc is already using sse4.2 and it shows up 
in your profiles:
  1,069,870 
/build/buildd/eglibc-2.17/string/../sysdeps/x86_64/multiarch/strcmp-sse42.S:__strcmp_
 **sse42** (37467x) [/lib/x86_64-linux-gnu/libc-2.17.so]
  1,832,321 
/build/buildd/eglibc-2.17/string/../sysdeps/x86_64/multiarch/strcmp-sse42.S:__strncmp_
 **sse42** (66829x) [/lib/x86_64-linux-gnu/libc-2.17.so]

I'm not sure if your $CC will generate more sse4.2 in wireshark, still for sure 
if you pass -march=native -O3 it should be faster,
(it should be even more faster when you compile with -flto ;)).


Anyway the proper way for autotools is to do:

 export CFLAGS=-O2 -march=native -pipe
 ./configure


Cheers,
Jakub.
___
Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org
Archives:http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe


[Wireshark-dev] Building with QT on Windows using VS 2013

2014-06-03 Thread Graham Bloice
Experimenting using VS2013 (Pro) to build Wireshark, I ran into some QT
issues and for posterity thought I'd list them here:

   1. You need a VS2013 compatible version of QT, I used
   qt-opensource-windows-x86-msvc2013-5.3.0.exe.  I can't remember if I forced
   the install to C:\QT, but it ended up in C:\QT\QT5.3.0.
   2. Set QT5_BASE_DIR to the bin directory of the install, in my case
   C:\Qt\Qt5.3.0\5.3\msvc2013\bin.
   3. nmake as normal.
   4. qtshark won't run from the wireshark-qt-release directory as not all
   the required DLL's have been copied over.  Using the windeployqt tool from
   the qt bin dir showed the required list (some had already been copied by
   the build) as:

wireshark-qt-release\icuin52.dll
wireshark-qt-release\icuuc52.dll
wireshark-qt-release\icudt52.dll
wireshark-qt-release\Qt5Cored.dll
wireshark-qt-release\Qt5Guid.dll
wireshark-qt-release\Qt5PrintSupportd.dll
wireshark-qt-release\Qt5Widgetsd.dll
wireshark-qt-release\libEGLd.dll
wireshark-qt-release\libGLESv2d.dll
wireshark-qt-release\D3Dcompiler_47.dll
wireshark-qt-release\accessible\qtaccessiblequickd.dll
wireshark-qt-release\accessible\qtaccessiblewidgetsd.dll
wireshark-qt-release\iconengines\qsvgicond.dll
wireshark-qt-release\imageformats\qddsd.dll
wireshark-qt-release\imageformats\qgifd.dll
wireshark-qt-release\imageformats\qicnsd.dll
wireshark-qt-release\imageformats\qicod.dll
wireshark-qt-release\imageformats\qjp2d.dll
wireshark-qt-release\imageformats\qjpegd.dll
wireshark-qt-release\imageformats\qmngd.dll
wireshark-qt-release\imageformats\qsvgd.dll
wireshark-qt-release\imageformats\qtgad.dll
wireshark-qt-release\imageformats\qtiffd.dll
wireshark-qt-release\imageformats\qwbmpd.dll
wireshark-qt-release\imageformats\qwebpd.dll
wireshark-qt-release\platforms\qwindowsd.dll
wireshark-qt-release\printsupport\windowsprintersupportd.dll

After this qtshark runs.

Note windeployqt will also copy all the files as well as list them, I think
we should use it in the build.

-- 

Graham Bloice
___
Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org
Archives:http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

Re: [Wireshark-dev] Building with QT on Windows using VS 2013

2014-06-03 Thread Graham Bloice
On 3 June 2014 22:59, Graham Bloice graham.blo...@trihedral.com wrote:

 Experimenting using VS2013 (Pro) to build Wireshark, I ran into some QT
 issues and for posterity thought I'd list them here:

1. You need a VS2013 compatible version of QT, I used
qt-opensource-windows-x86-msvc2013-5.3.0.exe.  I can't remember if I forced
the install to C:\QT, but it ended up in C:\QT\QT5.3.0.
2. Set QT5_BASE_DIR to the bin directory of the install, in my case
C:\Qt\Qt5.3.0\5.3\msvc2013\bin.
3. nmake as normal.
4. qtshark won't run from the wireshark-qt-release directory as not
all the required DLL's have been copied over.  Using the windeployqt tool
from the qt bin dir showed the required list (some had already been copied
by the build) as:

 wireshark-qt-release\icuin52.dll
 wireshark-qt-release\icuuc52.dll
 wireshark-qt-release\icudt52.dll
 wireshark-qt-release\Qt5Cored.dll
 wireshark-qt-release\Qt5Guid.dll
 wireshark-qt-release\Qt5PrintSupportd.dll
 wireshark-qt-release\Qt5Widgetsd.dll
 wireshark-qt-release\libEGLd.dll
 wireshark-qt-release\libGLESv2d.dll
 wireshark-qt-release\D3Dcompiler_47.dll
 wireshark-qt-release\accessible\qtaccessiblequickd.dll
 wireshark-qt-release\accessible\qtaccessiblewidgetsd.dll
 wireshark-qt-release\iconengines\qsvgicond.dll
 wireshark-qt-release\imageformats\qddsd.dll
 wireshark-qt-release\imageformats\qgifd.dll
 wireshark-qt-release\imageformats\qicnsd.dll
 wireshark-qt-release\imageformats\qicod.dll
 wireshark-qt-release\imageformats\qjp2d.dll
 wireshark-qt-release\imageformats\qjpegd.dll
 wireshark-qt-release\imageformats\qmngd.dll
 wireshark-qt-release\imageformats\qsvgd.dll
 wireshark-qt-release\imageformats\qtgad.dll
 wireshark-qt-release\imageformats\qtiffd.dll
 wireshark-qt-release\imageformats\qwbmpd.dll
 wireshark-qt-release\imageformats\qwebpd.dll
 wireshark-qt-release\platforms\qwindowsd.dll
 wireshark-qt-release\printsupport\windowsprintersupportd.dll


Oops.  Need some more DLLS's I left off the list:

gtk2\bin\libgcc_s_sjlj-1.dll
libGLESv2.dll
libEGL.dll

It looks as though windeployqt copied the debug versions over for some
reason and nmake failed to copy the gtk dll


 After this qtshark runs.

 Note windeployqt will also copy all the files as well as list them, I
 think we should use it in the build.

 --

 Graham Bloice




-- 
Graham Bloice
___
Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org
Archives:http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

Re: [Wireshark-dev] Is there a single document that describes converting from emem to wmem?

2014-06-03 Thread Richard Sharpe
On Tue, Jun 3, 2014 at 10:13 AM, Evan Huus eapa...@gmail.com wrote:

 On Tue, Jun 3, 2014 at 1:07 PM, Richard Sharpe realrichardsha...@gmail.com
 wrote:

 Hi folks,

 I have to get a plugin that was developed a while ago converted to wmem.

 Is there a single document that describes the conversion process?


 There isn't a conversion guide specifically, but doc/README.wmem was written
 with conversion in mind. Read that, and if you still have questions I'm
 happy to answer them.

Thanks. Got is converted eventually ...

-- 
Regards,
Richard Sharpe
(何以解憂?唯有杜康。--曹操)
___
Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org
Archives:http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe