[Wireshark-dev] Expert "name" field in same name space as hf[] "abbrev" field ?
Since both the ei_register_info "'name' field and the hf_register_info
'abbrev' field can be used as filters I expect that they effectively are
in the same name space and thus there should not be a matching
'name'/'abbrev' between the ei[] entries and the hf[] entries in a
dissector.
Is this correct ?
If so, I would have expected matching entries (ei[] 'name' vs hf[]
'abbrev') to have been detected and rejected.
AFAIKT, matching entries ('name"/"abbrev') apparently aren't being
rejected. (See packet-mausb.c).
Thoughts ?
Bill
___
Sent via:Wireshark-dev mailing list
Archives:http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
Re: [Wireshark-dev] Adding trace to buildbot for fuzz testing
On 8/25/2014 3:37 PM, Stalley, Sean wrote: Hello All, I have a trace that I would like to add to the buildbot for regression testing. I uploaded it here: https://bugs.wireshark.org/bugzilla/attachment.cgi?id=13015&action=edit Is there a way I can add this trace to the list of traces that the buildbot runs? Thanks, Sean The MAUSB dissector does not register for a TCP port (i.e., the default port is 0). So: MAUSB TCP captures read by Wireshark (default configuration) won't be dissected. Unfortunately, we don't currently have a solution for that (altho ISTR that there's been suggestions to somehow include Wireshark configuration information in PCAPNG files). (The MAUSB SNAP capture files will be dissected and thus at least those will exercise the dissector during buildbot fuzz-testing). Bill ___ Sent via:Wireshark-dev mailing list Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
[Wireshark-dev] Adding trace to buildbot for fuzz testing
Hello All, I have a trace that I would like to add to the buildbot for regression testing. I uploaded it here: https://bugs.wireshark.org/bugzilla/attachment.cgi?id=13015&action=edit Is there a way I can add this trace to the list of traces that the buildbot runs? Thanks, Sean ___ Sent via:Wireshark-dev mailing list Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
Re: [Wireshark-dev] Adding trace to buildbot for fuzz testing
If things are working normally, it will get picked up automatically. On Mon, Aug 25, 2014 at 3:37 PM, Stalley, Sean wrote: > Hello All, > > I have a trace that I would like to add to the buildbot for regression > testing. I uploaded it here: > > https://bugs.wireshark.org/bugzilla/attachment.cgi?id=13015&action=edit > > > > Is there a way I can add this trace to the list of traces that the buildbot > runs? > > > > Thanks, > > Sean > > > ___ > Sent via:Wireshark-dev mailing list > Archives:http://www.wireshark.org/lists/wireshark-dev > Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev > mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe ___ Sent via:Wireshark-dev mailing list Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
Re: [Wireshark-dev] Gerrit patches with trailing whitespace
On 25 August 2014 20:03, Joerg Mayer wrote: > On Mon, Aug 25, 2014 at 06:06:15PM +0100, Graham Bloice wrote: > > When reviewing some submissions on Gerrit, I've noted a few with trailing > > whitespace. The git pre-commit hook always warns me of this, so how are > > folks managing to do this? Are they using clients that ignore the hook? > > How about adding a test to our build systems: > > If we are part of a git repo and .git/hooks/pre-commit doesn't exist > then print a message at the end of the build that in case of an intended > submission the file should be installed first. > > +1 -- Graham Bloice ___ Sent via:Wireshark-dev mailing list Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
Re: [Wireshark-dev] Gerrit patches with trailing whitespace
On Mon, Aug 25, 2014 at 06:06:15PM +0100, Graham Bloice wrote: > When reviewing some submissions on Gerrit, I've noted a few with trailing > whitespace. The git pre-commit hook always warns me of this, so how are > folks managing to do this? Are they using clients that ignore the hook? How about adding a test to our build systems: If we are part of a git repo and .git/hooks/pre-commit doesn't exist then print a message at the end of the build that in case of an intended submission the file should be installed first. Ciao Jörg -- Joerg Mayer We are stuck with technology when what we really want is just stuff that works. Some say that should read Microsoft instead of technology. ___ Sent via:Wireshark-dev mailing list Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
Re: [Wireshark-dev] Gerrit patches with trailing whitespace
On 8/25/2014 1:48 PM, Alexis La Goutte wrote: Should we add some info then to the Dev Guide as to where to get the hook, It's already in http://wiki.wireshark.org/Development/SubmittingPatches#Setup We keep running into this problem - should the wiki page and the dev guide be consolidated? and also run a server-side hook to reject the push? +1 if we can figure out how to return a nice error message explanation and not just "Your change was rejected by the remote server." -1 or only trailing whitespace check for the moment... ;-) I agree with Alexis. The hook needs work, which I started to do, but then I guess I lost interest when the work got to be "bigger than a breadbox" and then didn't announce that I was no longer working on making changes to the hook. Bill ___ Sent via:Wireshark-dev mailing list Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
Re: [Wireshark-dev] Gerrit patches with trailing whitespace
On Mon, Aug 25, 2014 at 7:32 PM, Evan Huus wrote: > On Mon, Aug 25, 2014 at 1:21 PM, Graham Bloice > wrote: >> On 25 August 2014 18:17, Graham Bloice wrote: >>> >>> On 25 August 2014 18:11, Juan Jose Martin Carrascosa >>> wrote: I think that you are talking about my just committed changes. I just did it and I just checked in the website that it has the whitespaces... As Evan said, I don't have it installed by default and I wasn't really aware of the process (even reading the doc a couple of times). I am really sorry. I will take a look at how to "stop" my changes from being reviewed and fix it. Thanks! Juanjo >>> >>> >>> It's just a trivial thing to have to go around the submission loop once >>> again. Annoying for both the submitter and the reviewer, as we all know >>> trailing white space is a heinous crime :-) >>> >>> Did git-review install the hook for me, I can't think where else it came >>> from? >>> >> >> Should we add some info then to the Dev Guide as to where to get the hook, > > It's already in http://wiki.wireshark.org/Development/SubmittingPatches#Setup > > We keep running into this problem - should the wiki page and the dev > guide be consolidated? > >> and also run a server-side hook to reject the push? > > +1 if we can figure out how to return a nice error message explanation > and not just "Your change was rejected by the remote server." -1 or only trailing whitespace check for the moment... ;-) > >> -- >> Graham Bloice >> >> ___ >> Sent via:Wireshark-dev mailing list >> Archives:http://www.wireshark.org/lists/wireshark-dev >> Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev >> mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe > ___ > Sent via:Wireshark-dev mailing list > Archives:http://www.wireshark.org/lists/wireshark-dev > Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev > mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe ___ Sent via:Wireshark-dev mailing list Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
Re: [Wireshark-dev] Gerrit patches with trailing whitespace
On Mon, Aug 25, 2014 at 1:21 PM, Graham Bloice wrote: > On 25 August 2014 18:17, Graham Bloice wrote: >> >> On 25 August 2014 18:11, Juan Jose Martin Carrascosa >> wrote: >>> >>> I think that you are talking about my just committed changes. I just did >>> it and I just checked in the website that it has the whitespaces... >>> >>> As Evan said, I don't have it installed by default and I wasn't really >>> aware of the process (even reading the doc a couple of times). I am really >>> sorry. >>> >>> I will take a look at how to "stop" my changes from being reviewed and >>> fix it. >>> >>> Thanks! >>> Juanjo >> >> >> It's just a trivial thing to have to go around the submission loop once >> again. Annoying for both the submitter and the reviewer, as we all know >> trailing white space is a heinous crime :-) >> >> Did git-review install the hook for me, I can't think where else it came >> from? >> > > Should we add some info then to the Dev Guide as to where to get the hook, It's already in http://wiki.wireshark.org/Development/SubmittingPatches#Setup We keep running into this problem - should the wiki page and the dev guide be consolidated? > and also run a server-side hook to reject the push? +1 if we can figure out how to return a nice error message explanation and not just "Your change was rejected by the remote server." > -- > Graham Bloice > > ___ > Sent via:Wireshark-dev mailing list > Archives:http://www.wireshark.org/lists/wireshark-dev > Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev > mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe ___ Sent via:Wireshark-dev mailing list Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
Re: [Wireshark-dev] Gerrit patches with trailing whitespace
On 25 August 2014 18:17, Graham Bloice wrote: > On 25 August 2014 18:11, Juan Jose Martin Carrascosa > wrote: > >> I think that you are talking about my just committed changes. I just did >> it and I just checked in the website that it has the whitespaces... >> >> As Evan said, I don't have it installed by default and I wasn't really >> aware of the process (even reading the doc a couple of times). I am really >> sorry. >> >> I will take a look at how to "stop" my changes from being reviewed and >> fix it. >> >> Thanks! >> Juanjo >> > > It's just a trivial thing to have to go around the submission loop once > again. Annoying for both the submitter and the reviewer, as we all know > trailing white space is a heinous crime :-) > > Did git-review install the hook for me, I can't think where else it came > from? > > Should we add some info then to the Dev Guide as to where to get the hook, and also run a server-side hook to reject the push? -- Graham Bloice ___ Sent via:Wireshark-dev mailing list Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
Re: [Wireshark-dev] Gerrit patches with trailing whitespace
On 25 August 2014 18:11, Juan Jose Martin Carrascosa wrote: > I think that you are talking about my just committed changes. I just did > it and I just checked in the website that it has the whitespaces... > > As Evan said, I don't have it installed by default and I wasn't really > aware of the process (even reading the doc a couple of times). I am really > sorry. > > I will take a look at how to "stop" my changes from being reviewed and fix > it. > > Thanks! > Juanjo > It's just a trivial thing to have to go around the submission loop once again. Annoying for both the submitter and the reviewer, as we all know trailing white space is a heinous crime :-) Did git-review install the hook for me, I can't think where else it came from? -- Graham Bloice ___ Sent via:Wireshark-dev mailing list Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
Re: [Wireshark-dev] Gerrit patches with trailing whitespace
I think that you are talking about my just committed changes. I just did it and I just checked in the website that it has the whitespaces... As Evan said, I don't have it installed by default and I wasn't really aware of the process (even reading the doc a couple of times). I am really sorry. I will take a look at how to "stop" my changes from being reviewed and fix it. Thanks! Juanjo On Mon, Aug 25, 2014 at 7:08 PM, Evan Huus wrote: > Probably they are simply not installing the hook - none of our tooling > sets it up by default that I'm aware of. > > On Mon, Aug 25, 2014 at 1:06 PM, Graham Bloice > wrote: > > When reviewing some submissions on Gerrit, I've noted a few with trailing > > whitespace. The git pre-commit hook always warns me of this, so how are > > folks managing to do this? Are they using clients that ignore the hook? > > > > -- > > Graham Bloice > > > > > ___ > > Sent via:Wireshark-dev mailing list > > Archives:http://www.wireshark.org/lists/wireshark-dev > > Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev > > mailto:wireshark-dev-requ...@wireshark.org > ?subject=unsubscribe > ___ > Sent via:Wireshark-dev mailing list > Archives:http://www.wireshark.org/lists/wireshark-dev > Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev > mailto:wireshark-dev-requ...@wireshark.org > ?subject=unsubscribe > > ___ Sent via:Wireshark-dev mailing list Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
[Wireshark-dev] Gerrit patches with trailing whitespace
When reviewing some submissions on Gerrit, I've noted a few with trailing whitespace. The git pre-commit hook always warns me of this, so how are folks managing to do this? Are they using clients that ignore the hook? -- Graham Bloice ___ Sent via:Wireshark-dev mailing list Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
Re: [Wireshark-dev] Gerrit patches with trailing whitespace
Probably they are simply not installing the hook - none of our tooling sets it up by default that I'm aware of. On Mon, Aug 25, 2014 at 1:06 PM, Graham Bloice wrote: > When reviewing some submissions on Gerrit, I've noted a few with trailing > whitespace. The git pre-commit hook always warns me of this, so how are > folks managing to do this? Are they using clients that ignore the hook? > > -- > Graham Bloice > > ___ > Sent via:Wireshark-dev mailing list > Archives:http://www.wireshark.org/lists/wireshark-dev > Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev > mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe ___ Sent via:Wireshark-dev mailing list Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
Re: [Wireshark-dev] [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.6 x64
sorry, my fault I merge two things in the wrong order master should build ok now Thus wrote buildbot-no-re...@wireshark.org (buildbot-no-re...@wireshark.org): > The Buildbot has detected a new failure on builder OSX 10.6 x64 while > building wireshark. > Full details are available at: > http://buildbot.wireshark.org/trunk/builders/OSX%2010.6%20x64/builds/5016 > Buildbot URL: http://buildbot.wireshark.org/trunk/ > Buildslave for this Build: osx-10.6-x64 > Build Reason: scheduler > Build Source Stamp: [branch master] c284e1211296361d1548e8f98a7ccc51c621019f > Blamelist: Martin Kaiser > BUILD FAILED: failed compile > sincerely, > -The Buildbot > ___ > Sent via:Wireshark-commits mailing list > Archives:http://www.wireshark.org/lists/wireshark-commits > Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits > > mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe ___ Sent via:Wireshark-dev mailing list Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
Re: [Wireshark-dev] Should labels in the tree view for the 802.11ad dissector additions conform to the spec?
Oops, screen shot now attached ... On Mon, Aug 25, 2014 at 12:39 AM, Anders Broman wrote: > > > > > From: wireshark-dev-boun...@wireshark.org > [mailto:wireshark-dev-boun...@wireshark.org] On Behalf Of Richard Sharpe > Sent: den 25 augusti 2014 00:06 > To: Developer support list for Wireshark > Subject: [Wireshark-dev] Should labels in the tree view for the 802.11ad > dissector additions conform to the spec? > > > > Hi folks, > > > > I notice, as in the attached screen shot, that the 802.11ad dissector > additions label the field that the spec (available for free from > http://standards.ieee.org/getieee802/download/802.11ad-2012.pdf) calls the > Control Frame Extension simply as the Extension. > > > > While it could be considered obvious, I tend to believe that it should > conform fully to the spec. > > > > Any thoughts? > > > > Although no screen shot attached, I agree using the name from the spec is > the way to go. > > Regards > > Anders > > > ___ > Sent via:Wireshark-dev mailing list > Archives:http://www.wireshark.org/lists/wireshark-dev > Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev > mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe -- Regards, Richard Sharpe (何以解憂？唯有杜康。--曹操) ___ Sent via:Wireshark-dev mailing list Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
Re: [Wireshark-dev] Should labels in the tree view for the 802.11ad dissector additions conform to the spec?
From: wireshark-dev-boun...@wireshark.org [mailto:wireshark-dev-boun...@wireshark.org] On Behalf Of Richard Sharpe Sent: den 25 augusti 2014 00:06 To: Developer support list for Wireshark Subject: [Wireshark-dev] Should labels in the tree view for the 802.11ad dissector additions conform to the spec? Hi folks, I notice, as in the attached screen shot, that the 802.11ad dissector additions label the field that the spec (available for free from http://standards.ieee.org/getieee802/download/802.11ad-2012.pdf) calls the Control Frame Extension simply as the Extension. While it could be considered obvious, I tend to believe that it should conform fully to the spec. Any thoughts? Although no screen shot attached, I agree using the name from the spec is the way to go. Regards Anders ___ Sent via:Wireshark-dev mailing list Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
