Re: [Wireshark-dev] Failing to push to gerrit
On 7 September 2014 23:51, Martin Mathieson < martin.r.mathie...@googlemail.com> wrote: > I hadn't updated git-review since I first installed it, but running > > $ pip install -U git-review > Requirement already up-to-date: git-review in c:\python27\lib\site-packages > Cleaning up... > > showed that I was apparently already at the latest version. > > > A little late to the conversation (I was on vacation), but git-review does have a `--version` parameter. FWIW I'm currently running 1.24 with Python 2.7.6 on Windows 7. Are you running your git ops in a Cygwin shell? Doesn't that cause issues with line-endings? -- Graham Bloice ___ Sent via:Wireshark-dev mailing list Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
Re: [Wireshark-dev] Valgrind profiling results gone bad
>The culprit seems to be proto_tre_add_item() does any one know what changed? >and why? Hi, Looking further into it I think the regression is introduced in commit 5460d7fa0cd13f84ff567c96ee89d07b37cd4b62 https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=5460d7fa0cd13f84ff567c96ee89d07b37cd4b62 I suspect (PTREE_FINFO(tree)->ds_tvb May be NULL if the previous item was faked. Regards Anders ___ Sent via:Wireshark-dev mailing list Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
Re: [Wireshark-dev] Failing to push to gerrit
Hi Graham, I am running git inside a Cygwin shell. I didn't notice any issues wth line-endings. I cannot run git-review even to print the version. I did manually delete the entries for git-review in the scripts and lib folders and reinstalled, but still see the following error: $ git-review --version Traceback (most recent call last): File "C:\Python27\lib\runpy.py", line 162, in _run_module_as_main "__main__", fname, loader, pkg_name) File "C:\Python27\lib\runpy.py", line 72, in _run_code exec code in run_globals File "C:\Python27\Scripts\git-review.exe\__main__.py", line 9, in File "C:\Python27\lib\site-packages\git_review\cmd.py", line 1132, in main (os.path.split(sys.argv[0])[-1], get_version())) File "C:\Python27\lib\site-packages\git_review\cmd.py", line 180, in get_version provider = pkg_resources.get_provider(requirement) File "C:\Python27\lib\site-packages\setuptools-0.6c11-py2.7.egg\pkg_resources.py", line 197, in get_provider File "C:\Python27\lib\site-packages\setuptools-0.6c11-py2.7.egg\pkg_resources.py", line 666, in require File "C:\Python27\lib\site-packages\setuptools-0.6c11-py2.7.egg\pkg_resources.py", line 565, in resolve pkg_resources.DistributionNotFound: git-review mmathie2@mmathie2-WS /cygdrive/c/wireshark-git I don't understand egg files. At git_review\gmd.py:180 it is doing: provider = pkg_resources.get_provider(requirement) The .egg file does exist, I don't know what goes wrong inside it. Best regards, Martin On Thu, Sep 11, 2014 at 11:54 AM, Graham Bloice wrote: > On 7 September 2014 23:51, Martin Mathieson < > martin.r.mathie...@googlemail.com> wrote: > >> I hadn't updated git-review since I first installed it, but running >> >> $ pip install -U git-review >> Requirement already up-to-date: git-review in >> c:\python27\lib\site-packages >> Cleaning up... >> >> showed that I was apparently already at the latest version. >> >> >> > A little late to the conversation (I was on vacation), but git-review does > have a `--version` parameter. FWIW I'm currently running 1.24 with Python > 2.7.6 on Windows 7. > > Are you running your git ops in a Cygwin shell? Doesn't that cause issues > with line-endings? > > -- > Graham Bloice > > > ___ > Sent via:Wireshark-dev mailing list > Archives:http://www.wireshark.org/lists/wireshark-dev > Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev > mailto:wireshark-dev-requ...@wireshark.org > ?subject=unsubscribe > ___ Sent via:Wireshark-dev mailing list Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
Re: [Wireshark-dev] Failing to push to gerrit
On 11 September 2014 18:11, Martin Mathieson < martin.r.mathie...@googlemail.com> wrote: > Hi Graham, > > I am running git inside a Cygwin shell. I didn't notice any issues wth > line-endings. > So are you using Cygwin git or Windows git? > > I cannot run git-review even to print the version. I did manually delete > the entries for git-review in the scripts and lib folders and reinstalled, > but still see the following error: > > $ git-review --version > Traceback (most recent call last): > File "C:\Python27\lib\runpy.py", line 162, in _run_module_as_main > "__main__", fname, loader, pkg_name) > File "C:\Python27\lib\runpy.py", line 72, in _run_code > exec code in run_globals > File "C:\Python27\Scripts\git-review.exe\__main__.py", line 9, in > > File "C:\Python27\lib\site-packages\git_review\cmd.py", line 1132, in > main > (os.path.split(sys.argv[0])[-1], get_version())) > File "C:\Python27\lib\site-packages\git_review\cmd.py", line 180, in > get_version > provider = pkg_resources.get_provider(requirement) > File > "C:\Python27\lib\site-packages\setuptools-0.6c11-py2.7.egg\pkg_resources.py", > line 197, in get_provider > File > "C:\Python27\lib\site-packages\setuptools-0.6c11-py2.7.egg\pkg_resources.py", > line 666, in require > File > "C:\Python27\lib\site-packages\setuptools-0.6c11-py2.7.egg\pkg_resources.py", > line 565, in resolve > pkg_resources.DistributionNotFound: git-review > > mmathie2@mmathie2-WS /cygdrive/c/wireshark-git > > I don't understand egg files. At git_review\gmd.py:180 it is doing: > provider = pkg_resources.get_provider(requirement) > The .egg file does exist, I don't know what goes wrong inside it. > > > Could the issue be running Windows Python and Windows git-review in the Cygwin shell (possibly with Cygwin git)? I use Windows git for all my git\Gerrit work along with Windows Python in a PowerShell, er, shell. Can you try running `C:\Python27\Scripts\git-review --version` in a Windows Command Prompt or PowerShell? An egg is a Python application distribution unit, similar to a java .jar file. See http://peak.telecommunity.com/DevCenter/PythonEggs -- Graham Bloice ___ Sent via:Wireshark-dev mailing list Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
Re: [Wireshark-dev] Failing to push to gerrit
On Thu, Sep 11, 2014 at 6:31 PM, Graham Bloice wrote: > On 11 September 2014 18:11, Martin Mathieson < > martin.r.mathie...@googlemail.com> wrote: > >> Hi Graham, >> >> I am running git inside a Cygwin shell. I didn't notice any issues wth >> line-endings. >> > > So are you using Cygwin git or Windows git? > $ git --version git version 1.9.0.msysgit.0 I think this is Windows git? >> I cannot run git-review even to print the version. I did manually delete >> the entries for git-review in the scripts and lib folders and reinstalled, >> but still see the following error: >> >> $ git-review --version >> Traceback (most recent call last): >> File "C:\Python27\lib\runpy.py", line 162, in _run_module_as_main >> "__main__", fname, loader, pkg_name) >> File "C:\Python27\lib\runpy.py", line 72, in _run_code >> exec code in run_globals >> File "C:\Python27\Scripts\git-review.exe\__main__.py", line 9, in >> >> File "C:\Python27\lib\site-packages\git_review\cmd.py", line 1132, in >> main >> (os.path.split(sys.argv[0])[-1], get_version())) >> File "C:\Python27\lib\site-packages\git_review\cmd.py", line 180, in >> get_version >> provider = pkg_resources.get_provider(requirement) >> File >> "C:\Python27\lib\site-packages\setuptools-0.6c11-py2.7.egg\pkg_resources.py", >> line 197, in get_provider >> File >> "C:\Python27\lib\site-packages\setuptools-0.6c11-py2.7.egg\pkg_resources.py", >> line 666, in require >> File >> "C:\Python27\lib\site-packages\setuptools-0.6c11-py2.7.egg\pkg_resources.py", >> line 565, in resolve >> pkg_resources.DistributionNotFound: git-review >> >> mmathie2@mmathie2-WS /cygdrive/c/wireshark-git >> >> I don't understand egg files. At git_review\gmd.py:180 it is doing: >> provider = pkg_resources.get_provider(requirement) >> The .egg file does exist, I don't know what goes wrong inside it. >> >> >> > Could the issue be running Windows Python and Windows git-review in the > Cygwin shell (possibly with Cygwin git)? > > I use Windows git for all my git\Gerrit work along with Windows Python in > a PowerShell, er, shell. > > Can you try running `C:\Python27\Scripts\git-review --version` in a > Windows Command Prompt or PowerShell? > > Running in a Windows Command Prompt gives me the same stack trace as above. > An egg is a Python application distribution unit, similar to a java .jar > file. See http://peak.telecommunity.com/DevCenter/PythonEggs > > > > -- > Graham Bloice > I am finding that I can push from my master branch, which I'd rather not do, but that I need to do 'git rebase' every time now. When I create another topic branch from master, I cannot push from it, even after rebasing. I really don't know what I did to my setup, as git-review used to work. I have taken to writing scripts in python now, and did try to get python3 installed a while back, though it would crash upon startup. I just tried uninstalling python3 but it doesn't seem to have helped. Thanks, Martin ___ Sent via:Wireshark-dev mailing list Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
[Wireshark-dev] rtp player codec plugin issue
Hi every one.I'm trying to wirte a g729 codec plugin using bcg729 in
windows7.I consult the easy_codec plugin and write the plugin.The plugin
is complied and loaded ok.The problem i encountered is below:
main(wireshark\codecs\codecs.c):
static GHashTable *registered_codecs = NULL;
...
gboolean
register_codec(const char *name, codec_init_fn init_fn, codec_release_fn
release_fn,
codec_get_channels_fn channels_fn, codec_get_frequency_fn frequency_fn,
codec_decode_fn decode_fn)
{
...
}
myplugin(bcg729_codec_plugin.c):
WS_DLL_PUBLIC_DEF void register_codec_module(void)
{
register_codec("g729", codec_g729_init, codec_g729_release,
codec_g729_get_channels, codec_g729_get_frequency, codec_g729_decode);
}
The problem is when the main load the plugin and call plugin's
register_cdec_moule fucntion, they don't share the same
registered_codecs instance.
This problem can be demonstrated by below code:
test.c:
#include
extern void increase();
extern void subcall();
int main(void)
{
printf("main start:\n");
increase();
subcall();
printf("main end:\n");
}
increase.c:
#include
static s_value = 0;
void increase()
{
s_value++;
printf("s_value=[%d]\n", s_value);
}
subcall.c:
#include
#define EXPORT __declspec(dllexport)
extern void increase();
void EXPORT subcall(void)
{
printf("subcall start:\n");
increase();
printf("subcall end:\n");
}
build.bat:
cl -c increase.c
link /lib increase.obj
cl /LD subcall.c increase.lib
cl test.c subcall.lib increase.lib
The result of test is:
main start:
s_value=[1]
subcall start:
s_value=[1]
subcall end:
main end:
Can anyont give me some tips on how to fix this issue.Thanks.Sorry for
my poor english.
___
Sent via:Wireshark-dev mailing list
Archives:http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
