Re: [Wireshark-dev] hadoop dissector
Maybe some developer like to "develop in the wild"... that could mean they can avoid some rules, push incomplete dissectors, or whatever else I can't figure out. Rules for dissectors are very strict. I don't mean they are useless, but they have been set to have a very robust code _inside_ wireshark. Code that isn't so performing or robust or good can live outside it in the form of a plugin. For instance I have found in that dissector some code that I don't know if could go into the master: 1) it is written in c++. Would it be acceptable? 2) it uses stl maps. Would it be acceptable or should it be replaced by some "wmem maps" (maps with custom allocator)? Thanks for the info. Dario. On Thu, Jul 2, 2015 at 7:04 PM, wrote: > I'd recommend attaching the capture file to a Bugzilla ticket (with all > of the links mentioned here) and possibly your patch of the internal > dissector. Perhaps somebody can take it from there. > > As a side note, I still don't know how I feel about dissectors being > "pulled from the wild" from developers rather than pushed to Wireshark (via > Gerrit) by the original author(s). Gerrit (and just Buzilla before that) > isn't THAT hard to navigate. Are we missing something? Are our code > standards too strict? > > > > > -Original Message- > From: Dario Lombardo > To: Developer support list for Wireshark > Sent: Thu, Jul 2, 2015 12:03 pm > Subject: [Wireshark-dev] hadoop dissector > > Hi list > I opened a hadoop 2.6 capture file with the current master and I found > that the hadoop dissector fails in opening the file (wrong dissection). > This is probably related to the changes in the wire protocol that have not > been reflected into the current dissector. So I decided to start > understading how the dissector should be updated... but I stucked. > > I can't find the specifications of the wire protocol. I just found this > https://wiki.apache.org/hadoop/HadoopRpc. > > I've found this project https://github.com/liukeyou/hadoop-wireshark that, > from the screenshots, sound promising, but is for WS 1.10, and is a plugin > for windows (my dev env is linux). I succeded to compile it as internal > dissector, but nothing gets dissected. Maybe it looks for something > somewhere that I didn't copy. > > I tried to compile hadoop myself, to instrument it in order to have a > better understand of the flow and of the protocol, but the high level of > abstraction of the hadoop java code made me lost. > > These are my attempts so far... not very happy about them. > Did anyone tried to make the same or something different? Anyone having > links/resources/ideas to share? Anyone interested in working on it? > > Cheers, > > Dario > >___ > Sent > via:Wireshark-dev mailing list > Archives: https://www.wireshark.org/lists/wireshark-dev > Unsubscribe:https://wireshark.org/mailman/options/wireshark-dev > mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe > > > > ___ > Sent via:Wireshark-dev mailing list > Archives:https://www.wireshark.org/lists/wireshark-dev > Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev > mailto:wireshark-dev-requ...@wireshark.org > ?subject=unsubscribe > ___ Sent via:Wireshark-dev mailing list Archives:https://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
Re: [Wireshark-dev] How do I submit changes to gerrit again?
Hi Richard If you commit with SSH, you can upload your public key in gerrit (upper right corner -> settings -> SSH public keys). If you commit with HTTP, you should use the password gerrit provides you (upper right cornet -> settings -> HTTP password). Dario. On Fri, Jul 3, 2015 at 5:57 AM, Richard Sharpe wrote: > Hi, > > I seem to be able to log into review.wireshark.org. > > What syntax do I use to push my change again? > > In particular, where do I put the username and password? > > -- > Regards, > Richard Sharpe > (何以解憂？唯有杜康。--曹操) > ___ > Sent via:Wireshark-dev mailing list > Archives:https://www.wireshark.org/lists/wireshark-dev > Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev > mailto:wireshark-dev-requ...@wireshark.org > ?subject=unsubscribe ___ Sent via:Wireshark-dev mailing list Archives:https://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
Re: [Wireshark-dev] Problem with http2
Capture file attached and I'll go to open a bug in bugzilla On 2 July 2015 at 12:28, Pascal Quantin wrote: > 2015-07-02 11:03 GMT+02:00 Luis Espla : > >> Hello, >> Until now, I have used wireshark 1.99.5 and it can recognise http2 >> traffic, but now I have updated to 1.99.7 and I need to actívate it with >> Analyze/Decode As option. Why do I need it?, what did it change? >> And I want to use it with tshark is there any command line option for >> telling it Decode as http2? My captures files are done with last nghttp >> server and client and RFC is closed and when 1.99.5 version was published >> until 1.99.7 version nothing respect to frames structure has changed >> Best regards >> >> > Hi Luis, > > this might be a side effect of the commit > https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=570bc36b587de3af3b2321d8a03f8cc88973fb00 > Could you share a small pcap? Or even better fill a bug on > https://bugs.wireshark.org/bugzilla/ with the sample pcap attached? > > Thanks, > Pascal. > > ___ > Sent via:Wireshark-dev mailing list > Archives:https://www.wireshark.org/lists/wireshark-dev > Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev > mailto:wireshark-dev-requ...@wireshark.org > ?subject=unsubscribe > P_GET_TWO_DIFFERENT_URL_1_FLOW_IPV6.pcap Description: Binary data ___ Sent via:Wireshark-dev mailing list Archives:https://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
Re: [Wireshark-dev] Problem with http2
Le 3 juil. 2015 10:29 AM, "Luis Espla" a écrit : > > Capture file attached and I'll go to open a bug in bugzilla Thanks Luis, it confirms that this is a side effect of the change I was talking about. Pascal. > > On 2 July 2015 at 12:28, Pascal Quantin wrote: >> >> 2015-07-02 11:03 GMT+02:00 Luis Espla : >>> >>> Hello, >>> Until now, I have used wireshark 1.99.5 and it can recognise http2 traffic, but now I have updated to 1.99.7 and I need to actívate it with Analyze/Decode As option. Why do I need it?, what did it change? >>> And I want to use it with tshark is there any command line option for telling it Decode as http2? My captures files are done with last nghttp server and client and RFC is closed and when 1.99.5 version was published until 1.99.7 version nothing respect to frames structure has changed >>> Best regards >>> >> >> Hi Luis, >> >> this might be a side effect of the commit https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=570bc36b587de3af3b2321d8a03f8cc88973fb00 >> Could you share a small pcap? Or even better fill a bug on https://bugs.wireshark.org/bugzilla/ with the sample pcap attached? >> >> Thanks, >> Pascal. >> >> ___ >> Sent via:Wireshark-dev mailing list >> Archives:https://www.wireshark.org/lists/wireshark-dev >> Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev >> mailto:wireshark-dev-requ...@wireshark.org ?subject=unsubscribe > > > > ___ > Sent via:Wireshark-dev mailing list > Archives:https://www.wireshark.org/lists/wireshark-dev > Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev > mailto:wireshark-dev-requ...@wireshark.org ?subject=unsubscribe ___ Sent via:Wireshark-dev mailing list Archives:https://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
Re: [Wireshark-dev] hadoop dissector
Hi Dario, Le 3 juil. 2015 9:45 AM, "Dario Lombardo" a écrit : > > Maybe some developer like to "develop in the wild"... that could mean they can avoid some rules, push incomplete dissectors, or whatever else I can't figure out. Rules for dissectors are very strict. I don't mean they are useless, but they have been set to have a very robust code _inside_ wireshark. Code that isn't so performing or robust or good can live outside it in the form of a plugin. > > For instance I have found in that dissector some code that I don't know if could go into the master: > > 1) it is written in c++. Would it be acceptable? No for now we are not accepting any C++ dissector. > 2) it uses stl maps. Would it be acceptable or should it be replaced by some "wmem maps" (maps with custom allocator)? It should be replaced by wmem maps, like all the other C++ code ;) Pascal. > > Thanks for the info. > Dario. > > On Thu, Jul 2, 2015 at 7:04 PM, wrote: >> >> I'd recommend attaching the capture file to a Bugzilla ticket (with all of the links mentioned here) and possibly your patch of the internal dissector. Perhaps somebody can take it from there. >> >> As a side note, I still don't know how I feel about dissectors being "pulled from the wild" from developers rather than pushed to Wireshark (via Gerrit) by the original author(s). Gerrit (and just Buzilla before that) isn't THAT hard to navigate. Are we missing something? Are our code standards too strict? >> >> >> >> >> -Original Message- >> From: Dario Lombardo >> To: Developer support list for Wireshark >> Sent: Thu, Jul 2, 2015 12:03 pm >> Subject: [Wireshark-dev] hadoop dissector >> >> Hi list >> I opened a hadoop 2.6 capture file with the current master and I found that the hadoop dissector fails in opening the file (wrong dissection). This is probably related to the changes in the wire protocol that have not been reflected into the current dissector. So I decided to start understading how the dissector should be updated... but I stucked. >> >> I can't find the specifications of the wire protocol. I just found this https://wiki.apache.org/hadoop/HadoopRpc. >> >> I've found this project https://github.com/liukeyou/hadoop-wireshark that, from the screenshots, sound promising, but is for WS 1.10, and is a plugin for windows (my dev env is linux). I succeded to compile it as internal dissector, but nothing gets dissected. Maybe it looks for something somewhere that I didn't copy. >> >> I tried to compile hadoop myself, to instrument it in order to have a better understand of the flow and of the protocol, but the high level of abstraction of the hadoop java code made me lost. >> >> These are my attempts so far... not very happy about them. >> Did anyone tried to make the same or something different? Anyone having links/resources/ideas to share? Anyone interested in working on it? >> >> Cheers, >> >> Dario >> >> ___ >> Sent >> via:Wireshark-dev mailing list >> Archives: >> https://www.wireshark.org/lists/wireshark-dev >> Unsubscribe: >> https://wireshark.org/mailman/options/wireshark-dev >> >> mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe >> >> >> ___ >> Sent via:Wireshark-dev mailing list >> Archives:https://www.wireshark.org/lists/wireshark-dev >> Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev >> mailto:wireshark-dev-requ...@wireshark.org ?subject=unsubscribe > > > > ___ > Sent via:Wireshark-dev mailing list > Archives:https://www.wireshark.org/lists/wireshark-dev > Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev > mailto:wireshark-dev-requ...@wireshark.org ?subject=unsubscribe ___ Sent via:Wireshark-dev mailing list Archives:https://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
Re: [Wireshark-dev] How do I submit changes to gerrit again?
On Fri, Jul 3, 2015 at 12:49 AM, Dario Lombardo wrote: > Hi Richard > If you commit with SSH, you can upload your public key in gerrit (upper > right corner -> settings -> SSH public keys). > If you commit with HTTP, you should use the password gerrit provides you > (upper right cornet -> settings -> HTTP password). Thanks. I finally just tried it anyway and it worked and I fumbled through it. Now to figure out how to run a petri-dish build with the new interface and get some reviews. -- Regards, Richard Sharpe (何以解憂？唯有杜康。--曹操) ___ Sent via:Wireshark-dev mailing list Archives:https://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
Re: [Wireshark-dev] hadoop dissector
Am Fri, 3 Jul 2015 11:26:08 +0200 schrieb Pascal Quantin : > if could go into the master: > > > > 1) it is written in c++. Would it be acceptable? > > No for now we are not accepting any C++ dissector. > > > 2) it uses stl maps. Would it be acceptable or should it be > > replaced by > some "wmem maps" (maps with custom allocator)? > > It should be replaced by wmem maps, like all the other C++ code ;) > Well, there may be some rules for dissectors that shall be added the the Wireshark master branch. But I just want to note that I wrote all of my dissectors "in the wild" (except the first one) in C++. Especially the allocators one must be careful and consider the live time of the objects. But as long as you build maps at the load time you can use the standard allocators. C++ provides so many features that it would be a waste of time to mimic all of them in C. Probably my dissectors won't get to the Wireshark master source code. But I can live with my plug-ins. Some of them implement a proprietary protocol anyway. Best regards Helge -- GnuPG fingerprint: EDCE F8C8 B727 6CC5 7006 05C1 BD3F EADC 8922 1F61 ___ Sent via:Wireshark-dev mailing list Archives:https://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
[Wireshark-dev] Is Wireshark maintaining the official WinPcap repo now?
Hi list, Since the last mail about how to make NPcap available for Wireshark, I have been waiting for WinPcap's official repo's news and I fortunately found this these days: https://github.com/wireshark/winpcap, is this the official WinPcap repo now? If yes, then what's the review policy? Like recently we have added the "Admin-only mode" into NPcap, it restricts the capturing access only to Administrators for security purpose (see details in: https://github.com/nmap/npcap and http://nmap.org/soc/#winpcap). I don't know if the review party would like this idea? (and like other parts of NPcap like current NDIS 6 implementation). And how hard would it be for NPcap to be merged into WinPcap upstream? I noticed that this repo used gerrit for code review and it is kind of strict system in my mind:) Cheers, Yang ___ Sent via:Wireshark-dev mailing list Archives:https://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
Re: [Wireshark-dev] Is Wireshark maintaining the official WinPcap repo now?
On 3 July 2015 at 17:29, Yang Luo wrote: > Hi list, > > Since the last mail about how to make NPcap available for Wireshark, I > have been waiting for WinPcap's official repo's news and I fortunately > found this these days: https://github.com/wireshark/winpcap, is this the > official WinPcap repo now? If yes, then what's the review policy? Like > recently we have added the "Admin-only mode" into NPcap, it restricts the > capturing access only to Administrators for security purpose (see details > in: https://github.com/nmap/npcap and http://nmap.org/soc/#winpcap). I > don't know if the review party would like this idea? (and like other parts > of NPcap like current NDIS 6 implementation). And how hard would it be for > NPcap to be merged into WinPcap upstream? I noticed that this repo used > gerrit for code review and it is kind of strict system in my mind:) > > Cheers, > Yang > > Hi, As discussed elsewhere, and at Sharkfest with Fyodor, the Wireshark project is now hosting the "official" WinPCap repo ( https://code.wireshark.org/review/winpcap) and are using Gerrit for code reviews, etc. The github repo is a read-only copy. This repo is basically a dump from the internal Riverbed\Cace repo. The current "plan" is to make minimal changes to this code to get it compiling with a modern compiler (VS2013) and do whatever is necessary to make it run on Win 10. XP support *might* be lost during this. This will likely be WinPCap 4.1.4. After that all, things are up for consideration, including rewriting WinPCap for NDIS6, moving over to NPCap, synchronising with current libpcap, the security enhancement you mention etc. -- Graham Bloice ___ Sent via:Wireshark-dev mailing list Archives:https://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
Re: [Wireshark-dev] hadoop dissector
On Fri, Jul 3, 2015 at 11:53 AM, Helge wrote: > Am Fri, 3 Jul 2015 11:26:08 +0200 > schrieb Pascal Quantin : > >> if could go into the master: >> > >> > 1) it is written in c++. Would it be acceptable? >> >> No for now we are not accepting any C++ dissector. >> >> > 2) it uses stl maps. Would it be acceptable or should it be >> > replaced by >> some "wmem maps" (maps with custom allocator)? >> >> It should be replaced by wmem maps, like all the other C++ code ;) >> > > Well, there may be some rules for dissectors that shall be added the > the Wireshark master branch. But I just want to note that I wrote all > of my dissectors "in the wild" (except the first one) in C++. > Especially the allocators one must be careful and consider the live > time of the objects. But as long as you build maps at the load time you > can use the standard allocators. > > C++ provides so many features that it would be a waste of time to > mimic all of them in C. It's worth noting that wmem is not a replacement for the C++ std library and allocators, it works somewhat differently due to the lifetimes that occur naturally in Wireshark (e.g. per-packet lifetime, etc) and the way exceptions are handled internally to wireshark. We would need something like wmem in order to avoid memory leaks, even if we were to write all our dissectors in C++. > Probably my dissectors won't get to the > Wireshark master source code. But I can live with my plug-ins. Some of > them implement a proprietary protocol anyway. > > Best regards > Helge > > -- > GnuPG fingerprint: EDCE F8C8 B727 6CC5 7006 05C1 BD3F EADC 8922 1F61 > ___ > Sent via:Wireshark-dev mailing list > Archives:https://www.wireshark.org/lists/wireshark-dev > Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev > mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe ___ Sent via:Wireshark-dev mailing list Archives:https://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
[Wireshark-dev] Buildbot Lua Init Tests
The buildbot test suite is currently failing on the lua step, I believe because Peter's recent init/cleanup split has changed the number of times the init function is called, which is breaking expectations in the lua bindings somewhere. The fix may be as simple as changing the "expected number of calls" in the test suite, but I'm not sure if there may be other things the lua bindings use init routines for that also need fixing? Evan ___ Sent via:Wireshark-dev mailing list Archives:https://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
Re: [Wireshark-dev] Is Wireshark maintaining the official WinPcap repo now?
Thanks for info, Graham! It seems that WinPcap will view stability as the primary goal. While as a Summer of Code project, NPcap will try to move as fast as possible especially for these months. I am even planning to add loopback packet capturing for NPcap and have made some progress these days, and Wireshark will be a perfect tool to test this function. Given that it's no short-term effort to migrating to trunk, as the ways Gerald suggested, NPcap will choose the "Make NPcap obviously separate. Give it a separate name and modify Wireshark to try to load it first." way. I will try to make a patch for Wireshark to support NPcap recently. Cheers, Yang On Sat, Jul 4, 2015 at 12:46 AM, Graham Bloice wrote: > On 3 July 2015 at 17:29, Yang Luo wrote: > >> Hi list, >> >> Since the last mail about how to make NPcap available for Wireshark, I >> have been waiting for WinPcap's official repo's news and I fortunately >> found this these days: https://github.com/wireshark/winpcap, is this the >> official WinPcap repo now? If yes, then what's the review policy? Like >> recently we have added the "Admin-only mode" into NPcap, it restricts the >> capturing access only to Administrators for security purpose (see details >> in: https://github.com/nmap/npcap and http://nmap.org/soc/#winpcap). I >> don't know if the review party would like this idea? (and like other parts >> of NPcap like current NDIS 6 implementation). And how hard would it be for >> NPcap to be merged into WinPcap upstream? I noticed that this repo used >> gerrit for code review and it is kind of strict system in my mind:) >> >> Cheers, >> Yang >> >> > Hi, > > As discussed elsewhere, and at Sharkfest with Fyodor, the Wireshark > project is now hosting the "official" WinPCap repo ( > https://code.wireshark.org/review/winpcap) and are using Gerrit for code > reviews, etc. The github repo is a read-only copy. This repo is basically > a dump from the internal Riverbed\Cace repo. > > The current "plan" is to make minimal changes to this code to get it > compiling with a modern compiler (VS2013) and do whatever is necessary to > make it run on Win 10. XP support *might* be lost during this. This will > likely be WinPCap 4.1.4. > > After that all, things are up for consideration, including rewriting > WinPCap for NDIS6, moving over to NPCap, synchronising with current > libpcap, the security enhancement you mention etc. > > > -- > Graham Bloice > > ___ > Sent via:Wireshark-dev mailing list > Archives:https://www.wireshark.org/lists/wireshark-dev > Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev > mailto:wireshark-dev-requ...@wireshark.org > ?subject=unsubscribe > ___ Sent via:Wireshark-dev mailing list Archives:https://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
[Wireshark-dev] Plan to make NPcap available for Wireshark
Hi list, Given that current Wireshark can't make use of NPcap because of the DLL search path problem mentioned in https://www.wireshark.org/lists/wireshark-dev/201506/msg00030.html, I'd like to make a patch for Wireshark. As it is a security consideration that Wireshark don't want to search the DLLs in the Windows way. My plan is to explicitly add the NPcap path to Wireshark's DLL search logic. NPcap uses the "C:\Windows\System32\NPcap" and "C:\Windows\SysWow64\NPcap" to store its DLLs (WinPcap uses "C:\Windows\System32" and "C:\Windows\SysWow64" directly). As it is a sub directory of System32 folder. Its access control policy is the same with System32, and there should be no security problem I think. The second question is if WinPcap and NPcap are both available in a system, which will be loaded first? I'd like to hear your opinions:) Cheers, Yang ___ Sent via:Wireshark-dev mailing list Archives:https://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
Re: [Wireshark-dev] Buildbot Lua Init Tests
Yeah, I figured it would break Lua when I saw his changes on gerrit this morning, but he was doing the changes in little pieces so I thought I’d wait until some of it got into master before doing the necessary changes to wslua. -hadriel > On Jul 3, 2015, at 9:57 PM, Evan Huus wrote: > > The buildbot test suite is currently failing on the lua step, I > believe because Peter's recent init/cleanup split has changed the > number of times the init function is called, which is breaking > expectations in the lua bindings somewhere. > > The fix may be as simple as changing the "expected number of calls" in > the test suite, but I'm not sure if there may be other things the lua > bindings use init routines for that also need fixing? > > Evan > ___ > Sent via:Wireshark-dev mailing list > Archives:https://www.wireshark.org/lists/wireshark-dev > Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev > mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe ___ Sent via:Wireshark-dev mailing list Archives:https://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
Re: [Wireshark-dev] Buildbot Lua Init Tests
Should be fixed now, in master. -hadriel > On Jul 3, 2015, at 11:20 PM, Hadriel Kaplan wrote: > > Yeah, I figured it would break Lua when I saw his changes on gerrit this > morning, but he was doing the changes in little pieces so I thought I’d wait > until some of it got into master before doing the necessary changes to wslua. > > -hadriel > > >> On Jul 3, 2015, at 9:57 PM, Evan Huus wrote: >> >> The buildbot test suite is currently failing on the lua step, I >> believe because Peter's recent init/cleanup split has changed the >> number of times the init function is called, which is breaking >> expectations in the lua bindings somewhere. >> >> The fix may be as simple as changing the "expected number of calls" in >> the test suite, but I'm not sure if there may be other things the lua >> bindings use init routines for that also need fixing? >> >> Evan >> ___ >> Sent via:Wireshark-dev mailing list >> Archives:https://www.wireshark.org/lists/wireshark-dev >> Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev >>mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe > ___ Sent via:Wireshark-dev mailing list Archives:https://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
