Re: [Wireshark-dev] Master build fails without pcap
Dario Lombardo wrote: > The current master can't build if we disable PCAP in cmake. I can't be build if HAVE_EXTCAP is not defined either -- --gv ___ Sent via:Wireshark-dev mailing list Archives:https://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
[Wireshark-dev] Master build fails without pcap
The current master can't build if we disable PCAP in cmake. A build history can be found here https://travis-ci.org/crondaemon/wireshark/builds the commit that broke it was a very huge one, so I started to look at it but I'm still on it. Did someone started to track it or has any idea? Thanks Dario. ___ Sent via:Wireshark-dev mailing list Archives:https://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
Re: [Wireshark-dev] Conditional compilation (debug)
I was thinking to something like CMAKE_BUILD_TYPE (Debug/Release), but I'm not sure it fits the purpose and anyway it is cmake specific. The goal is: I want to make the debug of the interaction between ui and extcaps easier. For that I'd like to use some debug entries in the extcap interface dialog. Those flags are mostly developer-oriented, then I'd like to get rid of them in release builds, although I don't know if wireshark release builds and others differ in some way. I'd like something that mimics assert() behavior, if I'm not mistaken. On Thu, Jul 27, 2017 at 6:58 PM, Jeff Morriss wrote: > > > On Thu, Jul 27, 2017 at 12:34 PM, Dario Lombardo < > dario.lombardo...@gmail.com> wrote: > >> Hi >> I'd like to add some code that appears only in development builds of >> wireshark. Is there some define that helps me understand if I am in such a >> case, both in autotools and cmake? >> > > Define "development build." Do you mean 2.3.x or 2.5.x or do you mean > anything not built on a buildbot? For the latter we frequently just check > if we're running in a build directory (there's also an environment variable > for that). > > > ___ > Sent via:Wireshark-dev mailing list > Archives:https://www.wireshark.org/lists/wireshark-dev > Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev > mailto:wireshark-dev-requ...@wireshark.org?subject= > unsubscribe > ___ Sent via:Wireshark-dev mailing list Archives:https://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
Re: [Wireshark-dev] "[UNVERIFIED SENDER]Re: "[UNVERIFIED SENDER]Re: Hierarchy of fields & offsets
> -Original Message- > From: Guy Harris [mailto:g...@alum.mit.edu] > Sent: Tuesday, July 25, 2017 7:06 PM > To: Sultan, Hassan > Cc: Developer support list for Wireshark > Subject: "[UNVERIFIED SENDER]Re: "[UNVERIFIED SENDER]Re: [Wireshark-dev] > Hierarchy of fields & offsets > > On Jul 25, 2017, at 5:58 PM, Sultan, Hassan wrote: > ... > For people in the former group, the right way to do the field would be as an > FT_NONE, with the three items underneath it, and with the FT_NONE item being > composed of two disconnected ranges. The blob data itself could just be > dissected as NTLMSSP or GSSAPI, without an FT_BYTES field; the top-level > protocol item should have all the blob's data in it. > > For people in the latter group, the right way to do it would be to have > separate > fields for the length and offset, not under the item for the security blob, > with the > security blob as a separate item - which, again, could just be NTLMSSP or > GSSAPI, without an FT_BYTES field. Ok cool, would anyone object if I submitted a patch moving them out of the blob ? Thanks, Hassan ___ Sent via:Wireshark-dev mailing list Archives:https://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
Re: [Wireshark-dev] Conditional compilation (debug)
On Thu, Jul 27, 2017 at 12:34 PM, Dario Lombardo < dario.lombardo...@gmail.com> wrote: > Hi > I'd like to add some code that appears only in development builds of > wireshark. Is there some define that helps me understand if I am in such a > case, both in autotools and cmake? > Define "development build." Do you mean 2.3.x or 2.5.x or do you mean anything not built on a buildbot? For the latter we frequently just check if we're running in a build directory (there's also an environment variable for that). ___ Sent via:Wireshark-dev mailing list Archives:https://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
Re: [Wireshark-dev] Conditional compilation (debug)
Hi Dario, 2017-07-27 18:34 GMT+02:00 Dario Lombardo : > Hi > I'd like to add some code that appears only in development builds of > wireshark. Is there some define that helps me understand if I am in such a > case, both in autotools and cmake? > You could check that VERSION_MINOR is odd. But depending on the kind of code you want to checkin, maybe a specific compilation flag could be more appropriate? Cheers, Pascal. ___ Sent via:Wireshark-dev mailing list Archives:https://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
[Wireshark-dev] Conditional compilation (debug)
Hi I'd like to add some code that appears only in development builds of wireshark. Is there some define that helps me understand if I am in such a case, both in autotools and cmake? Thanks. Dario. ___ Sent via:Wireshark-dev mailing list Archives:https://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
Re: [Wireshark-dev] Build of Wireshark 2.4.0 source is failing to find bash during prep step
Hi Michael,
2017-07-26 22:21 GMT+02:00 Michael Lum :
> Hello,
>
> I have built 2.2.0, 2.2.1, 2.2.5 with no problems.
>
> I unpacked 2.4.0 source and created a build directory ws240-64.
>
> The first issue was a complaint about cmake version 3.5 not being good
> enough.
> I installed cmake 3.9.
>
This is something new related to some changes done in CMake 3.9, preventing
it to properly find Cygwin installation path. Until this is sorted out,
install CMake 3.8.2 instead and the error will disappear (do not forget to
clean your cmake build folder)
Best regards,
Pascal.
> I added a print statement in FindSH.cmake and it appears
> CYGWIN_INSTALL_PATH does not get set correctly.
> (The Windows environment variable WIRESHARK_CYGWIN_INSTALL_PATH IS set
> correctly.)
>
> Any help would be appreciated, I know nothing about cmake.
>
> Thank you
>
> This is my build command file run as 'mybuild.cmd prep'
>
>
> @echo off
> set myPath=%~dp0
>
> IF [%WIRESHARK_BASE_DIR%] == [] (
> REM
> REM change this if you change version
> REM
> set WIRESHARK_BASE_DIR=C:\ws240-64
>
> REM
> REM Note if you want to change this AFTER you have built:
> REM Do 'clean', then 'prep', then 'build', 'package'
> REM
> set WIRESHARK_VERSION_EXTRA=-StarSolutions-1
>
> set CYGWIN=nodosfilewarning
> set WIRESHARK_TARGET_PLATFORM=win64
> set QT5_BASE_DIR=C:\Qt\Qt5.6.2\5.6\msvc2013_64
> set WIRESHARK_CYGWIN_INSTALL_PATH=c:\cygwin64
>
> REM set WIRESHARK_CYGWIN_INSTALL_PATH=c:\cygwin or whatever other path
> that is applicable to your setup
> )
>
> echo "WIRESHARK_CYGWIN_INSTALL_PATH=%WIRESHARK_CYGWIN_INSTALL_PATH%"
>
> IF [%myPath%] == [%cd%\] (
> echo Do not run this command from the source directory
> echo "(run it from the target output directory %WIRESHARK_BASE_DIR%)"
> echo i.e. ..\wireshark-xxx\mybuild.cmd %*
> exit /b
> )
>
> IF [%1] == [build] (
> msbuild /m /p:Configuration=RelWithDebInfo Wireshark.sln
> exit /b
> )
>
> IF [%1] == [clean] (
> msbuild /m /p:Configuration=RelWithDebInfo Wireshark.sln /t:Clean
> exit /b
> )
>
> IF [%1] == [package] (
> msbuild /m /p:Configuration=RelWithDebInfo nsis_package_prep.vcxproj
> msbuild /m /p:Configuration=RelWithDebInfo nsis_package.vcxproj
> exit /b
> )
>
> IF [%1] == [prep] (
> @echo cmake -DPYTHON_EXECUTABLE=c:\Python27\python
> -DENABLE_CHM_GUIDES=on -G "Visual Studio 12 2013 Win64" %myPath%
> cmake -DPYTHON_EXECUTABLE=c:\Python27\python -DENABLE_CHM_GUIDES=on -G
> "Visual Studio 12 2013 Win64" %myPath%
> exit /b
> )
>
> echo %myPath%mybuild.cmd {prep^|build^|clean^|package}
> exit /b
>
>
> This is the output.
>
> C:\>cd ws240-64
>
> C:\ws240-64>..\wireshark-2.4.0\mybuild.cmd prep
> "WIRESHARK_CYGWIN_INSTALL_PATH=c:\cygwin64"
> cmake -DPYTHON_EXECUTABLE=c:\Python27\python -DENABLE_CHM_GUIDES=on -G
> "Visual Studio 12 2013 Win64" C:\wireshark-2.4.0\
> -- Generating build using CMake 3.9.0
> CMake Deprecation Warning at CMakeLists.txt:51 (cmake_policy):
> The OLD behavior for policy CMP0011 will be removed from a future version
> of CMake.
>
> The cmake-policies(7) manual explains that the OLD behaviors of all
> policies are deprecated and that a policy should be set to OLD only under
> specific short-term circumstances. Projects should be ported to the NEW
> behavior and not rely on setting a policy to OLD.
>
>
> CMake Deprecation Warning at CMakeLists.txt:60 (cmake_policy):
> The OLD behavior for policy CMP0026 will be removed from a future version
> of CMake.
>
> The cmake-policies(7) manual explains that the OLD behaviors of all
> policies are deprecated and that a policy should be set to OLD only under
> specific short-term circumstances. Projects should be ported to the NEW
> behavior and not rely on setting a policy to OLD.
>
>
> -- Building for win64 using Visual Studio 12 2013 Win64
> Working in C:\ws240-64\wireshark-win64-libs-2.4
> Tag 2017-05-11 found. Skipping.
> -- Including C:/wireshark-2.4.0/CMakeListsCustom.txt
> -- Configuration types: Debug;Release;MinSizeRel;RelWithDebInfo
> -- CMAKE_C_FLAGS_RELWITHDEBINFO: /MD /Zi /O2 /Ob1 /DNDEBUG
> -- CMAKE_CXX_FLAGS_RELWITHDEBINFO: /MD /Zi /O2 /Ob1 /DNDEBUG
> -- V: 2.4.0-StarSolutions-1, MaV: 2, MiV: 4, PL: 0, EV: -StarSolutions-1.
> -- Found PythonInterp: C:/Python27/python (found version "2.7.11")
> -- Checking for c-compiler flag: /MP
> -- Checking for c-compiler flag: /Zo
> -- Checking for c-compiler flag: /w34295 /w34189 /wd4200
> -- Checking for c++-compiler flag: /MP
> -- Checking for c++-compiler flag: /Zo
> -- Checking for c++-compiler flag: /w34295 /w34189 /wd4200
> statuscheck linker flag - test linker flags: -Wl,--as-needed
> statuscheck linker flag - test linker flags: -pie
> -- Packagelist: AIRPCAP;CAP;CARES;GCRYPT;GEOIP;GLIB2;GMODULE2;GNUTLS;
> GTHREAD2;Gettext;Git;KERBEROS;LEX;LIBSSH;LUA;LZ4;LibXml2;M;
> NGHTTP2;PCAP;POD;
[Wireshark-dev] Build of Wireshark 2.4.0 source is failing to find bash during prep step
Hello,
I have built 2.2.0, 2.2.1, 2.2.5 with no problems.
I unpacked 2.4.0 source and created a build directory ws240-64.
The first issue was a complaint about cmake version 3.5 not being good enough.
I installed cmake 3.9.
I added a print statement in FindSH.cmake and it appears CYGWIN_INSTALL_PATH
does not get set correctly.
(The Windows environment variable WIRESHARK_CYGWIN_INSTALL_PATH IS set
correctly.)
Any help would be appreciated, I know nothing about cmake.
Thank you
This is my build command file run as 'mybuild.cmd prep'
@echo off
set myPath=%~dp0
IF [%WIRESHARK_BASE_DIR%] == [] (
REM
REM change this if you change version
REM
set WIRESHARK_BASE_DIR=C:\ws240-64
REM
REM Note if you want to change this AFTER you have built:
REM Do 'clean', then 'prep', then 'build', 'package'
REM
set WIRESHARK_VERSION_EXTRA=-StarSolutions-1
set CYGWIN=nodosfilewarning
set WIRESHARK_TARGET_PLATFORM=win64
set QT5_BASE_DIR=C:\Qt\Qt5.6.2\5.6\msvc2013_64
set WIRESHARK_CYGWIN_INSTALL_PATH=c:\cygwin64
REM set WIRESHARK_CYGWIN_INSTALL_PATH=c:\cygwin or whatever other path that is
applicable to your setup
)
echo "WIRESHARK_CYGWIN_INSTALL_PATH=%WIRESHARK_CYGWIN_INSTALL_PATH%"
IF [%myPath%] == [%cd%\] (
echo Do not run this command from the source directory
echo "(run it from the target output directory %WIRESHARK_BASE_DIR%)"
echo i.e. ..\wireshark-xxx\mybuild.cmd %*
exit /b
)
IF [%1] == [build] (
msbuild /m /p:Configuration=RelWithDebInfo Wireshark.sln
exit /b
)
IF [%1] == [clean] (
msbuild /m /p:Configuration=RelWithDebInfo Wireshark.sln /t:Clean
exit /b
)
IF [%1] == [package] (
msbuild /m /p:Configuration=RelWithDebInfo nsis_package_prep.vcxproj
msbuild /m /p:Configuration=RelWithDebInfo nsis_package.vcxproj
exit /b
)
IF [%1] == [prep] (
@echo cmake -DPYTHON_EXECUTABLE=c:\Python27\python -DENABLE_CHM_GUIDES=on -G
"Visual Studio 12 2013 Win64" %myPath%
cmake -DPYTHON_EXECUTABLE=c:\Python27\python -DENABLE_CHM_GUIDES=on -G
"Visual Studio 12 2013 Win64" %myPath%
exit /b
)
echo %myPath%mybuild.cmd {prep^|build^|clean^|package}
exit /b
This is the output.
C:\>cd ws240-64
C:\ws240-64>..\wireshark-2.4.0\mybuild.cmd prep
"WIRESHARK_CYGWIN_INSTALL_PATH=c:\cygwin64"
cmake -DPYTHON_EXECUTABLE=c:\Python27\python -DENABLE_CHM_GUIDES=on -G "Visual
Studio 12 2013 Win64" C:\wireshark-2.4.0\
-- Generating build using CMake 3.9.0
CMake Deprecation Warning at CMakeLists.txt:51 (cmake_policy):
The OLD behavior for policy CMP0011 will be removed from a future version
of CMake.
The cmake-policies(7) manual explains that the OLD behaviors of all
policies are deprecated and that a policy should be set to OLD only under
specific short-term circumstances. Projects should be ported to the NEW
behavior and not rely on setting a policy to OLD.
CMake Deprecation Warning at CMakeLists.txt:60 (cmake_policy):
The OLD behavior for policy CMP0026 will be removed from a future version
of CMake.
The cmake-policies(7) manual explains that the OLD behaviors of all
policies are deprecated and that a policy should be set to OLD only under
specific short-term circumstances. Projects should be ported to the NEW
behavior and not rely on setting a policy to OLD.
-- Building for win64 using Visual Studio 12 2013 Win64
Working in C:\ws240-64\wireshark-win64-libs-2.4
Tag 2017-05-11 found. Skipping.
-- Including C:/wireshark-2.4.0/CMakeListsCustom.txt
-- Configuration types: Debug;Release;MinSizeRel;RelWithDebInfo
-- CMAKE_C_FLAGS_RELWITHDEBINFO: /MD /Zi /O2 /Ob1 /DNDEBUG
-- CMAKE_CXX_FLAGS_RELWITHDEBINFO: /MD /Zi /O2 /Ob1 /DNDEBUG
-- V: 2.4.0-StarSolutions-1, MaV: 2, MiV: 4, PL: 0, EV: -StarSolutions-1.
-- Found PythonInterp: C:/Python27/python (found version "2.7.11")
-- Checking for c-compiler flag: /MP
-- Checking for c-compiler flag: /Zo
-- Checking for c-compiler flag: /w34295 /w34189 /wd4200
-- Checking for c++-compiler flag: /MP
-- Checking for c++-compiler flag: /Zo
-- Checking for c++-compiler flag: /w34295 /w34189 /wd4200
statuscheck linker flag - test linker flags: -Wl,--as-needed
statuscheck linker flag - test linker flags: -pie
-- Packagelist:
AIRPCAP;CAP;CARES;GCRYPT;GEOIP;GLIB2;GMODULE2;GNUTLS;GTHREAD2;Gettext;Git;KERBEROS;LEX;LIBSSH;LUA;LZ4;LibXml2;M;NGHTTP2;PCAP;POD;Perl;PythonInterp;Qt5Core;Qt5LinguistTools;Qt5Multimedia;Qt5PrintSupport;Qt5Svg;Qt5Widgets;Qt5WinExtras;SBC;SETCAP;SH;SMI;SNAPPY;SPANDSP;WINSPARKLE;YACC;YAPP;ZLIB
-- AIRPCAP FOUND
-- AIRPCAP includes:
C:/ws240-64/wireshark-win64-libs-2.4/AirPcap_Devpack_4_1_0_1622/Airpcap_Devpack/include
-- AIRPCAP libs:
C:/ws240-64/wireshark-win64-libs-2.4/AirPcap_Devpack_4_1_0_1622/Airpcap_Devpack/lib/airpcap.lib
-- Could NOT find PkgConfig (missing: PKG_CONFIG_EXECUTABLE)
-- Checking for one of the modules 'libcap'
-- Could NOT find CAP (missing: CAP_LIBRARY CAP_INCLUDE_D
Re: [Wireshark-dev] Wireshark 2.5.0 ws.css errors in docbook\developer_guide_chm.vcxproj
Hi, Please, it is a better to open a bug on bugtracker (for don't forget...) Cheers On Tue, Jul 25, 2017 at 10:07 PM, Jay Turner wrote: > ws.css has errors on lines 107 (body pre) and 116 (tt.literal, > code.literal where color 333 is written, but color code 333 is not a valid > color value. > -- > Jay Turner > Contact: 214-587-7364 > > > ___ > Sent via:Wireshark-dev mailing list > Archives:https://www.wireshark.org/lists/wireshark-dev > Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev > mailto:wireshark-dev-requ...@wireshark.org?subject= > unsubscribe > ___ Sent via:Wireshark-dev mailing list Archives:https://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
