Re: [Wireshark-dev] ThreadSanitizer issue in RecentFileStatus()
On 2/3/18 3:23 AM, Stig Bjørlykke wrote: > On Fri, Feb 2, 2018 at 7:33 PM, Gerald Combs wrote: >> That's correct -- the main and RecentFileStatus threads could operate on the >> filename at the same time. I think the data race is harmless in this case, >> but it's easy enough to create a local copy of the filename. Fix inbound at >> https://code.wireshark.org/review/#/c/25572. > > I'm still getting a similar race condition report from > RecentFileStatus. Even if it's harmless it would have been good to > fix this to make it possible to run with TSAN and "Pause on issues". > > == > WARNING: ThreadSanitizer: data race (pid=4733) > Read of size 8 at 0x7e800059edb0 by main thread: > * #0 QString::QString(QString const&) qstring.h:906 > (Wireshark:x86_64+0x100039256) > #1 QString::QString(QString const&) qstring.h:907 > (Wireshark:x86_64+0x100038498) > #2 WiresharkApplication::qt_static_metacall(QObject*, > QMetaObject::Call, int, void**) moc_wireshark_application.cpp:239 > (Wireshark:x86_64+0x1000bb990) > #3 QObject::event(QEvent*) (QtCore:x86_64+0x211b80) > #4 QApplicationPrivate::notify_helper(QObject*, QEvent*) > (QtWidgets:x86_64+0x119ac) > #5 start (libdyld.dylib:x86_64+0x1114) > > Previous write of size 8 at 0x7e800059edb0 by thread T14: > * #0 QString::QString(QString const&) qstring.h:906 > (Wireshark:x86_64+0x10003926d) > #1 QString::QString(QString const&) qstring.h:907 > (Wireshark:x86_64+0x100038498) > #2 RecentFileStatus::run() recent_file_status.cpp:32 > (Wireshark:x86_64+0x1005000cc) > #3 non-virtual thunk to RecentFileStatus::run() > recent_file_status.cpp (Wireshark:x86_64+0x10050020c) > #4 (QtCore:x86_64+0x27b6d) Does ThreadSanitizer support QMutex on macOS (which appears to use Mach semaphores)? Switching from Qt::BlockingQueuedConnection to Qt::QueuedConnection fixed the warning here, which suggests that it's ignoring Qt's event mutex. I get similar warnings for GMutex when using TSAN on Linux. A switch from Qt::BlockingQueuedConnection to Qt::QueuedConnection is inbound in change 25576. ___ Sent via:Wireshark-dev mailing list Archives:https://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
Re: [Wireshark-dev] 2.5.0, 2.6, and 3.0 release planning
yes, those should be fixed before a 2.6 release. For 2.5 I think it could be ok. cheers Roland On Sat, Feb 3, 2018 at 12:52 PM, Jakub Zawadzki wrote: > Hello, > > W dniu 2018-02-02 23:45, Gerald Combs napisał(a): > >> I think we've fixed the major issues identified by Stig, Jim, and >> others so I'd like to release 2.5.0 on February 6. >> > > In oss-fuzz queue currently there are few crashes, and one inifite loop. > Should it be a blocker for a release? > > Regards, > Jakub. > > > ___ > Sent via:Wireshark-dev mailing list > Archives:https://www.wireshark.org/lists/wireshark-dev > Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev > mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe > ___ Sent via:Wireshark-dev mailing list Archives:https://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
Re: [Wireshark-dev] 2.5.0, 2.6, and 3.0 release planning
Hello, W dniu 2018-02-02 23:45, Gerald Combs napisał(a): I think we've fixed the major issues identified by Stig, Jim, and others so I'd like to release 2.5.0 on February 6. In oss-fuzz queue currently there are few crashes, and one inifite loop. Should it be a blocker for a release? Regards, Jakub. ___ Sent via:Wireshark-dev mailing list Archives:https://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
Re: [Wireshark-dev] 2.5.0, 2.6, and 3.0 release planning
On Fri, Feb 2, 2018 at 11:45 PM, Gerald Combs wrote: > I think we've fixed the major issues identified by Stig, Jim, and others so > I'd like to release 2.5.0 on February 6. Maybe not a show stopper the release, but selecting a byte in the ByteView does not expand the corresponding tree item as it does in 2.4. -- Stig Bjørlykke ___ Sent via:Wireshark-dev mailing list Archives:https://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
Re: [Wireshark-dev] ThreadSanitizer issue in RecentFileStatus()
On Fri, Feb 2, 2018 at 7:33 PM, Gerald Combs wrote: > That's correct -- the main and RecentFileStatus threads could operate on the > filename at the same time. I think the data race is harmless in this case, > but it's easy enough to create a local copy of the filename. Fix inbound at > https://code.wireshark.org/review/#/c/25572. I'm still getting a similar race condition report from RecentFileStatus. Even if it's harmless it would have been good to fix this to make it possible to run with TSAN and "Pause on issues". == WARNING: ThreadSanitizer: data race (pid=4733) Read of size 8 at 0x7e800059edb0 by main thread: * #0 QString::QString(QString const&) qstring.h:906 (Wireshark:x86_64+0x100039256) #1 QString::QString(QString const&) qstring.h:907 (Wireshark:x86_64+0x100038498) #2 WiresharkApplication::qt_static_metacall(QObject*, QMetaObject::Call, int, void**) moc_wireshark_application.cpp:239 (Wireshark:x86_64+0x1000bb990) #3 QObject::event(QEvent*) (QtCore:x86_64+0x211b80) #4 QApplicationPrivate::notify_helper(QObject*, QEvent*) (QtWidgets:x86_64+0x119ac) #5 start (libdyld.dylib:x86_64+0x1114) Previous write of size 8 at 0x7e800059edb0 by thread T14: * #0 QString::QString(QString const&) qstring.h:906 (Wireshark:x86_64+0x10003926d) #1 QString::QString(QString const&) qstring.h:907 (Wireshark:x86_64+0x100038498) #2 RecentFileStatus::run() recent_file_status.cpp:32 (Wireshark:x86_64+0x1005000cc) #3 non-virtual thunk to RecentFileStatus::run() recent_file_status.cpp (Wireshark:x86_64+0x10050020c) #4 (QtCore:x86_64+0x27b6d) Issue is caused by frames marked with "*". Location is stack of thread T14. Thread T14 (tid=1194099, running) created by main thread at: #0 pthread_create (libclang_rt.tsan_osx_dynamic.dylib:x86_64h+0x2a34d) #1 QThread::start(QThread::Priority) (QtCore:x86_64+0x2b5cb) #2 main wireshark-qt.cpp:667 (Wireshark:x86_64+0x1000366cd) SUMMARY: ThreadSanitizer: data race qstring.h:906 in QString::QString(QString const&) == -- Stig Bjørlykke ___ Sent via:Wireshark-dev mailing list Archives:https://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
Re: [Wireshark-dev] copy from the packet pane broken?
Den 3 feb. 2018 10:47 skrev "Roland Knall" : On Sat, Feb 3, 2018 at 10:41 AM, Anders Broman wrote: > > > Den 3 feb. 2018 10:36 fm skrev "Roland Knall" : > > Hi > > Copy works from the "Packets Detail" pane as well as the "Packets List" on > the latest master. Tried various copy functions. > > What does not seem to work on my mac build is the submenu indicator for > the copy submenu. But this might be a Qt issue, not a WS one, we register > the submenu correctly. > > > I think that was it, tried to copy but the choices was greyed out. > > Hm, if you do it immediately upon capture start, that might be an issue, but otherwise this should not happen. Please try to reproduce it and file a report, because if this is permanent it might be a bug. cheers This was after loading an existing capture file. I get more details on Monday. Regards Anders ___ Sent via:Wireshark-dev mailing list Archives:https://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe ___ Sent via:Wireshark-dev mailing list Archives:https://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
Re: [Wireshark-dev] copy from the packet pane broken?
On Sat, Feb 3, 2018 at 10:41 AM, Anders Broman wrote: > > > Den 3 feb. 2018 10:36 fm skrev "Roland Knall" : > > Hi > > Copy works from the "Packets Detail" pane as well as the "Packets List" on > the latest master. Tried various copy functions. > > What does not seem to work on my mac build is the submenu indicator for > the copy submenu. But this might be a Qt issue, not a WS one, we register > the submenu correctly. > > > I think that was it, tried to copy but the choices was greyed out. > > Hm, if you do it immediately upon capture start, that might be an issue, but otherwise this should not happen. Please try to reproduce it and file a report, because if this is permanent it might be a bug. cheers ___ Sent via:Wireshark-dev mailing list Archives:https://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
Re: [Wireshark-dev] copy from the packet pane broken?
Den 3 feb. 2018 10:36 fm skrev "Roland Knall" : Hi Copy works from the "Packets Detail" pane as well as the "Packets List" on the latest master. Tried various copy functions. What does not seem to work on my mac build is the submenu indicator for the copy submenu. But this might be a Qt issue, not a WS one, we register the submenu correctly. I think that was it, tried to copy but the choices was greyed out. What was it, that did not seem to work for you? cheers On Sat, Feb 3, 2018 at 9:28 AM, Anders Broman wrote: > Hi, > I think the copy function may be broken. > No possibility to check today. > Regards > Anders > > > ___ > Sent via:Wireshark-dev mailing list > Archives:https://www.wireshark.org/lists/wireshark-dev > Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev > mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscr > ibe > ___ Sent via:Wireshark-dev mailing list Archives:https://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe ___ Sent via:Wireshark-dev mailing list Archives:https://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
Re: [Wireshark-dev] copy from the packet pane broken?
Hi Copy works from the "Packets Detail" pane as well as the "Packets List" on the latest master. Tried various copy functions. What does not seem to work on my mac build is the submenu indicator for the copy submenu. But this might be a Qt issue, not a WS one, we register the submenu correctly. What was it, that did not seem to work for you? cheers On Sat, Feb 3, 2018 at 9:28 AM, Anders Broman wrote: > Hi, > I think the copy function may be broken. > No possibility to check today. > Regards > Anders > > > ___ > Sent via:Wireshark-dev mailing list > Archives:https://www.wireshark.org/lists/wireshark-dev > Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev > mailto:wireshark-dev-requ...@wireshark.org?subject= > unsubscribe > ___ Sent via:Wireshark-dev mailing list Archives:https://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
[Wireshark-dev] copy from the packet pane broken?
Hi, I think the copy function may be broken. No possibility to check today. Regards Anders ___ Sent via:Wireshark-dev mailing list Archives:https://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
