Re: [Wireshark-dev] export_pdu

[Pascal Quantin]

Hi Dario,

Le 17 mars 2018 17:42, "Dario Lombardo"  a
écrit :

To reduce the duplicated code between libwireshark and udpdump I tried to
move the export_pdu code from epan to a shared library (as done for
writecap and randpkt_core) in this change:

https://code.wireshark.org/review/#/c/26257/

Some issues on windows arose a problem about symbols exported. The
discussion with Pascal showed apparently just one solution: the library has
to be a dynamic library and not a static one. Before pushing a new
changeset I would like to get some other opinion, because this move could
not be worth, and keeping the code as is could be more desirable. For
instance the plugins that use export_pdu and link libwireshark would be
required to link this new library or they would stop working.
Thanks for your help.
Dario.


Personally I vote for keeping the code as it is today. The export PDU code
is so small and so easy to write that I do not think it deserves being a
library by its own, and there are not many lines of code corresponding to
this in udpdump.c (less than 100 lines of code that could have been written
in a much more compact way if required). So it's a -1 on my side.

Best regards,
Pascal.
___
Sent via:Wireshark-dev mailing list 
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

[Wireshark-dev] export_pdu

[Dario Lombardo]

To reduce the duplicated code between libwireshark and udpdump I tried to
move the export_pdu code from epan to a shared library (as done for
writecap and randpkt_core) in this change:

https://code.wireshark.org/review/#/c/26257/

Some issues on windows arose a problem about symbols exported. The
discussion with Pascal showed apparently just one solution: the library has
to be a dynamic library and not a static one. Before pushing a new
changeset I would like to get some other opinion, because this move could
not be worth, and keeping the code as is could be more desirable. For
instance the plugins that use export_pdu and link libwireshark would be
required to link this new library or they would stop working.
Thanks for your help.
Dario.
___
Sent via:Wireshark-dev mailing list 
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

Re: [Wireshark-dev] Adding sample capture

[e-mail graham.shanks via Wireshark-dev]

GrahamShanks

Regards
Graham


> On 17 March 2018 at 13:38 Jaap Keuter  wrote:
> 
> 
> 
> > > On 17 Mar 2018, at 00:28, e-mail graham.shanks via 
> Wireshark-dev < wireshark-dev@wireshark.org 
> mailto:wireshark-dev@wireshark.org > wrote:
> > 
> > 
> > How do I get permission to enable me to upload a capture file to 
> > the Sample Captures page? In particular I want to add the capture file 
> > associated with Bug: 14441 
> > https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=14441
> > 
> > 
> > Regards
> > Graham
> > 
> > > Hi,
> 
> What is your Wiki user name?
> 
> 
> 
 

> ___
> Sent via: Wireshark-dev mailing list 
> Archives: https://www.wireshark.org/lists/wireshark-dev
> Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
> mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
> 
 
___
Sent via:Wireshark-dev mailing list 
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

Re: [Wireshark-dev] 2.6 branch planning and post-branch changes

[Uli Heilmeier]

> 
>> Renaming protocols to match current reality, e.g. "bootp" to "dhcp" and 
>> "ssl" to "tls".
> 
> The latter makes sense; the former is a little weird, given that, 
> technically, DHCP is a protocol that's implemented with BOOTP options, but if 
> there's not much BOOTP-without-DHCP traffic now, it probably won't bother 
> people that they need to type "dhcp" to refer to BOOTP.
> 

What about having a display filter alias „dhcp“ for „bootp“? This way 
inexperienced users would be able to see DHCP by using „dhcp“ as a filter.

-1 for renaming „bootp"
+/- 0 for renaming „ssl"
___
Sent via:Wireshark-dev mailing list 
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

Re: [Wireshark-dev] Adding sample capture

[Jaap Keuter]

> On 17 Mar 2018, at 00:28, e-mail graham.shanks via Wireshark-dev 
>  wrote:
> 
> How do I get permission to enable me to upload a capture file to the Sample 
> Captures page? In particular I want to add the capture file associated with 
> Bug: 14441 
> 
> Regards
> Graham
> 
Hi,

What is your Wiki user name?


___
Sent via:Wireshark-dev mailing list 
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe