Re: [Wireshark-dev] SCTP association analysis & selection does not work correctly

2024-02-22 Thread John Thacker
On Thu, Feb 22, 2024 at 10:24 AM Cristian Constantin via Wireshark-dev <
wireshark-dev@wireshark.org> wrote:

> Hi,
> How to figure out if a fix for an issue like the one mentioned by John
> above is part of a Wireshark release? And what Wireshark release is
> part of...
>

 The Gitlab page for the commit has some entries that indicate which
branches and tags (tags would indicate releases) have a commit. This one is
only in the master branch, not a release.

https://gitlab.com/wireshark/wireshark/-/commit/922d1f621935ace31d08243c2627c149111401be

Some commits that fix bugs (as opposed to new features or performance
enhancements) are backported. There will be links added in the merge
request and the commits to other commits that were backported. That is not
going to happen for this commit.

John
___
Sent via:Wireshark-dev mailing list 
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe


Re: [Wireshark-dev] SCTP association analysis & selection does not work correctly

2024-02-22 Thread Cristian Constantin via Wireshark-dev
Hi,
How to figure out if a fix for an issue like the one mentioned by John
above is part of a Wireshark release? And what Wireshark release is
part of...

Thank you,
Cristian

On Sat, Dec 23, 2023 at 4:45 AM John Thacker  wrote:
>
> On Thu, Dec 7, 2023 at 3:32 AM Cristian Constantin via Wireshark-dev 
>  wrote:
>>
>> Hi Jeff,
>>
>> Yes, after enabling the respective protocol decoding option, SCTP
>> association analysis works.
>> SCTP association analysis is _quite_ slow, though. I'll check why it
>> is so slow when I have some spare time.
>
>
> If you have some time, can you see if 
> https://gitlab.com/wireshark/wireshark/-/merge_requests/13786
> works for you and if it's faster (at least the dissection part, this doesn't 
> affect the tapping)? It works
> on my samples, and it uses hashmaps instead of lists so it should be better 
> on large files.
>
> Thanks,
> John
> ___
> Sent via:Wireshark-dev mailing list 
> Archives:https://www.wireshark.org/lists/wireshark-dev
> Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
>  mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
___
Sent via:Wireshark-dev mailing list 
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe