Re: [Wireshark-dev] [PATCH] packet-sctp.c: rename SERIAL_NUMBER_LENGTH to SCTP_SERIAL_NUMBER_LENGTH to fix compilation failure

2007-12-17 Thread Jeff Morriss 


Kaul wrote:
> On Windows, with both MSVC 2005 express and MSVC 2008 express, 
> compilation fails due to redefinition of SERIAL_NUMBER_LENGTH.
> Changed it to SCTP_SERIAL_NUMBER_LENGTH to avoid the collision.

Huh, it compiles fine for me using MSVC 2005 Express (free) edition. 
SERIAL_NUMBER_LENGTH appears to only be defined in WinIoCtl.h; I wonder 
how that is making its way into packet-sctp.c ??

Anyway, changing it does no harm, so checked in rev 23899.

BTW, I'd suggest opening bugs for these things so they don't get lost.
___
Wireshark-dev mailing list
Wireshark-dev@wireshark.org
http://www.wireshark.org/mailman/listinfo/wireshark-dev

[Wireshark-dev] [PATCH] packet-sctp.c: rename SERIAL_NUMBER_LENGTH to SCTP_SERIAL_NUMBER_LENGTH to fix compilation failure

2007-12-15 Thread Kaul 
On Windows, with both MSVC 2005 express and MSVC 2008 express, compilation
fails due to redefinition of SERIAL_NUMBER_LENGTH.
Changed it to SCTP_SERIAL_NUMBER_LENGTH to avoid the collision.


packet-sctp.c.diff
Description: Binary data
___
Wireshark-dev mailing list
Wireshark-dev@wireshark.org
http://www.wireshark.org/mailman/listinfo/wireshark-dev