Re: [Wireshark-dev] [Wireshark-commits] master 3147087: Fix ranlib "has no symbols" errors in the codecs directory.
On Thu, Dec 11, 2014 at 8:02 AM, Michal Labedzki wrote: > On 10 December 2014 at 20:05, Alexis La Goutte > wrote: >> On Wed, Dec 10, 2014 at 12:28 AM, Guy Harris wrote: >>> Even if we don't want to use it by default if present, should we have >>> --with-spandsp, defaulting to "no", so that people don't have to do quite >>> as much work to use it if they choose to build a custom version of >>> Wireshark? >> Good for me >> (There is already some code for CMakeList ?) >> And there is already some stuff only for Linux only like SBC (Codec >> for Bluetooth A2DP stream playing) > > SBC is not Linux only. It iss cross-platform. But there is no build package include for Windows ? like gtk, ares... ? > I do not see ENABLE_SPANDSP in cmake. I prefer to add this and > defaults to TRUE. Like SBC - optional package, only use it if detect > it. > > The same should be done in autotools (then drop support for autotools...) +1 > > I think Wireshark should provide own codecs, because system codecs are > not always available (like FLAC in Windows, SBC - there is probably no > SBC codecs anywhere). I like sentence: "See packet bytes, hear packet > stream, watch packets result". We can see packet bytes (and bits), for > RTP we can hear it, but no watching yet (sometimes you can extract > [part of]stream...) Nice sentence ! > > -- > > Pozdrawiam / Best regards > - > Michał Łabędzki, Software Engineer > Tieto Corporation > > Product Development Services > > http://www.tieto.com / http://www.tieto.pl > --- > ASCII: Michal Labedzki > location: Swobodna 1 Street, 50-088 Wrocław, Poland > room: 5.01 (desk next to 5.08) > --- > Please note: The information contained in this message may be legally > privileged and confidential and protected from disclosure. If the > reader of this message is not the intended recipient, you are hereby > notified that any unauthorised use, distribution or copying of this > communication is strictly prohibited. If you have received this > communication in error, please notify us immediately by replying to > the message and deleting it from your computer. Thank You. > --- > Please consider the environment before printing this e-mail. > --- > Tieto Poland spółka z ograniczoną odpowiedzialnością z siedzibą w > Szczecinie, ul. Malczewskiego 26. Zarejestrowana w Sądzie Rejonowym > Szczecin-Centrum w Szczecinie, XIII Wydział Gospodarczy Krajowego > Rejestru Sądowego pod numerem 124858. NIP: 8542085557. REGON: > 812023656. Kapitał zakładowy: 4 271500 PLN > ___ > Sent via:Wireshark-dev mailing list > Archives:http://www.wireshark.org/lists/wireshark-dev > Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev > mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe ___ Sent via:Wireshark-dev mailing list Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
Re: [Wireshark-dev] [Wireshark-commits] master 3147087: Fix ranlib "has no symbols" errors in the codecs directory.
On 10 December 2014 at 20:05, Alexis La Goutte wrote: > On Wed, Dec 10, 2014 at 12:28 AM, Guy Harris wrote: >> Even if we don't want to use it by default if present, should we have >> --with-spandsp, defaulting to "no", so that people don't have to do quite as >> much work to use it if they choose to build a custom version of Wireshark? > Good for me > (There is already some code for CMakeList ?) > And there is already some stuff only for Linux only like SBC (Codec > for Bluetooth A2DP stream playing) SBC is not Linux only. It iss cross-platform. I do not see ENABLE_SPANDSP in cmake. I prefer to add this and defaults to TRUE. Like SBC - optional package, only use it if detect it. The same should be done in autotools (then drop support for autotools...) I think Wireshark should provide own codecs, because system codecs are not always available (like FLAC in Windows, SBC - there is probably no SBC codecs anywhere). I like sentence: "See packet bytes, hear packet stream, watch packets result". We can see packet bytes (and bits), for RTP we can hear it, but no watching yet (sometimes you can extract [part of]stream...) -- Pozdrawiam / Best regards - Michał Łabędzki, Software Engineer Tieto Corporation Product Development Services http://www.tieto.com / http://www.tieto.pl --- ASCII: Michal Labedzki location: Swobodna 1 Street, 50-088 Wrocław, Poland room: 5.01 (desk next to 5.08) --- Please note: The information contained in this message may be legally privileged and confidential and protected from disclosure. If the reader of this message is not the intended recipient, you are hereby notified that any unauthorised use, distribution or copying of this communication is strictly prohibited. If you have received this communication in error, please notify us immediately by replying to the message and deleting it from your computer. Thank You. --- Please consider the environment before printing this e-mail. --- Tieto Poland spółka z ograniczoną odpowiedzialnością z siedzibą w Szczecinie, ul. Malczewskiego 26. Zarejestrowana w Sądzie Rejonowym Szczecin-Centrum w Szczecinie, XIII Wydział Gospodarczy Krajowego Rejestru Sądowego pod numerem 124858. NIP: 8542085557. REGON: 812023656. Kapitał zakładowy: 4 271500 PLN ___ Sent via:Wireshark-dev mailing list Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
Re: [Wireshark-dev] [Wireshark-commits] master 3147087: Fix ranlib "has no symbols" errors in the codecs directory.
On Wed, Dec 10, 2014 at 12:28 AM, Guy Harris wrote: > > On Dec 9, 2014, at 1:25 PM, Wireshark code review > wrote: > >> URL: >> https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=3147087de323c0294b51006f97b641fc408f1b06 >> Submitter: Gerald Combs (ger...@wireshark.org) >> Changed: branch: master >> Repository: wireshark >> >> Commits: >> >> 3147087 by Gerald Combs (ger...@wireshark.org): >> >>Fix ranlib "has no symbols" errors in the codecs directory. >> >>Don't build the G.722 or G.726 codecs for now. Each are wrapped in >>"#ifdef HAVE_SPANDSP", which we don't define. > > Should we be checking for that library: > > http://www.soft-switch.org > > as per, for example: > > https://www.wireshark.org/lists/wireshark-dev/201412/msg00013.html > > and > > https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5619 > > or is spandsp not yet mature or cross-platform (where "platform" includes > "CPU" - and "generation of the instruction set of that CPU") enough? > > They also say: > > http://www.soft-switch.org/installing-spandsp.html > > "A number of Linux and other software distributions include SpanDSP, but they > usually supply older versions of the library, which lack a lot of the > features of the current version." > > Even if we don't want to use it by default if present, should we have > --with-spandsp, defaulting to "no", so that people don't have to do quite as > much work to use it if they choose to build a custom version of Wireshark? Good for me (There is already some code for CMakeList ?) And there is already some stuff only for Linux only like SBC (Codec for Bluetooth A2DP stream playing) Gerald About GXXX Codec, the Qt port will be enhance this support (with QtMultimediaWidgets) ? (or need always some external lib) Regards, > ___ > Sent via:Wireshark-dev mailing list > Archives:http://www.wireshark.org/lists/wireshark-dev > Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev > mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe ___ Sent via:Wireshark-dev mailing list Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
Re: [Wireshark-dev] [Wireshark-commits] master 3147087: Fix ranlib "has no symbols" errors in the codecs directory.
On Dec 9, 2014, at 1:25 PM, Wireshark code review wrote: > URL: > https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=3147087de323c0294b51006f97b641fc408f1b06 > Submitter: Gerald Combs (ger...@wireshark.org) > Changed: branch: master > Repository: wireshark > > Commits: > > 3147087 by Gerald Combs (ger...@wireshark.org): > >Fix ranlib "has no symbols" errors in the codecs directory. > >Don't build the G.722 or G.726 codecs for now. Each are wrapped in >"#ifdef HAVE_SPANDSP", which we don't define. Should we be checking for that library: http://www.soft-switch.org as per, for example: https://www.wireshark.org/lists/wireshark-dev/201412/msg00013.html and https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5619 or is spandsp not yet mature or cross-platform (where "platform" includes "CPU" - and "generation of the instruction set of that CPU") enough? They also say: http://www.soft-switch.org/installing-spandsp.html "A number of Linux and other software distributions include SpanDSP, but they usually supply older versions of the library, which lack a lot of the features of the current version." Even if we don't want to use it by default if present, should we have --with-spandsp, defaulting to "no", so that people don't have to do quite as much work to use it if they choose to build a custom version of Wireshark? ___ Sent via:Wireshark-dev mailing list Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
