Re: [Wireshark-dev] [Wireshark-commits] master 31f3187: Fix warning: no previous prototype for ... [-Wmissing-prototypes]

2014-08-18 Thread Jeff Morriss

On 08/18/14 09:14, Wireshark code review wrote:

 Fix warning: no previous prototype for ... [-Wmissing-prototypes]

[...]

Actions performed:

 from  3adbd93   Fix warning: no previous prototype for ... 
[-Wmissing-prototypes]
 adds  31f3187   Fix warning: no previous prototype for ... 
[-Wmissing-prototypes]

Summary of changes:
  ui/cli/tap-iousers.c |1 +
  1 file changed, 1 insertion(+)


Would it be reasonable to request fewer commits with the same comment 
but to different files?  E.g., rather than 9 commits covering 10 files 
(as we had here) could there be 1 commit?


Having so many commits makes reading the -commits list more tiring than 
[I think] it should be.


___
Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org
Archives:http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe


Re: [Wireshark-dev] [Wireshark-commits] master 31f3187: Fix warning: no previous prototype for ... [-Wmissing-prototypes]

2014-08-18 Thread Bill Meier

On 8/18/2014 5:11 PM, Jeff Morriss wrote:

On 08/18/14 09:14, Wireshark code review wrote:

 Fix warning: no previous prototype for ... [-Wmissing-prototypes]

[...]

Actions performed:

 from  3adbd93   Fix warning: no previous prototype for ...
[-Wmissing-prototypes]
 adds  31f3187   Fix warning: no previous prototype for ...
[-Wmissing-prototypes]

Summary of changes:
  ui/cli/tap-iousers.c |1 +
  1 file changed, 1 insertion(+)


Would it be reasonable to request fewer commits with the same comment
but to different files?  E.g., rather than 9 commits covering 10 files
(as we had here) could there be 1 commit?

Having so many commits makes reading the -commits list more tiring than
[I think] it should be.




+1



___
Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org
Archives:http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe