Re: [Wireshark-dev] [Wireshark-commits] rev 38304: /trunk/epan/dissectors/ /trunk/epan/dissectors/: packet-snmp.c
Gerald Combs wrote: On 10/4/11 1:11 PM, Jeff Morriss wrote: Balint Reczey wrote: Let's make Python a requirement now. I fully support the idea of not keeping generated files in SVN and in the release tarball. I know it's been a while, but... Any other thoughts/votes on this topic? It's fine with me. One downside with this is that it takes (at least on my not-that-old home PC) about 3.5 minutes to build all the ASN.1 dissectors (time make -C asn1). Since the ASN.1 dissectors are all in subdirectories (and each subdir has only one target) the build does not parallelize (make -j X) well. It probably could be made more parallel through some ugliness (making what is currently a recursive build non-recursive). Thoughts? ___ Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
Re: [Wireshark-dev] [Wireshark-commits] rev 38304: /trunk/epan/dissectors/ /trunk/epan/dissectors/: packet-snmp.c
On 10/07/2011 04:07 PM, Jeff Morriss wrote: Gerald Combs wrote: On 10/4/11 1:11 PM, Jeff Morriss wrote: Balint Reczey wrote: Let's make Python a requirement now. I fully support the idea of not keeping generated files in SVN and in the release tarball. I know it's been a while, but... Any other thoughts/votes on this topic? It's fine with me. One downside with this is that it takes (at least on my not-that-old home PC) about 3.5 minutes to build all the ASN.1 dissectors (time make -C asn1). Since the ASN.1 dissectors are all in subdirectories (and each subdir has only one target) the build does not parallelize (make -j X) well. It probably could be made more parallel through some ugliness (making what is currently a recursive build non-recursive). Thoughts? We can make it parallel without converting them non-recursive. I'm in for improving the parallelism. Cheers, Balint ___ Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
Re: [Wireshark-dev] [Wireshark-commits] rev 38304: /trunk/epan/dissectors/ /trunk/epan/dissectors/: packet-snmp.c
Balint Reczey wrote: On 10/07/2011 04:07 PM, Jeff Morriss wrote: Gerald Combs wrote: On 10/4/11 1:11 PM, Jeff Morriss wrote: Balint Reczey wrote: Let's make Python a requirement now. I fully support the idea of not keeping generated files in SVN and in the release tarball. I know it's been a while, but... Any other thoughts/votes on this topic? It's fine with me. One downside with this is that it takes (at least on my not-that-old home PC) about 3.5 minutes to build all the ASN.1 dissectors (time make -C asn1). Since the ASN.1 dissectors are all in subdirectories (and each subdir has only one target) the build does not parallelize (make -j X) well. It probably could be made more parallel through some ugliness (making what is currently a recursive build non-recursive). Thoughts? We can make it parallel without converting them non-recursive. I'm in for improving the parallelism. How? (At the moment I'm looking only at automake, but I suppose eventually Windows and CMake must be considered.) ___ Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
Re: [Wireshark-dev] [Wireshark-commits] rev 38304: /trunk/epan/dissectors/ /trunk/epan/dissectors/: packet-snmp.c
On 10/07/2011 04:26 PM, Jeff Morriss wrote: Balint Reczey wrote: On 10/07/2011 04:07 PM, Jeff Morriss wrote: Gerald Combs wrote: On 10/4/11 1:11 PM, Jeff Morriss wrote: Balint Reczey wrote: Let's make Python a requirement now. I fully support the idea of not keeping generated files in SVN and in the release tarball. I know it's been a while, but... Any other thoughts/votes on this topic? It's fine with me. One downside with this is that it takes (at least on my not-that-old home PC) about 3.5 minutes to build all the ASN.1 dissectors (time make -C asn1). Since the ASN.1 dissectors are all in subdirectories (and each subdir has only one target) the build does not parallelize (make -j X) well. It probably could be made more parallel through some ugliness (making what is currently a recursive build non-recursive). Thoughts? We can make it parallel without converting them non-recursive. I'm in for improving the parallelism. How? (At the moment I'm looking only at automake, but I suppose eventually Windows and CMake must be considered.) I was thinking about using build-stamps and inter-directory dependencies without implementing a full non-recursive make system, but I have to investigate the current situation to be sure. In the meantime maybe we could simply speed up the asn2wrs script, but I haven't done any profiling on it yet. Right now I'm getting errors even with -j1. :-( Cheers, Balint ___ Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
Re: [Wireshark-dev] [Wireshark-commits] rev 38304: /trunk/epan/dissectors/ /trunk/epan/dissectors/: packet-snmp.c
Balint Reczey wrote: On 10/07/2011 04:26 PM, Jeff Morriss wrote: Balint Reczey wrote: On 10/07/2011 04:07 PM, Jeff Morriss wrote: Gerald Combs wrote: On 10/4/11 1:11 PM, Jeff Morriss wrote: Balint Reczey wrote: Let's make Python a requirement now. I fully support the idea of not keeping generated files in SVN and in the release tarball. I know it's been a while, but... Any other thoughts/votes on this topic? It's fine with me. One downside with this is that it takes (at least on my not-that-old home PC) about 3.5 minutes to build all the ASN.1 dissectors (time make -C asn1). Since the ASN.1 dissectors are all in subdirectories (and each subdir has only one target) the build does not parallelize (make -j X) well. It probably could be made more parallel through some ugliness (making what is currently a recursive build non-recursive). Thoughts? We can make it parallel without converting them non-recursive. I'm in for improving the parallelism. How? (At the moment I'm looking only at automake, but I suppose eventually Windows and CMake must be considered.) I was thinking about using build-stamps and inter-directory dependencies without implementing a full non-recursive make system, but I have to investigate the current situation to be sure. In the meantime maybe we could simply speed up the asn2wrs script, but I haven't done any profiling on it yet. Right now I'm getting errors even with -j1. :-( I have it working except for asn1/x721 which, well, doesn't actually have a dissector in it yet (need to find a way to make it do nothing for make all). I can check in my changes--thus far just cleanup and putting the asn1 dissectors straight into epan/dissectors/ tonight or this weekend. (I think the changes I made will port over easily to Windows/nmake.) ___ Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
Re: [Wireshark-dev] [Wireshark-commits] rev 38304: /trunk/epan/dissectors/ /trunk/epan/dissectors/: packet-snmp.c
Balint Reczey wrote: Hi, On 08/05/2011 04:01 AM, Jeff Morriss wrote: On 08/04/2011 07:35 PM, Tony Trinh wrote: Isn't Python also necessary for the Wireshark Python API? (It's disabled by default, unlike the Lua API.) Yes, but here we're talking about whether we have/should have a (hard) requirement to have Python in order to compile Wireshark (from the source tarball, which is often different than building from SVN). Let's make Python a requirement now. I fully support the idea of not keeping generated files in SVN and in the release tarball. I know it's been a while, but... Any other thoughts/votes on this topic? ___ Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
Re: [Wireshark-dev] [Wireshark-commits] rev 38304: /trunk/epan/dissectors/ /trunk/epan/dissectors/: packet-snmp.c
On 10/4/11 1:11 PM, Jeff Morriss wrote: Balint Reczey wrote: Let's make Python a requirement now. I fully support the idea of not keeping generated files in SVN and in the release tarball. I know it's been a while, but... Any other thoughts/votes on this topic? It's fine with me. ___ Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
Re: [Wireshark-dev] [Wireshark-commits] rev 38304: /trunk/epan/dissectors/ /trunk/epan/dissectors/: packet-snmp.c
Hi, On 08/05/2011 04:01 AM, Jeff Morriss wrote: On 08/04/2011 07:35 PM, Tony Trinh wrote: Isn't Python also necessary for the Wireshark Python API? (It's disabled by default, unlike the Lua API.) Yes, but here we're talking about whether we have/should have a (hard) requirement to have Python in order to compile Wireshark (from the source tarball, which is often different than building from SVN). Let's make Python a requirement now. I fully support the idea of not keeping generated files in SVN and in the release tarball. Cheers, Balint ___ Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
Re: [Wireshark-dev] [Wireshark-commits] rev 38304: /trunk/epan/dissectors/ /trunk/epan/dissectors/: packet-snmp.c
On Wed, Aug 03, 2011 at 09:36:40PM -0400, Maynard, Chris wrote: On Tue, Aug 02, 2011 at 11:22:03AM -0400, Jeff Morriss wrote: Do we already require Python to build Wireshark [even from a source distribution]? I don't think so. Isn't it? ===C:\Python27\python.exe: /cygdrive/c/Python27/python.exe === Sorry, I was thinking along the lines of do we require python to be linked into Wireshark which is no. But yes, we do use it for building. AFAIK, it is only used to build register.c and packet-ncp.c. At least for register.c, it can also be built with /bin/sh but much more slowly. ___ Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
Re: [Wireshark-dev] [Wireshark-commits] rev 38304: /trunk/epan/dissectors/ /trunk/epan/dissectors/: packet-snmp.c
Stephen Fisher wrote: On Wed, Aug 03, 2011 at 09:36:40PM -0400, Maynard, Chris wrote: On Tue, Aug 02, 2011 at 11:22:03AM -0400, Jeff Morriss wrote: Do we already require Python to build Wireshark [even from a source distribution]? I don't think so. Isn't it? ===C:\Python27\python.exe: /cygdrive/c/Python27/python.exe === Sorry, I was thinking along the lines of do we require python to be linked into Wireshark which is no. But yes, we do use it for building. AFAIK, it is only used to build register.c and packet-ncp.c. At least for register.c, it can also be built with /bin/sh but much more slowly. But this still doesn't mean it's *required* for building from a source tarball. And I think we don't: the README says you only need Python if you're going to modify the NCCP dissector (that is, rebuild packet-ncp.c). As you say, building register.c falls back to sh if Python's not there. (So building the ASN.1 dissectors at compile time would add a requirement to those building from the source tarballs.) ___ Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
Re: [Wireshark-dev] [Wireshark-commits] rev 38304: /trunk/epan/dissectors/ /trunk/epan/dissectors/: packet-snmp.c
Isn't Python also necessary for the Wireshark Python API? (It's disabled by default, unlike the Lua API.) ___ Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
Re: [Wireshark-dev] [Wireshark-commits] rev 38304: /trunk/epan/dissectors/ /trunk/epan/dissectors/: packet-snmp.c
On 08/04/2011 07:35 PM, Tony Trinh wrote: Isn't Python also necessary for the Wireshark Python API? (It's disabled by default, unlike the Lua API.) Yes, but here we're talking about whether we have/should have a (hard) requirement to have Python in order to compile Wireshark (from the source tarball, which is often different than building from SVN). ___ Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
Re: [Wireshark-dev] [Wireshark-commits] rev 38304: /trunk/epan/dissectors/ /trunk/epan/dissectors/: packet-snmp.c
-Original Message- From: wireshark-dev-boun...@wireshark.org [mailto:wireshark-dev- boun...@wireshark.org] On Behalf Of Stephen Fisher Sent: Tuesday, August 02, 2011 11:32 AM To: Developer support list for Wireshark Subject: Re: [Wireshark-dev] [Wireshark-commits] rev 38304: /trunk/epan/dissectors/ /trunk/epan/dissectors/: packet-snmp.c On Tue, Aug 02, 2011 at 11:22:03AM -0400, Jeff Morriss wrote: Do we already require Python to build Wireshark [even from a source distribution]? I don't think so. Isn't it? C:\wireshark\work-svnnmake -f Makefile.nmake verify_tools Microsoft (R) Program Maintenance Utility Version 9.00.30729.01 Copyright (C) Microsoft Corporation. All rights reserved. Checking for required applications: cl: /cygdrive/c/Program Files/Microsoft Visual Studio 9.0/VC/BIN/cl link: /cygdrive/c/Program Files/Microsoft Visual Studio 9.0/VC/BIN/link nmake: /cygdrive/c/Program Files/Microsoft Visual Studio 9.0/VC/BIN/nmake mt: /cygdrive/c/Program Files/Microsoft SDKs/Windows/v6.0A/bin/mt bash: /usr/bin/bash bison: /usr/bin/bison flex: /usr/bin/flex env: /usr/bin/env grep: /usr/bin/grep /usr/bin/find: /usr/bin/find perl: /usr/bin/perl ===C:\Python27\python.exe: /cygdrive/c/Python27/python.exe === sed: /usr/bin/sed unzip: /usr/bin/unzip wget: /usr/bin/wget CONFIDENTIALITY NOTICE: The contents of this email are confidential and for the exclusive use of the intended recipient. If you receive this email in error, please delete it from your system immediately and notify us either by email, telephone or fax. You should not copy, forward, or otherwise disclose the content of the email. ___ Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
Re: [Wireshark-dev] [Wireshark-commits] rev 38304: /trunk/epan/dissectors/ /trunk/epan/dissectors/: packet-snmp.c
On Tue, Aug 02, 2011 at 08:42:53AM -0400, Maynard, Chris wrote: Oops. Thanks. Would it make sense to have these types of dissectors automatically generated at compile time? If there was a way to tell if it was changed and only then generate it, I would say yes. If it is re-generated without changes, I suspect the compiler would recompile it every time. ___ Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
Re: [Wireshark-dev] [Wireshark-commits] rev 38304: /trunk/epan/dissectors/ /trunk/epan/dissectors/: packet-snmp.c
Stephen Fisher wrote: On Tue, Aug 02, 2011 at 08:42:53AM -0400, Maynard, Chris wrote: Oops. Thanks. Would it make sense to have these types of dissectors automatically generated at compile time? Historically this wasn't done because it wasn't sure that asn2wrs was ready for prime time, i.e., stable enough to be run on thousands of people's machines. I don't know if argument still holds or not. It seems like now might be a reasonable time to experiment with changing it. Do we already require Python to build Wireshark [even from a source distribution]? If there was a way to tell if it was changed and only then generate it, I would say yes. If it is re-generated without changes, I suspect the compiler would recompile it every time. 'make' does that for you :-) ___ Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
Re: [Wireshark-dev] [Wireshark-commits] rev 38304: /trunk/epan/dissectors/ /trunk/epan/dissectors/: packet-snmp.c
On Tue, Aug 02, 2011 at 11:22:03AM -0400, Jeff Morriss wrote: Do we already require Python to build Wireshark [even from a source distribution]? I don't think so. If there was a way to tell if it was changed and only then generate it, I would say yes. If it is re-generated without changes, I suspect the compiler would recompile it every time. 'make' does that for you :-) Yes.. :) but what about if the file's modification time is changed because it was re-generated even though the contents of the file are the same? Or will the generating program not re-generate it? ___ Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
Re: [Wireshark-dev] [Wireshark-commits] rev 38304: /trunk/epan/dissectors/ /trunk/epan/dissectors/: packet-snmp.c
Stephen Fisher wrote: On Tue, Aug 02, 2011 at 11:22:03AM -0400, Jeff Morriss wrote: If there was a way to tell if it was changed and only then generate it, I would say yes. If it is re-generated without changes, I suspect the compiler would recompile it every time. 'make' does that for you :-) Yes.. :) but what about if the file's modification time is changed because it was re-generated even though the contents of the file are the same? Or will the generating program not re-generate it? 'make' won't regenerate it unless the source files have changed (e.g., if you type make twice in asn1/snmp, it'll only run asn2wrs once). BUT, we do have some room for improvement there because it does COPY the source over to epan/dissectors twice. A cp -p (assuming that's portable and has a Windows equivalent) would help (by preserving the timestamps) as would simply sending the generation output directly to epan/dissectors . ___ Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
