Re: [Wireshark-dev] German translation issues
Am 10.08.2019 um 19:59 schrieb Roland Knall: > The main reason why the preference pane did not work, where, that > QT_TR_NOOP did not take. I moved the texts inside the class which seemed to > do the trick. I will walk through the rest of the application and see if > this is also the case in some other places. Right now, there are 13 other > instances where QT_TR_NOOP is being used, and I will have to check them > individually My fix for QT_TR_NOOP was to place a tr() around the string variables where they are used, e.g. tr(ADVANCED_PREFERENCE_TREE_NAME). This also did the job. -- Thomas ___ Sent via:Wireshark-dev mailing list Archives:https://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
Re: [Wireshark-dev] German translation issues
Hi The backport will happen on Sunday in an automated fashion. I will have to take a look why it may not include some items. There are two reasons why translations are not effective. The first being text entries, which are declared either by dissectors or inside epan. The main reason why the preference pane did not work, where, that QT_TR_NOOP did not take. I moved the texts inside the class which seemed to do the trick. I will walk through the rest of the application and see if this is also the case in some other places. Right now, there are 13 other instances where QT_TR_NOOP is being used, and I will have to check them individually cheers Roland Am Sa., 10. Aug. 2019 um 13:16 Uhr schrieb Thomas Wiens : > Hi Uli, > > do you know who is doing the backport of the translation files from > transifex to Wireshark? > > I've seen that at transifex all entries in master are translated now, > but they aren't in the wireshark_de.ts file. > > -- > Thomas > ___ > Sent via:Wireshark-dev mailing list > Archives:https://www.wireshark.org/lists/wireshark-dev > Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev > mailto:wireshark-dev-requ...@wireshark.org > ?subject=unsubscribe ___ Sent via:Wireshark-dev mailing list Archives:https://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
Re: [Wireshark-dev] German translation issues
Hi Uli, do you know who is doing the backport of the translation files from transifex to Wireshark? I've seen that at transifex all entries in master are translated now, but they aren't in the wireshark_de.ts file. -- Thomas ___ Sent via:Wireshark-dev mailing list Archives:https://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
Re: [Wireshark-dev] German translation issues
I've seen Roland has fixed this. Roland, are you also working on the other translation problems in the preferences dialog? -- Thomas ___ Sent via:Wireshark-dev mailing list Archives:https://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
Re: [Wireshark-dev] German translation issues
Hi, by the way, is there any known issue why not all text elements are translated correctly? For example in the preferences window all text elements in the tree aren't translated, although the text is packed inside QT_TR_NOOP() for which I understand should do the job. There's also an entry for "Appearance" in the german translation ts-file, but it does not work for me. I still get "Appearance" when I switch to german or any other language. wireshark/ui/qt/models/pref_models.cpp:const char* PrefsModel::APPEARANCE_PREFERENCE_TREE_NAME = QT_TR_NOOP("Appearance"); There are some other text elements which aren't translated. I usually work with the english ui, but when there is a language setting, I'd like to see almost all elements are translated if possible. I'd start working on this, if there is no general problem why some elements can't be translated. I guess for the protocol preferences it's not possible as the texts are inside the protocol dissectors. -- Cheers Thomas Wiens ___ Sent via:Wireshark-dev mailing list Archives:https://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
Re: [Wireshark-dev] German translation issues
Hi Roland > ", %Ln profile(s) skipped" has been translated with "%1" instead of "%Ln" > leading to a display error (%xx must be copied > 1:1 as Qt uses that to format the values differently) Fixed > > "copy" in the context as noun is translated as "kopieren" when it should be > "Kopie". With copy, there is a context > provided (noun) to allow differentiation between other instances of "copy" has been fixed by yourself I haven't been aware about the context info... Cheers Uli ___ Sent via:Wireshark-dev mailing list Archives:https://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
[Wireshark-dev] German translation issues
Hi There are some german translation issues with the git version. As Transifex does not allow me to be added to the german language I hope this is the right place to forward this to. Namely I found two issues so far: ", %Ln profile(s) skipped" has been translated with "%1" instead of "%Ln" leading to a display error (%xx must be copied 1:1 as Qt uses that to format the values differently) "copy" in the context as noun is translated as "kopieren" when it should be "Kopie". With copy, there is a context provided (noun) to allow differentiation between other instances of "copy" kind regards Roland ___ Sent via:Wireshark-dev mailing list Archives:https://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe