Re: [Wireshark-dev] JXTA dissector memory leak?

2007-08-21 Thread Jeff Morriss 


Andrej Mikus wrote:
 On Wed, 28.Mar.07 16:41:59 -0700, Stephen Fisher wrote:
 The dissector file packet-jxta.c has a comment saying that an allocation 
 is a memory leak:

 if (NULL != found_addr) {
  found_addr-type = AT_URI;
  found_addr-len = strlen(*current_token);
  /* FIXME 20050605 bondolo THIS ALLOCATION IS A MEMORY LEAK! */
  found_addr-data = g_strdup(*current_token);
 }

 Anyone familiar enough with this dissector to fix it easily?
 
 Should be enough just to change g_strdup to ep_strdup or se_strdup.
 See README.malloc for more details.

[Wow, came on this old email thread by accident!]

Changed to se_strdup() in rev 22579.  (That address is used in a 
conversation structure which makes it seasonal.)
___
Wireshark-dev mailing list
Wireshark-dev@wireshark.org
http://www.wireshark.org/mailman/listinfo/wireshark-dev

[Wireshark-dev] JXTA dissector memory leak?

2007-03-28 Thread Stephen Fisher 
The dissector file packet-jxta.c has a comment saying that an allocation 
is a memory leak:

if (NULL != found_addr) {
found_addr-type = AT_URI;
found_addr-len = strlen(*current_token);
/* FIXME 20050605 bondolo THIS ALLOCATION IS A MEMORY LEAK! */
found_addr-data = g_strdup(*current_token);
}

Anyone familiar enough with this dissector to fix it easily?


Steve

___
Wireshark-dev mailing list
Wireshark-dev@wireshark.org
http://www.wireshark.org/mailman/listinfo/wireshark-dev

Re: [Wireshark-dev] JXTA dissector memory leak?

2007-03-28 Thread Andrej Mikus 
On Wed, 28.Mar.07 16:41:59 -0700, Stephen Fisher wrote:
 The dissector file packet-jxta.c has a comment saying that an allocation 
 is a memory leak:
 
 if (NULL != found_addr) {
   found_addr-type = AT_URI;
   found_addr-len = strlen(*current_token);
   /* FIXME 20050605 bondolo THIS ALLOCATION IS A MEMORY LEAK! */
   found_addr-data = g_strdup(*current_token);
 }
 
 Anyone familiar enough with this dissector to fix it easily?

Should be enough just to change g_strdup to ep_strdup or se_strdup.
See README.malloc for more details.

Andrej
___
Wireshark-dev mailing list
Wireshark-dev@wireshark.org
http://www.wireshark.org/mailman/listinfo/wireshark-dev