Re: [Wireshark-dev] MSVC 2015 (VC14) notes/issue

2015-08-31 Thread Bill Meier 

On 8/31/2015 4:24 AM, Pascal Quantin wrote:

 > May be directly move to GeoIP 2 ?
 > https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=10658
 >
 >
 >
 > I think the code is available from here:
 >
 > https://github.com/maxmind/libmaxminddb

Hi all,

I propose to do it in 2 steps as changing the library is more work than
upgrading the current one:
- first recompile version 1.6.6 and see if it solves the build issue
with MSVC2015 (I'm gonna cross compile it as I have the environment). I
will send an email once it is ready for testing (as I did for Lua).
- then eventually change the library (and keep backward compatibility
with the older one?).




According to https://github.com/maxmind/libmaxminddb, the license is 
Apache V2.



From: http://www.apache.org/licenses/GPL-compatibility.html

"Despite our best efforts, the FSF has never considered the Apache 
License to be compatible with GPL version 2, citing the patent 
termination and indemnification provisions as restrictions not present 
in the older GPL license. The Apache Software Foundation believes that 
you should always try to obey the constraints expressed by the copyright 
holder when redistributing their work."


So: It would seem that doing an upgrade to use libmaxminddb may not be OK.

(I did the license chack after noticing that the Fedora22 repository 
does not contain libmaxminddb).




___
Sent via:Wireshark-dev mailing list 
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

Re: [Wireshark-dev] MSVC 2015 (VC14) notes/issue

2015-08-31 Thread Pascal Quantin 
2015-08-31 18:10 GMT+02:00 Bill Meier :

> On 8/31/2015 4:24 AM, Pascal Quantin wrote:
>
>>  > May be directly move to GeoIP 2 ?
>>  > https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=10658
>>  >
>>  >
>>  >
>>  > I think the code is available from here:
>>  >
>>  > https://github.com/maxmind/libmaxminddb
>>
>> Hi all,
>>
>> I propose to do it in 2 steps as changing the library is more work than
>> upgrading the current one:
>> - first recompile version 1.6.6 and see if it solves the build issue
>> with MSVC2015 (I'm gonna cross compile it as I have the environment). I
>> will send an email once it is ready for testing (as I did for Lua).
>> - then eventually change the library (and keep backward compatibility
>> with the older one?).
>>
>>
>
> According to https://github.com/maxmind/libmaxminddb, the license is
> Apache V2.
>
>
> From: http://www.apache.org/licenses/GPL-compatibility.html
>
> "Despite our best efforts, the FSF has never considered the Apache License
> to be compatible with GPL version 2, citing the patent termination and
> indemnification provisions as restrictions not present in the older GPL
> license. The Apache Software Foundation believes that you should always try
> to obey the constraints expressed by the copyright holder when
> redistributing their work."
>
> So: It would seem that doing an upgrade to use libmaxminddb may not be OK.
>
> (I did the license chack after noticing that the Fedora22 repository does
> not contain libmaxminddb).
>
>
Interesting... You should definitely put this in bug 10658.

Pascal.
___
Sent via:Wireshark-dev mailing list 
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

Re: [Wireshark-dev] MSVC 2015 (VC14) notes/issue

2015-08-31 Thread Alexis La Goutte 
On Sun, Aug 30, 2015 at 11:25 PM, Bill Meier  wrote:

> On 8/12/2015 12:21 PM, Bill Meier wrote:
>
>>
>> 2. I had to disable building with geoip because:
>>
>> #error:  Macro definition of snprintf conflicts with Stan
>> dard Library function declaration (compiling source file packet-ip.c)
>>
>>
>>
>
> A little digging finds that the Windows Wireshark version of the GeoIP
> library(1.5.2) is a bit old; The current version (on GitHub [1]) is 1.6.6
> and has had various fixes made since 1.5.2.
>
> I also note that the 1.6.6 GeoIP.h no longer has the macro definition for
> snprintf so the MSVC2015 GeoIP compile problem obviously won't occur using
> the latest version.
>
> I don't really know to create the GeoIP libraries (and couldn't easily do
> a 64 bit version anyway) so I'll leave this as a ToDo for others (Gerald ?).
>
> (Obviously there's no urgency for this).
>
> [1] https://github.com/maxmind/geoip-api-c
>
> May be directly move to GeoIP 2 ?
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=10658

Cheers,

>
> Bill
>
>
>
> ___
> Sent via:Wireshark-dev mailing list 
> Archives:https://www.wireshark.org/lists/wireshark-dev
> Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
> mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
>
___
Sent via:Wireshark-dev mailing list 
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

Re: [Wireshark-dev] MSVC 2015 (VC14) notes/issue

2015-08-31 Thread Anders Broman 


From: wireshark-dev-boun...@wireshark.org 
[mailto:wireshark-dev-boun...@wireshark.org] On Behalf Of Alexis La Goutte
Sent: den 31 augusti 2015 09:43
To: Developer support list for Wireshark
Subject: Re: [Wireshark-dev] MSVC 2015 (VC14) notes/issue



On Sun, Aug 30, 2015 at 11:25 PM, Bill Meier 
<wme...@newsguy.com<mailto:wme...@newsguy.com>> wrote:
On 8/12/2015 12:21 PM, Bill Meier wrote:

2. I had to disable building with geoip because:

#error:  Macro definition of snprintf conflicts with Stan
dard Library function declaration (compiling source file packet-ip.c)



A little digging finds that the Windows Wireshark version of the GeoIP 
library(1.5.2) is a bit old; The current version (on GitHub [1]) is 1.6.6 and 
has had various fixes made since 1.5.2.

I also note that the 1.6.6 GeoIP.h no longer has the macro definition for 
snprintf so the MSVC2015 GeoIP compile problem obviously won't occur using the 
latest version.

I don't really know to create the GeoIP libraries (and couldn't easily do a 64 
bit version anyway) so I'll leave this as a ToDo for others (Gerald ?).

(Obviously there's no urgency for this).

[1] https://github.com/maxmind/geoip-api-c

May be directly move to GeoIP 2 ?
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=10658

I think the code is available from here:
https://github.com/maxmind/libmaxminddb
Regards
Anders


Cheers,

Bill



___
Sent via:Wireshark-dev mailing list 
<wireshark-dev@wireshark.org<mailto:wireshark-dev@wireshark.org>>
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev

mailto:wireshark-dev-requ...@wireshark.org<mailto:wireshark-dev-requ...@wireshark.org>?subject=unsubscribe

___
Sent via:Wireshark-dev mailing list <wireshark-dev@wireshark.org>
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

Re: [Wireshark-dev] MSVC 2015 (VC14) notes/issue

2015-08-31 Thread Anders Broman 
Den 31 aug 2015 10:24 skrev "Pascal Quantin" <pascal.quan...@gmail.com>:
>
>
> Le 31 août 2015 10:09 AM, "Anders Broman" <anders.bro...@ericsson.com> a
écrit :
> >
> >
> >
> >
> >
> > From: wireshark-dev-boun...@wireshark.org [mailto:
wireshark-dev-boun...@wireshark.org] On Behalf Of Alexis La Goutte
> > Sent: den 31 augusti 2015 09:43
> > To: Developer support list for Wireshark
> > Subject: Re: [Wireshark-dev] MSVC 2015 (VC14) notes/issue
> >
> >
> >
> >
> >
> >
> >
> > On Sun, Aug 30, 2015 at 11:25 PM, Bill Meier <wme...@newsguy.com> wrote:
> >
> > On 8/12/2015 12:21 PM, Bill Meier wrote:
> >
> >
> > 2. I had to disable building with geoip because:
> >
> > #error:  Macro definition of snprintf conflicts with Stan
> > dard Library function declaration (compiling source file packet-ip.c)
> >
> >
> >
> > A little digging finds that the Windows Wireshark version of the GeoIP
library(1.5.2) is a bit old; The current version (on GitHub [1]) is 1.6.6
and has had various fixes made since 1.5.2.
> >
> > I also note that the 1.6.6 GeoIP.h no longer has the macro definition
for snprintf so the MSVC2015 GeoIP compile problem obviously won't occur
using the latest version.
> >
> > I don't really know to create the GeoIP libraries (and couldn't easily
do a 64 bit version anyway) so I'll leave this as a ToDo for others (Gerald
?).
> >
> > (Obviously there's no urgency for this).
> >
> > [1] https://github.com/maxmind/geoip-api-c
> >
> >
> >
> > May be directly move to GeoIP 2 ?
> > https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=10658
> >
> >
> >
> > I think the code is available from here:
> >
> > https://github.com/maxmind/libmaxminddb
>
> Hi all,
>
> I propose to do it in 2 steps as changing the library is more work than
upgrading the current one:
> - first recompile version 1.6.6 and see if it solves the build issue with
MSVC2015 (I'm gonna cross compile it as I have the environment). I will
send an email once it is ready for testing (as I did for Lua).
> - then eventually change the library (and keep backward compatibility
with the older one?).
>
> Cheers,
> Pascal.
>

Sounds good to me.
Regards
Anders

>
>
___
> Sent via:Wireshark-dev mailing list <wireshark-dev@wireshark.org>
> Archives:https://www.wireshark.org/lists/wireshark-dev
> Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
>  mailto:wireshark-dev-requ...@wireshark.org
?subject=unsubscribe
___
Sent via:Wireshark-dev mailing list <wireshark-dev@wireshark.org>
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

Re: [Wireshark-dev] MSVC 2015 (VC14) notes/issue

2015-08-31 Thread Pascal Quantin 
Le 31 août 2015 10:09 AM, "Anders Broman" <anders.bro...@ericsson.com> a
écrit :
>
>
>
>
>
> From: wireshark-dev-boun...@wireshark.org [mailto:
wireshark-dev-boun...@wireshark.org] On Behalf Of Alexis La Goutte
> Sent: den 31 augusti 2015 09:43
> To: Developer support list for Wireshark
> Subject: Re: [Wireshark-dev] MSVC 2015 (VC14) notes/issue
>
>
>
>
>
>
>
> On Sun, Aug 30, 2015 at 11:25 PM, Bill Meier <wme...@newsguy.com> wrote:
>
> On 8/12/2015 12:21 PM, Bill Meier wrote:
>
>
> 2. I had to disable building with geoip because:
>
> #error:  Macro definition of snprintf conflicts with Stan
> dard Library function declaration (compiling source file packet-ip.c)
>
>
>
> A little digging finds that the Windows Wireshark version of the GeoIP
library(1.5.2) is a bit old; The current version (on GitHub [1]) is 1.6.6
and has had various fixes made since 1.5.2.
>
> I also note that the 1.6.6 GeoIP.h no longer has the macro definition for
snprintf so the MSVC2015 GeoIP compile problem obviously won't occur using
the latest version.
>
> I don't really know to create the GeoIP libraries (and couldn't easily do
a 64 bit version anyway) so I'll leave this as a ToDo for others (Gerald ?).
>
> (Obviously there's no urgency for this).
>
> [1] https://github.com/maxmind/geoip-api-c
>
>
>
> May be directly move to GeoIP 2 ?
> https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=10658
>
>
>
> I think the code is available from here:
>
> https://github.com/maxmind/libmaxminddb

Hi all,

I propose to do it in 2 steps as changing the library is more work than
upgrading the current one:
- first recompile version 1.6.6 and see if it solves the build issue with
MSVC2015 (I'm gonna cross compile it as I have the environment). I will
send an email once it is ready for testing (as I did for Lua).
- then eventually change the library (and keep backward compatibility with
the older one?).

Cheers,
Pascal.
___
Sent via:Wireshark-dev mailing list <wireshark-dev@wireshark.org>
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

Re: [Wireshark-dev] MSVC 2015 (VC14) notes/issue

2015-08-30 Thread Pascal Quantin 
Hi all,

2015-08-12 18:57 GMT+02:00 Pascal Quantin pascal.quan...@gmail.com:

 Hi,
 Le 12 août 2015 6:21 PM, Bill Meier wme...@newsguy.com a écrit :
 
  [Resend]
 
  I see that several people (Anders, ...) been building with MSVC-2015
 (VC14) and have fixed a number of issues.
 
  So: I decided to download VC14 and give it a try (using NMake).
 
  A few questions:
 
  Are you using CMake or NMake ?
 
  If using NMake, I assume that you've updated config.nmake  etc. Is
 there some reason you've not committed the changes ?
 
  If not, I've made what I think are the required changes for NMake. Do
 you think it's Ok to commit them ?
 
 
 
  Have you been able to do a complete build ?
 
  So far:
 
  1. Compiling packet-pdc.c gets:
 
  [...]\packet-pdc.c(205) : fatal error C1001: An internal error has
 occurred in the compiler.
  (compiler file 'f:\dd\vctools\compiler\utc\src\p2\main.c', line 246)
   To work around this problem, try simplifying or changing the program
 near the locations listed above.
  Please choose the Technical Support command on the Visual C++
   Help menu, or open the Technical Support help file for more information
 
  INTERNAL COMPILER ERROR in 'C:\Program Files\Microsoft Visual Studio
 14.0\VC\BIN\cl.exe'
  Please choose the Technical Support command on the Visual C++
  Help menu, or open the Technical Support help file for more
 information
 
  I've figured out what to change to fix this.
  (I've also extracted a much smaller test file which causes the error and
 will submit the file to Microsoft).
 
 
 
  2. I had to disable building with geoip because:
 
  C:\Program Files\Windows
 Kits\10\include\10.0.10150.0\ucrt\stdio.h(1925): warning C4005: 'snprintf':
 macro redefinition (compiling source file packet-
  ip.c)
  [...]\GeoIP-1.5.1-2-win32ws\include\GeoIP.h(36): note: see previous
 definition of 'snprintf' (compili
  ng source file packet-ip.c)
  C:\Program Files\Windows
 Kits\10\include\10.0.10150.0\ucrt\stdio.h(1927): fatal error C1189:
 #error:  Macro definition of snprintf conflicts with Stan
  dard Library function declaration (compiling source file packet-ip.c)
 
 
  3. I disabled building with LUA because there's apparently yet no LUA
 library (dll) for use with VC14.

 I might have a look at it when coming back from vacation if the packager I
 used last time did not update the library (I have no reliable Internet
 access right now, yes this is still possible nowadays :)). But I was not in
 a hurry as there is no Qt package compiled with MSVC2015 yet, so we still
 have a strong dependency on MSVC2013.


I have now uploaded Lua libraries compiled with MSVC2015. Could one of you
having this compiler give a try to
https://code.wireshark.org/review/#/c/10313/ ?

Thanks,
Pascal.

 libraries compiled with MSVC =
 
  After addressing #1, #2  #3 above (as well as an issue in
 packet-lwres.c), I got a complete working build (based upon a quick test).
 
 
  4. When compiling with code-analysis enabled, I'm getting a boatload of
 the following warning message:
 
  c:\program files\windows kits\10\include\10.0.10150.0
  \ucrt\string.h(130) : warning C28252: Inconsistent annotation for
  'strcpy': _Param_(1) has 'SAL_w
  ritableTo(elementCount(_String_length_(__formal(1,parameter1))+1))' on
  the prior instance. See no file(0).
 
 
  This makes using analysis with vc14 kind of difficult.
 
 
  Bill
 
 ___
  Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org
  Archives:https://www.wireshark.org/lists/wireshark-dev
  Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
  mailto:wireshark-dev-requ...@wireshark.org
 ?subject=unsubscribe

___
Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

Re: [Wireshark-dev] MSVC 2015 (VC14) notes/issue

2015-08-30 Thread Bill Meier 

On 8/12/2015 12:21 PM, Bill Meier wrote:


2. I had to disable building with geoip because:

#error:  Macro definition of snprintf conflicts with Stan
dard Library function declaration (compiling source file packet-ip.c)





A little digging finds that the Windows Wireshark version of the GeoIP 
library(1.5.2) is a bit old; The current version (on GitHub [1]) is 
1.6.6 and has had various fixes made since 1.5.2.


I also note that the 1.6.6 GeoIP.h no longer has the macro definition 
for snprintf so the MSVC2015 GeoIP compile problem obviously won't occur 
using the latest version.


I don't really know to create the GeoIP libraries (and couldn't easily 
do a 64 bit version anyway) so I'll leave this as a ToDo for others 
(Gerald ?).


(Obviously there's no urgency for this).

[1] https://github.com/maxmind/geoip-api-c

Bill



___
Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

Re: [Wireshark-dev] MSVC 2015 (VC14) notes/issue

2015-08-12 Thread Pascal Quantin 
Le 12 août 2015 7:19 PM, Graham Bloice graham.blo...@trihedral.com a
écrit :

 On 12 August 2015 at 17:57, Pascal Quantin pascal.quan...@gmail.com
wrote:

 Hi,

 Le 12 août 2015 6:21 PM, Bill Meier wme...@newsguy.com a écrit :
 
  [Resend]
 
  I see that several people (Anders, ...) been building with MSVC-2015
(VC14) and have fixed a number of issues.
 
  So: I decided to download VC14 and give it a try (using NMake).
 
  A few questions:
 
  Are you using CMake or NMake ?
 
  If using NMake, I assume that you've updated config.nmake  etc. Is
there some reason you've not committed the changes ?
 
  If not, I've made what I think are the required changes for NMake. Do
you think it's Ok to commit them ?
 
 
 
  Have you been able to do a complete build ?
 
  So far:
 
  1. Compiling packet-pdc.c gets:
 
  [...]\packet-pdc.c(205) : fatal error C1001: An internal error has
occurred in the compiler.
  (compiler file 'f:\dd\vctools\compiler\utc\src\p2\main.c', line 246)
   To work around this problem, try simplifying or changing the program
near the locations listed above.
  Please choose the Technical Support command on the Visual C++
   Help menu, or open the Technical Support help file for more
information
 
  INTERNAL COMPILER ERROR in 'C:\Program Files\Microsoft Visual Studio
14.0\VC\BIN\cl.exe'
  Please choose the Technical Support command on the Visual C++
  Help menu, or open the Technical Support help file for more
information
 
  I've figured out what to change to fix this.
  (I've also extracted a much smaller test file which causes the error
and will submit the file to Microsoft).
 
 
 
  2. I had to disable building with geoip because:
 
  C:\Program Files\Windows
Kits\10\include\10.0.10150.0\ucrt\stdio.h(1925): warning C4005: 'snprintf':
macro redefinition (compiling source file packet-
  ip.c)
  [...]\GeoIP-1.5.1-2-win32ws\include\GeoIP.h(36): note: see previous
definition of 'snprintf' (compili
  ng source file packet-ip.c)
  C:\Program Files\Windows
Kits\10\include\10.0.10150.0\ucrt\stdio.h(1927): fatal error C1189:
#error:  Macro definition of snprintf conflicts with Stan
  dard Library function declaration (compiling source file packet-ip.c)
 
 
  3. I disabled building with LUA because there's apparently yet no LUA
library (dll) for use with VC14.

 I might have a look at it when coming back from vacation if the packager
I used last time did not update the library (I have no reliable Internet
access right now, yes this is still possible nowadays :)). But I was not in
a hurry as there is no Qt package compiled with MSVC2015 yet, so we still
have a strong dependency on MSVC2013.

 Pascal.

 FYI Windows CMake doesn't currently seem to configure without Qt, I'm not
too fussed about that as on Windows the Qt version is the main build.

 The QT folks had previously indicated VS2015 support would be released as
a 5.5.x release so it's likely not too far off:
https://blog.qt.io/blog/2015/04/29/windows-10-support-in-qt/

 Enjoying your vacation in the mountains Pascal?

Yep, in the Cevennes for now and moving to the Alps soon :)



 --
 Graham Bloice


___
 Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org
 Archives:https://www.wireshark.org/lists/wireshark-dev
 Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
  mailto:wireshark-dev-requ...@wireshark.org
?subject=unsubscribe
___
Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

[Wireshark-dev] MSVC 2015 (VC14) notes/issue

2015-08-12 Thread Bill Meier 

[Resend]

I see that several people (Anders, ...) been building with MSVC-2015 
(VC14) and have fixed a number of issues.


So: I decided to download VC14 and give it a try (using NMake).

A few questions:

Are you using CMake or NMake ?

If using NMake, I assume that you've updated config.nmake  etc. Is 
there some reason you've not committed the changes ?


If not, I've made what I think are the required changes for NMake. Do 
you think it's Ok to commit them ?




Have you been able to do a complete build ?

So far:

1. Compiling packet-pdc.c gets:

[...]\packet-pdc.c(205) : fatal error C1001: An internal error has 
occurred in the compiler.

(compiler file 'f:\dd\vctools\compiler\utc\src\p2\main.c', line 246)
 To work around this problem, try simplifying or changing the program 
near the locations listed above.

Please choose the Technical Support command on the Visual C++
 Help menu, or open the Technical Support help file for more information

INTERNAL COMPILER ERROR in 'C:\Program Files\Microsoft Visual Studio 
14.0\VC\BIN\cl.exe'

Please choose the Technical Support command on the Visual C++
Help menu, or open the Technical Support help file for more information

I've figured out what to change to fix this.
(I've also extracted a much smaller test file which causes the error and 
will submit the file to Microsoft).




2. I had to disable building with geoip because:

C:\Program Files\Windows 
Kits\10\include\10.0.10150.0\ucrt\stdio.h(1925): warning C4005: 
'snprintf': macro redefinition (compiling source file packet-

ip.c)
[...]\GeoIP-1.5.1-2-win32ws\include\GeoIP.h(36): note: see previous 
definition of 'snprintf' (compili

ng source file packet-ip.c)
C:\Program Files\Windows 
Kits\10\include\10.0.10150.0\ucrt\stdio.h(1927): fatal error C1189: 
#error:  Macro definition of snprintf conflicts with Stan

dard Library function declaration (compiling source file packet-ip.c)


3. I disabled building with LUA because there's apparently yet no LUA 
library (dll) for use with VC14.



After addressing #1, #2  #3 above (as well as an issue in 
packet-lwres.c), I got a complete working build (based upon a quick test).



4. When compiling with code-analysis enabled, I'm getting a boatload of 
the following warning message:


c:\program files\windows kits\10\include\10.0.10150.0
\ucrt\string.h(130) : warning C28252: Inconsistent annotation for
'strcpy': _Param_(1) has 'SAL_w
ritableTo(elementCount(_String_length_(__formal(1,parameter1))+1))' on
the prior instance. See no file(0).


This makes using analysis with vc14 kind of difficult.


Bill
___
Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

Re: [Wireshark-dev] MSVC 2015 (VC14) notes/issue

2015-08-12 Thread Graham Bloice 
On 12 August 2015 at 17:21, Bill Meier wme...@newsguy.com wrote:

 [Resend]

 I see that several people (Anders, ...) been building with MSVC-2015
 (VC14) and have fixed a number of issues.

 So: I decided to download VC14 and give it a try (using NMake).

 A few questions:

 Are you using CMake or NMake ?


I think the general plan was to move to CMake, although there are some
hold-outs.  README.cmake has the details, although there would be some
adjustments required to generate a solution for VS2015 (I think the CMake
generator option is Visual Studio 14).

I've been meaning to update the Dev Guide to have CMake as the primary
build for Windows for some time, but spare time to do it has been limited.


 If using NMake, I assume that you've updated config.nmake  etc. Is there
 some reason you've not committed the changes ?

 If not, I've made what I think are the required changes for NMake. Do you
 think it's Ok to commit them ?


See change 8683, I presume that's still live Anders?




 Have you been able to do a complete build ?

 So far:

 1. Compiling packet-pdc.c gets:

 [...]\packet-pdc.c(205) : fatal error C1001: An internal error has
 occurred in the compiler.
 (compiler file 'f:\dd\vctools\compiler\utc\src\p2\main.c', line 246)
  To work around this problem, try simplifying or changing the program near
 the locations listed above.
 Please choose the Technical Support command on the Visual C++
  Help menu, or open the Technical Support help file for more information

 INTERNAL COMPILER ERROR in 'C:\Program Files\Microsoft Visual Studio
 14.0\VC\BIN\cl.exe'
 Please choose the Technical Support command on the Visual C++
 Help menu, or open the Technical Support help file for more information

 I've figured out what to change to fix this.
 (I've also extracted a much smaller test file which causes the error and
 will submit the file to Microsoft).



 2. I had to disable building with geoip because:

 C:\Program Files\Windows Kits\10\include\10.0.10150.0\ucrt\stdio.h(1925):
 warning C4005: 'snprintf': macro redefinition (compiling source file packet-
 ip.c)
 [...]\GeoIP-1.5.1-2-win32ws\include\GeoIP.h(36): note: see previous
 definition of 'snprintf' (compili
 ng source file packet-ip.c)
 C:\Program Files\Windows Kits\10\include\10.0.10150.0\ucrt\stdio.h(1927):
 fatal error C1189: #error:  Macro definition of snprintf conflicts with Stan
 dard Library function declaration (compiling source file packet-ip.c)


 3. I disabled building with LUA because there's apparently yet no LUA
 library (dll) for use with VC14.


CMake should handle that, I'd like to know if it doesn't.



 After addressing #1, #2  #3 above (as well as an issue in
 packet-lwres.c), I got a complete working build (based upon a quick test).


 4. When compiling with code-analysis enabled, I'm getting a boatload of
 the following warning message:

 c:\program files\windows kits\10\include\10.0.10150.0
 \ucrt\string.h(130) : warning C28252: Inconsistent annotation for
 'strcpy': _Param_(1) has 'SAL_w
 ritableTo(elementCount(_String_length_(__formal(1,parameter1))+1))' on
 the prior instance. See no file(0).


 This makes using analysis with vc14 kind of difficult.


I've also noticed that elsewhere.  Looks like a MS issue with bad SAL
annotations in the SDK headers.


-- 
Graham Bloice
___
Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

Re: [Wireshark-dev] MSVC 2015 (VC14) notes/issue

2015-08-12 Thread Pascal Quantin 
Hi,
Le 12 août 2015 6:21 PM, Bill Meier wme...@newsguy.com a écrit :

 [Resend]

 I see that several people (Anders, ...) been building with MSVC-2015
(VC14) and have fixed a number of issues.

 So: I decided to download VC14 and give it a try (using NMake).

 A few questions:

 Are you using CMake or NMake ?

 If using NMake, I assume that you've updated config.nmake  etc. Is there
some reason you've not committed the changes ?

 If not, I've made what I think are the required changes for NMake. Do you
think it's Ok to commit them ?



 Have you been able to do a complete build ?

 So far:

 1. Compiling packet-pdc.c gets:

 [...]\packet-pdc.c(205) : fatal error C1001: An internal error has
occurred in the compiler.
 (compiler file 'f:\dd\vctools\compiler\utc\src\p2\main.c', line 246)
  To work around this problem, try simplifying or changing the program
near the locations listed above.
 Please choose the Technical Support command on the Visual C++
  Help menu, or open the Technical Support help file for more information

 INTERNAL COMPILER ERROR in 'C:\Program Files\Microsoft Visual Studio
14.0\VC\BIN\cl.exe'
 Please choose the Technical Support command on the Visual C++
 Help menu, or open the Technical Support help file for more
information

 I've figured out what to change to fix this.
 (I've also extracted a much smaller test file which causes the error and
will submit the file to Microsoft).



 2. I had to disable building with geoip because:

 C:\Program Files\Windows Kits\10\include\10.0.10150.0\ucrt\stdio.h(1925):
warning C4005: 'snprintf': macro redefinition (compiling source file packet-
 ip.c)
 [...]\GeoIP-1.5.1-2-win32ws\include\GeoIP.h(36): note: see previous
definition of 'snprintf' (compili
 ng source file packet-ip.c)
 C:\Program Files\Windows Kits\10\include\10.0.10150.0\ucrt\stdio.h(1927):
fatal error C1189: #error:  Macro definition of snprintf conflicts with Stan
 dard Library function declaration (compiling source file packet-ip.c)


 3. I disabled building with LUA because there's apparently yet no LUA
library (dll) for use with VC14.

I might have a look at it when coming back from vacation if the packager I
used last time did not update the library (I have no reliable Internet
access right now, yes this is still possible nowadays :)). But I was not in
a hurry as there is no Qt package compiled with MSVC2015 yet, so we still
have a strong dependency on MSVC2013.

Pascal.



 After addressing #1, #2  #3 above (as well as an issue in
packet-lwres.c), I got a complete working build (based upon a quick test).


 4. When compiling with code-analysis enabled, I'm getting a boatload of
the following warning message:

 c:\program files\windows kits\10\include\10.0.10150.0
 \ucrt\string.h(130) : warning C28252: Inconsistent annotation for
 'strcpy': _Param_(1) has 'SAL_w
 ritableTo(elementCount(_String_length_(__formal(1,parameter1))+1))' on
 the prior instance. See no file(0).


 This makes using analysis with vc14 kind of difficult.


 Bill

___
 Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org
 Archives:https://www.wireshark.org/lists/wireshark-dev
 Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
___
Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

Re: [Wireshark-dev] MSVC 2015 (VC14) notes/issue

2015-08-12 Thread Graham Bloice 
On 12 August 2015 at 17:57, Pascal Quantin pascal.quan...@gmail.com wrote:

 Hi,
 Le 12 août 2015 6:21 PM, Bill Meier wme...@newsguy.com a écrit :
 
  [Resend]
 
  I see that several people (Anders, ...) been building with MSVC-2015
 (VC14) and have fixed a number of issues.
 
  So: I decided to download VC14 and give it a try (using NMake).
 
  A few questions:
 
  Are you using CMake or NMake ?
 
  If using NMake, I assume that you've updated config.nmake  etc. Is
 there some reason you've not committed the changes ?
 
  If not, I've made what I think are the required changes for NMake. Do
 you think it's Ok to commit them ?
 
 
 
  Have you been able to do a complete build ?
 
  So far:
 
  1. Compiling packet-pdc.c gets:
 
  [...]\packet-pdc.c(205) : fatal error C1001: An internal error has
 occurred in the compiler.
  (compiler file 'f:\dd\vctools\compiler\utc\src\p2\main.c', line 246)
   To work around this problem, try simplifying or changing the program
 near the locations listed above.
  Please choose the Technical Support command on the Visual C++
   Help menu, or open the Technical Support help file for more information
 
  INTERNAL COMPILER ERROR in 'C:\Program Files\Microsoft Visual Studio
 14.0\VC\BIN\cl.exe'
  Please choose the Technical Support command on the Visual C++
  Help menu, or open the Technical Support help file for more
 information
 
  I've figured out what to change to fix this.
  (I've also extracted a much smaller test file which causes the error and
 will submit the file to Microsoft).
 
 
 
  2. I had to disable building with geoip because:
 
  C:\Program Files\Windows
 Kits\10\include\10.0.10150.0\ucrt\stdio.h(1925): warning C4005: 'snprintf':
 macro redefinition (compiling source file packet-
  ip.c)
  [...]\GeoIP-1.5.1-2-win32ws\include\GeoIP.h(36): note: see previous
 definition of 'snprintf' (compili
  ng source file packet-ip.c)
  C:\Program Files\Windows
 Kits\10\include\10.0.10150.0\ucrt\stdio.h(1927): fatal error C1189:
 #error:  Macro definition of snprintf conflicts with Stan
  dard Library function declaration (compiling source file packet-ip.c)
 
 
  3. I disabled building with LUA because there's apparently yet no LUA
 library (dll) for use with VC14.

 I might have a look at it when coming back from vacation if the packager I
 used last time did not update the library (I have no reliable Internet
 access right now, yes this is still possible nowadays :)). But I was not in
 a hurry as there is no Qt package compiled with MSVC2015 yet, so we still
 have a strong dependency on MSVC2013.

 Pascal.

FYI Windows CMake doesn't currently seem to configure without Qt, I'm not
too fussed about that as on Windows the Qt version is the main build.

The QT folks had previously indicated VS2015 support would be released as a
5.5.x release so it's likely not too far off:
https://blog.qt.io/blog/2015/04/29/windows-10-support-in-qt/

Enjoying your vacation in the mountains Pascal?


-- 
Graham Bloice
___
Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

Re: [Wireshark-dev] MSVC 2015 (VC14) notes/issue

2015-08-12 Thread Bill Meier 


I used nmake



 If using NMake, I assume that you've updated config.nmake  etc.
Is there some reason you've not committed the changes ?





Oops: I hadn't checked for and noticed change #8683.  I would have saved 
myself a lot of effort.  I'll try it out.






 So far:

 1. Compiling packet-pdc.c gets:



I didn't encounter that problem...



I'll see if I get the error with your change #8683 (and if not try to 
see what the difference is).



Bill

___
Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

Re: [Wireshark-dev] MSVC 2015 (VC14) notes/issue

2015-08-12 Thread Anders Broman 

Graham Bloice skrev den 2015-08-12 19:18:
On 12 August 2015 at 17:57, Pascal Quantin pascal.quan...@gmail.com 
mailto:pascal.quan...@gmail.com wrote:


Hi,

Le 12 août 2015 6:21 PM, Bill Meier wme...@newsguy.com
mailto:wme...@newsguy.com a écrit :

 [Resend]

 I see that several people (Anders, ...) been building with
MSVC-2015 (VC14) and have fixed a number of issues.

 So: I decided to download VC14 and give it a try (using NMake).

 A few questions:

 Are you using CMake or NMake ?



I used nmake



 If using NMake, I assume that you've updated config.nmake  etc.
Is there some reason you've not committed the changes ?



Graham asked me to hold off until all issues was fixed ad as LUA, GeoIP 
and Qt was excluded I was in no hurry.



 If not, I've made what I think are the required changes for
NMake. Do you think it's Ok to commit them ?

I have no objections, it'll be easier to make sure it continues to work 
if the changes are committed.





 Have you been able to do a complete build ?



Yes



 So far:

 1. Compiling packet-pdc.c gets:

 [...]\packet-pdc.c(205) : fatal error C1001: An internal error
has occurred in the compiler.
 (compiler file 'f:\dd\vctools\compiler\utc\src\p2\main.c', line 246)
  To work around this problem, try simplifying or changing the
program near the locations listed above.
 Please choose the Technical Support command on the Visual C++
  Help menu, or open the Technical Support help file for more
information

 INTERNAL COMPILER ERROR in 'C:\Program Files\Microsoft Visual
Studio 14.0\VC\BIN\cl.exe'
 Please choose the Technical Support command on the Visual C++
 Help menu, or open the Technical Support help file for more
information

 I've figured out what to change to fix this.
 (I've also extracted a much smaller test file which causes the
error and will submit the file to Microsoft).




I didn't encounter that problem...




 2. I had to disable building with geoip because:

 C:\Program Files\Windows
Kits\10\include\10.0.10150.0\ucrt\stdio.h(1925): warning C4005:
'snprintf': macro redefinition (compiling source file packet-
 ip.c)
 [...]\GeoIP-1.5.1-2-win32ws\include\GeoIP.h(36): note: see
previous definition of 'snprintf' (compili
 ng source file packet-ip.c)
 C:\Program Files\Windows
Kits\10\include\10.0.10150.0\ucrt\stdio.h(1927): fatal error
C1189: #error:  Macro definition of snprintf conflicts with Stan
 dard Library function declaration (compiling source file
packet-ip.c)



Yes me too and that's also a comment about it in my commit, same for the 
next point..




 3. I disabled building with LUA because there's apparently yet
no LUA library (dll) for use with VC14.

I might have a look at it when coming back from vacation if the
packager I used last time did not update the library (I have no
reliable Internet access right now, yes this is still possible
nowadays :)). But I was not in a hurry as there is no Qt package
compiled with MSVC2015 yet, so we still have a strong dependency
on MSVC2013.

Pascal.

FYI Windows CMake doesn't currently seem to configure without Qt, I'm 
not too fussed about that as on Windows the Qt version is the main build.


The QT folks had previously indicated VS2015 support would be released 
as a 5.5.x release so it's likely not too far off: 
https://blog.qt.io/blog/2015/04/29/windows-10-support-in-qt/


Enjoying your vacation in the mountains Pascal?


--
Graham Bloice


___
Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
  mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe


___
Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

Re: [Wireshark-dev] MSVC 2015 (VC14) notes/issue

2015-08-12 Thread Graham Bloice 
On 12 August 2015 at 18:38, Anders Broman a.bro...@bredband.net wrote:

 Graham Bloice skrev den 2015-08-12 19:18:

 On 12 August 2015 at 17:57, Pascal Quantin pascal.quan...@gmail.com
 wrote:

 Hi,
 Le 12 août 2015 6:21 PM, Bill Meier wme...@newsguy.com a écrit :
 
  [Resend]
 
  I see that several people (Anders, ...) been building with MSVC-2015
 (VC14) and have fixed a number of issues.
 
  So: I decided to download VC14 and give it a try (using NMake).
 
  A few questions:
 
  Are you using CMake or NMake ?


 I used nmake

 
  If using NMake, I assume that you've updated config.nmake  etc. Is
 there some reason you've not committed the changes ?


 Graham asked me to hold off until all issues was fixed ad as LUA, GeoIP
 and Qt was excluded I was in no hurry.

 I think the point I made was that I didn't think we should commit things
to master that don't build.  If we now have something that builds, I'm fine
with that.


-- 
Graham Bloice
___
Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

Re: [Wireshark-dev] MSVC 2015 (VC14) notes/issue

2015-08-12 Thread Guy Harris 

On Aug 12, 2015, at 10:18 AM, Graham Bloice graham.blo...@trihedral.com wrote:

 FYI Windows CMake doesn't currently seem to configure without Qt, I'm not too 
 fussed about that as on Windows the Qt version is the main build.

...and people are probably a *lot* less likely to want CLI-only builds on 
Windows than on UN*X (on UN*X, we need to support them; people often want to 
build TShark for headless machines).

That might change some day for, say, headless Windows machines (I always find 
the notion of headless Windows amusing; in the world of the Internet of 
Things, if things go the way Microsoft wants them to, more machines running 
Windows may be incapable of displaying actual *windows* than capable of 
displaying them).
___
Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

Re: [Wireshark-dev] MSVC 2015 (VC14) notes/issue

2015-08-12 Thread Graham Bloice 
On 12 August 2015 at 18:37, Guy Harris g...@alum.mit.edu wrote:


 On Aug 12, 2015, at 10:18 AM, Graham Bloice graham.blo...@trihedral.com
 wrote:

  FYI Windows CMake doesn't currently seem to configure without Qt, I'm
 not too fussed about that as on Windows the Qt version is the main build.

 ...and people are probably a *lot* less likely to want CLI-only builds on
 Windows than on UN*X (on UN*X, we need to support them; people often want
 to build TShark for headless machines).

 That might change some day for, say, headless Windows machines (I always
 find the notion of headless Windows amusing; in the world of the Internet
 of Things, if things go the way Microsoft wants them to, more machines
 running Windows may be incapable of displaying actual *windows* than
 capable of displaying them).


Good point, I forgot about folks wanting to build only tshark.  IIRC the
issue is that some of the CMake tasks to copy the 3rd party DLL's etc. seem
to complain if Qt isn't found.  Should be able to fix that up.


-- 
Graham Bloice
___
Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

Re: [Wireshark-dev] MSVC 2015 (VC14) notes/issue

2015-08-12 Thread Bill Meier 

On 8/12/2015 3:17 PM, Bill Meier wrote:


I used nmake



Oops: I hadn't checked for and noticed change #8683.  I would have saved
myself a lot of effort.  I'll try it out.



Ok: There are a few additional changes needed to config.nmake when 
building on a 32-bit Windows system.  I'll upload a revised patch to 
change #8683 shortly.







 So far:

 1. Compiling packet-pdc.c gets:



I didn't encounter that problem...



I'll see if I get the error with your change #8683 (and if not try to
see what the difference is).


I still get the failure. I'm now guessing that the issue is something 
related to building on a 32 bit system.





Bill



___
Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe