Re: [Wireshark-dev] Patch to AMQP dissector

2007-03-28 Thread ronnie sahlberg 
checked in

On 3/27/07, Martin Sustrik <[EMAIL PROTECTED]> wrote:
> Hi Ronnie,
>
> here's a patch to AMQP dissector. The only change is that when there are
> seceral AMQP frames in single TCP packet, all of them are referred in
> the info column.
>
> Can you check it in?
>
> Thanks.
> Martin
>
___
Wireshark-dev mailing list
Wireshark-dev@wireshark.org
http://www.wireshark.org/mailman/listinfo/wireshark-dev

Re: [Wireshark-dev] Patch to AMQP dissector

2007-03-27 Thread ronnie sahlberg 
Why do you change all function argumentns to use _U_ ?

_U_ is only used to mark a parameter as unused so that the compiler
will not emit any warnings "parameter foo is never used".

You only set this _U_ for arguments that are indeed never used inside
the function to suppress these kinds of compiler warnings.


Can you resubmit the patch after removing and reviewing these _U_ changes?


On 3/27/07, Martin Sustrik <[EMAIL PROTECTED]> wrote:
> Hi Ronnie,
>
> here's a patch to AMQP dissector. The only change is that when there are
> seceral AMQP frames in single TCP packet, all of them are referred in
> the info column.
>
> Can you check it in?
>
> Thanks.
> Martin
>
___
Wireshark-dev mailing list
Wireshark-dev@wireshark.org
http://www.wireshark.org/mailman/listinfo/wireshark-dev

[Wireshark-dev] Patch to AMQP dissector

2007-03-27 Thread Martin Sustrik 

Hi Ronnie,

here's a patch to AMQP dissector. The only change is that when there are 
seceral AMQP frames in single TCP packet, all of them are referred in 
the info column.


Can you check it in?

Thanks.
Martin


wireshark.amqp.r21226.diff.gz
Description: GNU Zip compressed data
___
Wireshark-dev mailing list
Wireshark-dev@wireshark.org
http://www.wireshark.org/mailman/listinfo/wireshark-dev