Re: [Wireshark-dev] Windows automated builds migrated to CMake
Awesome. Good job! - Juanjo On Thursday, April 16, 2015, Graham Bloice graham.blo...@trihedral.com wrote: Woohoo. Change to delete *.nmake incoming :-) On 16 April 2015 at 04:06, Gerald Combs ger...@wireshark.org javascript:_e(%7B%7D,'cvml','ger...@wireshark.org'); wrote: We reached a bit of a milestone today. The packages created by the 32-bit and 64-bit Windows builders at https://buildbot.wireshark.org/trunk/waterfall are now produced using CMake and MSBuild. Thanks to everyone for helping to get the Windows CMake environment up and running! ___ Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org javascript:_e(%7B%7D,'cvml','wireshark-dev@wireshark.org'); Archives:https://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org javascript:_e(%7B%7D,'cvml','wireshark-dev-requ...@wireshark.org'); ?subject=unsubscribe -- Graham Bloice Software Developer Trihedral UK Limited ___ Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org Archives:https://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
Re: [Wireshark-dev] Windows automated builds migrated to CMake
Woohoo. Change to delete *.nmake incoming :-) On 16 April 2015 at 04:06, Gerald Combs ger...@wireshark.org wrote: We reached a bit of a milestone today. The packages created by the 32-bit and 64-bit Windows builders at https://buildbot.wireshark.org/trunk/waterfall are now produced using CMake and MSBuild. Thanks to everyone for helping to get the Windows CMake environment up and running! ___ Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org Archives:https://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org ?subject=unsubscribe -- Graham Bloice Software Developer Trihedral UK Limited ___ Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org Archives:https://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
Re: [Wireshark-dev] Windows automated builds migrated to CMake
Hi Am I correct, that as for now, there is no plan to move the download of the necessary libraries for building Wireshark on Windows from the nmake system to cmake as well? Also, the wiki pages do not seem to reflect the cmake build and the buildbot waterfall display only seem to run cmake, but not build using it? Would be helpful to setup a cmake enforced build on Windows, which is still a little bit tricky (even using MSVC2013 and Qt). regards, Roland On Thu, Apr 16, 2015 at 10:19 AM, Graham Bloice graham.blo...@trihedral.com wrote: Woohoo. Change to delete *.nmake incoming :-) On 16 April 2015 at 04:06, Gerald Combs ger...@wireshark.org wrote: We reached a bit of a milestone today. The packages created by the 32-bit and 64-bit Windows builders at https://buildbot.wireshark.org/trunk/waterfall are now produced using CMake and MSBuild. Thanks to everyone for helping to get the Windows CMake environment up and running! ___ Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org Archives:https://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org ?subject=unsubscribe -- Graham Bloice Software Developer Trihedral UK Limited ___ Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org Archives:https://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org ?subject=unsubscribe ___ Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org Archives:https://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
Re: [Wireshark-dev] Windows automated builds migrated to CMake
On 16 April 2015 at 09:29, Roland Knall rkn...@gmail.com wrote: Also, the wiki pages do not seem to reflect the cmake build and the buildbot waterfall display only seem to run cmake, but not build using it? Would be helpful to setup a cmake enforced build on Windows, which is still a little bit tricky (even using MSVC2013 and Qt). The buildbot builds using CMake first, both x86 and x64 including packaging and tests and then repeats using nmake. The automated installers are now from the CMake build. The Windows Petri-dish buildbot also builds with CMake (and has done for some time). -- Graham Bloice ___ Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org Archives:https://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
Re: [Wireshark-dev] Windows automated builds migrated to CMake
On 16 April 2015 at 10:11, Roland Knall rkn...@gmail.com wrote: Hi Very cool + 1 The waterfall display was a little bit misleading, but found it now. Still waiting for the get-go in my company to install VS2013, but will try it as soon as possible. VS2015 is out soon! I suspect that the 1.99.x and 2.0.x releases will use VS2013 though as the primary compiler. I don't know of anyone using VS2012 (or 2010) with the CMake build, but it might work. It would be good to know for the docs update. As of dependencies, this leaves more or less the mac plattform with the setup script. I played around with that last week, and it seems, port is a better solution for Mac then the setup script. I am going to write a README.macosx detailing what and how things must be installed. Maybe this can be automated using cmake as well. Presumably in a similar manner to that done for the Windows build, a call out to something external from CMake to do that task. -- Graham Bloice ___ Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org Archives:https://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
Re: [Wireshark-dev] Windows automated builds migrated to CMake
On 16 April 2015 at 09:29, Roland Knall rkn...@gmail.com wrote: Hi Am I correct, that as for now, there is no plan to move the download of the necessary libraries for building Wireshark on Windows from the nmake system to cmake as well? The download of libraries is in CMake (excepting QT). See change 7990 ( https://code.wireshark.org/review/#/c/7990/). Also, the wiki pages do not seem to reflect the cmake build and the buildbot waterfall display only seem to run cmake, but not build using it? Would be helpful to setup a cmake enforced build on Windows, which is still a little bit tricky (even using MSVC2013 and Qt). The Developers Guide hasn't been updated yet, README.cmake is the current source of info. There are still some loose ends to tidy up, e.g. PortAudio and CMake warnings but it's usable as is. -- Graham Bloice ___ Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org Archives:https://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
Re: [Wireshark-dev] Windows automated builds migrated to CMake
Hi Very cool + 1 The waterfall display was a little bit misleading, but found it now. Still waiting for the get-go in my company to install VS2013, but will try it as soon as possible. As of dependencies, this leaves more or less the mac plattform with the setup script. I played around with that last week, and it seems, port is a better solution for Mac then the setup script. I am going to write a README.macosx detailing what and how things must be installed. Maybe this can be automated using cmake as well. regards, Roland On Thu, Apr 16, 2015 at 10:58 AM, Graham Bloice graham.blo...@trihedral.com wrote: On 16 April 2015 at 09:29, Roland Knall rkn...@gmail.com wrote: Also, the wiki pages do not seem to reflect the cmake build and the buildbot waterfall display only seem to run cmake, but not build using it? Would be helpful to setup a cmake enforced build on Windows, which is still a little bit tricky (even using MSVC2013 and Qt). The buildbot builds using CMake first, both x86 and x64 including packaging and tests and then repeats using nmake. The automated installers are now from the CMake build. The Windows Petri-dish buildbot also builds with CMake (and has done for some time). -- Graham Bloice ___ Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org Archives:https://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org ?subject=unsubscribe ___ Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org Archives:https://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
Re: [Wireshark-dev] Windows automated builds migrated to CMake
2015-04-16 5:06 GMT+02:00 Gerald Combs ger...@wireshark.org: We reached a bit of a milestone today. The packages created by the 32-bit and 64-bit Windows builders at https://buildbot.wireshark.org/trunk/waterfall are now produced using CMake and MSBuild. Thanks to everyone for helping to get the Windows CMake environment up and running! Hi Gerald, one thing I noticed is that the Wireshark 1.99.6-243 32 bits coming from the buildbot (and thus CMake) systematically open a console window (both with Qt and GTK GUI) whatever my console window setting. This does not happen when I compile locally the same release with nmake. I have not installed CMake yet on my machine to cross check, but it seems that we still have discrepancies between nmake and CMake. Regards, Pascal. ___ Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org Archives:https://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
Re: [Wireshark-dev] Windows automated builds migrated to CMake
Great! Good job! Cheers, Balint 2015-04-16 10:19 GMT+02:00 Graham Bloice graham.blo...@trihedral.com: Woohoo. Change to delete *.nmake incoming :-) On 16 April 2015 at 04:06, Gerald Combs ger...@wireshark.org wrote: We reached a bit of a milestone today. The packages created by the 32-bit and 64-bit Windows builders at https://buildbot.wireshark.org/trunk/waterfall are now produced using CMake and MSBuild. Thanks to everyone for helping to get the Windows CMake environment up and running! ___ Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org Archives:https://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe -- Graham Bloice Software Developer Trihedral UK Limited ___ Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org Archives:https://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe ___ Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org Archives:https://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
Re: [Wireshark-dev] Windows automated builds migrated to CMake
On 16 April 2015 at 11:49, Pascal Quantin pascal.quan...@gmail.com wrote: 2015-04-16 5:06 GMT+02:00 Gerald Combs ger...@wireshark.org: We reached a bit of a milestone today. The packages created by the 32-bit and 64-bit Windows builders at https://buildbot.wireshark.org/trunk/waterfall are now produced using CMake and MSBuild. Thanks to everyone for helping to get the Windows CMake environment up and running! Hi Gerald, one thing I noticed is that the Wireshark 1.99.6-243 32 bits coming from the buildbot (and thus CMake) systematically open a console window (both with Qt and GTK GUI) whatever my console window setting. This does not happen when I compile locally the same release with nmake. I have not installed CMake yet on my machine to cross check, but it seems that we still have discrepancies between nmake and CMake. This is down to the subsystem type. The nmake builds are marked as Windows Gui and the CMake builds as Windows Console. It's a linker flag, supplied in $(guiflags) for nmake builds (or $(conflags) for command line programs e.g. tshark.exe). I think CMake requires a set_target_properties(target_name PROPERTIES LINK_FLAGS /SUBSYSTEM:WINDOWS) call for each gui target. -- Graham Bloice ___ Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org Archives:https://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
Re: [Wireshark-dev] Windows automated builds migrated to CMake
2015-04-16 14:55 GMT+02:00 Graham Bloice graham.blo...@trihedral.com: On 16 April 2015 at 11:49, Pascal Quantin pascal.quan...@gmail.com wrote: 2015-04-16 5:06 GMT+02:00 Gerald Combs ger...@wireshark.org: We reached a bit of a milestone today. The packages created by the 32-bit and 64-bit Windows builders at https://buildbot.wireshark.org/trunk/waterfall are now produced using CMake and MSBuild. Thanks to everyone for helping to get the Windows CMake environment up and running! Hi Gerald, one thing I noticed is that the Wireshark 1.99.6-243 32 bits coming from the buildbot (and thus CMake) systematically open a console window (both with Qt and GTK GUI) whatever my console window setting. This does not happen when I compile locally the same release with nmake. I have not installed CMake yet on my machine to cross check, but it seems that we still have discrepancies between nmake and CMake. This is down to the subsystem type. The nmake builds are marked as Windows Gui and the CMake builds as Windows Console. It's a linker flag, supplied in $(guiflags) for nmake builds (or $(conflags) for command line programs e.g. tshark.exe). I think CMake requires a set_target_properties(target_name PROPERTIES LINK_FLAGS /SUBSYSTEM:WINDOWS) call for each gui target. Indeed, it's something I explicitly added to andoiddump.exe to improve the user experience and I did not even realize it could be the same thing :) Thanks Graham ! ___ Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org Archives:https://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
Re: [Wireshark-dev] Windows automated builds migrated to CMake
Hi, The checkAPI target is missing from the cmake build isn't it? Regards Anders Pascal Quantin skrev den 2015-04-16 15:09: 2015-04-16 14:55 GMT+02:00 Graham Bloice graham.blo...@trihedral.com mailto:graham.blo...@trihedral.com: On 16 April 2015 at 11:49, Pascal Quantin pascal.quan...@gmail.com mailto:pascal.quan...@gmail.com wrote: 2015-04-16 5:06 GMT+02:00 Gerald Combs ger...@wireshark.org mailto:ger...@wireshark.org: We reached a bit of a milestone today. The packages created by the 32-bit and 64-bit Windows builders at https://buildbot.wireshark.org/trunk/waterfall are now produced using CMake and MSBuild. Thanks to everyone for helping to get the Windows CMake environment up and running! Hi Gerald, one thing I noticed is that the Wireshark 1.99.6-243 32 bits coming from the buildbot (and thus CMake) systematically open a console window (both with Qt and GTK GUI) whatever my console window setting. This does not happen when I compile locally the same release with nmake. I have not installed CMake yet on my machine to cross check, but it seems that we still have discrepancies between nmake and CMake. This is down to the subsystem type. The nmake builds are marked as Windows Gui and the CMake builds as Windows Console. It's a linker flag, supplied in $(guiflags) for nmake builds (or $(conflags) for command line programs e.g. tshark.exe). I think CMake requires a set_target_properties(target_name PROPERTIES LINK_FLAGS /SUBSYSTEM:WINDOWS) call for each gui target. Indeed, it's something I explicitly added to andoiddump.exe to improve the user experience and I did not even realize it could be the same thing :) Thanks Graham ! ___ Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org Archives:https://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe ___ Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org Archives:https://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
Re: [Wireshark-dev] Windows automated builds migrated to CMake
It's defined in cmake/modules/UseCheckAPI.cmake which is included by the top-level CMakeLists.txt. It's run by the Visual Studio Code Analysis builder. On 4/16/15 7:12 AM, Anders Broman wrote: Hi, The checkAPI target is missing from the cmake build isn't it? Regards Anders Pascal Quantin skrev den 2015-04-16 15:09: 2015-04-16 14:55 GMT+02:00 Graham Bloice graham.blo...@trihedral.com mailto:graham.blo...@trihedral.com: On 16 April 2015 at 11:49, Pascal Quantin pascal.quan...@gmail.com mailto:pascal.quan...@gmail.com wrote: 2015-04-16 5:06 GMT+02:00 Gerald Combs ger...@wireshark.org mailto:ger...@wireshark.org: We reached a bit of a milestone today. The packages created by the 32-bit and 64-bit Windows builders at https://buildbot.wireshark.org/trunk/waterfall are now produced using CMake and MSBuild. Thanks to everyone for helping to get the Windows CMake environment up and running! Hi Gerald, one thing I noticed is that the Wireshark 1.99.6-243 32 bits coming from the buildbot (and thus CMake) systematically open a console window (both with Qt and GTK GUI) whatever my console window setting. This does not happen when I compile locally the same release with nmake. I have not installed CMake yet on my machine to cross check, but it seems that we still have discrepancies between nmake and CMake. This is down to the subsystem type. The nmake builds are marked as Windows Gui and the CMake builds as Windows Console. It's a linker flag, supplied in $(guiflags) for nmake builds (or $(conflags) for command line programs e.g. tshark.exe). I think CMake requires a set_target_properties(target_name PROPERTIES LINK_FLAGS /SUBSYSTEM:WINDOWS) call for each gui target. Indeed, it's something I explicitly added to andoiddump.exe to improve the user experience and I did not even realize it could be the same thing :) Thanks Graham ! ___ Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org Archives:https://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe ___ Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org Archives:https://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe ___ Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org Archives:https://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
Re: [Wireshark-dev] Windows automated builds migrated to CMake
We're also missing a .dmg target (packaging/macosx/osx-dmg.sh). I think that's the only thing missing on the OS X builders. On 4/16/15 2:11 AM, Roland Knall wrote: Hi Very cool + 1 The waterfall display was a little bit misleading, but found it now. Still waiting for the get-go in my company to install VS2013, but will try it as soon as possible. As of dependencies, this leaves more or less the mac plattform with the setup script. I played around with that last week, and it seems, port is a better solution for Mac then the setup script. I am going to write a README.macosx detailing what and how things must be installed. Maybe this can be automated using cmake as well. regards, Roland On Thu, Apr 16, 2015 at 10:58 AM, Graham Bloice graham.blo...@trihedral.com mailto:graham.blo...@trihedral.com wrote: On 16 April 2015 at 09:29, Roland Knall rkn...@gmail.com mailto:rkn...@gmail.com wrote: Also, the wiki pages do not seem to reflect the cmake build and the buildbot waterfall display only seem to run cmake, but not build using it? Would be helpful to setup a cmake enforced build on Windows, which is still a little bit tricky (even using MSVC2013 and Qt). The buildbot builds using CMake first, both x86 and x64 including packaging and tests and then repeats using nmake. The automated installers are now from the CMake build. The Windows Petri-dish buildbot also builds with CMake (and has done for some time). -- Graham Bloice ___ Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org mailto:wireshark-dev@wireshark.org Archives:https://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe ___ Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org Archives:https://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe ___ Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org Archives:https://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
Re: [Wireshark-dev] Windows automated builds migrated to CMake
On 4/16/15 5:55 AM, Graham Bloice wrote: This is down to the subsystem type. The nmake builds are marked as Windows Gui and the CMake builds as Windows Console. It's a linker flag, supplied in $(guiflags) for nmake builds (or $(conflags) for command line programs e.g. tshark.exe). I think CMake requires a set_target_properties(target_name PROPERTIES LINK_FLAGS /SUBSYSTEM:WINDOWS) call for each gui target. add_executable has a WIN32 flag which appears to take care of this. Unfortunately it reveals another problem -- we don't have a WinMain entry point in wireshark-qt.cpp. ___ Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org Archives:https://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
[Wireshark-dev] Windows automated builds migrated to CMake
We reached a bit of a milestone today. The packages created by the 32-bit and 64-bit Windows builders at https://buildbot.wireshark.org/trunk/waterfall are now produced using CMake and MSBuild. Thanks to everyone for helping to get the Windows CMake environment up and running! ___ Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org Archives:https://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
