Re: [Wireshark-dev] Wireshark User's Guide error

2022-02-03 Thread Uli Heilmeier

Thanks Morten for reporting this.

Fixed in !6114

Am 02.02.22 um 17:23 schrieb Morten Brørup:

Dear Richard Sharpe, Ed Warnicke, Ulf Lamping,

Chapter 7.5 in the Wireshark User's Guide error (https://www.wireshark.org/docs/wsug_html_chunked/ChAdvTCPAnalysis.html 
) says:


TCP Keep-Alive

Set when the segment size is zero or one, the current sequence number is one byte less than the next expected sequence 
number, and any of SYN, FIN, or RST are set.


It should say:

TCP Keep-Alive

Set when the segment size is zero or one, the current sequence number is one byte less than the next expected sequence 
number, and none of SYN, FIN, or RST are set.


Please refer to the TCP packet dissector source code for confirmation:

https://github.com/boundary/wireshark/blob/master/epan/dissectors/packet-tcp.c#L950 



Med venlig hilsen / kind regards

*Morten Brørup*

CTO

*SmartShare Systems A/S*

Tonsbakken 16-18

DK-2740 Skovlunde

Denmark

Office  +45 70 20 00 93

Direct  +45 89 93 50 22

Mobile +45 25 40 82 12

m...@smartsharesystems.com 

www.smartsharesystems.com 


___
Sent via:Wireshark-dev mailing list 
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
  mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

___
Sent via:Wireshark-dev mailing list 
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe


[Wireshark-dev] Wireshark User's Guide error

2022-02-03 Thread Morten Brørup
Dear Richard Sharpe, Ed Warnicke, Ulf Lamping,

 

Chapter 7.5 in the Wireshark User's Guide error 
(https://www.wireshark.org/docs/wsug_html_chunked/ChAdvTCPAnalysis.html) says:

 

TCP Keep-Alive

Set when the segment size is zero or one, the current sequence number is one 
byte less than the next expected sequence number, and any of SYN, FIN, or RST 
are set.

 

It should say:

TCP Keep-Alive

Set when the segment size is zero or one, the current sequence number is one 
byte less than the next expected sequence number, and none of SYN, FIN, or RST 
are set.

 

Please refer to the TCP packet dissector source code for confirmation:

https://github.com/boundary/wireshark/blob/master/epan/dissectors/packet-tcp.c#L950

 

 

Med venlig hilsen / kind regards

 

Morten Brørup

CTO

 

 

SmartShare Systems A/S

Tonsbakken 16-18

DK-2740 Skovlunde

Denmark

 

Office  +45 70 20 00 93

Direct  +45 89 93 50 22

Mobile +45 25 40 82 12

 

m...@smartsharesystems.com  

www.smartsharesystems.com  

 

___
Sent via:Wireshark-dev mailing list 
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe