Re: [Wireshark-dev] proposed graph_analysis.c change
On 03/23/2013 12:58 AM, Ed Beroset wrote: In working on fixing a bug today, I made a proposed change or two to graph_analysis.c. See https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7418 for the context. The first patch was a very conservative one that simply added a bit of code to address a problem with not being able to resize the panes. The second, superseding patch is a bit more extensive in that it completely eliminates the pane_callback function. I thought that I would point out that I have only tested the change on GTK+ 3 and not earlier versions, but didn't know how far back we're intending to support. Comments, accolades, brickbats welcome. :) Ed Well, GTK2 would be nice ;) Thanks, Jaap ___ Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
Re: [Wireshark-dev] proposed graph_analysis.c change
Jaap Keuter wrote: On 03/23/2013 12:58 AM, Ed Beroset wrote: In working on fixing a bug today, I made a proposed change or two to graph_analysis.c. See https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7418 for the context. The first patch was a very conservative one that simply added a bit of code to address a problem with not being able to resize the panes. The second, superseding patch is a bit more extensive in that it completely eliminates the pane_callback function. I thought that I would point out that I have only tested the change on GTK+ 3 and not earlier versions, but didn't know how far back we're intending to support. Comments, accolades, brickbats welcome. :) Ed Well, GTK2 would be nice ;) Ha! OK, that's a good start. I have verified it on Windows and two different Linux machines all using GTK 2.24, but don't have a good way to try it on other configurations. One thing still puzzling me is the comment in the (now elided) code for pane_callback which says repaint the comment area because when moving the pane position there are times that the expose_event_comments is not called. I can't see why the pane_callback routine needs to exist at all and things seem to work just fine with it deleted as per my patch. Ed ___ Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
Re: [Wireshark-dev] proposed graph_analysis.c change
On Mar 23, 2013, at 1:00 PM, Ed Beroset bero...@mindspring.com wrote: One thing still puzzling me is the comment in the (now elided) code for pane_callback which says repaint the comment area because when moving the pane position there are times that the expose_event_comments is not called. I can't see why the pane_callback routine needs to exist at all and things seem to work just fine with it deleted as per my patch. If expose event refers to window system expose events, as in I, the window system, did not save a copy of the pixels behind this portion of your window when some other window was dragged on top of it or came to the front and covered it, and that portion of your window is now exposed, so you're going to have to draw it all over again, then whether thing work without expose event callbacks may depend on whether the window system saves those copies and redraws the exposed part of the window for you or doesn't save them and requires the application to do so. ___ Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
[Wireshark-dev] proposed graph_analysis.c change
In working on fixing a bug today, I made a proposed change or two to graph_analysis.c. See https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7418 for the context. The first patch was a very conservative one that simply added a bit of code to address a problem with not being able to resize the panes. The second, superseding patch is a bit more extensive in that it completely eliminates the pane_callback function. I thought that I would point out that I have only tested the change on GTK+ 3 and not earlier versions, but didn't know how far back we're intending to support. Comments, accolades, brickbats welcome. :) Ed ___ Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
